63085 2011-06-21 12:21:04 -0700 IndexedDB: keyrange methods should throw TypeError if required arguments are missing 2011-06-21 14:10:15 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 pilgrim webkit-unassigned abarth dgrogan fishd hans tony webkit.review.bot oldest_to_newest 424657 0 pilgrim 2011-06-21 12:21:04 -0700 http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#idl-def-IDBKeyRange states that only(), lowerBound(), upperBound(), and bound() have required arguments. As per the WebIDL spec, calling these functions without the required arguments should throw a TypeError. This test calls these functions without arguments, or with too few arguments, and checks that they throw properly. Expected behavior: throw TypeError Actual behavior: does not throw, creates IDBKeyRange object Patch included. The fix is to remove the LegacyDefaultOptionalArguments flag from the IDBKeyRange.idl. This will force the code generator to check for required arguments and throw TypeError if they are missing. 424661 1 98039 pilgrim 2011-06-21 12:22:42 -0700 Created attachment 98039 Patch 424746 2 98039 webkit.review.bot 2011-06-21 14:10:10 -0700 Comment on attachment 98039 Patch Clearing flags on attachment: 98039 Committed r89380: <http://trac.webkit.org/changeset/89380> 424747 3 webkit.review.bot 2011-06-21 14:10:15 -0700 All reviewed patches have been landed. Closing bug. 98039 2011-06-21 12:22:42 -0700 2011-06-21 14:10:10 -0700 Patch bug-63085-20110621152243.patch text/plain 4976 pilgrim SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5MzY5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMjEgIE1hcmsgUGls Z3JpbSAgPHBpbGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEluZGV4ZWREQjoga2V5cmFuZ2UgbWV0aG9kcyBzaG91bGQg dGhyb3cgVHlwZUVycm9yIGlmIHJlcXVpcmVkIGFyZ3VtZW50cyBhcmUgbWlzc2luZworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjMwODUKKworICAgICAg ICBUZXN0OiBzdG9yYWdlL2luZGV4ZWRkYi9rZXlyYW5nZS1yZXF1aXJlZC1hcmd1bWVudHMuaHRt bAorCisgICAgICAgICogc3RvcmFnZS9JREJLZXlSYW5nZS5pZGw6IHJlbW92ZSBMZWdhY3lEZWZh dWx0T3B0aW9uYWxBcmd1bWVudHMgZmxhZworICAgICAgICBzbyBtaXNzaW5nIHJlcXVpcmVkIGFy Z3VtZW50cyB0aHJvdyBUeXBlRXJyb3IsIGFzIHBlciBXZWJJREwgc3BlYy4KKwogMjAxMS0wNi0y MSAgVnNldm9sb2QgVmxhc292ICA8dnNldmlrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpJbmRleDogU291cmNlL1dlYkNvcmUvc3RvcmFnZS9JREJL ZXlSYW5nZS5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvc3RvcmFnZS9JREJLZXlS YW5nZS5pZGwJKHJldmlzaW9uIDg5MzIxKQorKysgU291cmNlL1dlYkNvcmUvc3RvcmFnZS9JREJL ZXlSYW5nZS5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTI2LDcgKzI2LDYgQEAKIG1vZHVsZSBzdG9y YWdlIHsKIAogICAgIGludGVyZmFjZSBbCi0gICAgICAgIExlZ2FjeURlZmF1bHRPcHRpb25hbEFy Z3VtZW50cywKICAgICAgICAgQ29uZGl0aW9uYWw9SU5ERVhFRF9EQVRBQkFTRQogICAgIF0gSURC S2V5UmFuZ2UgewogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgSURCS2V5IGxvd2VyOwpJbmRl eDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5n ZUxvZwkocmV2aXNpb24gODkzNjkpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0wNi0yMSAgTWFyayBQaWxncmltICA8cGlsZ3Jp bUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgSW5kZXhlZERCOiBrZXlyYW5nZSBtZXRob2RzIHNob3VsZCB0aHJvdyBUeXBlRXJy b3IgaWYgcmVxdWlyZWQgYXJndW1lbnRzIGFyZSBtaXNzaW5nCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzA4NQorCisgICAgICAgICogc3RvcmFnZS9p bmRleGVkZGIva2V5cmFuZ2UtcmVxdWlyZWQtYXJndW1lbnRzLWV4cGVjdGVkLnR4dDogQWRkZWQu CisgICAgICAgICogc3RvcmFnZS9pbmRleGVkZGIva2V5cmFuZ2UtcmVxdWlyZWQtYXJndW1lbnRz Lmh0bWw6IEFkZGVkLgorCiAyMDExLTA2LTIxICBEaXJrIFNjaHVsemUgIDxrcml0QHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUm9iIEJ1aXMuCkluZGV4OiBMYXlvdXRUZXN0cy9z dG9yYWdlL2luZGV4ZWRkYi9rZXlyYW5nZS1yZXF1aXJlZC1hcmd1bWVudHMtZXhwZWN0ZWQudHh0 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2tleXJhbmdlLXJl cXVpcmVkLWFyZ3VtZW50cy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0 cy9zdG9yYWdlL2luZGV4ZWRkYi9rZXlyYW5nZS1yZXF1aXJlZC1hcmd1bWVudHMtZXhwZWN0ZWQu dHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDIyIEBACitUZXN0IEluZGV4ZWREQiBrZXlyYW5n ZSByZXF1aXJlZCBhcmd1bWVudHMKKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVz IG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK2lu ZGV4ZWREQiA9IHdpbmRvdy5pbmRleGVkREIgfHwgd2luZG93LndlYmtpdEluZGV4ZWREQiB8fCB3 aW5kb3cubW96SW5kZXhlZERCOworUEFTUyBpbmRleGVkREIgPT0gbnVsbCBpcyBmYWxzZQorSURC RGF0YWJhc2VFeGNlcHRpb24gPSB3aW5kb3cuSURCRGF0YWJhc2VFeGNlcHRpb24gfHwgd2luZG93 LndlYmtpdElEQkRhdGFiYXNlRXhjZXB0aW9uOworUEFTUyBJREJEYXRhYmFzZUV4Y2VwdGlvbiA9 PSBudWxsIGlzIGZhbHNlCitJREJDdXJzb3IgPSB3aW5kb3cuSURCQ3Vyc29yIHx8IHdpbmRvdy53 ZWJraXRJREJDdXJzb3I7CitQQVNTIElEQkN1cnNvciA9PSBudWxsIGlzIGZhbHNlCitJREJLZXlS YW5nZSA9IHdpbmRvdy5JREJLZXlSYW5nZSB8fCB3aW5kb3cud2Via2l0SURCS2V5UmFuZ2U7CitQ QVNTIElEQktleVJhbmdlID09IG51bGwgaXMgZmFsc2UKK1BBU1MgSURCS2V5UmFuZ2Uub25seSgp OyB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBOb3QgZW5vdWdoIGFyZ3VtZW50cy4KK1BBU1Mg SURCS2V5UmFuZ2UubG93ZXJCb3VuZCgpOyB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBOb3Qg ZW5vdWdoIGFyZ3VtZW50cy4KK1BBU1MgSURCS2V5UmFuZ2UudXBwZXJCb3VuZCgpOyB0aHJldyBl eGNlcHRpb24gVHlwZUVycm9yOiBOb3QgZW5vdWdoIGFyZ3VtZW50cy4KK1BBU1MgSURCS2V5UmFu Z2UuYm91bmQoMSk7IHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IE5vdCBlbm91Z2ggYXJndW1l bnRzLgorUEFTUyBJREJLZXlSYW5nZS5ib3VuZCgpOyB0aHJldyBleGNlcHRpb24gVHlwZUVycm9y OiBOb3QgZW5vdWdoIGFyZ3VtZW50cy4KK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUK KworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9r ZXlyYW5nZS1yZXF1aXJlZC1hcmd1bWVudHMuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9zdG9yYWdlL2luZGV4ZWRkYi9rZXlyYW5nZS1yZXF1aXJlZC1hcmd1bWVudHMuaHRtbAkocmV2 aXNpb24gMCkKKysrIExheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2tleXJhbmdlLXJlcXVp cmVkLWFyZ3VtZW50cy5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQ0IEBACis8IURPQ1RZ UEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4u Ly4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIj4KKzxzY3JpcHQgc3JjPSIu Li8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0 IHNyYz0iLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LWZ1bmN0aW9uLmpzIj48 L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvc2hhcmVkLmpzIj48L3NjcmlwdD4KKzwv aGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xl Ij48L2Rpdj4KKzxzY3JpcHQ+CisKK2Rlc2NyaXB0aW9uKCJUZXN0IEluZGV4ZWREQiBrZXlyYW5n ZSByZXF1aXJlZCBhcmd1bWVudHMiKTsKK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIp CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworCitmdW5jdGlvbiB0 ZXN0KCkKK3sKKyAgICBpbmRleGVkREIgPSBldmFsQW5kTG9nKCJpbmRleGVkREIgPSB3aW5kb3cu aW5kZXhlZERCIHx8IHdpbmRvdy53ZWJraXRJbmRleGVkREIgfHwgd2luZG93Lm1vekluZGV4ZWRE QjsiKTsKKyAgICBzaG91bGRCZUZhbHNlKCJpbmRleGVkREIgPT0gbnVsbCIpOworICAgIElEQkRh dGFiYXNlRXhjZXB0aW9uID0gZXZhbEFuZExvZygiSURCRGF0YWJhc2VFeGNlcHRpb24gPSB3aW5k b3cuSURCRGF0YWJhc2VFeGNlcHRpb24gfHwgd2luZG93LndlYmtpdElEQkRhdGFiYXNlRXhjZXB0 aW9uOyIpOworICAgIHNob3VsZEJlRmFsc2UoIklEQkRhdGFiYXNlRXhjZXB0aW9uID09IG51bGwi KTsKKyAgICBJREJDdXJzb3IgPSBldmFsQW5kTG9nKCJJREJDdXJzb3IgPSB3aW5kb3cuSURCQ3Vy c29yIHx8IHdpbmRvdy53ZWJraXRJREJDdXJzb3I7Iik7CisgICAgc2hvdWxkQmVGYWxzZSgiSURC Q3Vyc29yID09IG51bGwiKTsKKyAgICBJREJLZXlSYW5nZSA9IGV2YWxBbmRMb2coIklEQktleVJh bmdlID0gd2luZG93LklEQktleVJhbmdlIHx8IHdpbmRvdy53ZWJraXRJREJLZXlSYW5nZTsiKTsK KyAgICBzaG91bGRCZUZhbHNlKCJJREJLZXlSYW5nZSA9PSBudWxsIik7CisKKyAgICBzaG91bGRU aHJvdygiSURCS2V5UmFuZ2Uub25seSgpOyIpOworICAgIHNob3VsZFRocm93KCJJREJLZXlSYW5n ZS5sb3dlckJvdW5kKCk7Iik7CisgICAgc2hvdWxkVGhyb3coIklEQktleVJhbmdlLnVwcGVyQm91 bmQoKTsiKTsKKyAgICBzaG91bGRUaHJvdygiSURCS2V5UmFuZ2UuYm91bmQoMSk7Iik7CisgICAg c2hvdWxkVGhyb3coIklEQktleVJhbmdlLmJvdW5kKCk7Iik7CisKKyAgICBkb25lKCk7Cit9CisK K3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworCit0ZXN0KCk7CisKKzwvc2NyaXB0Pgor PC9ib2R5PgorPC9odG1sPgo=