63080 2011-06-21 11:11:38 -0700 Unit-tests step on test-only bot is broken 2011-06-21 12:58:54 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 dslomov webkit-unassigned aroben dslomov webkit.review.bot oldest_to_newest 424576 0 dslomov 2011-06-21 11:11:38 -0700 Removing the step until run-api-tests is fixed 424578 1 98013 dslomov 2011-06-21 11:13:25 -0700 Created attachment 98013 Fix 424621 2 98013 aroben 2011-06-21 11:46:25 -0700 Comment on attachment 98013 Fix View in context: https://bugs.webkit.org/attachment.cgi?id=98013&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:-564 > - # FIXME: Only running in debug mode due to https://bugs.webkit.org/show_bug.cgi?id=61812 > - if configuration == "debug": > - self.addStep(RunUnitTests) Presumably BuildAndTestFactory doesn't need this fix? 424622 3 98013 aroben 2011-06-21 11:47:40 -0700 Comment on attachment 98013 Fix View in context: https://bugs.webkit.org/attachment.cgi?id=98013&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:-564 >> - self.addStep(RunUnitTests) > > Presumably BuildAndTestFactory doesn't need this fix? Indeed, SnowLeopard Intel Leaks (which uses BuildAndTestFactory) doesn't show the issue you're trying to fix: http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/17616/steps/run-api-tests/logs/stdio 424626 4 dslomov 2011-06-21 11:48:39 -0700 (In reply to comment #3) > (From update of attachment 98013 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=98013&action=review > > >> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:-564 > >> - self.addStep(RunUnitTests) > > > > Presumably BuildAndTestFactory doesn't need this fix? > > Indeed, SnowLeopard Intel Leaks (which uses BuildAndTestFactory) doesn't show the issue you're trying to fix: http://build.webkit.org/builders/SnowLeopard%20Intel%20Leaks/builds/17616/steps/run-api-tests/logs/stdio Cool - I'll be back :) 424633 5 98030 dslomov 2011-06-21 11:53:57 -0700 Created attachment 98030 Not disabling on build-and-test bots; disabling on non-(win and mac) 424649 6 98030 aroben 2011-06-21 12:08:53 -0700 Comment on attachment 98030 Not disabling on build-and-test bots; disabling on non-(win and mac) View in context: https://bugs.webkit.org/attachment.cgi?id=98030&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:559 > + if configuration == "debug" and (platform == 'mac' or platform == 'win'): An even better way to write this is: if configuration == 'debug' and platform in ('mac', 'win'): 424688 7 98030 webkit.review.bot 2011-06-21 12:58:50 -0700 Comment on attachment 98030 Not disabling on build-and-test bots; disabling on non-(win and mac) Clearing flags on attachment: 98030 Committed r89373: <http://trac.webkit.org/changeset/89373> 424689 8 webkit.review.bot 2011-06-21 12:58:54 -0700 All reviewed patches have been landed. Closing bug. 98013 2011-06-21 11:13:25 -0700 2011-06-21 11:53:57 -0700 Fix 63080.patch text/plain 1878 dslomov ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL21hc3Rlci5jZmcgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IDVjMmY0YzUuLjdmODJkYWQgMTAwNjQ0Ci0tLSBhL1Rv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcK KysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz dGVyLmNmZwpAQCAtNTM1LDEwICs1MzUsNiBAQCBjbGFzcyBUZXN0RmFjdG9yeShGYWN0b3J5KToK ICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1bkphdmFTY3JpcHRDb3JlVGVzdHMsIGJ1aWxkSlNDVG9v bD1GYWxzZSkKICAgICAgICAgc2VsZi5hZGRTdGVwKHNlbGYuVGVzdENsYXNzLCBidWlsZEpTQ1Rv b2w9KHBsYXRmb3JtICE9ICd3aW4nKSkKIAotICAgICAgICAjIEZJWE1FOiBPbmx5IHJ1bm5pbmcg aW4gZGVidWcgbW9kZSBkdWUgdG8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTYxODEyCi0gICAgICAgIGlmIGNvbmZpZ3VyYXRpb24gPT0gImRlYnVnIjoKLSAgICAgICAg ICAgIHNlbGYuYWRkU3RlcChSdW5Vbml0VGVzdHMpCi0KICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1 blB5dGhvblRlc3RzKQogICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuUGVybFRlc3RzKQogICAgICAg ICBzZWxmLmFkZFN0ZXAoUnVuQmluZGluZ3NUZXN0cykKQEAgLTU1OSw5ICs1NTUsNiBAQCBjbGFz cyBCdWlsZEFuZFRlc3RGYWN0b3J5KEZhY3RvcnkpOgogICAgICAgICBpZiBwbGF0Zm9ybS5zdGFy dHN3aXRoKCJjaHJvbWl1bSIpOgogICAgICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1bkNocm9taXVt V2ViS2l0VW5pdFRlc3RzKQogICAgICAgICBzZWxmLmFkZFN0ZXAoc2VsZi5UZXN0Q2xhc3MpCi0g ICAgICAgICMgRklYTUU6IE9ubHkgcnVubmluZyBpbiBkZWJ1ZyBtb2RlIGR1ZSB0byBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjE4MTIKLSAgICAgICAgaWYgY29uZmln dXJhdGlvbiA9PSAiZGVidWciOgotICAgICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1blVuaXRUZXN0 cykKICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1blB5dGhvblRlc3RzKQogICAgICAgICAjIENocm9t aXVtIFdpbiBydW5zIGluIG5vbi1DeWd3aW4gZW52aXJvbm1lbnQsIHdoaWNoIGlzIG5vdCB5ZXQg Zml0CiAgICAgICAgICMgZm9yIHJ1bm5pbmcgdGVzdHMuIFRoaXMgY2FuIGJlIHJlbW92ZWQgb25j ZSBidWcgNDgxNjYgaXMgZml4ZWQuCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29s cy9DaGFuZ2VMb2cKaW5kZXggOTExNzkwMi4uMWFhN2I0MyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hh bmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTA2LTIx ICBEbWl0cnkgTG9tb3YgIDxkc2xvbW92QGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTYzMDgwCisgICAgICAgIFVuaXQtdGVzdHMgc3RlcCBvbiB0ZXN0LW9ubHkg Ym90IGlzIGJyb2tlbi4KKyAgICAgICAgUmVtb3ZpbmcgdGhlIHN0ZXAgdW50aWwgcnVuLWFwaS10 ZXN0cyBpcyBmaXhlZC4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtp dC5vcmctY29uZmlnL21hc3Rlci5jZmc6CisKIDIwMTEtMDYtMjAgIERtaXRyeSBMb21vdiAgPGRz bG9tb3ZAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4K 98030 2011-06-21 11:53:57 -0700 2011-06-21 12:58:50 -0700 Not disabling on build-and-test bots; disabling on non-(win and mac) 63080.patch text/plain 1841 dslomov ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL21hc3Rlci5jZmcgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IDVjMmY0YzUuLjQzNjdjNmMgMTAwNjQ0Ci0tLSBhL1Rv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcK KysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz dGVyLmNmZwpAQCAtNTM1LDEwICs1MzUsNiBAQCBjbGFzcyBUZXN0RmFjdG9yeShGYWN0b3J5KToK ICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1bkphdmFTY3JpcHRDb3JlVGVzdHMsIGJ1aWxkSlNDVG9v bD1GYWxzZSkKICAgICAgICAgc2VsZi5hZGRTdGVwKHNlbGYuVGVzdENsYXNzLCBidWlsZEpTQ1Rv b2w9KHBsYXRmb3JtICE9ICd3aW4nKSkKIAotICAgICAgICAjIEZJWE1FOiBPbmx5IHJ1bm5pbmcg aW4gZGVidWcgbW9kZSBkdWUgdG8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTYxODEyCi0gICAgICAgIGlmIGNvbmZpZ3VyYXRpb24gPT0gImRlYnVnIjoKLSAgICAgICAg ICAgIHNlbGYuYWRkU3RlcChSdW5Vbml0VGVzdHMpCi0KICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1 blB5dGhvblRlc3RzKQogICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuUGVybFRlc3RzKQogICAgICAg ICBzZWxmLmFkZFN0ZXAoUnVuQmluZGluZ3NUZXN0cykKQEAgLTU2MCw3ICs1NTYsNyBAQCBjbGFz cyBCdWlsZEFuZFRlc3RGYWN0b3J5KEZhY3RvcnkpOgogICAgICAgICAgICAgc2VsZi5hZGRTdGVw KFJ1bkNocm9taXVtV2ViS2l0VW5pdFRlc3RzKQogICAgICAgICBzZWxmLmFkZFN0ZXAoc2VsZi5U ZXN0Q2xhc3MpCiAgICAgICAgICMgRklYTUU6IE9ubHkgcnVubmluZyBpbiBkZWJ1ZyBtb2RlIGR1 ZSB0byBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjE4MTIKLSAgICAg ICAgaWYgY29uZmlndXJhdGlvbiA9PSAiZGVidWciOgorICAgICAgICBpZiBjb25maWd1cmF0aW9u ID09ICJkZWJ1ZyIgYW5kIChwbGF0Zm9ybSA9PSAnbWFjJyBvciBwbGF0Zm9ybSA9PSAnd2luJyk6 CiAgICAgICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuVW5pdFRlc3RzKQogICAgICAgICBzZWxmLmFk ZFN0ZXAoUnVuUHl0aG9uVGVzdHMpCiAgICAgICAgICMgQ2hyb21pdW0gV2luIHJ1bnMgaW4gbm9u LUN5Z3dpbiBlbnZpcm9ubWVudCwgd2hpY2ggaXMgbm90IHlldCBmaXQKZGlmZiAtLWdpdCBhL1Rv b2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5MTE3OTAyLi4xYWE3YjQzIDEw MDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTMgQEAKKzIwMTEtMDYtMjEgIERtaXRyeSBMb21vdiAgPGRzbG9tb3ZAZ29vZ2xlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjMwODAKKyAgICAgICAgVW5pdC10ZXN0 cyBzdGVwIG9uIHRlc3Qtb25seSBib3QgaXMgYnJva2VuLgorICAgICAgICBSZW1vdmluZyB0aGUg c3RlcCB1bnRpbCBydW4tYXBpLXRlc3RzIGlzIGZpeGVkLgorCisgICAgICAgICogQnVpbGRTbGF2 ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZzoKKwogMjAxMS0wNi0y MCAgRG1pdHJ5IExvbW92ICA8ZHNsb21vdkBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERhdmlkIExldmluLgo=