63065 2011-06-21 06:35:26 -0700 IndexedDB: should throw TypeError when indexedDB.open() name argument is missing 2011-06-21 14:07:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 pilgrim webkit-unassigned abarth dgrogan fishd hans tony webkit.review.bot oldest_to_newest 424421 0 pilgrim 2011-06-21 06:35:26 -0700 Follow-on to bug 62398, which incorrectly fixed this issue. (My bad.) As per WebIDL spec, missing required arguments should throw a TypeError, not a database exception. Patch + fixed test case attached. 424423 1 97978 pilgrim 2011-06-21 06:38:03 -0700 Created attachment 97978 Patch 424426 2 hans 2011-06-21 06:47:24 -0700 Looks good to me. 424742 3 97978 webkit.review.bot 2011-06-21 14:07:13 -0700 Comment on attachment 97978 Patch Clearing flags on attachment: 97978 Committed r89378: <http://trac.webkit.org/changeset/89378> 424743 4 webkit.review.bot 2011-06-21 14:07:18 -0700 All reviewed patches have been landed. Closing bug. 97978 2011-06-21 06:38:03 -0700 2011-06-21 14:07:13 -0700 Patch bug-63065-20110621093802.patch text/plain 3480 pilgrim SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5MzUwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDYtMjEgIE1hcmsgUGls Z3JpbSAgPHBpbGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEluZGV4ZWREQjogc2hvdWxkIHRocm93IFR5cGVFcnJvciB3 aGVuIGluZGV4ZWREQi5vcGVuKCkgbmFtZSBhcmd1bWVudCBpcyBtaXNzaW5nCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzA2NQorCisgICAgICAgICog c3RvcmFnZS9JREJGYWN0b3J5LmlkbDogcmVtb3ZlIExlZ2FjeURlZmF1bHRPcHRpb25hbEFyZ3Vt ZW50cyBmbGFnCisgICAgICAgIGFuZCBmaXggZnVuY3Rpb24gYXJndW1lbnQgZmxhZ3MKKwogMjAx MS0wNi0yMSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGdvb2dsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgWXVyeSBTZW1pa2hhdHNreS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3N0b3Jh Z2UvSURCRmFjdG9yeS5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvc3RvcmFnZS9J REJGYWN0b3J5LmlkbAkocmV2aXNpb24gODkzMjEpCisrKyBTb3VyY2UvV2ViQ29yZS9zdG9yYWdl L0lEQkZhY3RvcnkuaWRsCSh3b3JraW5nIGNvcHkpCkBAIC0yNiwxMCArMjYsOSBAQAogbW9kdWxl IHN0b3JhZ2UgewogCiAgICAgaW50ZXJmYWNlIFsKLSAgICAgICAgTGVnYWN5RGVmYXVsdE9wdGlv bmFsQXJndW1lbnRzLAogICAgICAgICBDb25kaXRpb25hbD1JTkRFWEVEX0RBVEFCQVNFCiAgICAg XSBJREJGYWN0b3J5IHsKLSAgICAgICAgW0NhbGxXaXRoPVNjcmlwdEV4ZWN1dGlvbkNvbnRleHRd IElEQlJlcXVlc3Qgb3BlbihpbiBbQ29udmVydFVuZGVmaW5lZE9yTnVsbFRvTnVsbFN0cmluZ10g RE9NU3RyaW5nIG5hbWUpCisgICAgICAgIFtDYWxsV2l0aD1TY3JpcHRFeGVjdXRpb25Db250ZXh0 XSBJREJSZXF1ZXN0IG9wZW4oaW4gW0NvbnZlcnROdWxsVG9OdWxsU3RyaW5nXSBET01TdHJpbmcg bmFtZSkKICAgICAgICAgICAgIHJhaXNlcyAoSURCRGF0YWJhc2VFeGNlcHRpb24pOwogICAgIH07 CiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5MzUwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDYtMjEgIE1hcmsgUGlsZ3JpbSAg PHBpbGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEluZGV4ZWREQjogc2hvdWxkIHRocm93IFR5cGVFcnJvciB3aGVuIGlu ZGV4ZWREQi5vcGVuKCkgbmFtZSBhcmd1bWVudCBpcyBtaXNzaW5nCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzA2NQorCisgICAgICAgICogc3RvcmFn ZS9pbmRleGVkZGIvZGF0YWJhc2UtbmFtZS11bmRlZmluZWQtZXhwZWN0ZWQudHh0OgorICAgICAg ICAqIHN0b3JhZ2UvaW5kZXhlZGRiL2RhdGFiYXNlLW5hbWUtdW5kZWZpbmVkLmh0bWw6CisKIDIw MTEtMDYtMjEgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KSW5kZXg6IExheW91dFRlc3RzL3N0b3JhZ2Uv aW5kZXhlZGRiL2RhdGFiYXNlLW5hbWUtdW5kZWZpbmVkLWV4cGVjdGVkLnR4dAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9kYXRhYmFzZS1uYW1lLXVuZGVmaW5l ZC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDg5MzIxKQorKysgTGF5b3V0VGVzdHMvc3RvcmFnZS9p bmRleGVkZGIvZGF0YWJhc2UtbmFtZS11bmRlZmluZWQtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNv cHkpCkBAIC0xMSw5ICsxMSw4IEBAIElEQkN1cnNvciA9IHdpbmRvdy5JREJDdXJzb3IgfHwgd2lu ZG93LncKIFBBU1MgSURCQ3Vyc29yID09IG51bGwgaXMgZmFsc2UKIElEQktleVJhbmdlID0gd2lu ZG93LklEQktleVJhbmdlIHx8IHdpbmRvdy53ZWJraXRJREJLZXlSYW5nZTsKIFBBU1MgSURCS2V5 UmFuZ2UgPT0gbnVsbCBpcyBmYWxzZQotRXhwZWN0aW5nIGV4Y2VwdGlvbiBmcm9tIGluZGV4ZWRE Qi5vcGVuKCk7Ci1QQVNTIEV4Y2VwdGlvbiB3YXMgdGhyb3duLgotUEFTUyBjb2RlIGlzIElEQkRh dGFiYXNlRXhjZXB0aW9uLk5PTl9UUkFOU0lFTlRfRVJSCitQQVNTIGluZGV4ZWREQi5vcGVuKCk7 IHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IE5vdCBlbm91Z2ggYXJndW1lbnRzLgorUEFTUyBp bmRleGVkREIub3BlbihudWxsKTsgdGhyZXcgZXhjZXB0aW9uIEVycm9yOiBOT05fVFJBTlNJRU5U X0VSUjogRE9NIElEQkRhdGFiYXNlIEV4Y2VwdGlvbiAyLgogUEFTUyBzdWNjZXNzZnVsbHlQYXJz ZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCkluZGV4OiBMYXlvdXRUZXN0cy9zdG9yYWdlL2lu ZGV4ZWRkYi9kYXRhYmFzZS1uYW1lLXVuZGVmaW5lZC5odG1sCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2RhdGFiYXNlLW5hbWUtdW5kZWZpbmVkLmh0bWwJKHJl dmlzaW9uIDg5MzIxKQorKysgTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvZGF0YWJhc2Ut bmFtZS11bmRlZmluZWQuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMjYsNyArMjYsOCBAQCBmdW5j dGlvbiB0ZXN0KCkKICAgICBJREJLZXlSYW5nZSA9IGV2YWxBbmRMb2coIklEQktleVJhbmdlID0g d2luZG93LklEQktleVJhbmdlIHx8IHdpbmRvdy53ZWJraXRJREJLZXlSYW5nZTsiKTsKICAgICBz aG91bGRCZUZhbHNlKCJJREJLZXlSYW5nZSA9PSBudWxsIik7CiAKLSAgICBldmFsQW5kRXhwZWN0 RXhjZXB0aW9uKCJpbmRleGVkREIub3BlbigpOyIsICJJREJEYXRhYmFzZUV4Y2VwdGlvbi5OT05f VFJBTlNJRU5UX0VSUiIpOworICAgIHNob3VsZFRocm93KCJpbmRleGVkREIub3BlbigpOyIpOwor ICAgIHNob3VsZFRocm93KCJpbmRleGVkREIub3BlbihudWxsKTsiKTsKICAgICBkb25lKCk7CiB9 CiAK