63053 2011-06-21 00:34:55 -0700 IndexedDB: createObjectStore() should check if keypath is valid 2011-10-14 13:42:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 63054 P2 Normal --- 0 haraken webkit-unassigned haraken jsbell robin.qiu.dev oldest_to_newest 424332 0 haraken 2011-06-21 00:34:55 -0700 The spec (http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBDatabase-createObjectStore-IDBObjectStore-DOMString-name-Object-optionalParameters) says "If keyPath is an array and any items in the array is not a valid key path, or if keyPath is a string and is not a valid key path then a NON_TRANSIENT_ERR error must be thrown". However, the current createObjectStore() does not check the keypath argument and thus it does not throw any exception when we give an invalid keypath. I attached the test case that should throw an exception. 447602 1 robin.qiu.dev 2011-08-06 05:58:10 -0700 Forgot to attach the test case? 447603 2 robin.qiu.dev 2011-08-06 06:09:02 -0700 This bug was fixed, in commit 63663e38. 85 63663e38 Source/WebCore/storage/IDBDatabase.cpp (commit-queue@webkit.org 2011-06-22 20:09:05 +0000 85) if (!IDBIsValidKeyPath(keyPath)) { 86 63663e38 Source/WebCore/storage/IDBDatabase.cpp (commit-queue@webkit.org 2011-06-22 20:09:05 +0000 86) ec = IDBDatabaseException::NON_TRANSIENT_ERR; 87 63663e38 Source/WebCore/storage/IDBDatabase.cpp (commit-queue@webkit.org 2011-06-22 20:09:05 +0000 87) return 0; 88 63663e38 Source/WebCore/storage/IDBDatabase.cpp (commit-queue@webkit.org 2011-06-22 20:09:05 +0000 88) } 89 63663e38 Source/WebCore/storage/IDBDatabase.cpp (commit-queue@webkit.org 2011-06-22 20:09:05 +0000 89) 447604 3 robin.qiu.dev 2011-08-06 06:18:42 -0700 Duplicate bug, see bug 63054. 484245 4 jsbell 2011-10-14 13:42:32 -0700 *** This bug has been marked as a duplicate of bug 63054 ***