63051 2011-06-21 00:25:19 -0700 Web Inspector: [Chromium] Path finding to window objects has stopped working after we started to report DOMWindow URL 2011-06-21 02:52:53 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mnaganov mnaganov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 424323 0 mnaganov 2011-06-21 00:25:19 -0700 We need to compare with DOMWindow only the beginning of the object name, not the whole name. 424324 1 97941 mnaganov 2011-06-21 00:27:15 -0700 Created attachment 97941 patch 424360 2 mnaganov 2011-06-21 02:52:53 -0700 Manually committed http://trac.webkit.org/changeset/89344 2011-06-21 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Yury Semikhatsky. Web Inspector: [Chromium] Fix path finding to window objects. https://bugs.webkit.org/show_bug.cgi?id=63051 * inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotRetainingPathsList.prototype._setRootChildrenForFinder): 97941 2011-06-21 00:27:15 -0700 2011-06-21 01:51:22 -0700 patch patch-63051 text/plain 1345 mnaganov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjOTVjZDQ4Li4zYWMwYWRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDYtMjEgIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBbQ2hyb21pdW1dIEZpeCBwYXRoIGZpbmRpbmcgdG8gd2luZG93IG9iamVjdHMuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzA1MQorCisg ICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9EZXRhaWxlZEhlYXBzaG90Vmlldy5qczoKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RSZXRhaW5pbmdQYXRoc0xpc3QucHJvdG90 eXBlLl9zZXRSb290Q2hpbGRyZW5Gb3JGaW5kZXIpOgorCiAyMDExLTA2LTIwICBEYWkgTWlrdXJ1 YmUgIDxkbWlrdXJ1YmVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbnQg VGFtdXJhLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9E ZXRhaWxlZEhlYXBzaG90Vmlldy5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvRGV0YWlsZWRIZWFwc2hvdFZpZXcuanMKaW5kZXggMzljNTk2OS4uY2IxMjZlYyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EZXRhaWxlZEhlYXBzaG90 Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RldGFpbGVk SGVhcHNob3RWaWV3LmpzCkBAIC00NjEsNyArNDYxLDcgQEAgV2ViSW5zcGVjdG9yLkhlYXBTbmFw c2hvdFJldGFpbmluZ1BhdGhzTGlzdC5wcm90b3R5cGUgPSB7CiAgICAgewogICAgICAgICBpZiAo dGhpcy5zbmFwc2hvdFZpZXcuaXNUcmFjaW5nVG9XaW5kb3dPYmplY3RzKQogICAgICAgICAgICAg dGhpcy5wYXRoRmluZGVyLnVwZGF0ZVJvb3RzKAotICAgICAgICAgICAgICAgICJmdW5jdGlvbiAo bm9kZSkgeyByZXR1cm4gbm9kZS5uYW1lID09PSBcIkRPTVdpbmRvd1wiOyB9Iik7CisgICAgICAg ICAgICAgICAgImZ1bmN0aW9uIChub2RlKSB7IHJldHVybiBub2RlLm5hbWUuc3Vic3RyKDAsIDkp ID09PSBcIkRPTVdpbmRvd1wiOyB9Iik7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIHRoaXMu cGF0aEZpbmRlci51cGRhdGVSb290cygpOwogICAgIH0sCg==