<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>63046</bug_id>
          
          <creation_ts>2011-06-20 23:36:36 -0700</creation_ts>
          <short_desc>HTMLLIElement::attach() seems incorrect</short_desc>
          <delta_ts>2012-07-25 19:10:50 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>72352</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Roland Steiner">rolandsteiner</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>dominicc</cc>
    
    <cc>haraken</cc>
    
    <cc>hayato</cc>
    
    <cc>morrita</cc>
    
    <cc>shinyak</cc>
    
    <cc>shinyak</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>424293</commentid>
    <comment_count>0</comment_count>
    <who name="Roland Steiner">rolandsteiner</who>
    <bug_when>2011-06-20 23:36:36 -0700</bug_when>
    <thetext>HTMLLIElement::attach() searches its parents for the containing list. However:

.) It ignores intervening &quot;terrain&quot;, so will happily pass through whole tables, etc.
.) It doesn&apos;t check the element&apos;s display type, so will accept an &lt;ol&gt; or &lt;ul&gt;, even if their display type is not [un]ordered list. And conversely, it will not consider other elements even if their display type is set to list.

This seems incorrect.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>424294</commentid>
    <comment_count>1</comment_count>
    <who name="Roland Steiner">rolandsteiner</who>
    <bug_when>2011-06-20 23:37:06 -0700</bug_when>
    <thetext>i should add that the only outcome of this is incorrect styling.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>424295</commentid>
    <comment_count>2</comment_count>
    <who name="Roland Steiner">rolandsteiner</who>
    <bug_when>2011-06-20 23:38:11 -0700</bug_when>
    <thetext>It will also fail if the &lt;li&gt; is inside shadow DOM, and the containing &lt;ol&gt;/&lt;ul&gt; is outside - i.e., parentNode() should be changed to parentOrHostNode().</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>424366</commentid>
    <comment_count>3</comment_count>
    <who name="Dominic Cooney">dominicc</who>
    <bug_when>2011-06-21 03:22:53 -0700</bug_when>
    <thetext>(In reply to comment #0)
&gt; HTMLLIElement::attach() searches its parents for the containing list. However:
&gt; 
&gt; .) It ignores intervening &quot;terrain&quot;, so will happily pass through whole tables, etc.

That seems busted.

&gt; .) It doesn&apos;t check the element&apos;s display type, so will accept an &lt;ol&gt; or &lt;ul&gt;, even if their display type is not [un]ordered list. And conversely, it will not consider other elements even if their display type is set to list.

This seems OK. What is the problem with this behavior?

&gt; This seems incorrect.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>424821</commentid>
    <comment_count>4</comment_count>
    <who name="Roland Steiner">rolandsteiner</who>
    <bug_when>2011-06-21 15:52:58 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; (In reply to comment #0)
&gt; &gt; .) It doesn&apos;t check the element&apos;s display type, so will accept an &lt;ol&gt; or &lt;ul&gt;, even if their display type is not [un]ordered list. And conversely, it will not consider other elements even if their display type is set to list.
&gt; 
&gt; This seems OK. What is the problem with this behavior?

You&apos;re right, of course, esp. as there IS NO &apos;list&apos; display type (just &apos;list-item&apos;). @_@;;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>503449</commentid>
    <comment_count>5</comment_count>
    <who name="Dominic Cooney">dominicc</who>
    <bug_when>2011-11-15 16:53:08 -0800</bug_when>
    <thetext>May be related to bug 72440.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>678752</commentid>
    <comment_count>6</comment_count>
    <who name="Hajime Morrita">morrita</who>
    <bug_when>2012-07-25 19:10:50 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/123570 fixed this.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>