63032 2011-06-20 18:21:00 -0700 IndexedDB: cursor update() value argument is required 2011-06-21 13:42:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 pilgrim webkit-unassigned abarth dgrogan fishd hans tony webkit.review.bot oldest_to_newest 424149 0 pilgrim 2011-06-20 18:21:00 -0700 http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBCursor-update-IDBRequest-any-value states that the value argument to update() must be present (required and not null). This test calls update() without any arguments. Expected behavior: throw TypeError Actual behavior: does not throw Test case + patch attached. 424152 1 97901 pilgrim 2011-06-20 18:23:23 -0700 Created attachment 97901 Patch 424178 2 dgrogan 2011-06-20 18:56:22 -0700 LGTM 424715 3 97901 webkit.review.bot 2011-06-21 13:42:40 -0700 Comment on attachment 97901 Patch Clearing flags on attachment: 97901 Committed r89375: <http://trac.webkit.org/changeset/89375> 424716 4 webkit.review.bot 2011-06-21 13:42:45 -0700 All reviewed patches have been landed. Closing bug. 97901 2011-06-20 18:23:23 -0700 2011-06-21 13:42:40 -0700 Patch bug-63032-20110620212322.patch text/plain 7068 pilgrim SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5MzI1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMjAgIE1hcmsgUGls Z3JpbSAgPHBpbGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEluZGV4ZWREQjogY3Vyc29yIHVwZGF0ZSgpIHZhbHVlIGFy Z3VtZW50IGlzIHJlcXVpcmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02MzAzMgorCisgICAgICAgIFRlc3Q6IHN0b3JhZ2UvaW5kZXhlZGRiL2N1cnNv ci11cGRhdGUtdmFsdWUtYXJndW1lbnQtcmVxdWlyZWQuaHRtbAorCisgICAgICAgICogc3RvcmFn ZS9JREJDdXJzb3IuaWRsOiByZW1vdmUgTGVnYWN5RGVmYXVsdE9wdGlvbmFsQXJndW1lbnRzIGZs YWcgc28KKyAgICAgICAgICBjYWxsaW5nIGZ1bmN0aW9ucyB3aXRoIG1pc3NpbmcgcmVxdWlyZWQg YXJndW1lbnRzIHdpbGwgcmFpc2UgYSBUeXBlRXJyb3IKKwogMjAxMS0wNi0yMCAgQWRhbSBCYXJ0 aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIE1hYyBidWlsZCBmaXguICBJbiBhZGRp dGlvbiB0byBhZGRpbmcgdGhlIGZpbGVzIHRvIHRoZSBwcm9qZWN0LCB3ZSBuZWVkCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9zdG9yYWdlL0lEQkN1cnNvci5pZGwKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvc3RvcmFnZS9JREJDdXJzb3IuaWRsCShyZXZpc2lvbiA4OTMyMSkKKysrIFNvdXJj ZS9XZWJDb3JlL3N0b3JhZ2UvSURCQ3Vyc29yLmlkbAkod29ya2luZyBjb3B5KQpAQCAtMjcsNyAr MjcsNiBAQCBtb2R1bGUgc3RvcmFnZSB7CiAKICAgICBpbnRlcmZhY2UgWwogICAgICAgICBDb25k aXRpb25hbD1JTkRFWEVEX0RBVEFCQVNFLAotICAgICAgICBMZWdhY3lEZWZhdWx0T3B0aW9uYWxB cmd1bWVudHMsCiAgICAgXSBJREJDdXJzb3IgewogICAgICAgICBjb25zdCB1bnNpZ25lZCBzaG9y dCBORVhUID0gMDsKICAgICAgICAgY29uc3QgdW5zaWduZWQgc2hvcnQgTkVYVF9OT19EVVBMSUNB VEUgPSAxOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gODkzMjUpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0wNi0yMCAgTWFyayBQaWxn cmltICA8cGlsZ3JpbUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgSW5kZXhlZERCOiBjdXJzb3IgdXBkYXRlKCkgdmFsdWUgYXJn dW1lbnQgaXMgcmVxdWlyZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTYzMDMyCisKKyAgICAgICAgKiBzdG9yYWdlL2luZGV4ZWRkYi9jdXJzb3ItdXBk YXRlLXZhbHVlLWFyZ3VtZW50LXJlcXVpcmVkLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAg ICogc3RvcmFnZS9pbmRleGVkZGIvY3Vyc29yLXVwZGF0ZS12YWx1ZS1hcmd1bWVudC1yZXF1aXJl ZC5odG1sOiBBZGRlZC4KKwogMjAxMS0wNi0yMCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQu b3JnPgogCiAgICAgICAgIFVwZGF0ZSBpbWFnZSByZXN1bHRzIGFmdGVyIG1waWxncmltJ3MgZXhj ZXB0aW9uIHR5cGUgY2hhbmdlLgpJbmRleDogTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIv Y3Vyc29yLXVwZGF0ZS12YWx1ZS1hcmd1bWVudC1yZXF1aXJlZC1leHBlY3RlZC50eHQKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvY3Vyc29yLXVwZGF0ZS12YWx1 ZS1hcmd1bWVudC1yZXF1aXJlZC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRU ZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9jdXJzb3ItdXBkYXRlLXZhbHVlLWFyZ3VtZW50LXJlcXVp cmVkLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzOCBAQAorVGVzdCBJbmRl eGVkREIgY3Vyc29yLnVwZGF0ZSByZXF1aXJlZCBhcmd1bWVudHMKKworT24gc3VjY2VzcywgeW91 IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1Qg Q09NUExFVEUiLgorCisKK2luZGV4ZWREQiA9IHdpbmRvdy5pbmRleGVkREIgfHwgd2luZG93Lndl YmtpdEluZGV4ZWREQiB8fCB3aW5kb3cubW96SW5kZXhlZERCOworUEFTUyBpbmRleGVkREIgPT0g bnVsbCBpcyBmYWxzZQorSURCRGF0YWJhc2VFeGNlcHRpb24gPSB3aW5kb3cuSURCRGF0YWJhc2VF eGNlcHRpb24gfHwgd2luZG93LndlYmtpdElEQkRhdGFiYXNlRXhjZXB0aW9uOworUEFTUyBJREJE YXRhYmFzZUV4Y2VwdGlvbiA9PSBudWxsIGlzIGZhbHNlCitJREJDdXJzb3IgPSB3aW5kb3cuSURC Q3Vyc29yIHx8IHdpbmRvdy53ZWJraXRJREJDdXJzb3I7CitQQVNTIElEQkN1cnNvciA9PSBudWxs IGlzIGZhbHNlCitJREJLZXlSYW5nZSA9IHdpbmRvdy5JREJLZXlSYW5nZSB8fCB3aW5kb3cud2Vi a2l0SURCS2V5UmFuZ2U7CitQQVNTIElEQktleVJhbmdlID09IG51bGwgaXMgZmFsc2UKK2luZGV4 ZWREQi5vcGVuKG5hbWUsIGRlc2NyaXB0aW9uKQorZGIgPSBldmVudC50YXJnZXQucmVzdWx0City ZXF1ZXN0ID0gZGIuc2V0VmVyc2lvbignMScpCitEZWxldGVkIGFsbCBvYmplY3Qgc3RvcmVzLgor ZGIuY3JlYXRlT2JqZWN0U3RvcmUoJ2F1dG9JbmNyZW1lbnQnLCB7IGF1dG9JbmNyZW1lbnQ6IHRy dWUgfSk7CityZXF1ZXN0ID0gb2JqZWN0U3RvcmUub3BlbkN1cnNvcigpOwora2V5cyA9IFsxLCAt MSwgMCwgMTAsIDIwMDAsICdxJywgJ3onLCAndHdvJywgJ2InLCAnYSddOwora2V5SW5kZXggPSAw OworcmVxdWVzdCA9IG9iamVjdFN0b3JlLmFkZCgnZm9vJywga2V5c1tpXSk7CityZXF1ZXN0ID0g b2JqZWN0U3RvcmUuYWRkKCdmb28nLCBrZXlzW2ldKTsKK3JlcXVlc3QgPSBvYmplY3RTdG9yZS5h ZGQoJ2ZvbycsIGtleXNbaV0pOworcmVxdWVzdCA9IG9iamVjdFN0b3JlLmFkZCgnZm9vJywga2V5 c1tpXSk7CityZXF1ZXN0ID0gb2JqZWN0U3RvcmUuYWRkKCdmb28nLCBrZXlzW2ldKTsKK3JlcXVl c3QgPSBvYmplY3RTdG9yZS5hZGQoJ2ZvbycsIGtleXNbaV0pOworcmVxdWVzdCA9IG9iamVjdFN0 b3JlLmFkZCgnZm9vJywga2V5c1tpXSk7CityZXF1ZXN0ID0gb2JqZWN0U3RvcmUuYWRkKCdmb28n LCBrZXlzW2ldKTsKK3JlcXVlc3QgPSBvYmplY3RTdG9yZS5hZGQoJ2ZvbycsIGtleXNbaV0pOwor cmVxdWVzdCA9IG9iamVjdFN0b3JlLmFkZCgnZm9vJywga2V5c1tpXSk7CityZXF1ZXN0ID0gb2Jq ZWN0U3RvcmUub3BlbkN1cnNvcigpOworY3Vyc29yID0gZXZlbnQudGFyZ2V0LnJlc3VsdDsKK1BB U1MgY3Vyc29yLnVwZGF0ZSgpOyB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBOb3QgZW5vdWdo IGFyZ3VtZW50cy4KK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01Q TEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9jdXJzb3ItdXBkYXRl LXZhbHVlLWFyZ3VtZW50LXJlcXVpcmVkLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv c3RvcmFnZS9pbmRleGVkZGIvY3Vyc29yLXVwZGF0ZS12YWx1ZS1hcmd1bWVudC1yZXF1aXJlZC5o dG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvY3Vyc29y LXVwZGF0ZS12YWx1ZS1hcmd1bWVudC1yZXF1aXJlZC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCww ICsxLDk3IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0 eWxlc2hlZXQiIGhyZWY9Ii4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3Nz Ij4KKzxzY3JpcHQgc3JjPSIuLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+ PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1w b3N0LWZ1bmN0aW9uLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvc2hhcmVk LmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+ Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQ+CisKK2Rlc2NyaXB0aW9uKCJUZXN0 IEluZGV4ZWREQiBjdXJzb3IudXBkYXRlIHJlcXVpcmVkIGFyZ3VtZW50cyIpOworaWYgKHdpbmRv dy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50 aWxEb25lKCk7CisKK2Z1bmN0aW9uIHRlc3QoKQoreworICAgIGluZGV4ZWREQiA9IGV2YWxBbmRM b2coImluZGV4ZWREQiA9IHdpbmRvdy5pbmRleGVkREIgfHwgd2luZG93LndlYmtpdEluZGV4ZWRE QiB8fCB3aW5kb3cubW96SW5kZXhlZERCOyIpOworICAgIHNob3VsZEJlRmFsc2UoImluZGV4ZWRE QiA9PSBudWxsIik7CisgICAgSURCRGF0YWJhc2VFeGNlcHRpb24gPSBldmFsQW5kTG9nKCJJREJE YXRhYmFzZUV4Y2VwdGlvbiA9IHdpbmRvdy5JREJEYXRhYmFzZUV4Y2VwdGlvbiB8fCB3aW5kb3cu d2Via2l0SURCRGF0YWJhc2VFeGNlcHRpb247Iik7CisgICAgc2hvdWxkQmVGYWxzZSgiSURCRGF0 YWJhc2VFeGNlcHRpb24gPT0gbnVsbCIpOworICAgIElEQkN1cnNvciA9IGV2YWxBbmRMb2coIklE QkN1cnNvciA9IHdpbmRvdy5JREJDdXJzb3IgfHwgd2luZG93LndlYmtpdElEQkN1cnNvcjsiKTsK KyAgICBzaG91bGRCZUZhbHNlKCJJREJDdXJzb3IgPT0gbnVsbCIpOworICAgIElEQktleVJhbmdl ID0gZXZhbEFuZExvZygiSURCS2V5UmFuZ2UgPSB3aW5kb3cuSURCS2V5UmFuZ2UgfHwgd2luZG93 LndlYmtpdElEQktleVJhbmdlOyIpOworICAgIHNob3VsZEJlRmFsc2UoIklEQktleVJhbmdlID09 IG51bGwiKTsKKworICAgIG5hbWUgPSB3aW5kb3cubG9jYXRpb24ucGF0aG5hbWU7CisgICAgZGVz Y3JpcHRpb24gPSAiTXkgVGVzdCBEYXRhYmFzZSI7CisgICAgcmVxdWVzdCA9IGV2YWxBbmRMb2co ImluZGV4ZWREQi5vcGVuKG5hbWUsIGRlc2NyaXB0aW9uKSIpOworICAgIHJlcXVlc3Qub25zdWNj ZXNzID0gb3BlblN1Y2Nlc3M7CisgICAgcmVxdWVzdC5vbmVycm9yID0gdW5leHBlY3RlZEVycm9y Q2FsbGJhY2s7Cit9CisKK2Z1bmN0aW9uIG9wZW5TdWNjZXNzKCkKK3sKKyAgICBkYiA9IGV2YWxB bmRMb2coImRiID0gZXZlbnQudGFyZ2V0LnJlc3VsdCIpOworCisgICAgcmVxdWVzdCA9IGV2YWxB bmRMb2coInJlcXVlc3QgPSBkYi5zZXRWZXJzaW9uKCcxJykiKTsKKyAgICByZXF1ZXN0Lm9uc3Vj Y2VzcyA9IHRlc3RHcm91cDE7CisgICAgcmVxdWVzdC5vbmVycm9yID0gdW5leHBlY3RlZEVycm9y Q2FsbGJhY2s7Cit9CisKK2Z1bmN0aW9uIHRlc3RHcm91cDEoKQoreworICAgIGRlbGV0ZUFsbE9i amVjdFN0b3JlcyhkYik7CisKKyAgICBvYmplY3RTdG9yZSA9IGV2YWxBbmRMb2coImRiLmNyZWF0 ZU9iamVjdFN0b3JlKCdhdXRvSW5jcmVtZW50JywgeyBhdXRvSW5jcmVtZW50OiB0cnVlIH0pOyIp OworCisgICAgcmVxdWVzdCA9IGV2YWxBbmRMb2coInJlcXVlc3QgPSBvYmplY3RTdG9yZS5vcGVu Q3Vyc29yKCk7Iik7CisgICAgcmVxdWVzdC5vbmVycm9yID0gdW5leHBlY3RlZEVycm9yQ2FsbGJh Y2s7CisgICAgcmVxdWVzdC5vbnN1Y2Nlc3MgPSBmdW5jdGlvbiAoZXZlbnQpIHsKKyAgICAgIHRl c3RHcm91cDIoKTsKKyAgICB9Cit9CisKK2Z1bmN0aW9uIHRlc3RHcm91cDIoKQoreworICAgIGtl eXMgPSBldmFsQW5kTG9nKCJrZXlzID0gWzEsIC0xLCAwLCAxMCwgMjAwMCwgJ3EnLCAneicsICd0 d28nLCAnYicsICdhJ107Iik7CisKKyAgICBrZXlJbmRleCA9IGV2YWxBbmRMb2coImtleUluZGV4 ID0gMDsiKTsKKworICAgIGZvciAoaSBpbiBrZXlzKSB7CisgICAgICByZXF1ZXN0ID0gZXZhbEFu ZExvZygicmVxdWVzdCA9IG9iamVjdFN0b3JlLmFkZCgnZm9vJywga2V5c1tpXSk7Iik7CisgICAg ICByZXF1ZXN0Lm9uZXJyb3IgPSB1bmV4cGVjdGVkRXJyb3JDYWxsYmFjazsKKyAgICAgIHJlcXVl c3Qub25zdWNjZXNzID0gZnVuY3Rpb24oZXZlbnQpIHsKKyAgICAgICAgaWYgKCsra2V5SW5kZXgg PT0ga2V5cy5sZW5ndGgpIHsKKyAgICAgICAgICB0ZXN0R3JvdXAzKCk7CisgICAgICAgIH0KKyAg ICAgIH07CisgICAgfQorfQorCitmdW5jdGlvbiB0ZXN0R3JvdXAzKCkKK3sKKyAgICByZXF1ZXN0 ID0gZXZhbEFuZExvZygicmVxdWVzdCA9IG9iamVjdFN0b3JlLm9wZW5DdXJzb3IoKTsiKTsKKyAg ICByZXF1ZXN0Lm9uZXJyb3IgPSB1bmV4cGVjdGVkRXJyb3JDYWxsYmFjazsKKyAgICByZXF1ZXN0 Lm9uc3VjY2VzcyA9IGZ1bmN0aW9uIChldmVudCkgeworICAgICAgICBjdXJzb3IgPSBldmFsQW5k TG9nKCJjdXJzb3IgPSBldmVudC50YXJnZXQucmVzdWx0OyIpOworICAgICAgICBpZiAoY3Vyc29y KSB7CisgICAgICAgICAgICBzaG91bGRUaHJvdygiY3Vyc29yLnVwZGF0ZSgpOyIpOworICAgICAg ICB9IGVsc2UgeworICAgICAgICAgICAgdGVzdEZhaWxlZCgiY3Vyc29yIHdhcyBudWxsIik7Cisg ICAgICAgIH0KKyAgICAgICAgZG9uZSgpOworICAgIH0KK30KKwordmFyIHN1Y2Nlc3NmdWxseVBh cnNlZCA9IHRydWU7CisKK3Rlc3QoKTsKKworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CisK