63020 2011-06-20 15:35:34 -0700 [GTK] Windowless plugins sometimes crash with a BadMatch error 2011-06-20 17:34:28 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 mrobinson mrobinson webkit.review.bot oldest_to_newest 423994 0 mrobinson 2011-06-20 15:35:34 -0700 #0 gdk_x_error (display=0x42a420, error=0x7fffffffc490) at /build/buildd/gtk+2.0-2.24.4/gdk/x11/gdkmain-x11.c:458 #1 0x00007fffed1aad3f in _XError () from /usr/lib/x86_64-linux-gnu/libX11.so.6 #2 0x00007fffed1a7fb1 in ?? () from /usr/lib/x86_64-linux-gnu/libX11.so.6 #3 0x00007fffed1a7ff5 in ?? () from /usr/lib/x86_64-linux-gnu/libX11.so.6 #4 0x00007fffed1a89a0 in _XReply () from /usr/lib/x86_64-linux-gnu/libX11.so.6 #5 0x00007fffed1a4103 in XSync () from /usr/lib/x86_64-linux-gnu/libX11.so.6 #6 0x00007fffed1a41ab in ?? () from /usr/lib/x86_64-linux-gnu/libX11.so.6 #7 0x00007fffed1a98df in ?? () from /usr/lib/x86_64-linux-gnu/libX11.so.6 #8 0x00007fffed184c4a in XCreatePixmap () from /usr/lib/x86_64-linux-gnu/libX11.so.6 #9 0x00007ffff5342ede in WebCore::PluginView::updatePluginWidget (this=0x7fffe07289f0) at ../../Source/WebCore/plugins/gtk/PluginViewGtk.cpp:149 #10 0x00007ffff5345b7c in WebCore::PluginView::platformStart (this=0x7fffe07289f0) at ../../Source/WebCore/plugins/gtk/PluginViewGtk.cpp:906 #11 0x00007ffff5b15764 in WebCore::PluginView::start (this=0x7fffe07289f0) at ../../Source/WebCore/plugins/PluginView.cpp:269 #12 0x00007ffff5b15309 in WebCore::PluginView::startOrAddToUnstartedList (this=0x7fffe07289f0) at ../../Source/WebCore/plugins/PluginView.cpp:224 #13 0x00007ffff5b15210 in WebCore::PluginView::init (this=0x7fffe07289f0) at ../../Source/WebCore/plugins/PluginView.cpp:202 #14 0x00007ffff53445b0 in WebCore::PluginView::setParent (this=0x7fffe07289f0, parent=0x7fffe04a9ef0) at ../../Source/WebCore/plugins/gtk/PluginViewGtk.cpp:469 #15 0x00007ffff5ad8f09 in WebCore::ScrollView::addChild (this=0x7fffe04a9ef0, prpChild=...) at ../../Source/WebCore/platform/ScrollView.cpp:72 #16 0x00007ffff5c55914 in WebCore::moveWidgetToParentSoon (child=0x7fffe07289f0, parent=0x7fffe04a9ef0) at ../../Source/WebCore/rendering/RenderWidget.cpp:90 #17 0x00007ffff5c56302 in WebCore::RenderWidget::setWidget (this=0x7fffe06e36b8, widget=...) at ../../Source/WebCore/rendering/RenderWidget.cpp:213 #18 0x00007ffff5c0b7fa in WebCore::RenderPart::setWidget (this=0x7fffe06e36b8, widget=...) at ../../Source/WebCore/rendering/RenderPart.cpp:50 #19 0x00007ffff59a7519 in WebCore::SubframeLoader::loadPlugin (this=0x7fffe04fdbe0, pluginElement=0x7fffe06d7790, url=..., mimeType="(null)", paramNames=WTF::Vector of length 5, capacity 16 = {...}, paramValues=WTF::Vector of length 5, capacity 16 = {...}, useFallback=false) at ../../Source/WebCore/loader/SubframeLoader.cpp:347 #20 0x00007ffff59a6652 in WebCore::SubframeLoader::requestObject (this=0x7fffe04fdbe0, ownerElement=0x7fffe06d7790, url="http://www.kickstarter.com/swf/kickplayer.swf?skin=http%3A%2F%2Fwww.kickstarter.com%2Fswf%2Fkickskin.swf&file=http%3A%2F%2Fs3.amazonaws.com%2Fksr%2Fprojects%2F34423%2Fvideo-39745-h264_high.mp4&allowfu"..., frameName="(null)", mimeType="(null)", paramNames=WTF::Vector of length 5, capacity 16 = {...}, paramValues=WTF::Vector of length 5, capacity 16 = {...}) at ../../Source/WebCore/loader/SubframeLoader.cpp:132 #21 0x00007ffff57f38ec in WebCore::HTMLEmbedElement::updateWidget (this=0x7fffe06d7790, pluginCreationOption=WebCore::CreateAnyWidgetType) at ../../Source/WebCore/html/HTMLEmbedElement.cpp:184 #22 0x00007ffff5a0d6cf in WebCore::FrameView::updateWidget (this=0x7fffe04a9ef0, object=0x7fffe06e36b8) at ../../Source/WebCore/page/FrameView.cpp:1854 #23 0x00007ffff5a0d8d5 in WebCore::FrameView::updateWidgets (this=0x7fffe04a9ef0) at ../../Source/WebCore/page/FrameView.cpp:1886 #24 0x00007ffff5a0db38 in WebCore::FrameView::performPostLayoutTasks (this=0x7fffe04a9ef0) at ../../Source/WebCore/page/FrameView.cpp:1930 #25 0x00007ffff5a0a749 in WebCore::FrameView::layout (this=0x7fffe04a9ef0, allowSubtree=true) at ../../Source/WebCore/page/FrameView.cpp:962 #26 0x00007ffff5c57096 in WebCore::RenderWidget::updateWidgetPosition (this=0x7fffe0524b48) at ../../Source/WebCore/rendering/RenderWidget.cpp:353 #27 0x00007ffff5c4d56d in WebCore::RenderView::updateWidgetPositions (this=0x7fffe00280b8) at ../../Source/WebCore/rendering/RenderView.cpp:614 #28 0x00007ffff5a0db23 in WebCore::FrameView::performPostLayoutTasks (this=0x7fffe0026bf0) at ../../Source/WebCore/page/FrameView.cpp:1927 #29 0x00007ffff5a0a749 in WebCore::FrameView::layout (this=0x7fffe0026bf0, allowSubtree=true) at ../../Source/WebCore/page/FrameView.cpp:962 #30 0x00007ffff565283d in WebCore::Document::updateLayout (this=0x7fffe02dcca0) at ../../Source/WebCore/dom/Document.cpp:1613 #31 0x00007ffff5bdf704 in WebCore::RenderLayer::hitTest (this=0x7fffe002e108, request=..., result=...) at ../../Source/WebCore/rendering/RenderLayer.cpp:2697 #32 0x00007ffff565697a in WebCore::Document::prepareMouseEvent (this=0x7fffe02dcca0, request=..., documentPoint=..., event=...) at ../../Source/WebCore/dom/Document.cpp:2746 #33 0x00007ffff59f216c in WebCore::EventHandler::prepareMouseEvent (this=0x46ba60, request=..., mev=...) at ../../Source/WebCore/page/EventHandler.cpp:1823 #34 0x00007ffff59f0a5b in WebCore::EventHandler::handleMouseMoveEvent (this=0x46ba60, mouseEvent=..., hoveredNode=0x7fffffffd8e0) at ../../Source/WebCore/page/EventHandler.cpp:1542 #35 0x00007ffff59f0615 in WebCore::EventHandler::mouseMoved (this=0x46ba60, event=...) at ../../Source/WebCore/page/EventHandler.cpp:1474 #36 0x00007ffff539402a in webkit_web_view_motion_event (widget=0x4b2030, event=0x7fffe02b7260) at ../../Source/WebKit/gtk/webkit/webkitwebview.cpp:925 #37 0x00007ffff4421578 in _gtk_marshal_BOOLEAN__BOXED (closure=0x465b00, return_value=0x7fffffffdbb0, n_param_values=<value optimized out>, param_values=0x7fffe013b210, invocation_hint=<value optimized out>, marshal_data=<value optimized out>) at /build/buildd/gtk+2.0-2.24.4/gtk/gtkmarshalers.c:86 #38 0x00007ffff25ef81c in g_closure_invoke () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 #39 0x00007ffff2600e1f in ?? () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 #40 0x00007ffff2609fa9 in g_signal_emit_valist () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 #41 0x00007ffff260a41f in g_signal_emit () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 #42 0x00007ffff453d4d1 in gtk_widget_event_internal (widget=0x4b2030, event=0x7fffe02b7260) at /build/buildd/gtk+2.0-2.24.4/gtk/gtkwidget.c:4988 #43 0x00007ffff441f763 in IA__gtk_propagate_event (widget=0x4b2030, event=0x7fffe02b7260) at /build/buildd/gtk+2.0-2.24.4/gtk/gtkmain.c:2495 #44 0x00007ffff441fa5b in IA__gtk_main_do_event (event=0x7fffe02b7260) at /build/buildd/gtk+2.0-2.24.4/gtk/gtkmain.c:1685 #45 0x00007ffff40925cc in gdk_event_dispatch (source=<value optimized out>, callback=<value optimized out>, user_data=<value optimized out>) at /build/buildd/gtk+2.0-2.24.4/gdk/x11/gdkevents-x11.c:2377 #46 0x00007ffff1d23bcd in g_main_context_dispatch () from /lib/x86_64-linux-gnu/libglib-2.0.so.0 #47 0x00007ffff1d243a8 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0 ---Type <return> to continue, or q <return> to quit---win #48 0x00007ffff1d249f2 in g_main_loop_run () from /lib/x86_64-linux-gnu/libglib-2.0.so.0 #49 0x00007ffff441eaf7 in IA__gtk_main () at /build/buildd/gtk+2.0-2.24.4/gtk/gtkmain.c:1257 #50 0x00000000004028d3 in main (argc=1, argv=0x7fffffffe1d8) at ../../Tools/GtkLauncher/main.c:252 I'm seeing this when browsing the front page of BoingBoing right now with a debug stable branch build. 424012 1 mrobinson 2011-06-20 15:45:25 -0700 Here's the GDK BadMatch output: This probably reflects a bug in the program. The error was 'BadValue (integer parameter out of range for operation)'. (Details: serial 3852 error_code 2 request_code 53 minor_code 0) (Note to programmers: normally, X errors are reported asynchronously; that is, you will receive the error a while after causing it. To debug your program, run it with the --sync command line option to change this behavior. You can then get a meaningful backtrace from your debugger if you break on the gdk_x_error() function.) 424020 2 mrobinson 2011-06-20 15:54:00 -0700 (In reply to comment #1) > Here's the GDK BadMatch output: > > This probably reflects a bug in the program. > The error was 'BadValue (integer parameter out of range for operation)'. > (Details: serial 3852 error_code 2 request_code 53 minor_code 0) > (Note to programmers: normally, X errors are reported asynchronously; > that is, you will receive the error a while after causing it. > To debug your program, run it with the --sync command line > option to change this behavior. You can then get a meaningful > backtrace from your debugger if you break on the gdk_x_error() function.) The issue here seems to be that the height argument of the XCreatePixmap call is zero. 424024 3 97877 mrobinson 2011-06-20 15:56:49 -0700 Created attachment 97877 Patch 424031 4 97879 mrobinson 2011-06-20 16:03:43 -0700 Created attachment 97879 Patch 424032 5 97879 xan.lopez 2011-06-20 16:05:12 -0700 Comment on attachment 97879 Patch r=me 424116 6 97879 webkit.review.bot 2011-06-20 17:34:24 -0700 Comment on attachment 97879 Patch Clearing flags on attachment: 97879 Committed r89319: <http://trac.webkit.org/changeset/89319> 424117 7 webkit.review.bot 2011-06-20 17:34:28 -0700 All reviewed patches have been landed. Closing bug. 97877 2011-06-20 15:56:49 -0700 2011-06-20 16:03:39 -0700 Patch bug-63020-20110620155648.patch text/plain 1575 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogODkyOTcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmMzE2ZTFhMmVjMWFiYjY0 MzlmNmEwNjFmNTY2NmI2Y2M1NjlmZmUzLi4yZTgyMDQ2MDk3NzNjZWU3NmUzMmYxYzcwNDk1YzQ2 MmNhNWI0MzVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDYtMjAgIE1hcnRp biBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIFdpbmRvd2xlc3MgcGx1Z2lucyBzb21l dGltZXMgY3Jhc2ggd2l0aCBhIEJhZE1hdGNoIGVycm9yCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzAyMAorCisgICAgICAgIERvIG5vdCB0cnkgdG8g Y3JlYXRlIGFuIFhQaXhtYXAgd2l0aCBhbnkgb2YgdGhlIGRpbWVuc2lvbnMgYXMgemVyby4KKwor ICAgICAgICAqIHBsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UGx1Z2luVmlldzo6dXBkYXRlUGx1Z2luV2lkZ2V0KTogR3VhcmQgYWdhaW5zdCBhbmQgZW1w dHkgd2luZG93IHJlY3QKKyAgICAgICAgYmVmb3JlIHRyeWluZyB0byBjcmVhdGUgYSB3aW5kb3ds ZXNzIHBsdWdpbiBwaXhtYXAuCisKIDIwMTEtMDYtMjAgIEplciBOb2JsZSAgPGplci5ub2JsZUBh cHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXg7IEZpeCBMZW9wYXJkIFdl YkNvcmUgYnVpbGQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL2d0ay9QbHVn aW5WaWV3R3RrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsu Y3BwCmluZGV4IDg0MTQ1MDYxYWU0ZWMzMzc0MmFmNWMyOTBlMzEwOTVmN2NhMmUxMjguLmI1ODgx Mzc3Njc0ZjBjYTlkOGQ4ZTI0YTUwMDg4MmQxZjQ3MjhkOGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwCkBAIC0xNDcsNyArMTQ3LDcgQEAgdm9pZCBQ bHVnaW5WaWV3Ojp1cGRhdGVQbHVnaW5XaWRnZXQoKQogI2lmIGRlZmluZWQoWFBfVU5JWCkKICAg ICBpZiAoIW1faXNXaW5kb3dlZCkgewogICAgICAgICBEaXNwbGF5KiBkaXNwbGF5ID0gR0RLX0RJ U1BMQVlfWERJU1BMQVkoZ2RrX2Rpc3BsYXlfZ2V0X2RlZmF1bHQoKSk7Ci0gICAgICAgIGlmICht X2RyYXdhYmxlKQorICAgICAgICBpZiAobV9kcmF3YWJsZSAmJiAhbV93aW5kb3dSZWN0LmlzRW1w dHkoKSkgewogICAgICAgICAgICAgWEZyZWVQaXhtYXAoZGlzcGxheSwgbV9kcmF3YWJsZSk7CiAg ICAgICAgICAgICAKICAgICAgICAgbV9kcmF3YWJsZSA9IFhDcmVhdGVQaXhtYXAoZGlzcGxheSwg Z2V0Um9vdFdpbmRvdyhtX3BhcmVudEZyYW1lLmdldCgpKSwK 97879 2011-06-20 16:03:43 -0700 2011-06-20 17:34:24 -0700 Patch bug-63020-20110620160342.patch text/plain 1498 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogODkyOTcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmMzE2ZTFhMmVjMWFiYjY0 MzlmNmEwNjFmNTY2NmI2Y2M1NjlmZmUzLi4yZTgyMDQ2MDk3NzNjZWU3NmUzMmYxYzcwNDk1YzQ2 MmNhNWI0MzVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDYtMjAgIE1hcnRp biBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIFdpbmRvd2xlc3MgcGx1Z2lucyBzb21l dGltZXMgY3Jhc2ggd2l0aCBhIEJhZE1hdGNoIGVycm9yCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzAyMAorCisgICAgICAgIERvIG5vdCB0cnkgdG8g Y3JlYXRlIGFuIFhQaXhtYXAgd2l0aCBhbnkgb2YgdGhlIGRpbWVuc2lvbnMgYXMgemVyby4KKwor ICAgICAgICAqIHBsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UGx1Z2luVmlldzo6dXBkYXRlUGx1Z2luV2lkZ2V0KTogR3VhcmQgYWdhaW5zdCBhbmQgZW1w dHkgd2luZG93IHJlY3QKKyAgICAgICAgYmVmb3JlIHRyeWluZyB0byBjcmVhdGUgYSB3aW5kb3ds ZXNzIHBsdWdpbiBwaXhtYXAuCisKIDIwMTEtMDYtMjAgIEplciBOb2JsZSAgPGplci5ub2JsZUBh cHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXg7IEZpeCBMZW9wYXJkIFdl YkNvcmUgYnVpbGQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL2d0ay9QbHVn aW5WaWV3R3RrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsu Y3BwCmluZGV4IDg0MTQ1MDYxYWU0ZWMzMzc0MmFmNWMyOTBlMzEwOTVmN2NhMmUxMjguLjIyZGZk ZDFkNzM2OTEzMWQ2YWMwMGU0ZDMxNDBiNzUxYzc1NTg1ODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwCkBAIC0xNDUsNyArMTQ1LDcgQEAgdm9pZCBQ bHVnaW5WaWV3Ojp1cGRhdGVQbHVnaW5XaWRnZXQoKQogICAgICAgICByZXR1cm47CiAKICNpZiBk ZWZpbmVkKFhQX1VOSVgpCi0gICAgaWYgKCFtX2lzV2luZG93ZWQpIHsKKyAgICBpZiAoIW1faXNX aW5kb3dlZCAmJiAhbV93aW5kb3dSZWN0LmlzRW1wdHkoKSkgewogICAgICAgICBEaXNwbGF5KiBk aXNwbGF5ID0gR0RLX0RJU1BMQVlfWERJU1BMQVkoZ2RrX2Rpc3BsYXlfZ2V0X2RlZmF1bHQoKSk7 CiAgICAgICAgIGlmIChtX2RyYXdhYmxlKQogICAgICAgICAgICAgWEZyZWVQaXhtYXAoZGlzcGxh eSwgbV9kcmF3YWJsZSk7Cg==