63016 2011-06-20 14:51:41 -0700 New test for patch introduced in r89250 2011-06-21 06:50:12 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 senorblanco senorblanco jamesr kbr reed oldest_to_newest 423963 0 senorblanco 2011-06-20 14:51:41 -0700 New test for patch introduced in r89250 423964 1 97860 senorblanco 2011-06-20 14:52:50 -0700 Created attachment 97860 Patch 424017 2 97876 senorblanco 2011-06-20 15:48:59 -0700 Created attachment 97876 Make pixel test more lenient so it passes on mac 424071 3 97876 jamesr 2011-06-20 16:39:48 -0700 Comment on attachment 97876 Make pixel test more lenient so it passes on mac R=me 424236 4 97876 ap 2011-06-20 20:50:09 -0700 Comment on attachment 97876 Make pixel test more lenient so it passes on mac View in context: https://bugs.webkit.org/attachment.cgi?id=97876&action=review > LayoutTests/ChangeLog:10 > + * fast/canvas/script-tests/text-globalAlpha.js: Added. > + * fast/canvas/text-globalAlpha-expected.txt: Added. > + * fast/canvas/text-globalAlpha.html: Added. Please avoid splitting tests into multiple files. 424259 5 jamesr 2011-06-20 22:08:13 -0700 That's the standard way of doing script tests. 424429 6 senorblanco 2011-06-21 06:48:59 -0700 > (From update of attachment 97876 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=97876&action=review > > > LayoutTests/ChangeLog:10 > > + * fast/canvas/script-tests/text-globalAlpha.js: Added. > > + * fast/canvas/text-globalAlpha-expected.txt: Added. > > + * fast/canvas/text-globalAlpha.html: Added. > > Please avoid splitting tests into multiple files. (In reply to comment #5) > That's the standard way of doing script tests. Yes, I based it off existing tests. That said, the HTML is fairly boilerplate between these script tests, differing only in the line which pulls in the JS. I wonder if there's a way to share more code. 424430 7 senorblanco 2011-06-21 06:50:12 -0700 Committed r89351: <http://trac.webkit.org/changeset/89351> 97860 2011-06-20 14:52:50 -0700 2011-06-20 15:48:54 -0700 Patch bug-63016-20110620175248.patch text/plain 3009 senorblanco SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDg5MjkxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDYtMjAgIFN0ZXBoZW4gV2hpdGUgIDxz ZW5vcmJsYW5jb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTmV3IHRlc3QgZm9yIHBhdGNoIGludHJvZHVjZWQgaW4gcjg5MjUw CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzAxNgor CisgICAgICAgICogZmFzdC9jYW52YXMvc2NyaXB0LXRlc3RzL3RleHQtZ2xvYmFsQWxwaGEuanM6 IEFkZGVkLgorICAgICAgICAqIGZhc3QvY2FudmFzL3RleHQtZ2xvYmFsQWxwaGEtZXhwZWN0ZWQu dHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2NhbnZhcy90ZXh0LWdsb2JhbEFscGhhLmh0bWw6 IEFkZGVkLgorCiAyMDExLTA2LTIwICBEYXZpZCBMZXZpbiAgPGxldmluQGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBEbWl0cnkgVGl0b3YuCkluZGV4OiBMYXlvdXRUZXN0cy9m YXN0L2NhbnZhcy90ZXh0LWdsb2JhbEFscGhhLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9mYXN0L2NhbnZhcy90ZXh0LWdsb2JhbEFscGhhLWV4cGVjdGVkLnR4dAkocmV2 aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3RleHQtZ2xvYmFsQWxwaGEtZXhw ZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEwIEBACitFbnN1cmUgdGhhdCBnbG9i YWxBbHBoYSBpcyBhcHBsaWVkIGNvcnJlY3RseSB0byB0ZXh0LgorCitPbiBzdWNjZXNzLCB5b3Ug d2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBD T01QTEVURSIuCisKKworUEFTUyBpbWdkYXRhWzNdIGlzIDEyNworUEFTUyBzdWNjZXNzZnVsbHlQ YXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKClByb3BlcnR5IGNoYW5nZXMgb246IExh eW91dFRlc3RzL2Zhc3QvY2FudmFzL3RleHQtZ2xvYmFsQWxwaGEtZXhwZWN0ZWQudHh0Cl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KQWRkZWQ6IHN2bjplb2wtc3R5bGUKICAgKyBMRgoKSW5kZXg6IExheW91dFRlc3RzL2Zh c3QvY2FudmFzL3RleHQtZ2xvYmFsQWxwaGEuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9mYXN0L2NhbnZhcy90ZXh0LWdsb2JhbEFscGhhLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlv dXRUZXN0cy9mYXN0L2NhbnZhcy90ZXh0LWdsb2JhbEFscGhhLmh0bWwJKHJldmlzaW9uIDApCkBA IC0wLDAgKzEsMTMgQEAKKzwhRE9DVFlQRSBIVE1MPgorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJl bD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIj4K KzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0Pgor PC9oZWFkPgorPGJvZHk+Cis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNv bGUiPjwvZGl2PgorPHNjcmlwdCBzcmM9InNjcmlwdC10ZXN0cy90ZXh0LWdsb2JhbEFscGhhLmpz Ij48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0Lmpz Ij48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KClByb3BlcnR5IGNoYW5nZXMgb246IExheW91 dFRlc3RzL2Zhc3QvY2FudmFzL3RleHQtZ2xvYmFsQWxwaGEuaHRtbApfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkFkZGVk OiBzdm46ZW9sLXN0eWxlCiAgICsgTEYKCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9z Y3JpcHQtdGVzdHMvdGV4dC1nbG9iYWxBbHBoYS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9mYXN0L2NhbnZhcy9zY3JpcHQtdGVzdHMvdGV4dC1nbG9iYWxBbHBoYS5qcwkocmV2aXNpb24g MCkKKysrIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3NjcmlwdC10ZXN0cy90ZXh0LWdsb2JhbEFs cGhhLmpzCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDExIEBACitkZXNjcmlwdGlvbigiRW5zdXJl IHRoYXQgZ2xvYmFsQWxwaGEgaXMgYXBwbGllZCBjb3JyZWN0bHkgdG8gdGV4dC4iKTsKK3ZhciBj YW52YXMgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdjYW52YXMnKTsKK3ZhciBjdHggPSBjYW52 YXMuZ2V0Q29udGV4dCgnMmQnKTsKK2N0eC5maWxsU3R5bGUgPSAiYmxhY2siOworY3R4Lmdsb2Jh bEFscGhhID0gMC41OworY3R4LmZvbnQgPSAiNTBweCBBcmlhbCI7CitjdHguZmlsbFRleHQoIkEi LDUwLDUwKTsKK3ZhciBpbWFnZURhdGEgPSBjdHguZ2V0SW1hZ2VEYXRhKDYzLCAyMiwgMSwgMSk7 Cit2YXIgaW1nZGF0YSA9IGltYWdlRGF0YS5kYXRhOworc2hvdWxkQmUoImltZ2RhdGFbM10iLCAi MTI3Iik7Cit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKClByb3BlcnR5IGNoYW5nZXMg b246IExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3NjcmlwdC10ZXN0cy90ZXh0LWdsb2JhbEFscGhh LmpzCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KQWRkZWQ6IHN2bjplb2wtc3R5bGUKICAgKyBMRgoK 97876 2011-06-20 15:48:59 -0700 2011-06-20 20:50:09 -0700 Make pixel test more lenient so it passes on mac bug-63016-20110620184857.patch text/plain 3063 senorblanco SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDg5MjkxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDYtMjAgIFN0ZXBoZW4gV2hpdGUgIDxz ZW5vcmJsYW5jb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTmV3IHRlc3QgZm9yIHBhdGNoIGludHJvZHVjZWQgaW4gcjg5MjUw CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MzAxNgor CisgICAgICAgICogZmFzdC9jYW52YXMvc2NyaXB0LXRlc3RzL3RleHQtZ2xvYmFsQWxwaGEuanM6 IEFkZGVkLgorICAgICAgICAqIGZhc3QvY2FudmFzL3RleHQtZ2xvYmFsQWxwaGEtZXhwZWN0ZWQu dHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2NhbnZhcy90ZXh0LWdsb2JhbEFscGhhLmh0bWw6 IEFkZGVkLgorCiAyMDExLTA2LTIwICBEYXZpZCBMZXZpbiAgPGxldmluQGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBEbWl0cnkgVGl0b3YuCkluZGV4OiBMYXlvdXRUZXN0cy9m YXN0L2NhbnZhcy90ZXh0LWdsb2JhbEFscGhhLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9mYXN0L2NhbnZhcy90ZXh0LWdsb2JhbEFscGhhLWV4cGVjdGVkLnR4dAkocmV2 aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3RleHQtZ2xvYmFsQWxwaGEtZXhw ZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEwIEBACitFbnN1cmUgdGhhdCBnbG9i YWxBbHBoYSBpcyBhcHBsaWVkIGNvcnJlY3RseSB0byB0ZXh0LgorCitPbiBzdWNjZXNzLCB5b3Ug d2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBD T01QTEVURSIuCisKKworUEFTUyBpbWdkYXRhWzNdID09IDEyNyB8fCBpbWdkYXRhWzNdID09IDEy OCBpcyB0cnVlCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExF VEUKKwoKUHJvcGVydHkgY2hhbmdlcyBvbjogTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvdGV4dC1n bG9iYWxBbHBoYS1leHBlY3RlZC50eHQKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBZGRlZDogc3ZuOmVvbC1zdHlsZQog ICArIExGCgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvdGV4dC1nbG9iYWxBbHBoYS5o dG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3RleHQtZ2xvYmFsQWxw aGEuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3RleHQtZ2xv YmFsQWxwaGEuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMyBAQAorPCFET0NUWVBFIEhU TUw+Cis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIuLi9qcy9y ZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNl cy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwIGlkPSJkZXNj cmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8c2NyaXB0IHNyYz0ic2Ny aXB0LXRlc3RzL3RleHQtZ2xvYmFsQWxwaGEuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4u L2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1s PgoKUHJvcGVydHkgY2hhbmdlcyBvbjogTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvdGV4dC1nbG9i YWxBbHBoYS5odG1sCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KQWRkZWQ6IHN2bjplb2wtc3R5bGUKICAgKyBMRgoKSW5k ZXg6IExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3NjcmlwdC10ZXN0cy90ZXh0LWdsb2JhbEFscGhh LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3NjcmlwdC10ZXN0cy90 ZXh0LWdsb2JhbEFscGhhLmpzCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9jYW52 YXMvc2NyaXB0LXRlc3RzL3RleHQtZ2xvYmFsQWxwaGEuanMJKHJldmlzaW9uIDApCkBAIC0wLDAg KzEsMTEgQEAKK2Rlc2NyaXB0aW9uKCJFbnN1cmUgdGhhdCBnbG9iYWxBbHBoYSBpcyBhcHBsaWVk IGNvcnJlY3RseSB0byB0ZXh0LiIpOwordmFyIGNhbnZhcyA9IGRvY3VtZW50LmNyZWF0ZUVsZW1l bnQoJ2NhbnZhcycpOwordmFyIGN0eCA9IGNhbnZhcy5nZXRDb250ZXh0KCcyZCcpOworY3R4LmZp bGxTdHlsZSA9ICJibGFjayI7CitjdHguZ2xvYmFsQWxwaGEgPSAwLjU7CitjdHguZm9udCA9ICI1 MHB4IEFyaWFsIjsKK2N0eC5maWxsVGV4dCgiQSIsNTAsNTApOwordmFyIGltYWdlRGF0YSA9IGN0 eC5nZXRJbWFnZURhdGEoNjMsIDIyLCAxLCAxKTsKK3ZhciBpbWdkYXRhID0gaW1hZ2VEYXRhLmRh dGE7CitzaG91bGRCZVRydWUoImltZ2RhdGFbM10gPT0gMTI3IHx8IGltZ2RhdGFbM10gPT0gMTI4 Iik7Cit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKClByb3BlcnR5IGNoYW5nZXMgb246 IExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3NjcmlwdC10ZXN0cy90ZXh0LWdsb2JhbEFscGhhLmpz Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KQWRkZWQ6IHN2bjplb2wtc3R5bGUKICAgKyBMRgoK