63005 2011-06-20 12:17:36 -0700 AudioContext noteGrainOn() method should not apply explicit windowing 2011-06-22 13:18:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 crogers crogers kbr oldest_to_newest 423846 0 crogers 2011-06-20 12:17:36 -0700 AudioContext noteGrainOn() method should not apply explicit windowing 423850 1 97838 crogers 2011-06-20 12:19:16 -0700 Created attachment 97838 Patch 423859 2 crogers 2011-06-20 12:28:06 -0700 The noteGrainOn() method currently applies a hard-coded amplitude envelope (window) to the portion of sound played. The specification and use cases require that the portion should be played back as is with no further processing. If an amplitude envelope is desired, then scheduled AudioParam changes on an AudioGainNode may be used. 424762 3 97838 kbr 2011-06-21 14:26:45 -0700 Comment on attachment 97838 Patch Was this just a temporary stopgap for demos? Anyway, its removal looks fine. 424763 4 crogers 2011-06-21 14:29:22 -0700 The old implementation of hard-coded grain window was before the ability existed to apply high-resolution envelopes in an AudioGainNode. So yes, in a way, it was a stop-gap solution. 425520 5 crogers 2011-06-22 13:18:10 -0700 Committed r89471: <http://trac.webkit.org/changeset/89471> 97838 2011-06-20 12:19:16 -0700 2011-06-21 14:26:45 -0700 Patch bug-63005-20110620121915.patch text/plain 3616 crogers SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5MjY4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDYtMjAgIENocmlzIFJv Z2VycyAgPGNyb2dlcnNAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBdWRpb0NvbnRleHQgbm90ZUdyYWluT24oKSBtZXRob2Qgc2hv dWxkIG5vdCBhcHBseSBleHBsaWNpdCB3aW5kb3dpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYzMDA1CisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHNp bmNlIGF1ZGlvIEFQSSBpcyBub3QgeWV0IGltcGxlbWVudGVkLgorCisgICAgICAgICogd2ViYXVk aW8vQXVkaW9CdWZmZXJTb3VyY2VOb2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvQnVm ZmVyU291cmNlTm9kZTo6cmVhZEZyb21CdWZmZXIpOgorICAgICAgICAqIHdlYmF1ZGlvL0F1ZGlv QnVmZmVyU291cmNlTm9kZS5oOgorCiAyMDExLTA2LTIwICBBbGV4IE1pbG93c2tpICA8YWxleEBt aWxvd3NraS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBT b3VyY2UvV2ViQ29yZS93ZWJhdWRpby9BdWRpb0J1ZmZlclNvdXJjZU5vZGUuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0F1ZGlvQnVmZmVyU291cmNlTm9kZS5jcHAJ KHJldmlzaW9uIDg5MTUwKQorKysgU291cmNlL1dlYkNvcmUvd2ViYXVkaW8vQXVkaW9CdWZmZXJT b3VyY2VOb2RlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzIzLDQ0ICszMjMsMTUgQEAgdm9pZCBB dWRpb0J1ZmZlclNvdXJjZU5vZGU6OnJlYWRGcm9tQnVmZgogICAgIGlmICghaXNEZXN0aW5hdGlv bkdvb2QpCiAgICAgICAgIHJldHVybjsKIAotICAgIGlmIChtX2lzR3JhaW4pCi0gICAgICAgIHJl YWRGcm9tQnVmZmVyV2l0aEdyYWluRW52ZWxvcGUoc291cmNlTCwgc291cmNlUiwgZGVzdGluYXRp b25MLCBkZXN0aW5hdGlvblIsIGZyYW1lc1RvUHJvY2Vzcyk7Ci0gICAgZWxzZSB7Ci0gICAgICAg IC8vIFNpbXBseSBjb3B5IHRoZSBkYXRhIGZyb20gdGhlIHNvdXJjZSBidWZmZXIgdG8gdGhlIGRl c3RpbmF0aW9uLgotICAgICAgICBtZW1jcHkoZGVzdGluYXRpb25MLCBzb3VyY2VMLCBzaXplb2Yo ZmxvYXQpICogZnJhbWVzVG9Qcm9jZXNzKTsKLSAgICAgICAgaWYgKG51bWJlck9mQ2hhbm5lbHMg PT0gMikKLSAgICAgICAgICAgIG1lbWNweShkZXN0aW5hdGlvblIsIHNvdXJjZVIsIHNpemVvZihm bG9hdCkgKiBmcmFtZXNUb1Byb2Nlc3MpOwotICAgIH0KKyAgICAvLyBTaW1wbHkgY29weSB0aGUg ZGF0YSBmcm9tIHRoZSBzb3VyY2UgYnVmZmVyIHRvIHRoZSBkZXN0aW5hdGlvbi4KKyAgICBtZW1j cHkoZGVzdGluYXRpb25MLCBzb3VyY2VMLCBzaXplb2YoZmxvYXQpICogZnJhbWVzVG9Qcm9jZXNz KTsKKyAgICBpZiAobnVtYmVyT2ZDaGFubmVscyA9PSAyKQorICAgICAgICBtZW1jcHkoZGVzdGlu YXRpb25SLCBzb3VyY2VSLCBzaXplb2YoZmxvYXQpICogZnJhbWVzVG9Qcm9jZXNzKTsKIAogICAg IC8vIEFkdmFuY2UgdGhlIGJ1ZmZlcidzIHJlYWQgaW5kZXguCiAgICAgbV9yZWFkSW5kZXggKz0g ZnJhbWVzVG9Qcm9jZXNzOwogfQogCi12b2lkIEF1ZGlvQnVmZmVyU291cmNlTm9kZTo6cmVhZEZy b21CdWZmZXJXaXRoR3JhaW5FbnZlbG9wZShmbG9hdCogc291cmNlTCwgZmxvYXQqIHNvdXJjZVIs IGZsb2F0KiBkZXN0aW5hdGlvbkwsIGZsb2F0KiBkZXN0aW5hdGlvblIsIHNpemVfdCBmcmFtZXNU b1Byb2Nlc3MpCi17Ci0gICAgQVNTRVJUKHNvdXJjZUwgJiYgZGVzdGluYXRpb25MKTsKLSAgICBp ZiAoIXNvdXJjZUwgfHwgIWRlc3RpbmF0aW9uTCkKLSAgICAgICAgcmV0dXJuOwotICAgICAgICAK LSAgICBpbnQgZ3JhaW5GcmFtZUxlbmd0aCA9IHN0YXRpY19jYXN0PGludD4obV9ncmFpbkR1cmF0 aW9uICogbV9idWZmZXItPnNhbXBsZVJhdGUoKSk7Ci0gICAgYm9vbCBpc1N0ZXJlbyA9IHNvdXJj ZVIgJiYgZGVzdGluYXRpb25SOwotICAgIAotICAgIGludCBuID0gZnJhbWVzVG9Qcm9jZXNzOwot ICAgIHdoaWxlIChuLS0pIHsKLSAgICAgICAgLy8gQXBwbHkgdGhlIGdyYWluIGVudmVsb3BlLgot ICAgICAgICBmbG9hdCB4ID0gc3RhdGljX2Nhc3Q8ZmxvYXQ+KG1fZ3JhaW5GcmFtZUNvdW50KSAv IHN0YXRpY19jYXN0PGZsb2F0PihncmFpbkZyYW1lTGVuZ3RoKTsKLSAgICAgICAgbV9ncmFpbkZy YW1lQ291bnQrKzsKLQotICAgICAgICB4ID0gbWluKDEuMGYsIHgpOwotICAgICAgICBmbG9hdCBn cmFpbkVudmVsb3BlID0gc2luZihwaUZsb2F0ICogeCk7Ci0gICAgICAgIAotICAgICAgICAqZGVz dGluYXRpb25MKysgPSBncmFpbkVudmVsb3BlICogKnNvdXJjZUwrKzsKLQotICAgICAgICBpZiAo aXNTdGVyZW8pCi0gICAgICAgICAgICAqZGVzdGluYXRpb25SKysgPSBncmFpbkVudmVsb3BlICog KnNvdXJjZVIrKzsKLSAgICB9Ci19Ci0KIHZvaWQgQXVkaW9CdWZmZXJTb3VyY2VOb2RlOjpyZXNl dCgpCiB7CiAgICAgbV9yZXNhbXBsZXIucmVzZXQoKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3dl YmF1ZGlvL0F1ZGlvQnVmZmVyU291cmNlTm9kZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL3dlYmF1ZGlvL0F1ZGlvQnVmZmVyU291cmNlTm9kZS5oCShyZXZpc2lvbiA4OTE1MCkKKysr IFNvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0F1ZGlvQnVmZmVyU291cmNlTm9kZS5oCSh3b3JraW5n IGNvcHkpCkBAIC0xNDMsOSArMTQzLDYgQEAgcHJpdmF0ZToKICAgICAvLyBBIGdyYWluIGVudmVs b3BlIHdpbGwgYmUgYXBwbGllZCBpZiBtX2lzR3JhaW4gaXMgc2V0IHRvIHRydWUuCiAgICAgdm9p ZCByZWFkRnJvbUJ1ZmZlcihBdWRpb0J1cyogZGVzdGluYXRpb25CdXMsIHNpemVfdCBmcmFtZXNU b1Byb2Nlc3MpOwogCi0gICAgLy8gcmVhZEZyb21CdWZmZXJXaXRoR3JhaW5FbnZlbG9wZSgpIGlz IGEgbG93LWxldmVsIGJsaXR0ZXIgd2hpY2ggcmVhZHMgZnJvbSB0aGUgQXVkaW9CdWZmZXIgYW5k IGFwcGxpZXMgYSBncmFpbiBlbnZlbG9wZS4KLSAgICB2b2lkIHJlYWRGcm9tQnVmZmVyV2l0aEdy YWluRW52ZWxvcGUoZmxvYXQqIHNvdXJjZUwsIGZsb2F0KiBzb3VyY2VSLCBmbG9hdCogZGVzdGlu YXRpb25MLCBmbG9hdCogZGVzdGluYXRpb25SLCBzaXplX3QgZnJhbWVzVG9Qcm9jZXNzKTsKLQog ICAgIC8vIEhhbmRsZXMgdGhlIHRpbWUgd2hlbiB3ZSByZWFjaCB0aGUgZW5kIG9mIHNhbXBsZSBk YXRhIChub24tbG9vcGluZykgb3IgdGhlIG5vdGVPZmYoKSB0aW1lIGhhcyBiZWVuIHJlYWNoZWQu CiAgICAgdm9pZCBmaW5pc2goKTsKIH07Cg==