62988 2011-06-20 07:41:59 -0700 [Skia] remove repeated calls to setColor, which ignored global-alpha (previous setupPaintFor... already set the color+alpha) 2011-06-20 10:24:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 reed reed senorblanco webkit.review.bot oldest_to_newest 423665 0 reed 2011-06-20 07:41:59 -0700 [Skia] remove repeated calls to setColor, which ignored global-alpha (previous setupPaintFor... already set the color+alpha) 423666 1 97799 reed 2011-06-20 07:43:49 -0700 Created attachment 97799 Patch 423674 2 97799 senorblanco 2011-06-20 08:28:59 -0700 Comment on attachment 97799 Patch Looks good. r=me Does this affect any tests? Or only the one previously suppressed? 423676 3 reed 2011-06-20 08:34:10 -0700 this is not related to the previous suppression. It came out of some comments from Eric S. related to redundant code in this file. I have another bug to try to fix more of those separately. https://bugs.webkit.org/show_bug.cgi?id=62989 423706 4 97799 webkit.review.bot 2011-06-20 09:37:58 -0700 Comment on attachment 97799 Patch Clearing flags on attachment: 97799 Committed r89250: <http://trac.webkit.org/changeset/89250> 423707 5 webkit.review.bot 2011-06-20 09:38:02 -0700 All reviewed patches have been landed. Closing bug. 423709 6 97812 reed 2011-06-20 09:39:14 -0700 Created attachment 97812 Patch 423746 7 97812 senorblanco 2011-06-20 10:24:49 -0700 Comment on attachment 97812 Patch Thanks, I'll take what you have here and try to turn it into a script-test (so it doesn't require pixel results). 97799 2011-06-20 07:43:49 -0700 2011-06-20 09:39:09 -0700 Patch bug-62988-20110620104347.patch text/plain 2029 reed SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5MjQ2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMjAgIE1pa2UgUmVl ZCAgPHJlZWRAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBbU2tpYV0gcmVtb3ZlIHJlcGVhdGVkIGNhbGxzIHRvIHNldENvbG9yLCB3 aGljaCBpZ25vcmVkIGdsb2JhbC1hbHBoYSAocHJldmlvdXMgc2V0dXBQYWludEZvci4uLiBhbHJl YWR5IHNldCB0aGUgY29sb3IrYWxwaGEpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02Mjk4OAorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gcmVtb3Zpbmcg cmVkdW5kYW50IGNhbGxzCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9G b250TGludXguY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udDo6ZHJhd0dseXBocyk6CisKIDIw MTEtMDYtMjAgIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IFl1cnkgU2VtaWtoYXRza3kuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250TGludXguY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRMaW51eC5jcHAJKHJl dmlzaW9uIDg5MjQyKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vRm9udExpbnV4LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTIyLDcgKzEyMiw2IEBAIHZvaWQg Rm9udDo6ZHJhd0dseXBocyhHcmFwaGljc0NvbnRleHQqIGcKICAgICAgICAgZm9udC0+cGxhdGZv cm1EYXRhKCkuc2V0dXBQYWludCgmcGFpbnQpOwogICAgICAgICBhZGp1c3RUZXh0UmVuZGVyTW9k ZSgmcGFpbnQsIGdjLT5wbGF0Zm9ybUNvbnRleHQoKSk7CiAgICAgICAgIHBhaW50LnNldFRleHRF bmNvZGluZyhTa1BhaW50OjprR2x5cGhJRF9UZXh0RW5jb2RpbmcpOwotICAgICAgICBwYWludC5z ZXRDb2xvcihnYy0+ZmlsbENvbG9yKCkucmdiKCkpOwogCiAgICAgICAgIGlmIChpc1ZlcnRpY2Fs KSB7CiAgICAgICAgICAgICBTa1BhdGggcGF0aDsKQEAgLTE0NSwxMiArMTQ0LDEyIEBAIHZvaWQg Rm9udDo6ZHJhd0dseXBocyhHcmFwaGljc0NvbnRleHQqIGcKICAgICAgICAgZm9udC0+cGxhdGZv cm1EYXRhKCkuc2V0dXBQYWludCgmcGFpbnQpOwogICAgICAgICBhZGp1c3RUZXh0UmVuZGVyTW9k ZSgmcGFpbnQsIGdjLT5wbGF0Zm9ybUNvbnRleHQoKSk7CiAgICAgICAgIHBhaW50LnNldFRleHRF bmNvZGluZyhTa1BhaW50OjprR2x5cGhJRF9UZXh0RW5jb2RpbmcpOwotICAgICAgICBwYWludC5z ZXRDb2xvcihnYy0+c3Ryb2tlQ29sb3IoKS5yZ2IoKSk7CiAKICAgICAgICAgaWYgKHRleHRNb2Rl ICYgVGV4dE1vZGVGaWxsKSB7CiAgICAgICAgICAgICAvLyBJZiB3ZSBhbHNvIGZpbGxlZCwgd2Ug ZG9uJ3Qgd2FudCB0byBkcmF3IHNoYWRvd3MgdHdpY2UuCiAgICAgICAgICAgICAvLyBTZWUgY29t bWVudCBpbiBGb250Q2hyb21pdW1XaW4uY3BwOjpwYWludFNraWFUZXh0KCkgZm9yIG1vcmUgZGV0 YWlscy4KLSAgICAgICAgICAgIFNrU2FmZVVucmVmKHBhaW50LnNldExvb3BlcigwKSk7CisgICAg ICAgICAgICAvLyBTaW5jZSB3ZSB1c2UgdGhlIGxvb3BlciBmb3Igc2hhZG93cywgd2UgcmVtb3Zl IGl0IChpZiBhbnkpIG5vdy4KKyAgICAgICAgICAgIHBhaW50LnNldExvb3BlcigwKTsKICAgICAg ICAgfQogCiAgICAgICAgIGlmIChpc1ZlcnRpY2FsKSB7Cg== 97812 2011-06-20 09:39:14 -0700 2011-06-20 10:24:49 -0700 Patch bug-62988-20110620123912.patch text/plain 3496 reed SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5MjQ2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMjAgIE1pa2UgUmVl ZCAgPHJlZWRAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBbU2tpYV0gcmVtb3ZlIHJlcGVhdGVkIGNhbGxzIHRvIHNldENvbG9yLCB3 aGljaCBpZ25vcmVkIGdsb2JhbC1hbHBoYSAocHJldmlvdXMgc2V0dXBQYWludEZvci4uLiBhbHJl YWR5IHNldCB0aGUgY29sb3IrYWxwaGEpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02Mjk4OAorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gcmVtb3Zpbmcg cmVkdW5kYW50IGNhbGxzCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9G b250TGludXguY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udDo6ZHJhd0dseXBocyk6CisKIDIw MTEtMDYtMjAgIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IFl1cnkgU2VtaWtoYXRza3kuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250TGludXguY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRMaW51eC5jcHAJKHJl dmlzaW9uIDg5MjQyKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vRm9udExpbnV4LmNwcAkod29ya2luZyBjb3B5KQpAQCAtODYsMTIgKzg2LDYgQEAgdm9pZCBG b250OjpkcmF3R2x5cGhzKEdyYXBoaWNzQ29udGV4dCogZwogICAgIFNrU2NhbGFyIHggPSBTa0Zs b2F0VG9TY2FsYXIocG9pbnQueCgpKTsKICAgICBTa1NjYWxhciB5ID0gU2tGbG9hdFRvU2NhbGFy KHBvaW50LnkoKSk7CiAKLSAgICAvLyBGSVhNRTogdGV4dCByZW5kZXJpbmcgc3BlZWQ6Ci0gICAg Ly8gQW5kcm9pZCBoYXMgY29kZSBpbiB0aGVpciBXZWJDb3JlIGZvcmsgdG8gc3BlY2lhbCBjYXNl IHdoZW4gdGhlCi0gICAgLy8gR2x5cGhCdWZmZXIgaGFzIG5vIGFkdmFuY2VzIG90aGVyIHRoYW4g dGhlIGRlZmF1bHRzLiBJbiB0aGF0IGNhc2UgdGhlCi0gICAgLy8gdGV4dCBkcmF3aW5nIGNhbiBw cm9jZWVkIGZhc3Rlci4gSG93ZXZlciwgaXQncyB1bmNsZWFyIHdoZW4gdGhvc2UKLSAgICAvLyBw YXRjaGVzIG1heSBiZSB1cHN0cmVhbWVkIHRvIFdlYktpdCBzbyB3ZSBhbHdheXMgdXNlIHRoZSBz bG93ZXIgcGF0aAotICAgIC8vIGhlcmUuCiAgICAgY29uc3QgR2x5cGhCdWZmZXJBZHZhbmNlKiBh ZHYgPSBnbHlwaEJ1ZmZlci5hZHZhbmNlcyhmcm9tKTsKICAgICBTa0F1dG9TVE1hbGxvYzwzMiwg U2tQb2ludD4gc3RvcmFnZShudW1HbHlwaHMpLCBzdG9yYWdlMihudW1HbHlwaHMpLCBzdG9yYWdl MyhudW1HbHlwaHMpOwogICAgIFNrUG9pbnQqIHBvcyA9IHN0b3JhZ2UuZ2V0KCk7CkBAIC0xMjIs NyArMTE2LDYgQEAgdm9pZCBGb250OjpkcmF3R2x5cGhzKEdyYXBoaWNzQ29udGV4dCogZwogICAg ICAgICBmb250LT5wbGF0Zm9ybURhdGEoKS5zZXR1cFBhaW50KCZwYWludCk7CiAgICAgICAgIGFk anVzdFRleHRSZW5kZXJNb2RlKCZwYWludCwgZ2MtPnBsYXRmb3JtQ29udGV4dCgpKTsKICAgICAg ICAgcGFpbnQuc2V0VGV4dEVuY29kaW5nKFNrUGFpbnQ6OmtHbHlwaElEX1RleHRFbmNvZGluZyk7 Ci0gICAgICAgIHBhaW50LnNldENvbG9yKGdjLT5maWxsQ29sb3IoKS5yZ2IoKSk7CiAKICAgICAg ICAgaWYgKGlzVmVydGljYWwpIHsKICAgICAgICAgICAgIFNrUGF0aCBwYXRoOwpAQCAtMTQ1LDEy ICsxMzgsMTIgQEAgdm9pZCBGb250OjpkcmF3R2x5cGhzKEdyYXBoaWNzQ29udGV4dCogZwogICAg ICAgICBmb250LT5wbGF0Zm9ybURhdGEoKS5zZXR1cFBhaW50KCZwYWludCk7CiAgICAgICAgIGFk anVzdFRleHRSZW5kZXJNb2RlKCZwYWludCwgZ2MtPnBsYXRmb3JtQ29udGV4dCgpKTsKICAgICAg ICAgcGFpbnQuc2V0VGV4dEVuY29kaW5nKFNrUGFpbnQ6OmtHbHlwaElEX1RleHRFbmNvZGluZyk7 Ci0gICAgICAgIHBhaW50LnNldENvbG9yKGdjLT5zdHJva2VDb2xvcigpLnJnYigpKTsKIAogICAg ICAgICBpZiAodGV4dE1vZGUgJiBUZXh0TW9kZUZpbGwpIHsKICAgICAgICAgICAgIC8vIElmIHdl IGFsc28gZmlsbGVkLCB3ZSBkb24ndCB3YW50IHRvIGRyYXcgc2hhZG93cyB0d2ljZS4KICAgICAg ICAgICAgIC8vIFNlZSBjb21tZW50IGluIEZvbnRDaHJvbWl1bVdpbi5jcHA6OnBhaW50U2tpYVRl eHQoKSBmb3IgbW9yZSBkZXRhaWxzLgotICAgICAgICAgICAgU2tTYWZlVW5yZWYocGFpbnQuc2V0 TG9vcGVyKDApKTsKKyAgICAgICAgICAgIC8vIFNpbmNlIHdlIHVzZSB0aGUgbG9vcGVyIGZvciBz aGFkb3dzLCB3ZSByZW1vdmUgaXQgKGlmIGFueSkgbm93LgorICAgICAgICAgICAgcGFpbnQuc2V0 TG9vcGVyKDApOwogICAgICAgICB9CiAKICAgICAgICAgaWYgKGlzVmVydGljYWwpIHsKSW5kZXg6 IExheW91dFRlc3RzL2NhbnZhcy9nbG9iYWxBbHBoYS1kcmF3dGV4dC5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2NhbnZhcy9nbG9iYWxBbHBoYS1kcmF3dGV4dC5odG1sCShyZXZpc2lv biAwKQorKysgTGF5b3V0VGVzdHMvY2FudmFzL2dsb2JhbEFscGhhLWRyYXd0ZXh0Lmh0bWwJKHJl dmlzaW9uIDApCkBAIC0wLDAgKzEsMTcgQEAKKzxodG1sPgorPCEtLSBiYXNlZCBvbiBodHRwOi8v b3Ntb3NuaW1raS5ydS9rb3RoaWMvdGV4dC1vcGFjaXR5Lmh0bWwgLS0+Cis8c2NyaXB0IGxhbmd1 YWdlPSJqYXZhc2NyaXB0Ij48IS0tCitmdW5jdGlvbiBhYWFhKCl7CisgdmFyIGN0eCA9IGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCdjYW52YXMnKS5nZXRDb250ZXh0KCcyZCcpOworIGN0eC5nbG9i YWxBbHBoYSA9IDAuMzsKKyBjdHguZm9udCA9ICI1MHB4IEFyaWFsIgorIGN0eC5zdHJva2VUZXh0 KCJhYWFhYSIsNTAsNTApOworIGN0eC5maWxsVGV4dCgiYWFhYWEiLDUwLDE1MCk7Cit9OworLy8g LS0+PC9zY3JpcHQ+CisKKzxib2R5IG9ubG9hZD0iYWFhYSgpOyI+Cis8Y2FudmFzIGlkPSJjYW52 YXMiIHdpZHRoPTMwMCBoZWlnaHQ9MzAwPjwvY2FudmFzPjxicj4KK1RoZSB0ZXh0IGFib3ZlIHNo b3VsZCBiZSBkcmF3biBpbiBsaWdodCBncmF5LCByZWZsZWN0aW5nIHRoZSBnbG9iYWwgYWxwaGEu Cis8L2JvZHk+PC9odG1sPgorCg==