62986 2011-06-20 06:49:16 -0700 determine if Skia on Chrome Mac can return fallback fonts 2011-08-15 13:00:15 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED P2 Normal --- 1 caryclark caryclark webkit.review.bot oldest_to_newest 423643 0 caryclark 2011-06-20 06:49:16 -0700 Determine if the Mac port of Chromium using Skia can return fallback fonts for complex text. (The Windows and Linux ports for Chromium do not.) See 97636 for more discussion about this. 450559 1 103792 caryclark 2011-08-12 12:24:28 -0700 Created attachment 103792 Patch 450584 2 caryclark 2011-08-12 12:52:43 -0700 '97636' in the first description refers to https://bug-62889-attachments.webkit.org/attachment.cgi?id=97636 451147 3 103792 kbr 2011-08-15 11:01:14 -0700 Comment on attachment 103792 Patch Will this affect any other platforms than Mac Skia, and/or any layout tests? 451149 4 103792 fishd 2011-08-15 11:04:44 -0700 Comment on attachment 103792 Patch It seems a bit confusing that we have this function in three files: skia/FontSkia.cpp, chromium/FontChromiumWin.cpp, and chromium/FontLinux.cpp. It seems like our code is a bit disorganized. 451171 5 caryclark 2011-08-15 11:30:54 -0700 kbr: This affects only the Mac port of Chromium using Skia. It fixes layout tests used solely by this configuration. fishd: Once the Mac port on Skia replaces the CG port, it will be easier to remove duplicate code, although since each code path uses a different glyph generator, there will be platform differences in fonts and font rendering. 451242 6 103792 webkit.review.bot 2011-08-15 13:00:11 -0700 Comment on attachment 103792 Patch Clearing flags on attachment: 103792 Committed r93057: <http://trac.webkit.org/changeset/93057> 451243 7 webkit.review.bot 2011-08-15 13:00:15 -0700 All reviewed patches have been landed. Closing bug. 103792 2011-08-12 12:24:28 -0700 2011-08-15 13:00:11 -0700 Patch bug-62986-20110812152426.patch text/plain 1619 caryclark SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyOTc5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDgtMTIgIENhcnkgQ2xh cmsgIDxjYXJ5Y2xhcmtAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpc2UgU2tpYSBvbiBDaHJv bWUgTWFjIHRvIHJldHVybiBmYWxsYmFjayBmb250cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyOTg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgU2tpYSBvbiBDaHJvbWUgTWFjIHVzZXMgQ29y ZVRleHQgdG8gZGV0ZXJtaW5lCisgICAgICAgIHRleHQgbWV0cmljcywgQ0cgZm9udCBhcmNoaXRl Y3R1cmUgaXMgdXNlZCB0byByZXR1cm4KKyAgICAgICAgZmFsbGJhY2sgZm9udHMuCisKKyAgICAg ICAgVGhpcyBpbXByb3ZlcyBtYW55IGV4aXN0aW5nIGxheW91dCB0ZXN0cywgaW5jbHVkaW5nCisg ICAgICAgIGp1c3RpZnktaWRlb2dyYXBoLXNpbXBsZSBhbmQgdDA5MDUtYzQxNC1mbHQtMDQtYyAK KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEvRm9udFNraWEuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6Rm9udDo6Y2FuUmV0dXJuRmFsbGJhY2tGb250c0ZvckNvbXBsZXhUZXh0KToK KwogMjAxMS0wOC0xMiAgQ2hyaXMgUm9nZXJzICA8Y3JvZ2Vyc0Bnb29nbGUuY29tPgogCiAgICAg ICAgIEZpeCBtYWMgYnVpbGQgd2hlbiB3ZWIgYXVkaW8gaXMgZW5hYmxlZApJbmRleDogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9Gb250U2tpYS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9Gb250U2tpYS5jcHAJKHJl dmlzaW9uIDkyOTc5KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9G b250U2tpYS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQzLDEyICs0Myw5IEBACiAKIG5hbWVzcGFj ZSBXZWJDb3JlIHsKIAotLy8gRklYTUU6IERldGVybWluZSBpZiB0aGUgTWFjIHBvcnQgb2YgQ2hy b21pdW0gdXNpbmcgU2tpYSBjYW4gcmV0dXJuIGZhbGxiYWNrCi0vLyBmb250cyBmb3IgY29tcGxl eCB0ZXh0LiAoVGhlIFdpbmRvd3MgYW5kIExpbnV4IHBvcnRzIGZvciBDaHJvbWl1bSBkbyBub3Qu KQotLy8gVGhpcyBpc3N1ZSBpcyB0cmFja2VkIGluIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02Mjk4NgogYm9vbCBGb250OjpjYW5SZXR1cm5GYWxsYmFja0ZvbnRzRm9y Q29tcGxleFRleHQoKQogewotICAgIHJldHVybiBmYWxzZTsKKyAgICByZXR1cm4gdHJ1ZTsKIH0K IAogLy8gRklYTUU6IERldGVybWluZSBpZiB0aGUgTWFjIHBvcnQgb2YgQ2hyb21pdW0gdXNpbmcg U2tpYSBjYW4gZXhwYW5kIGFyb3VuZAo=