62964 2011-06-19 22:28:14 -0700 Support cast from CSSPrimitiveValue to short and use for CSSPropertyWidows and CSSPropertyOrphans. 2011-06-22 10:42:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson eric macpherson webkit.review.bot oldest_to_newest 423478 0 macpherson 2011-06-19 22:28:14 -0700 Support cast from CSSPrimitiveValue to short and use for CSSPropertyWidows and CSSPropertyOrphans. 423479 1 97746 macpherson 2011-06-19 22:29:47 -0700 Created attachment 97746 Patch 423499 2 97746 eric 2011-06-19 23:36:03 -0700 Comment on attachment 97746 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97746&action=review These seem kinda scary. But maybe they're useful? > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) This will cause the cq to fail. Normally you replace this with a list of tests or why testing is impossible/impractical/unnecessary. 423501 3 macpherson 2011-06-19 23:38:07 -0700 (In reply to comment #2) > (From update of attachment 97746 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=97746&action=review > > These seem kinda scary. But maybe they're useful? > > > Source/WebCore/ChangeLog:8 > > + No new tests. (OOPS!) > > This will cause the cq to fail. Normally you replace this with a list of tests or why testing is impossible/impractical/unnecessary. Ack. Yeah just overlooked that. 423503 4 97753 macpherson 2011-06-19 23:44:00 -0700 Created attachment 97753 Patch 423678 5 97753 dglazkov 2011-06-20 08:34:53 -0700 Comment on attachment 97753 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97753&action=review > Source/WebCore/css/CSSPrimitiveValueMappings.h:57 > +template<> inline CSSPrimitiveValue::operator short() const I worry that we're getting a bit too fancy here. Will I be able to understand what this means 2 years from now? 425335 6 macpherson 2011-06-22 10:21:50 -0700 Since CSSPrimitiveValue is essentially a union of all possible CSS types, including the number type, being able to cast CSSPrimitiveValue to numeric types seems reasonable. Could you expand on why you think this will be hard to understand (or harder than the numerous other casts that CSSPrimitiveValue supports)? 425342 7 97753 dglazkov 2011-06-22 10:29:53 -0700 Comment on attachment 97753 Patch I think it's because I have an unnatural antipathy toward templates and operators. 425351 8 97753 webkit.review.bot 2011-06-22 10:42:41 -0700 Comment on attachment 97753 Patch Clearing flags on attachment: 97753 Committed r89448: <http://trac.webkit.org/changeset/89448> 425352 9 webkit.review.bot 2011-06-22 10:42:45 -0700 All reviewed patches have been landed. Closing bug. 97746 2011-06-19 22:29:47 -0700 2011-06-19 23:43:53 -0700 Patch bug-62964-20110620152944.patch text/plain 2825 macpherson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5MjMwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDYtMTkgIEx1a2UgTWFj cGhlcnNvbiAgIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTdXBwb3J0IGNhc3QgZnJvbSBDU1NQcmltaXRp dmVWYWx1ZSB0byBzaG9ydCBhbmQgdXNlIGZvciBDU1NQcm9wZXJ0eVdpZG93cyBhbmQgQ1NTUHJv cGVydHlPcnBoYW5zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjI5NjQKKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAgICAq IGNzcy9DU1NQcmltaXRpdmVWYWx1ZU1hcHBpbmdzLmg6CisgICAgICAgIFN1cHBvcnQgY2FzdCB0 by9mcm9tIHNob3J0LgorICAgICAgICAqIGNzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkNTU1N0eWxlU2VsZWN0b3I6OmFwcGx5UHJvcGVydHkpOgorICAgICAgICBV c2UgY2FzdCB0byBzaG9ydCB0byBhbGxvdyBDU1NQcm9wZXJ0V2lkb3dzIGFuZCBDU1NQcm9wZXJ0 eU9ycGhhbnMgdG8gdXNlIGV4aXN0aW5nIG1hY3JvLgorCiAyMDExLTA2LTE5ICBNT1JJVEEgSGFq aW1lICA8bW9ycml0YUBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkg R2xhemtvdi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZU1hcHBp bmdzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVl TWFwcGluZ3MuaAkocmV2aXNpb24gODkyMjgpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJp bWl0aXZlVmFsdWVNYXBwaW5ncy5oCSh3b3JraW5nIGNvcHkpCkBAIC00Nyw2ICs0NywyMiBAQAog CiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKK3RlbXBsYXRlPD4gaW5saW5lIENTU1ByaW1pdGl2ZVZh bHVlOjpDU1NQcmltaXRpdmVWYWx1ZShzaG9ydCBpKQorICAgIDogbV90eXBlKENTU19OVU1CRVIp CisgICAgLCBtX2hhc0NhY2hlZENTU1RleHQoZmFsc2UpCit7CisgICAgbV92YWx1ZS5udW0gPSBz dGF0aWNfY2FzdDxkb3VibGU+KGkpOworfQorCit0ZW1wbGF0ZTw+IGlubGluZSBDU1NQcmltaXRp dmVWYWx1ZTo6b3BlcmF0b3Igc2hvcnQoKSBjb25zdAoreworICAgIGlmIChtX3R5cGUgPT0gQ1NT X05VTUJFUikgLy8gVmFsaWQgZm9yIENTUyBvdXRsaW5lLXN0eWxlCisgICAgICAgIHJldHVybiBz dGF0aWNfY2FzdDxzaG9ydD4obV92YWx1ZS5udW0pOworCisgICAgQVNTRVJUX05PVF9SRUFDSEVE KCk7CisgICAgcmV0dXJuIDA7Cit9CisKIHRlbXBsYXRlPD4gaW5saW5lIENTU1ByaW1pdGl2ZVZh bHVlOjpDU1NQcmltaXRpdmVWYWx1ZShFQm9yZGVyU3R5bGUgZSkKICAgICA6IG1fdHlwZShDU1Nf SURFTlQpCiAgICAgLCBtX2hhc0NhY2hlZENTU1RleHQoZmFsc2UpCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCShyZXZpc2lvbiA4OTIyOCkKKysrIFNvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDAzMCwy MyArNDAzMCwxMSBAQCB2b2lkIENTU1N0eWxlU2VsZWN0b3I6OmFwcGx5UHJvcGVydHkoaW50CiAg ICAgICAgIHJldHVybjsKICAgICB9CiAgICAgY2FzZSBDU1NQcm9wZXJ0eVdpZG93czoKLSAgICB7 Ci0gICAgICAgIEhBTkRMRV9JTkhFUklUX0FORF9JTklUSUFMKHdpZG93cywgV2lkb3dzKQotICAg ICAgICBpZiAoIXByaW1pdGl2ZVZhbHVlIHx8IHByaW1pdGl2ZVZhbHVlLT5wcmltaXRpdmVUeXBl KCkgIT0gQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19OVU1CRVIpCi0gICAgICAgICAgICByZXR1cm47 Ci0gICAgICAgIG1fc3R5bGUtPnNldFdpZG93cyhwcmltaXRpdmVWYWx1ZS0+Z2V0SW50VmFsdWUo KSk7CisgICAgICAgIEhBTkRMRV9JTkhFUklUX0FORF9JTklUSUFMX0FORF9QUklNSVRJVkUod2lk b3dzLCBXaWRvd3MpCiAgICAgICAgIHJldHVybjsKLSAgICB9Ci0gICAgICAgIAogICAgIGNhc2Ug Q1NTUHJvcGVydHlPcnBoYW5zOgotICAgIHsKLSAgICAgICAgSEFORExFX0lOSEVSSVRfQU5EX0lO SVRJQUwob3JwaGFucywgT3JwaGFucykKLSAgICAgICAgaWYgKCFwcmltaXRpdmVWYWx1ZSB8fCBw cmltaXRpdmVWYWx1ZS0+cHJpbWl0aXZlVHlwZSgpICE9IENTU1ByaW1pdGl2ZVZhbHVlOjpDU1Nf TlVNQkVSKQotICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICBtX3N0eWxlLT5zZXRPcnBoYW5z KHByaW1pdGl2ZVZhbHVlLT5nZXRJbnRWYWx1ZSgpKTsKKyAgICAgICAgSEFORExFX0lOSEVSSVRf QU5EX0lOSVRJQUxfQU5EX1BSSU1JVElWRShvcnBoYW5zLCBPcnBoYW5zKQogICAgICAgICByZXR1 cm47Ci0gICAgfSAgICAgICAgCi0KIC8vIGxlbmd0aCwgcGVyY2VudCwgbnVtYmVyCiAgICAgY2Fz ZSBDU1NQcm9wZXJ0eUxpbmVIZWlnaHQ6CiAgICAgewo= 97753 2011-06-19 23:44:00 -0700 2011-06-22 10:42:41 -0700 Patch bug-62964-20110620164357.patch text/plain 2836 macpherson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5MjMxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDYtMTkgIEx1a2UgTWFj cGhlcnNvbiAgIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTdXBwb3J0IGNhc3QgZnJvbSBDU1NQcmltaXRp dmVWYWx1ZSB0byBzaG9ydCBhbmQgdXNlIGZvciBDU1NQcm9wZXJ0eVdpZG93cyBhbmQgQ1NTUHJv cGVydHlPcnBoYW5zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjI5NjQKKworICAgICAgICBObyBuZXcgdGVzdHMgLyByZWZhY3RvcmluZyBvbmx5Lgor CisgICAgICAgICogY3NzL0NTU1ByaW1pdGl2ZVZhbHVlTWFwcGluZ3MuaDoKKyAgICAgICAgU3Vw cG9ydCBjYXN0IHRvL2Zyb20gc2hvcnQuCisgICAgICAgICogY3NzL0NTU1N0eWxlU2VsZWN0b3Iu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTU3R5bGVTZWxlY3Rvcjo6YXBwbHlQcm9wZXJ0eSk6 CisgICAgICAgIFVzZSBjYXN0IHRvIHNob3J0IHRvIGFsbG93IENTU1Byb3BlcnRXaWRvd3MgYW5k IENTU1Byb3BlcnR5T3JwaGFucyB0byB1c2UgZXhpc3RpbmcgbWFjcm8uCisKIDIwMTEtMDYtMTkg IE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGltaXRyaSBHbGF6a292LgpJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2 ZVZhbHVlTWFwcGluZ3MuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJp bWl0aXZlVmFsdWVNYXBwaW5ncy5oCShyZXZpc2lvbiA4OTIzMSkKKysrIFNvdXJjZS9XZWJDb3Jl L2Nzcy9DU1NQcmltaXRpdmVWYWx1ZU1hcHBpbmdzLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ3LDYg KzQ3LDIyIEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAordGVtcGxhdGU8PiBpbmxpbmUgQ1NT UHJpbWl0aXZlVmFsdWU6OkNTU1ByaW1pdGl2ZVZhbHVlKHNob3J0IGkpCisgICAgOiBtX3R5cGUo Q1NTX05VTUJFUikKKyAgICAsIG1faGFzQ2FjaGVkQ1NTVGV4dChmYWxzZSkKK3sKKyAgICBtX3Zh bHVlLm51bSA9IHN0YXRpY19jYXN0PGRvdWJsZT4oaSk7Cit9CisKK3RlbXBsYXRlPD4gaW5saW5l IENTU1ByaW1pdGl2ZVZhbHVlOjpvcGVyYXRvciBzaG9ydCgpIGNvbnN0Cit7CisgICAgaWYgKG1f dHlwZSA9PSBDU1NfTlVNQkVSKSAvLyBWYWxpZCBmb3IgQ1NTIG91dGxpbmUtc3R5bGUKKyAgICAg ICAgcmV0dXJuIHN0YXRpY19jYXN0PHNob3J0PihtX3ZhbHVlLm51bSk7CisKKyAgICBBU1NFUlRf Tk9UX1JFQUNIRUQoKTsKKyAgICByZXR1cm4gMDsKK30KKwogdGVtcGxhdGU8PiBpbmxpbmUgQ1NT UHJpbWl0aXZlVmFsdWU6OkNTU1ByaW1pdGl2ZVZhbHVlKEVCb3JkZXJTdHlsZSBlKQogICAgIDog bV90eXBlKENTU19JREVOVCkKICAgICAsIG1faGFzQ2FjaGVkQ1NTVGV4dChmYWxzZSkKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAJKHJldmlzaW9uIDg5MjMxKQor KysgU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC00MDMwLDIzICs0MDMwLDExIEBAIHZvaWQgQ1NTU3R5bGVTZWxlY3Rvcjo6YXBwbHlQcm9w ZXJ0eShpbnQKICAgICAgICAgcmV0dXJuOwogICAgIH0KICAgICBjYXNlIENTU1Byb3BlcnR5V2lk b3dzOgotICAgIHsKLSAgICAgICAgSEFORExFX0lOSEVSSVRfQU5EX0lOSVRJQUwod2lkb3dzLCBX aWRvd3MpCi0gICAgICAgIGlmICghcHJpbWl0aXZlVmFsdWUgfHwgcHJpbWl0aXZlVmFsdWUtPnBy aW1pdGl2ZVR5cGUoKSAhPSBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX05VTUJFUikKLSAgICAgICAg ICAgIHJldHVybjsKLSAgICAgICAgbV9zdHlsZS0+c2V0V2lkb3dzKHByaW1pdGl2ZVZhbHVlLT5n ZXRJbnRWYWx1ZSgpKTsKKyAgICAgICAgSEFORExFX0lOSEVSSVRfQU5EX0lOSVRJQUxfQU5EX1BS SU1JVElWRSh3aWRvd3MsIFdpZG93cykKICAgICAgICAgcmV0dXJuOwotICAgIH0KLSAgICAgICAg CiAgICAgY2FzZSBDU1NQcm9wZXJ0eU9ycGhhbnM6Ci0gICAgewotICAgICAgICBIQU5ETEVfSU5I RVJJVF9BTkRfSU5JVElBTChvcnBoYW5zLCBPcnBoYW5zKQotICAgICAgICBpZiAoIXByaW1pdGl2 ZVZhbHVlIHx8IHByaW1pdGl2ZVZhbHVlLT5wcmltaXRpdmVUeXBlKCkgIT0gQ1NTUHJpbWl0aXZl VmFsdWU6OkNTU19OVU1CRVIpCi0gICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIG1fc3R5bGUt PnNldE9ycGhhbnMocHJpbWl0aXZlVmFsdWUtPmdldEludFZhbHVlKCkpOworICAgICAgICBIQU5E TEVfSU5IRVJJVF9BTkRfSU5JVElBTF9BTkRfUFJJTUlUSVZFKG9ycGhhbnMsIE9ycGhhbnMpCiAg ICAgICAgIHJldHVybjsKLSAgICB9ICAgICAgICAKLQogLy8gbGVuZ3RoLCBwZXJjZW50LCBudW1i ZXIKICAgICBjYXNlIENTU1Byb3BlcnR5TGluZUhlaWdodDoKICAgICB7Cg==