62959 2011-06-19 19:21:17 -0700 [EFL] Add some PLATFORM(EFL) ifdefs to GraphicsContext3D.h 2011-06-27 09:57:28 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 62709 0 hw1008.kim webkit-unassigned gyuyoung.kim gyuyoung.kim kenneth krit leandro lucas.de.marchi mrobinson rakuco ryuan.choi tonikitoo webkit.review.bot oldest_to_newest 423420 0 hw1008.kim 2011-06-19 19:21:17 -0700 This patch adds some PLATFORM(EFL) ifdefs to GraphicsContext3D.cpp. 423428 1 97733 hw1008.kim 2011-06-19 19:53:32 -0700 Created attachment 97733 Patch 423459 2 97733 gyuyoung.kim 2011-06-19 21:22:40 -0700 Comment on attachment 97733 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97733&action=review > Source/WebCore/ChangeLog:8 > + No new functionality, no new tests. If your patch doesn't have test cases, AFAIK, you don't need to add above line. If you want to add this line, please write it below summary description. 423560 3 97767 hw1008.kim 2011-06-20 02:18:01 -0700 Created attachment 97767 Patch 423564 4 hw1008.kim 2011-06-20 02:25:25 -0700 (In reply to comment #2) > (From update of attachment 97733 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=97733&action=review > > > Source/WebCore/ChangeLog:8 > > + No new functionality, no new tests. > > If your patch doesn't have test cases, AFAIK, you don't need to add above line. If you want to add this line, please write it below summary description. Thanks Gyuyoung. I've deleted the line. 423654 5 rakuco 2011-06-20 07:05:32 -0700 The patch looks OK, but shouldn't it actually depend on bug 62709 as it depends on the functions implemented there? 424204 6 hw1008.kim 2011-06-20 20:02:38 -0700 (In reply to comment #5) > The patch looks OK, but shouldn't it actually depend on bug 62709 as it depends on the functions implemented there? You're right~ I agree. I will modify the dependency. Thanks 427724 7 ryuan.choi 2011-06-27 00:30:33 -0700 Informal r+ on my side. Could anyone review this? 427733 8 gyuyoung.kim 2011-06-27 00:39:02 -0700 CC'ing Martin and Dirk. Martin and Dirk, Could you please review this patch? 428019 9 97767 webkit.review.bot 2011-06-27 09:57:22 -0700 Comment on attachment 97767 Patch Clearing flags on attachment: 97767 Committed r89827: <http://trac.webkit.org/changeset/89827> 428020 10 webkit.review.bot 2011-06-27 09:57:28 -0700 All reviewed patches have been landed. Closing bug. 97733 2011-06-19 19:53:32 -0700 2011-06-20 02:17:53 -0700 Patch bug-62959-20110620115413.patch text/plain 2223 hw1008.kim U3VidmVyc2lvbiBSZXZpc2lvbjogODkyMjQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlN2U2MjdjOWQwNmE5OTYy MGZkMjQwYjlkZDMyYTI4NDY5MDdlOWQ5Li5mZWI0ZTEzMjE3ZGVhN2NkMTAxNjA4OWY2ZDdiODlj MzVhNjMyNWUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMTkgIEh5b3dv biBLaW0gIDxodzEwMDgua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIEFkZCBzb21lIFBMQVRGT1JNKEVGTCkgaWZk ZWZzIHRvIEdyYXBoaWNzQ29udGV4dDNELmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTYyOTU5CisKKyAgICAgICAgTm8gbmV3IGZ1bmN0aW9uYWxpdHks IG5vIG5ldyB0ZXN0cy4KKyAgICAgICAgQWRkIFBMQVRGT1JNKEVGTCkgaWZkZWZzIHRvIHVzZSBH cmFwaGljc0NvbnRleHQzREludGVybmFsLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv R3JhcGhpY3NDb250ZXh0M0QuaDoKKwogMjAxMS0wNi0xOSAgVW5hIFNhYm92aWMgIDx1bmEuc2Fi b3ZpY0BwYWxtLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNE LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5o CmluZGV4IDE0ZTcxMDc1ZTYyNDUxNGE1ODg2ZGZkZjE4ZjEzZDk3Njg5ZTYyMDUuLjczNGQ0YTMw OGY2OTQxMTljNGIyOGI3NzFiMzQxMDNiMzgxMjlkMWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmgKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuaApAQCAtMTAxLDcgKzEw MSw3IEBAIHN0cnVjdCBBY3RpdmVJbmZvIHsKIH07CiAKIC8vIEZJWE1FOiBpZGVhbGx5IHRoaXMg d291bGQgYmUgdXNlZCBvbiBhbGwgcGxhdGZvcm1zLgotI2lmIFBMQVRGT1JNKENIUk9NSVVNKSB8 fCBQTEFURk9STShRVCkgfHwgUExBVEZPUk0oR1RLKQorI2lmIFBMQVRGT1JNKENIUk9NSVVNKSB8 fCBQTEFURk9STShRVCkgfHwgUExBVEZPUk0oR1RLKSB8fCBQTEFURk9STShFRkwpCiBjbGFzcyBH cmFwaGljc0NvbnRleHQzREludGVybmFsOwogI2VuZGlmCiAKQEAgLTQ3Niw2ICs0NzYsMTEgQEAg cHVibGljOgogI2VsaWYgUExBVEZPUk0oR1RLKQogICAgIFBsYXRmb3JtR3JhcGhpY3NDb250ZXh0 M0QgcGxhdGZvcm1HcmFwaGljc0NvbnRleHQzRCgpOwogICAgIFBsYXRmb3JtM0RPYmplY3QgcGxh dGZvcm1UZXh0dXJlKCkgY29uc3QgeyByZXR1cm4gbV90ZXh0dXJlOyB9CisjZWxpZiBQTEFURk9S TShFRkwpCisgICAgUGxhdGZvcm1HcmFwaGljc0NvbnRleHQzRCBwbGF0Zm9ybUdyYXBoaWNzQ29u dGV4dDNEKCkgY29uc3Q7CisjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQorICAgIFBs YXRmb3JtTGF5ZXIqIHBsYXRmb3JtTGF5ZXIoKSBjb25zdDsKKyNlbmRpZgogI2Vsc2UKICAgICBQ bGF0Zm9ybUdyYXBoaWNzQ29udGV4dDNEIHBsYXRmb3JtR3JhcGhpY3NDb250ZXh0M0QoKSBjb25z dCB7IHJldHVybiBOdWxsUGxhdGZvcm1HcmFwaGljc0NvbnRleHQzRDsgfQogICAgIFBsYXRmb3Jt M0RPYmplY3QgcGxhdGZvcm1UZXh0dXJlKCkgY29uc3QgeyByZXR1cm4gTnVsbFBsYXRmb3JtM0RP YmplY3Q7IH0KQEAgLTkzMiw3ICs5MzcsNyBAQCBwdWJsaWM6CiAjZW5kaWYKIAogICAgIC8vIEZJ WE1FOiBpZGVhbGx5IHRoaXMgd291bGQgYmUgdXNlZCBvbiBhbGwgcGxhdGZvcm1zLgotI2lmIFBM QVRGT1JNKENIUk9NSVVNKSB8fCBQTEFURk9STShRVCkgfHwgUExBVEZPUk0oR1RLKQorI2lmIFBM QVRGT1JNKENIUk9NSVVNKSB8fCBQTEFURk9STShRVCkgfHwgUExBVEZPUk0oR1RLKSB8fCBQTEFU Rk9STShFRkwpCiAgICAgZnJpZW5kIGNsYXNzIEdyYXBoaWNzQ29udGV4dDNESW50ZXJuYWw7CiAg ICAgT3duUHRyPEdyYXBoaWNzQ29udGV4dDNESW50ZXJuYWw+IG1faW50ZXJuYWw7CiAjZW5kaWYK 97767 2011-06-20 02:18:01 -0700 2011-06-27 09:57:21 -0700 Patch bug-62959-20110620181845.patch text/plain 2176 hw1008.kim U3VidmVyc2lvbiBSZXZpc2lvbjogODkyMjQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlN2U2MjdjOWQwNmE5OTYy MGZkMjQwYjlkZDMyYTI4NDY5MDdlOWQ5Li43MDM0YzJiMGU2MTU5MGRjNTNlYTEzYWM1Y2E5MmQ4 MmEzMTNiMmNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDYtMjAgIEh5b3dv biBLaW0gIDxodzEwMDgua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIEFkZCBzb21lIFBMQVRGT1JNKEVGTCkgaWZk ZWZzIHRvIEdyYXBoaWNzQ29udGV4dDNELmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTYyOTU5CisKKyAgICAgICAgQWRkIFBMQVRGT1JNKEVGTCkgaWZk ZWZzIHRvIHVzZSBHcmFwaGljc0NvbnRleHRJbnRlcm5hbC4KKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmg6CisKIDIwMTEtMDYtMTkgIFVuYSBTYWJvdmlj ICA8dW5hLnNhYm92aWNAcGFsbS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRs ZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGlj c0NvbnRleHQzRC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3ND b250ZXh0M0QuaAppbmRleCAxNGU3MTA3NWU2MjQ1MTRhNTg4NmRmZGYxOGYxM2Q5NzY4OWU2MjA1 Li43MzRkNGEzMDhmNjk0MTE5YzRiMjhiNzcxYjM0MTAzYjM4MTI5ZDFiIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmgKQEAg LTEwMSw3ICsxMDEsNyBAQCBzdHJ1Y3QgQWN0aXZlSW5mbyB7CiB9OwogCiAvLyBGSVhNRTogaWRl YWxseSB0aGlzIHdvdWxkIGJlIHVzZWQgb24gYWxsIHBsYXRmb3Jtcy4KLSNpZiBQTEFURk9STShD SFJPTUlVTSkgfHwgUExBVEZPUk0oUVQpIHx8IFBMQVRGT1JNKEdUSykKKyNpZiBQTEFURk9STShD SFJPTUlVTSkgfHwgUExBVEZPUk0oUVQpIHx8IFBMQVRGT1JNKEdUSykgfHwgUExBVEZPUk0oRUZM KQogY2xhc3MgR3JhcGhpY3NDb250ZXh0M0RJbnRlcm5hbDsKICNlbmRpZgogCkBAIC00NzYsNiAr NDc2LDExIEBAIHB1YmxpYzoKICNlbGlmIFBMQVRGT1JNKEdUSykKICAgICBQbGF0Zm9ybUdyYXBo aWNzQ29udGV4dDNEIHBsYXRmb3JtR3JhcGhpY3NDb250ZXh0M0QoKTsKICAgICBQbGF0Zm9ybTNE T2JqZWN0IHBsYXRmb3JtVGV4dHVyZSgpIGNvbnN0IHsgcmV0dXJuIG1fdGV4dHVyZTsgfQorI2Vs aWYgUExBVEZPUk0oRUZMKQorICAgIFBsYXRmb3JtR3JhcGhpY3NDb250ZXh0M0QgcGxhdGZvcm1H cmFwaGljc0NvbnRleHQzRCgpIGNvbnN0OworI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElO RykKKyAgICBQbGF0Zm9ybUxheWVyKiBwbGF0Zm9ybUxheWVyKCkgY29uc3Q7CisjZW5kaWYKICNl bHNlCiAgICAgUGxhdGZvcm1HcmFwaGljc0NvbnRleHQzRCBwbGF0Zm9ybUdyYXBoaWNzQ29udGV4 dDNEKCkgY29uc3QgeyByZXR1cm4gTnVsbFBsYXRmb3JtR3JhcGhpY3NDb250ZXh0M0Q7IH0KICAg ICBQbGF0Zm9ybTNET2JqZWN0IHBsYXRmb3JtVGV4dHVyZSgpIGNvbnN0IHsgcmV0dXJuIE51bGxQ bGF0Zm9ybTNET2JqZWN0OyB9CkBAIC05MzIsNyArOTM3LDcgQEAgcHVibGljOgogI2VuZGlmCiAK ICAgICAvLyBGSVhNRTogaWRlYWxseSB0aGlzIHdvdWxkIGJlIHVzZWQgb24gYWxsIHBsYXRmb3Jt cy4KLSNpZiBQTEFURk9STShDSFJPTUlVTSkgfHwgUExBVEZPUk0oUVQpIHx8IFBMQVRGT1JNKEdU SykKKyNpZiBQTEFURk9STShDSFJPTUlVTSkgfHwgUExBVEZPUk0oUVQpIHx8IFBMQVRGT1JNKEdU SykgfHwgUExBVEZPUk0oRUZMKQogICAgIGZyaWVuZCBjbGFzcyBHcmFwaGljc0NvbnRleHQzRElu dGVybmFsOwogICAgIE93blB0cjxHcmFwaGljc0NvbnRleHQzREludGVybmFsPiBtX2ludGVybmFs OwogI2VuZGlmCg==