62950 2011-06-19 04:01:04 -0700 [GTK] [WK2] WebKit2 build break fixes. 2011-06-21 10:00:13 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 37369 0 l.slachciak webkit-unassigned webkit.review.bot oldest_to_newest 423352 0 l.slachciak 2011-06-19 04:01:04 -0700 When building WebKit2 for GTK there are few build breaks connected with missing include files. Attached patch fixes this issue. 423353 1 97719 l.slachciak 2011-06-19 04:02:54 -0700 Created attachment 97719 build break fix 423355 2 l.slachciak 2011-06-19 04:12:53 -0700 I encountered following errors when building webkit with --enable-webkit2 --with-gtk=3.0 options: --enable-webkit2 --with-gtk=3.0 /bin/mkdir -p ./.deps/DerivedSources ../../../../sources/WebKit/WebKit/Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp: In static member function ‘static WTF::PassRefPtr<WebKit::SharedMemory> WebKit::SharedMemory::create(size_t)’: ../../../../sources/WebKit/WebKit/Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp:115:60: error: ‘g_get_tmp_dir’ was not declared in this scope ../../../../sources/WebKit/WebKit/Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp:115:92: error: ‘g_build_filename’ was not declared in this scope make[1]: *** [Source/WebKit2/Platform/unix/libwebkit2gtk_3_0_la-SharedMemoryUnix.lo] Błąd 1 make[1]: *** Oczekiwanie na niezakończone zadania.... ../../../../sources/WebKit/WebKit/Source/WebKit2/Shared/gtk/WebCoreArgumentCodersGtk.cpp: In static member function ‘static bool CoreIPC::ArgumentCoder<WebCore::ResourceRequest>::decode(CoreIPC::ArgumentDecoder*, WebCore::ResourceRequest&)’: ../../../../sources/WebKit/WebKit/Source/WebKit2/Shared/gtk/WebCoreArgumentCodersGtk.cpp:81:60: error: invalid use of incomplete type ‘struct WTF::CString’ ../../../../sources/WebKit/WebKit/Source/JavaScriptCore/wtf/Forward.h:38:11: error: forward declaration of ‘struct WTF::CString’ make[1]: *** [Source/WebKit2/Shared/gtk/libwebkit2gtk_3_0_la-WebCoreArgumentCodersGtk.lo] Błąd 1 ../../../../sources/WebKit/WebKit/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp: In member function ‘virtual void WebKit::PageClientImpl::setCursor(const WebCore::Cursor&)’: ../../../../sources/WebKit/WebKit/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:145:34: error: invalid use of incomplete type ‘const struct WebCore::Cursor’ ../../../../sources/WebKit/WebKit/Source/WebKit2/Shared/WebCoreArgumentCoders.h:35:11: error: forward declaration of ‘const struct WebCore::Cursor’ Attached patch fixes these build breaks 423356 3 97720 l.slachciak 2011-06-19 04:16:24 -0700 Created attachment 97720 build break fix additionally small fix in my changelog entry 424511 4 97720 webkit.review.bot 2011-06-21 10:00:09 -0700 Comment on attachment 97720 build break fix Clearing flags on attachment: 97720 Committed r89360: <http://trac.webkit.org/changeset/89360> 424512 5 webkit.review.bot 2011-06-21 10:00:13 -0700 All reviewed patches have been landed. Closing bug. 97719 2011-06-19 04:02:54 -0700 2011-06-19 04:16:24 -0700 build break fix bb1.dif text/plain 2096 l.slachciak ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA0ZmZiZWY1Li44MWU1MjhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDYtMTkgIEx1a2FzeiBTbGFjaGNpYWsgIDxsdWthc3ouc2xhY2hjaWFrQGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb R1RLXSBbV0syXSBXZWJLaXQyIGJ1aWxkIGJyZWFrIGZpeGVzLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjI5NTAKKworICAgICAgICBXaGVuIGJ1aWxk aW5nIFdlYktpdDIgZm9yIEdUSyB0aGVyZSBhcmUgZmV3IGJ1aWxkIGJyZWFrcyBjb25uZWN0ZWQg d2l0aCBtaXNzaW5nIGluY2x1ZGUgZmlsZXMuCisKKyAgICAgICAgKiBQbGF0Zm9ybS91bml4L1No YXJlZE1lbW9yeVVuaXguY3BwOgorICAgICAgICAqIFNoYXJlZC9ndGsvV2ViQ29yZUFyZ3VtZW50 Q29kZXJzR3RrLmNwcDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1w bC5jcHA6CisKIDIwMTEtMDYtMTggIEV1bm1pIExlZSAgPGV1bm1pMTUubGVlQHNhbXN1bmcuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9QbGF0Zm9ybS91bml4L1NoYXJlZE1lbW9yeVVuaXguY3BwIGIvU291cmNlL1dlYktp dDIvUGxhdGZvcm0vdW5peC9TaGFyZWRNZW1vcnlVbml4LmNwcAppbmRleCAzZGNlMWMyLi40Njk4 OWRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS91bml4L1NoYXJlZE1lbW9y eVVuaXguY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL3VuaXgvU2hhcmVkTWVtb3J5 VW5peC5jcHAKQEAgLTQ1LDYgKzQ1LDcgQEAKICNpZiBQTEFURk9STShRVCkKICNpbmNsdWRlIDxR RGlyPgogI2VsaWYgUExBVEZPUk0oR1RLKQorI2luY2x1ZGUgPGdsaWIuaD4KICNpbmNsdWRlIDx3 dGYvZ29iamVjdC9HT3duUHRyLmg+CiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvU2hhcmVkL2d0ay9XZWJDb3JlQXJndW1lbnRDb2RlcnNHdGsuY3BwIGIvU291cmNlL1dlYktp dDIvU2hhcmVkL2d0ay9XZWJDb3JlQXJndW1lbnRDb2RlcnNHdGsuY3BwCmluZGV4IDI4NDI3YTMu LmFhZTU5ZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9ndGsvV2ViQ29yZUFy Z3VtZW50Q29kZXJzR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvZ3RrL1dlYkNv cmVBcmd1bWVudENvZGVyc0d0ay5jcHAKQEAgLTI3LDYgKzI3LDcgQEAKICNpbmNsdWRlICJjb25m aWcuaCIKICNpbmNsdWRlICJXZWJDb3JlQXJndW1lbnRDb2RlcnMuaCIKIAorI2luY2x1ZGUgPHd0 Zi90ZXh0L0NTdHJpbmcuaD4KICNpbmNsdWRlIDxXZWJDb3JlL1Jlc291cmNlRXJyb3IuaD4KICNp bmNsdWRlIDxXZWJDb3JlL1Jlc291cmNlUmVxdWVzdC5oPgogI2luY2x1ZGUgPFdlYkNvcmUvUmVz b3VyY2VSZXNwb25zZS5oPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9ndGsvUGFnZUNsaWVudEltcGwuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9n dGsvUGFnZUNsaWVudEltcGwuY3BwCmluZGV4IDdhMjRmZjAuLmFiNTY0NmYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5jcHAKQEAg LTM4LDYgKzM4LDcgQEAKICNpbmNsdWRlICJXZWJLaXRXZWJWaWV3QmFzZVByaXZhdGUuaCIKICNp bmNsdWRlICJXZWJQYWdlUHJveHkuaCIKICNpbmNsdWRlICJXZWJQb3B1cE1lbnVQcm94eUd0ay5o IgorI2luY2x1ZGUgPFdlYkNvcmUvQ3Vyc29yLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9HdGtVdGls aXRpZXMuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4KIAo= 97720 2011-06-19 04:16:24 -0700 2011-06-21 10:00:08 -0700 build break fix bb2.diff text/plain 2093 l.slachciak ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA0ZmZiZWY1Li4yYzBiNTkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDYtMTkgIEx1a2FzeiBTbGFjaGNpYWsgIDxsLnNsYWNoY2lha0BzYW1zdW5nLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RL XSBbV0syXSBXZWJLaXQyIGJ1aWxkIGJyZWFrIGZpeGVzLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjI5NTAKKworICAgICAgICBXaGVuIGJ1aWxkaW5n IFdlYktpdDIgZm9yIEdUSyB0aGVyZSBhcmUgZmV3IGJ1aWxkIGJyZWFrcyBjb25uZWN0ZWQgd2l0 aCBtaXNzaW5nIGluY2x1ZGUgZmlsZXMuCisKKyAgICAgICAgKiBQbGF0Zm9ybS91bml4L1NoYXJl ZE1lbW9yeVVuaXguY3BwOgorICAgICAgICAqIFNoYXJlZC9ndGsvV2ViQ29yZUFyZ3VtZW50Q29k ZXJzR3RrLmNwcDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5j cHA6CisKIDIwMTEtMDYtMTggIEV1bm1pIExlZSAgPGV1bm1pMTUubGVlQHNhbXN1bmcuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9QbGF0Zm9ybS91bml4L1NoYXJlZE1lbW9yeVVuaXguY3BwIGIvU291cmNlL1dlYktpdDIv UGxhdGZvcm0vdW5peC9TaGFyZWRNZW1vcnlVbml4LmNwcAppbmRleCAzZGNlMWMyLi40Njk4OWRk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS91bml4L1NoYXJlZE1lbW9yeVVu aXguY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL3VuaXgvU2hhcmVkTWVtb3J5VW5p eC5jcHAKQEAgLTQ1LDYgKzQ1LDcgQEAKICNpZiBQTEFURk9STShRVCkKICNpbmNsdWRlIDxRRGly PgogI2VsaWYgUExBVEZPUk0oR1RLKQorI2luY2x1ZGUgPGdsaWIuaD4KICNpbmNsdWRlIDx3dGYv Z29iamVjdC9HT3duUHRyLmg+CiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv U2hhcmVkL2d0ay9XZWJDb3JlQXJndW1lbnRDb2RlcnNHdGsuY3BwIGIvU291cmNlL1dlYktpdDIv U2hhcmVkL2d0ay9XZWJDb3JlQXJndW1lbnRDb2RlcnNHdGsuY3BwCmluZGV4IDI4NDI3YTMuLmFh ZTU5ZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9ndGsvV2ViQ29yZUFyZ3Vt ZW50Q29kZXJzR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvZ3RrL1dlYkNvcmVB cmd1bWVudENvZGVyc0d0ay5jcHAKQEAgLTI3LDYgKzI3LDcgQEAKICNpbmNsdWRlICJjb25maWcu aCIKICNpbmNsdWRlICJXZWJDb3JlQXJndW1lbnRDb2RlcnMuaCIKIAorI2luY2x1ZGUgPHd0Zi90 ZXh0L0NTdHJpbmcuaD4KICNpbmNsdWRlIDxXZWJDb3JlL1Jlc291cmNlRXJyb3IuaD4KICNpbmNs dWRlIDxXZWJDb3JlL1Jlc291cmNlUmVxdWVzdC5oPgogI2luY2x1ZGUgPFdlYkNvcmUvUmVzb3Vy Y2VSZXNwb25zZS5oPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9n dGsvUGFnZUNsaWVudEltcGwuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsv UGFnZUNsaWVudEltcGwuY3BwCmluZGV4IDdhMjRmZjAuLmFiNTY0NmYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5jcHAKQEAgLTM4 LDYgKzM4LDcgQEAKICNpbmNsdWRlICJXZWJLaXRXZWJWaWV3QmFzZVByaXZhdGUuaCIKICNpbmNs dWRlICJXZWJQYWdlUHJveHkuaCIKICNpbmNsdWRlICJXZWJQb3B1cE1lbnVQcm94eUd0ay5oIgor I2luY2x1ZGUgPFdlYkNvcmUvQ3Vyc29yLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9HdGtVdGlsaXRp ZXMuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4KIAo=