62947 2011-06-18 19:21:35 -0700 Don't use PassRefPtr variables in the V8 bindings generator 2011-06-20 10:55:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca sam oldest_to_newest 423301 0 andersca 2011-06-18 19:21:35 -0700 Don't use PassRefPtr variables in the V8 bindings generator 423302 1 andersca 2011-06-18 19:23:10 -0700 The V8 bindings generator will generate local variables of type PassRefPtr<DOMStringList> and then try to assign into them. This will break when https://bugs.webkit.org/show_bug.cgi?id=62940 is landed so I'll try to remove the offending line in CodeGeneratorV8.pm to see what else breaks. The offending line is return "PassRefPtr<DOMStringList>" if $type eq "DOMStringList" and $isParameter; and it was added as part of https://bugs.webkit.org/show_bug.cgi?id=56950 423303 2 97713 andersca 2011-06-18 19:23:36 -0700 Created attachment 97713 Patch 423399 3 sam 2011-06-19 14:08:23 -0700 Anders, are you waiting for something to mark this for review? It looks fine to me. 423763 4 andersca 2011-06-20 10:53:05 -0700 With this patch, addSpellcheckRangeCallback in V8HTMLTextAreaElement.cpp now looks like: --- V8HTMLTextAreaElement-baseline.cpp 2011-06-20 10:51:22.000000000 -0700 +++ V8HTMLTextAreaElement.cpp 2011-06-20 10:51:49.000000000 -0700 @@ -367,7 +367,7 @@ imp->addSpellcheckRange(start, length); return v8::Handle<v8::Value>(); } - EXCEPTION_BLOCK(PassRefPtr<DOMStringList>, suggestions, v8ValueToWebCoreDOMStringList(args[2])); + EXCEPTION_BLOCK(RefPtr<DOMStringList>, suggestions, v8ValueToWebCoreDOMStringList(args[2])); if (args.Length() <= 3) { imp->addSpellcheckRange(start, length, suggestions); return v8::Handle<v8::Value>(); 423767 5 97713 abarth 2011-06-20 10:53:53 -0700 Comment on attachment 97713 Patch + No new tests. (OOPS!) ^^^ You'll probably want to remove this line from the ChangeLog. 423771 6 andersca 2011-06-20 10:55:32 -0700 Committed r89261: <http://trac.webkit.org/changeset/89261> 97713 2011-06-18 19:23:36 -0700 2011-06-20 10:53:53 -0700 Patch bug-62947-20110618192334.patch text/plain 1218 andersca SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5MjA5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDYtMTggIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBEb24ndCB1c2UgUGFzc1JlZlB0ciB2YXJpYWJsZXMgaW4g dGhlIFY4IGJpbmRpbmdzIGdlbmVyYXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NjI5NDcKKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkK KworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtOgorCiAyMDEx LTA2LTE4ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9Db2RlR2VuZXJhdG9yVjgucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0JKHJldmlzaW9uIDg5MjA3KQorKysgU291cmNl L1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0JKHdvcmtpbmcgY29w eSkKQEAgLTI5MjEsNyArMjkyMSw2IEBAIHN1YiBHZXROYXRpdmVUeXBlCiAKICAgICByZXR1cm4g IlJlZlB0cjxNZWRpYVF1ZXJ5TGlzdExpc3RlbmVyPiIgaWYgJHR5cGUgZXEgIk1lZGlhUXVlcnlM aXN0TGlzdGVuZXIiOwogCi0gICAgcmV0dXJuICJQYXNzUmVmUHRyPERPTVN0cmluZ0xpc3Q+IiBp ZiAkdHlwZSBlcSAiRE9NU3RyaW5nTGlzdCIgYW5kICRpc1BhcmFtZXRlcjsKICAgICByZXR1cm4g IlJlZlB0cjxET01TdHJpbmdMaXN0PiIgaWYgJHR5cGUgZXEgIkRPTVN0cmluZ0xpc3QiOwogCiAg ICAgIyBEZWZhdWx0LCBhc3N1bWUgbmF0aXZlIHR5cGUgaXMgYSBwb2ludGVyIHdpdGggc2FtZSB0 eXBlIG5hbWUgYXMgaWRsIHR5cGUK