62943 2011-06-18 16:38:21 -0700 test-webkitpy --all errors out because scm_unittest.py can't find module checkout 2011-06-22 22:33:21 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dbates webkit-unassigned abarth eric webkit.review.bot oldest_to_newest 423273 0 dbates 2011-06-18 16:38:21 -0700 When I ran test-webkitpy --all today, I got the following error: atlas:WebKit dbates$ Tools/Scripts/test-webkitpy --all test-webkitpy: INFO Suppressing most webkitpy logging while running unit tests. test-webkitpy: WARNING You are testing webkitpy with a Python version (2.6.1) higher than the minimum version (2.5) it was meant to support. test-webkitpy: WARNING Skipping tests in Tools/QueueStatusServer due to failure (No module named dev_appserver). This module is optional. The failure is likely due to a missing Google AppEngine install. (http://code.google.com/appengine/downloads.html) Traceback (most recent call last): File "Tools/Scripts/test-webkitpy", line 266, in <module> Tester().run_tests(sys.argv, external_package_paths) File "/Users/dbates/Desktop/WebKit/Tools/Scripts/webkitpy/test/main.py", line 160, in run_tests __import__(module) File "/Users/dbates/Desktop/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 48, in <module> from .checkout import Checkout ImportError: No module named checkout 423275 1 97709 dbates 2011-06-18 16:53:14 -0700 Created attachment 97709 Patch (reference checkout module in parent directory) I was not sure whether to remove the "from .checkout import Checkout" (since it's imported in <http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/checkout/__init__.py?rev=85452>) or to change it to read "from ..checkout import Checkout" (so that it references the module which is in our parent directory. I mean, we seem to explicitly import modules even though they appear in a __init__.py. For example, in scm_unittests.py we import from module detection, git, and svn even though these identical imports are in <http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/checkout/scm/__init__.py?rev=85449> (why?) What is the best practice for this? 423276 2 97710 dbates 2011-06-18 16:54:29 -0700 Created attachment 97710 [Alternative] Patch (remove explicit import of checkout module) Alternative patch to remove the explicit import of the checkout module in scm_unittests.py since we import it when checkout/__init__.py is processed. 425946 3 97710 abarth 2011-06-22 21:47:01 -0700 Comment on attachment 97710 [Alternative] Patch (remove explicit import of checkout module) This one is better. Really we shouldn't be importing it in __init__, but that's another story. 425957 4 97710 webkit.review.bot 2011-06-22 22:33:17 -0700 Comment on attachment 97710 [Alternative] Patch (remove explicit import of checkout module) Clearing flags on attachment: 97710 Committed r89532: <http://trac.webkit.org/changeset/89532> 425958 5 webkit.review.bot 2011-06-22 22:33:21 -0700 All reviewed patches have been landed. Closing bug. 97709 2011-06-18 16:53:14 -0700 2011-06-22 21:47:59 -0700 Patch (reference checkout module in parent directory) bug62943.patch text/plain 1363 dbates SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDg5MjA3KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTQgQEAKKzIwMTEtMDYtMTggIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3ZWJraXQub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHRlc3Qtd2Vi a2l0cHkgLS1hbGwgZXJyb3JzIG91dCBiZWNhdXNlIHNjbV91bml0dGVzdC5weSBjYW4ndCBmaW5k IG1vZHVsZSBjaGVja291dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjI5NDMKKworICAgICAgICBDaGFuZ2UgdGhlIGltcG9ydCBjaGVja291dCBsaW5l IHRvIGltcG9ydCB0aGUgY2hlY2tvdXQgbW9kdWxlIGZyb20gb3VyIHBhcmVudCBkaXJlY3Rvcnku CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20vc2NtX3Vu aXR0ZXN0LnB5OgorCiAyMDExLTA2LTE4ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvbnkgQ2hhbmcuCkluZGV4OiBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20vc2NtX3VuaXR0ZXN0LnB5Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS9zY21fdW5p dHRlc3QucHkJKHJldmlzaW9uIDg5MjA3KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21t b24vY2hlY2tvdXQvc2NtL3NjbV91bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtNDUsNyAr NDUsNyBAQCBpbXBvcnQgdXJsbGliCiBpbXBvcnQgc2h1dGlsCiAKIGZyb20gZGF0ZXRpbWUgaW1w b3J0IGRhdGUKLWZyb20gLmNoZWNrb3V0IGltcG9ydCBDaGVja291dAorZnJvbSAuLmNoZWNrb3V0 IGltcG9ydCBDaGVja291dAogZnJvbSB3ZWJraXRweS5jb21tb24uY29uZmlnLmNvbW1pdHRlcnMg aW1wb3J0IENvbW1pdHRlciAgIyBGSVhNRTogVGhpcyBzaG91bGQgbm90IGJlIG5lZWRlZAogZnJv bSB3ZWJraXRweS5jb21tb24ubmV0LmJ1Z3ppbGxhIGltcG9ydCBBdHRhY2htZW50ICMgRklYTUU6 IFRoaXMgc2hvdWxkIG5vdCBiZSBuZWVkZWQKIGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5l eGVjdXRpdmUgaW1wb3J0IEV4ZWN1dGl2ZSwgcnVuX2NvbW1hbmQsIFNjcmlwdEVycm9yCg== 97710 2011-06-18 16:54:29 -0700 2011-06-22 22:33:17 -0700 [Alternative] Patch (remove explicit import of checkout module) bug62943_alt.patch text/plain 1380 dbates SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDg5MjA3KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMDYtMTggIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3ZWJraXQub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHRlc3Qtd2Vi a2l0cHkgLS1hbGwgZXJyb3JzIG91dCBiZWNhdXNlIHNjbV91bml0dGVzdC5weSBjYW4ndCBmaW5k IG1vZHVsZSBjaGVja291dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjI5NDMKKworICAgICAgICBSZW1vdmUgImZyb20gLmNoZWNrb3V0IGltcG9ydCBD aGVja291dCIgZnJvbSBzY21fdW5pdHRlc3QucHkgc2luY2UgaXQncyBpbmNsdWRlZAorICAgICAg ICBieSBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9fX2luaXRfXy5weS4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS9zY21fdW5pdHRlc3Qu cHk6CisKIDIwMTEtMDYtMTggIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgVG9ueSBDaGFuZy4KSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS9zY21fdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtL3NjbV91bml0dGVzdC5w eQkocmV2aXNpb24gODkyMDcpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVj a291dC9zY20vc2NtX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC00NSw3ICs0NSw2IEBA IGltcG9ydCB1cmxsaWIKIGltcG9ydCBzaHV0aWwKIAogZnJvbSBkYXRldGltZSBpbXBvcnQgZGF0 ZQotZnJvbSAuY2hlY2tvdXQgaW1wb3J0IENoZWNrb3V0CiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5j b25maWcuY29tbWl0dGVycyBpbXBvcnQgQ29tbWl0dGVyICAjIEZJWE1FOiBUaGlzIHNob3VsZCBu b3QgYmUgbmVlZGVkCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5uZXQuYnVnemlsbGEgaW1wb3J0IEF0 dGFjaG1lbnQgIyBGSVhNRTogVGhpcyBzaG91bGQgbm90IGJlIG5lZWRlZAogZnJvbSB3ZWJraXRw eS5jb21tb24uc3lzdGVtLmV4ZWN1dGl2ZSBpbXBvcnQgRXhlY3V0aXZlLCBydW5fY29tbWFuZCwg U2NyaXB0RXJyb3IK