62941 2011-06-18 15:49:08 -0700 Git.push_local_commits_to_server() should use passed username and password when we don't have cached credentials 2011-06-19 06:36:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dbates dbates abarth dominicc eric webkit.review.bot oldest_to_newest 423268 0 dbates 2011-06-18 15:49:08 -0700 Following up on Dominic Cooney's comment <https://bugs.webkit.org/show_bug.cgi?id=31500#c39>, Git.push_local_commits_to_server should only raise an AuthenticationError exception when "(not username or not password) and not self.has_authorization_for_realm(SVN.svn_server_realm)". Otherwise, we'll eventually prompt for a username and password but never actually use it. 423282 1 dbates 2011-06-18 17:27:15 -0700 When writing unit tests for this I ran into a issue with SCM.find_checkout_root(). See <https://bugs.webkit.org/show_bug.cgi?id=62945#c1> for more details. 423283 2 97711 dbates 2011-06-18 17:28:42 -0700 Created attachment 97711 Patch and unit tests We'll need to fix bug #62945 in order for the unit tests to run. 423294 3 97711 eric 2011-06-18 18:06:24 -0700 Comment on attachment 97711 Patch and unit tests LGTM. 423295 4 97711 webkit.review.bot 2011-06-18 18:55:37 -0700 Comment on attachment 97711 Patch and unit tests Clearing flags on attachment: 97711 Committed r89209: <http://trac.webkit.org/changeset/89209> 423296 5 webkit.review.bot 2011-06-18 18:55:42 -0700 All reviewed patches have been landed. Closing bug. 97711 2011-06-18 17:28:42 -0700 2011-06-18 18:55:37 -0700 Patch and unit tests bug62941.patch text/plain 3441 dbates SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDg5MjA3KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMjAgQEAKKzIwMTEtMDYtMTggIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3ZWJraXQub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdpdC5wdXNo X2xvY2FsX2NvbW1pdHNfdG9fc2VydmVyIHNob3VsZCB1c2UgcGFzc3dvcmQgdXNlcm5hbWUgYW5k CisgICAgICAgIHBhc3N3b3JkIHdoZW4gd2UgZG9uJ3QgaGF2ZSBjYWNoZWQgY3JlZGVudGlhbHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyOTQxCisK KyAgICAgICAgRml4ZXMgYSBpc3N1ZSB3aGVyZSBHaXQucHVzaF9sb2NhbF9jb21taXRzX3RvX3Nl cnZlcigpIHdvdWxkIGFsd2F5cyBsb29rCisgICAgICAgIGZvciBjYWNoZWQgY3JlZGVudGlhbHMg cmVnYXJkbGVzcyBvZiB3aGV0aGVyIGEgdXNlcm5hbWUgYW5kIHBhc3N3b3JkCisgICAgICAgIHdl cmUgcGFzc2VkIGFzIGFyZ3VtZW50cy4gSW5zdGVhZCwgaWYgZ2l2ZW4gYm90aCBhIHVzZXJuYW1l IGFuZCBwYXNzd29yZAorICAgICAgICB0aGVuIHdlIHNob3VsZG4ndCBsb29rIGZvciBjYWNoZWQg Y3JlZGVudGlhbHMgKHNpbmNlIHdlIHdlcmUgZXhwbGljaXRseSBnaXZlbgorICAgICAgICBjcmVk ZW50aWFscykuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9z Y20vZ2l0LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3Nj bS9zY21fdW5pdHRlc3QucHk6IEFkZGVkIHVuaXQgdGVzdHMuCisKIDIwMTEtMDYtMTggIERpcmsg UHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVG9u eSBDaGFuZy4KSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3Nj bS9naXQucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hl Y2tvdXQvc2NtL2dpdC5weQkocmV2aXNpb24gODkyMDYpCisrKyBUb29scy9TY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9jaGVja291dC9zY20vZ2l0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC00MDAsNyAr NDAwLDcgQEAgY2xhc3MgR2l0KFNDTSwgU1ZOUmVwb3NpdG9yeSk6CiAgICAgICAgIGRjb21taXRf Y29tbWFuZCA9IFsnZ2l0JywgJ3N2bicsICdkY29tbWl0J10KICAgICAgICAgaWYgc2VsZi5kcnly dW46CiAgICAgICAgICAgICBkY29tbWl0X2NvbW1hbmQuYXBwZW5kKCctLWRyeS1ydW4nKQotICAg ICAgICBpZiBub3Qgc2VsZi5oYXNfYXV0aG9yaXphdGlvbl9mb3JfcmVhbG0oU1ZOLnN2bl9zZXJ2 ZXJfcmVhbG0pOgorICAgICAgICBpZiAobm90IHVzZXJuYW1lIG9yIG5vdCBwYXNzd29yZCkgYW5k IG5vdCBzZWxmLmhhc19hdXRob3JpemF0aW9uX2Zvcl9yZWFsbShTVk4uc3ZuX3NlcnZlcl9yZWFs bSk6CiAgICAgICAgICAgICByYWlzZSBBdXRoZW50aWNhdGlvbkVycm9yKFNWTi5zdm5fc2VydmVy X2hvc3QsIHByb21wdF9mb3JfcGFzc3dvcmQ9VHJ1ZSkKICAgICAgICAgaWYgdXNlcm5hbWU6CiAg ICAgICAgICAgICBkY29tbWl0X2NvbW1hbmQuZXh0ZW5kKFsiLS11c2VybmFtZSIsIHVzZXJuYW1l XSkKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS9zY21f dW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24v Y2hlY2tvdXQvc2NtL3NjbV91bml0dGVzdC5weQkocmV2aXNpb24gODkyMDYpCisrKyBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20vc2NtX3VuaXR0ZXN0LnB5CSh3b3Jr aW5nIGNvcHkpCkBAIC0xNDU4LDYgKzE0NTgsMTcgQEAgY2xhc3MgR2l0VGVzdFdpdGhNb2NrKHVu aXR0ZXN0LlRlc3RDYXNlKQogICAgICAgICBleHBlY3RlZF9zdGRlcnIgPSAiTU9DSyBydW5fY29t bWFuZDogWydnaXQnLCAnbWVyZ2UtYmFzZScsIHUncmVmcy9yZW1vdGVzL29yaWdpbi9tYXN0ZXIn LCAnSEVBRCddXG5NT0NLIHJ1bl9jb21tYW5kOiBbJ2dpdCcsICdkaWZmJywgJy0tYmluYXJ5Jywg Jy0tbm8tZXh0LWRpZmYnLCAnLS1mdWxsLWluZGV4JywgJy1NJywgJ01PQ0sgb3V0cHV0IG9mIGNo aWxkIHByb2Nlc3MnLCAnLS0nXVxuTU9DSyBydW5fY29tbWFuZDogWydnaXQnLCAnbG9nJywgJy0y NSddXG4iCiAgICAgICAgIE91dHB1dENhcHR1cmUoKS5hc3NlcnRfb3V0cHV0cyhzZWxmLCBzZWxm LnNjbS5jcmVhdGVfcGF0Y2gsIGt3YXJncz17J2NoYW5nZWRfZmlsZXMnOiBOb25lfSwgZXhwZWN0 ZWRfc3RkZXJyPWV4cGVjdGVkX3N0ZGVycikKIAorICAgIGRlZiB0ZXN0X3B1c2hfbG9jYWxfY29t bWl0c190b19zZXJ2ZXJfd2l0aF91c2VybmFtZV9hbmRfcGFzc3dvcmQoc2VsZik6CisgICAgICAg IHNlbGYuYXNzZXJ0RXF1YWxzKHNlbGYuc2NtLnB1c2hfbG9jYWxfY29tbWl0c190b19zZXJ2ZXIo dXNlcm5hbWU9J2RiYXRlc0B3ZWJraXQub3JnJywgcGFzc3dvcmQ9J2JsYWgnKSwgIk1PQ0sgb3V0 cHV0IG9mIGNoaWxkIHByb2Nlc3MiKQorCisgICAgZGVmIHRlc3RfcHVzaF9sb2NhbF9jb21taXRz X3RvX3NlcnZlcl93aXRob3V0X3VzZXJuYW1lX2FuZF9wYXNzd29yZChzZWxmKToKKyAgICAgICAg c2VsZi5hc3NlcnRSYWlzZXMoQXV0aGVudGljYXRpb25FcnJvciwgc2VsZi5zY20ucHVzaF9sb2Nh bF9jb21taXRzX3RvX3NlcnZlcikKKworICAgIGRlZiB0ZXN0X3B1c2hfbG9jYWxfY29tbWl0c190 b19zZXJ2ZXJfd2l0aF91c2VybmFtZV9hbmRfd2l0aG91dF9wYXNzd29yZChzZWxmKToKKyAgICAg ICAgc2VsZi5hc3NlcnRSYWlzZXMoQXV0aGVudGljYXRpb25FcnJvciwgc2VsZi5zY20ucHVzaF9s b2NhbF9jb21taXRzX3RvX3NlcnZlciwgeyd1c2VybmFtZSc6ICdkYmF0ZXNAd2Via2l0Lm9yZyd9 KQorCisgICAgZGVmIHRlc3RfcHVzaF9sb2NhbF9jb21taXRzX3RvX3NlcnZlcl93aXRob3V0X3Vz ZXJuYW1lX2FuZF93aXRoX3Bhc3N3b3JkKHNlbGYpOgorICAgICAgICBzZWxmLmFzc2VydFJhaXNl cyhBdXRoZW50aWNhdGlvbkVycm9yLCBzZWxmLnNjbS5wdXNoX2xvY2FsX2NvbW1pdHNfdG9fc2Vy dmVyLCB7J3Bhc3N3b3JkJzogJ2JsYWgnfSkKIAogaWYgX19uYW1lX18gPT0gJ19fbWFpbl9fJzoK ICAgICB1bml0dGVzdC5tYWluKCkK