62923 2011-06-17 18:45:23 -0700 getComputedStyle doesn't work for pseudo elements on load 2023-12-24 02:40:09 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED CONFIGURATION CHANGED P2 Normal --- 1 sam webkit-unassigned ahmad.saleem792 annevk dbates jberlin sam oldest_to_newest 423010 0 97679 sam 2011-06-17 18:45:23 -0700 Created attachment 97679 Test Case window.getComputedStyle() doesn't seem to work for pseudo elements until unload. It seems like the style is not available until it has been painted. Test case attached. 423011 1 sam 2011-06-17 18:48:03 -0700 This is probably what the comment in Element::computedStyle is referring to when it states: // FIXME: Find and use the renderer from the pseudo element instead of the actual element so that the 'length' // properties, which are only known by the renderer because it did the layout, will be correct and so that the // values returned for the ":selection" pseudo-element will be correct. 423012 2 97680 sam 2011-06-17 18:51:43 -0700 Created attachment 97680 [WIP] Patch This patch fixes the issue, but I am not sure it is the best the way to do it. I am also not certain what should be done about the case of the element not in the tree/with no renderer. 1925032 3 ahmad.saleem792 2023-01-12 04:51:11 -0800 With attached test case, I am getting this across all browsers (Safari Technology Preview 160, Chrome Canary 111 and Firefox Nightly 110): In Script: rgb(0, 0, 0) On Load: rgb(0, 0, 0) On 100ms Timeout: rgb(0, 0, 0) Button Clicked: rgb(0, 0, 0) Is this still an issue? Thanks! 2001792 4 annevk 2023-12-24 02:40:09 -0800 Seems like this was resolved indeed. The FIXME is also no longer present. 97679 2011-06-17 18:45:23 -0700 2011-06-17 18:45:23 -0700 Test Case test.html text/html 1101 sam PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KCjxzdHlsZT4KICAgIGlucHV0Ojotd2Via2l0 LWlucHV0LXBsYWNlaG9sZGVyIHsKICAgICAgICBjb2xvcjogZ3JlZW47CiAgICB9Cjwvc3R5bGU+ Cgo8cHJlIGlkPSJjb25zb2xlIj48L3ByZT4KCjxpbnB1dCBpZD0iaW5wdXQiIHR5cGU9InRleHQi IHBsYWNlaG9sZGVyPSJQbGFjZWhvbGRlciI+CjxidXR0b24gb25jbGljaz0iZ28oKTsiPkNsaWNr PC9idXR0b24+Cgo8c2NyaXB0PgogICAgZnVuY3Rpb24gbG9nKG1zZykKICAgIHsKICAgICAgICBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29uc29sZSIpLmFwcGVuZENoaWxkKGRvY3VtZW50LmNy ZWF0ZVRleHROb2RlKG1zZyArICJcbiIpKTsKICAgIH0KCiAgICBmdW5jdGlvbiBnbygpCiAgICB7 CiAgICAgICAgbG9nKCJCdXR0b24gQ2xpY2tlZDogIiArIHdpbmRvdy5nZXRDb21wdXRlZFN0eWxl KGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdpbnB1dCcpLCAnLXdlYmtpdC1pbnB1dC1wbGFjZWhv bGRlcicpLmdldFByb3BlcnR5VmFsdWUoJ2NvbG9yJykpOwogICAgfQoKICAgIHdpbmRvdy5vbmxv YWQgPSBmdW5jdGlvbigpCiAgICB7CiAgICAgICAgbG9nKCJPbiBMb2FkOiAiICsgd2luZG93Lmdl dENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2lucHV0JyksICctd2Via2l0 LWlucHV0LXBsYWNlaG9sZGVyJykuZ2V0UHJvcGVydHlWYWx1ZSgnY29sb3InKSk7CiAgICB9Cgog ICAgd2luZG93LnNldFRpbWVvdXQoZnVuY3Rpb24oKQogICAgewogICAgICAgIGxvZygiT24gMTAw bXMgVGltZW91dDogIiArIHdpbmRvdy5nZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCdpbnB1dCcpLCAnLXdlYmtpdC1pbnB1dC1wbGFjZWhvbGRlcicpLmdldFByb3BlcnR5 VmFsdWUoJ2NvbG9yJykpOwogICAgfSwgMTAwKTsKCiAgICBsb2coIkluIFNjcmlwdDogIiArIHdp bmRvdy5nZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdpbnB1dCcpLCAn LXdlYmtpdC1pbnB1dC1wbGFjZWhvbGRlcicpLmdldFByb3BlcnR5VmFsdWUoJ2NvbG9yJykpOwoK PC9zY3JpcHQ+CjwvaHRtbD4K 97680 2011-06-17 18:51:43 -0700 2011-06-17 18:56:10 -0700 [WIP] Patch wip.diff text/plain 1526 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAJKHJldmlzaW9uIDg5MTc2KQorKysgU291cmNlL1dl YkNvcmUvZG9tL0VsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjgxLDE2ICsxNjgxLDIx IEBAIHZvaWQgRWxlbWVudDo6c2V0TWluaW11bVNpemVGb3JSZXNpemluZygKIAogUmVuZGVyU3R5 bGUqIEVsZW1lbnQ6OmNvbXB1dGVkU3R5bGUoUHNldWRvSWQgcHNldWRvRWxlbWVudFNwZWNpZmll cikKIHsKLSAgICAvLyBGSVhNRTogRmluZCBhbmQgdXNlIHRoZSByZW5kZXJlciBmcm9tIHRoZSBw c2V1ZG8gZWxlbWVudCBpbnN0ZWFkIG9mIHRoZSBhY3R1YWwgZWxlbWVudCBzbyB0aGF0IHRoZSAn bGVuZ3RoJwotICAgIC8vIHByb3BlcnRpZXMsIHdoaWNoIGFyZSBvbmx5IGtub3duIGJ5IHRoZSBy ZW5kZXJlciBiZWNhdXNlIGl0IGRpZCB0aGUgbGF5b3V0LCB3aWxsIGJlIGNvcnJlY3QgYW5kIHNv IHRoYXQgdGhlCi0gICAgLy8gdmFsdWVzIHJldHVybmVkIGZvciB0aGUgIjpzZWxlY3Rpb24iIHBz ZXVkby1lbGVtZW50IHdpbGwgYmUgY29ycmVjdC4KLSAgICBpZiAoUmVuZGVyU3R5bGUqIHVzZWRT dHlsZSA9IHJlbmRlclN0eWxlKCkpCi0gICAgICAgIHJldHVybiBwc2V1ZG9FbGVtZW50U3BlY2lm aWVyID8gdXNlZFN0eWxlLT5nZXRDYWNoZWRQc2V1ZG9TdHlsZShwc2V1ZG9FbGVtZW50U3BlY2lm aWVyKSA6IHVzZWRTdHlsZTsKKyAgICBpZiAoIXBzZXVkb0VsZW1lbnRTcGVjaWZpZXIpIHsKKyAg ICAgICAgaWYgKFJlbmRlclN0eWxlKiB1c2VkU3R5bGUgPSByZW5kZXJTdHlsZSgpKQorICAgICAg ICAgICAgcmV0dXJuIHVzZWRTdHlsZTsKKyAgICB9IGVsc2UgeworICAgICAgICBpZiAoUmVuZGVy T2JqZWN0KiByZW5kZXJlciA9IHRoaXMtPnJlbmRlcmVyKCkpIHsKKyAgICAgICAgICAgIGlmIChS ZW5kZXJTdHlsZSogdXNlZFN0eWxlID0gcmVuZGVyZXItPmdldENhY2hlZFBzZXVkb1N0eWxlKHBz ZXVkb0VsZW1lbnRTcGVjaWZpZXIpKQorICAgICAgICAgICAgICAgIHJldHVybiB1c2VkU3R5bGU7 CisgICAgICAgIH0KKyAgICB9CiAKLSAgICBpZiAoIWF0dGFjaGVkKCkpCisgICAgaWYgKCFhdHRh Y2hlZCgpKSB7CiAgICAgICAgIC8vIEZJWE1FOiBUcnkgdG8gZG8gYmV0dGVyIHRoYW4gdGhpcy4g RW5zdXJlIHRoYXQgc3R5bGVGb3JFbGVtZW50KCkgd29ya3MgZm9yIGVsZW1lbnRzIHRoYXQgYXJl IG5vdCBpbiB0aGUKICAgICAgICAgLy8gZG9jdW1lbnQgdHJlZSBhbmQgZmlndXJlIG91dCB3aGVu IHRvIGRlc3Ryb3kgdGhlIGNvbXB1dGVkIHN0eWxlIGZvciBzdWNoIGVsZW1lbnRzLgogICAgICAg ICByZXR1cm4gMDsKKyAgICB9CiAKICAgICBFbGVtZW50UmFyZURhdGEqIGRhdGEgPSBlbnN1cmVS YXJlRGF0YSgpOwogICAgIGlmICghZGF0YS0+bV9jb21wdXRlZFN0eWxlKQo=