62917 2011-06-17 17:19:01 -0700 KURL::protocolIs() triggers an assert when the protocol contains a character that is not an ASCII letter. 2011-06-20 13:08:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 61572 P2 Normal --- 1 aestes aestes ddkilzer oldest_to_newest 422965 0 aestes 2011-06-17 17:19:01 -0700 KURL::protocolIs() triggers an assert when the protocol contains a character that is not an ASCII letter. 422970 1 97670 aestes 2011-06-17 17:23:05 -0700 Created attachment 97670 Patch 422981 2 aestes 2011-06-17 17:32:30 -0700 *** This bug has been marked as a duplicate of bug 61572 *** 422983 3 97670 aestes 2011-06-17 17:34:04 -0700 Comment on attachment 97670 Patch I'm going to update this based on comments in https://bugs.webkit.org/show_bug.cgi?id=61572 422985 4 97670 darin 2011-06-17 17:35:09 -0700 Comment on attachment 97670 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97670&action=review > Source/WebCore/platform/KURL.cpp:705 > - if (!protocol[i] || !isLetterMatchIgnoringCase(m_string[i], protocol[i])) > + if (!protocol[i] || toASCIILower(m_string[i]) != protocol[i]) Need to assert that protocol[i] is not an uppercase letter. Also ought to assert that protocol[i] is not a colon character. Maybe assert that it's a legal protocol character. The old function was faster. At the time I wrote it I was super-obsessed with being as optimized as possible. Could still use that old algorithm when the string is all letters. 97670 2011-06-17 17:23:05 -0700 2011-06-17 17:35:09 -0700 Patch bug-62917-20110617172304.patch text/plain 1680 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogODkxNzgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhZDc4MWEwMDVkOWYyYmQ0 YTc2MWNkNjQwN2E2N2ZlOTljOTU2M2VlLi42YjAzN2RjMjlkNmE3OTI2MGI3NjI4YmQzNWViNzc1 MzNiNGRhYmYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDYtMTcgIEFuZHkg RXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEtVUkw6OnByb3RvY29sSXMoKSB0cmlnZ2VycyBhbiBhc3NlcnQg d2hlbiB0aGUgcHJvdG9jb2wgY29udGFpbnMgYQorICAgICAgICBjaGFyYWN0ZXIgdGhhdCBpcyBu b3QgYW4gQVNDSUkgbGV0dGVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NjI5MTcKKworICAgICAgICBObyBuZXcgdGVzdHMuIE5vIGNvZGUgY3VycmVu dGx5IGNhbGxzIHByb3RvY29sSXMoKSB3aXRoIGEgcHJvdG9jb2wgdGhhdAorICAgICAgICBjb250 YWlucyBhIG5vbi1sZXR0ZXIgY2hhcmFjdGVyLgorCisgICAgICAgICogcGxhdGZvcm0vS1VSTC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpLVVJMOjpwcm90b2NvbElzKTogQ2FsbCB0b0FTQ0lJTG93 ZXIoKSwgd2hpY2ggdG9sZXJhdGVzCisgICAgICAgIG5vbi1sZXR0ZXIgY2hhcmFjdGVycyBhcyBv cHBvc2VkIHRvIGlzTGV0dGVyTWF0Y2hJZ25vcmluZ0Nhc2UoKSwgd2hpY2gKKyAgICAgICAgZG9l cyBub3QuCisKIDIwMTEtMDYtMTcgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21h aWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI4OTE0My4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0tVUkwuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vS1VSTC5jcHAKaW5kZXggODYxMWVkMTg5OWQwMTYyMWMwZWRjNDJiYjlkZDE2MzA5 ZmFlMDRmZi4uMjM4MDY2NjNiN2U4MDQ5NjYxMjg1MjFjZTEzY2NjMDQ3YjA5ODYwYyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vS1VSTC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vS1VSTC5jcHAKQEAgLTcwMiw3ICs3MDIsNyBAQCBib29sIEtVUkw6OnByb3Rv Y29sSXMoY29uc3QgY2hhciogcHJvdG9jb2wpIGNvbnN0CiAKICAgICAvLyBEbyB0aGUgY29tcGFy aXNvbiB3aXRob3V0IG1ha2luZyBhIG5ldyBzdHJpbmcgb2JqZWN0LgogICAgIGZvciAoaW50IGkg PSAwOyBpIDwgbV9zY2hlbWVFbmQ7ICsraSkgewotICAgICAgICBpZiAoIXByb3RvY29sW2ldIHx8 ICFpc0xldHRlck1hdGNoSWdub3JpbmdDYXNlKG1fc3RyaW5nW2ldLCBwcm90b2NvbFtpXSkpCisg ICAgICAgIGlmICghcHJvdG9jb2xbaV0gfHwgdG9BU0NJSUxvd2VyKG1fc3RyaW5nW2ldKSAhPSBw cm90b2NvbFtpXSkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAgICAgcmV0dXJu ICFwcm90b2NvbFttX3NjaGVtZUVuZF07IC8vIFdlIHNob3VsZCBoYXZlIGNvbnN1bWVkIGFsbCBj aGFyYWN0ZXJzIGluIHRoZSBhcmd1bWVudC4K