62913 2011-06-17 15:44:19 -0700 Use ICU search collator when available 2011-07-20 13:52:19 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap darin jshin mitz webkit.review.bot oldest_to_newest 422922 0 ap 2011-06-17 15:44:19 -0700 New versions of ICU provide a collator that's specifically made for searching, and respects searching rules. We should be using it. <rdar://problem/8830218> <rdar://problem/8468873> 422927 1 97662 ap 2011-06-17 15:49:10 -0700 Created attachment 97662 proposed patch I do not know everything that's going to change; hoping for a silver bullet solution for all search problems. 422932 2 webkit.review.bot 2011-06-17 15:51:58 -0700 Attachment 97662 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 422935 3 97664 ap 2011-06-17 15:58:06 -0700 Created attachment 97664 patch for landing 422936 4 mitz 2011-06-17 16:02:08 -0700 Do I need to do anything with the newer patch? 422944 5 ap 2011-06-17 16:18:51 -0700 Sorry, I meant to cq+ it. 422958 6 97664 webkit.review.bot 2011-06-17 16:58:35 -0700 Comment on attachment 97664 patch for landing Rejecting attachment 97664 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2 Last 500 characters of output: clude/core/SkScalar.h U /mnt/git/webkit-commit-queue/Source/WebKit/chromium/third_party/skia/include/core/SkBlitter.h U /mnt/git/webkit-commit-queue/Source/WebKit/chromium/third_party/skia/include/core/SkPoint.h U /mnt/git/webkit-commit-queue/Source/WebKit/chromium/third_party/skia/include/views/SkOSWindow_Android.h Updated to revision 1613. ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/8880739 422962 7 97668 ap 2011-06-17 17:14:11 -0700 Created attachment 97668 actually truly no tabs 422990 8 97668 webkit.review.bot 2011-06-17 17:43:27 -0700 Comment on attachment 97668 actually truly no tabs Clearing flags on attachment: 97668 Committed r89181: <http://trac.webkit.org/changeset/89181> 422991 9 webkit.review.bot 2011-06-17 17:43:32 -0700 All reviewed patches have been landed. Closing bug. 439921 10 jshin 2011-07-20 12:15:49 -0700 Argh. This broke Korean search completely with ICU 4.6 (with CLDR 1.9.x) that has a search collator for Korean. (http://crbug.com/88434 ). 439957 11 ap 2011-07-20 13:14:55 -0700 Could you please file a new bug report with detailed steps to reproduce? I tried, but couldn't reproduce on Lion (which has ICU 4.6). 439995 12 jshin 2011-07-20 13:52:19 -0700 I've just filed bug 64892. Could you try to reproduce with Safari on Lion? 97662 2011-06-17 15:49:10 -0700 2011-06-17 15:58:06 -0700 proposed patch SearchCollator.txt text/plain 1807 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5MTc3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDYtMTcgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTYyOTEzCisgICAgICAgIFVzZSBJQ1Ugc2VhcmNoIGNvbGxhdG9yIHdoZW4gYXZhaWxhYmxl CisKKwkJPHJkYXI6Ly9wcm9ibGVtLzg4MzAyMTg+IFNlYXJjaCBvbiBhIHdlYnBhZ2UgaW4gU2Fm YXJpIGNvbmZsYXRlcyBzb21lIEN6ZWNoIGNoYXJhY3RlcnMKKwkJPHJkYXI6Ly9wcm9ibGVtLzg0 Njg4NzM+IFNhZmFyaSBzZWFyY2ggZG9lc24ndCBzdHJpcCBIYW16YQorCisgICAgICAgIFRoaXMg Y2hhbmdlcyBiZWhhdmlvcnMgdGhhdCBkZXBlbmQgb24gc3lzdGVtIGxhbmd1YWdlLCBhbmQgaXNu J3QgcHJhY3RpY2FsbHkgdGVzdGFibGUuCisKKyAgICAgICAgKiBlZGl0aW5nL1RleHRJdGVyYXRv ci5jcHA6IChXZWJDb3JlOjpjcmVhdGVTZWFyY2hlcik6IEFzayBJQ1UgZm9yIHNlYXJjaCBjb2xs YXRvciwgaWYgYXZhaWxhYmxlLgorCiAyMDExLTA2LTE3ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVA YXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYSBDaGFuLgpJbmRleDogU291cmNl L1dlYkNvcmUvZWRpdGluZy9UZXh0SXRlcmF0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL2VkaXRpbmcvVGV4dEl0ZXJhdG9yLmNwcAkocmV2aXNpb24gODkxNzEpCisrKyBTb3Vy Y2UvV2ViQ29yZS9lZGl0aW5nL1RleHRJdGVyYXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE1 ODYsNyArMTU4Niw4IEBAIHN0YXRpYyBVU3RyaW5nU2VhcmNoKiBjcmVhdGVTZWFyY2hlcigpCiAg ICAgLy8gYnV0IGl0IGRvZXNuJ3QgbWF0dGVyIGV4YWN0bHkgd2hhdCBpdCBpcywgc2luY2Ugd2Ug ZG9uJ3QgcGVyZm9ybSBhbnkgc2VhcmNoZXMKICAgICAvLyB3aXRob3V0IHNldHRpbmcgYm90aCB0 aGUgcGF0dGVybiBhbmQgdGhlIHRleHQuCiAgICAgVUVycm9yQ29kZSBzdGF0dXMgPSBVX1pFUk9f RVJST1I7Ci0gICAgVVN0cmluZ1NlYXJjaCogc2VhcmNoZXIgPSB1c2VhcmNoX29wZW4oJm5ld2xp bmVDaGFyYWN0ZXIsIDEsICZuZXdsaW5lQ2hhcmFjdGVyLCAxLCBjdXJyZW50U2VhcmNoTG9jYWxl SUQoKSwgMCwgJnN0YXR1cyk7CisgICAgU3RyaW5nIHNlYXJjaENvbGxhdG9yTmFtZSA9IG1ha2VT dHJpbmcoY3VycmVudFNlYXJjaExvY2FsZUlEKCksICJAY29sbGF0aW9uPXNlYXJjaCIpOworICAg IFVTdHJpbmdTZWFyY2gqIHNlYXJjaGVyID0gdXNlYXJjaF9vcGVuKCZuZXdsaW5lQ2hhcmFjdGVy LCAxLCAmbmV3bGluZUNoYXJhY3RlciwgMSwgc2VhcmNoQ29sbGF0b3JOYW1lLnV0ZjgoKS5kYXRh KCksIDAsICZzdGF0dXMpOwogICAgIEFTU0VSVChzdGF0dXMgPT0gVV9aRVJPX0VSUk9SIHx8IHN0 YXR1cyA9PSBVX1VTSU5HX0ZBTExCQUNLX1dBUk5JTkcgfHwgc3RhdHVzID09IFVfVVNJTkdfREVG QVVMVF9XQVJOSU5HKTsKICAgICByZXR1cm4gc2VhcmNoZXI7CiB9Cg== 97664 2011-06-17 15:58:06 -0700 2011-06-17 17:14:11 -0700 patch for landing SearchCollator.txt text/plain 1806 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5MTc3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDYtMTcgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJl cm5zdGVpbi4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjI5MTMKKyAgICAgICAgVXNlIElDVSBzZWFyY2ggY29sbGF0b3Igd2hlbiBhdmFpbGFibGUK KworCQk8cmRhcjovL3Byb2JsZW0vODgzMDIxOD4gU2VhcmNoIG9uIGEgd2VicGFnZSBpbiBTYWZh cmkgY29uZmxhdGVzIHNvbWUgQ3plY2ggY2hhcmFjdGVycworCQk8cmRhcjovL3Byb2JsZW0vODQ2 ODg3Mz4gU2FmYXJpIHNlYXJjaCBkb2Vzbid0IHN0cmlwIEhhbXphCisKKyAgICAgICAgVGhpcyBj aGFuZ2VzIGJlaGF2aW9ycyB0aGF0IGRlcGVuZCBvbiBzeXN0ZW0gbGFuZ3VhZ2UsIGFuZCBpc24n dCBwcmFjdGljYWxseSB0ZXN0YWJsZS4KKworICAgICAgICAqIGVkaXRpbmcvVGV4dEl0ZXJhdG9y LmNwcDogKFdlYkNvcmU6OmNyZWF0ZVNlYXJjaGVyKTogQXNrIElDVSBmb3Igc2VhcmNoIGNvbGxh dG9yLCBpZiBhdmFpbGFibGUuCisKIDIwMTEtMDYtMTcgIEplciBOb2JsZSAgPGplci5ub2JsZUBh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhIENoYW4uCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9lZGl0aW5nL1RleHRJdGVyYXRvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvZWRpdGluZy9UZXh0SXRlcmF0b3IuY3BwCShyZXZpc2lvbiA4OTE3MSkKKysrIFNvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvVGV4dEl0ZXJhdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU4 Niw3ICsxNTg2LDggQEAgc3RhdGljIFVTdHJpbmdTZWFyY2gqIGNyZWF0ZVNlYXJjaGVyKCkKICAg ICAvLyBidXQgaXQgZG9lc24ndCBtYXR0ZXIgZXhhY3RseSB3aGF0IGl0IGlzLCBzaW5jZSB3ZSBk b24ndCBwZXJmb3JtIGFueSBzZWFyY2hlcwogICAgIC8vIHdpdGhvdXQgc2V0dGluZyBib3RoIHRo ZSBwYXR0ZXJuIGFuZCB0aGUgdGV4dC4KICAgICBVRXJyb3JDb2RlIHN0YXR1cyA9IFVfWkVST19F UlJPUjsKLSAgICBVU3RyaW5nU2VhcmNoKiBzZWFyY2hlciA9IHVzZWFyY2hfb3BlbigmbmV3bGlu ZUNoYXJhY3RlciwgMSwgJm5ld2xpbmVDaGFyYWN0ZXIsIDEsIGN1cnJlbnRTZWFyY2hMb2NhbGVJ RCgpLCAwLCAmc3RhdHVzKTsKKyAgICBTdHJpbmcgc2VhcmNoQ29sbGF0b3JOYW1lID0gbWFrZVN0 cmluZyhjdXJyZW50U2VhcmNoTG9jYWxlSUQoKSwgIkBjb2xsYXRpb249c2VhcmNoIik7CisgICAg VVN0cmluZ1NlYXJjaCogc2VhcmNoZXIgPSB1c2VhcmNoX29wZW4oJm5ld2xpbmVDaGFyYWN0ZXIs IDEsICZuZXdsaW5lQ2hhcmFjdGVyLCAxLCBzZWFyY2hDb2xsYXRvck5hbWUudXRmOCgpLmRhdGEo KSwgMCwgJnN0YXR1cyk7CiAgICAgQVNTRVJUKHN0YXR1cyA9PSBVX1pFUk9fRVJST1IgfHwgc3Rh dHVzID09IFVfVVNJTkdfRkFMTEJBQ0tfV0FSTklORyB8fCBzdGF0dXMgPT0gVV9VU0lOR19ERUZB VUxUX1dBUk5JTkcpOwogICAgIHJldHVybiBzZWFyY2hlcjsKIH0K 97668 2011-06-17 17:14:11 -0700 2011-06-17 17:43:27 -0700 actually truly no tabs SearchCollator.txt text/plain 1818 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5MTc3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDYtMTcgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJl cm5zdGVpbi4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NjI5MTMKKyAgICAgICAgVXNlIElDVSBzZWFyY2ggY29sbGF0b3Igd2hlbiBhdmFpbGFibGUK KworICAgICAgICA8cmRhcjovL3Byb2JsZW0vODgzMDIxOD4gU2VhcmNoIG9uIGEgd2VicGFnZSBp biBTYWZhcmkgY29uZmxhdGVzIHNvbWUgQ3plY2ggY2hhcmFjdGVycworICAgICAgICA8cmRhcjov L3Byb2JsZW0vODQ2ODg3Mz4gU2FmYXJpIHNlYXJjaCBkb2Vzbid0IHN0cmlwIEhhbXphCisKKyAg ICAgICAgVGhpcyBjaGFuZ2VzIGJlaGF2aW9ycyB0aGF0IGRlcGVuZCBvbiBzeXN0ZW0gbGFuZ3Vh Z2UsIGFuZCBpc24ndCBwcmFjdGljYWxseSB0ZXN0YWJsZS4KKworICAgICAgICAqIGVkaXRpbmcv VGV4dEl0ZXJhdG9yLmNwcDogKFdlYkNvcmU6OmNyZWF0ZVNlYXJjaGVyKTogQXNrIElDVSBmb3Ig c2VhcmNoIGNvbGxhdG9yLCBpZiBhdmFpbGFibGUuCisKIDIwMTEtMDYtMTcgIEplciBOb2JsZSAg PGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhIENoYW4uCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1RleHRJdGVyYXRvci5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvZWRpdGluZy9UZXh0SXRlcmF0b3IuY3BwCShyZXZpc2lvbiA4OTE3 MSkKKysrIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVGV4dEl0ZXJhdG9yLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTU4Niw3ICsxNTg2LDggQEAgc3RhdGljIFVTdHJpbmdTZWFyY2gqIGNyZWF0ZVNl YXJjaGVyKCkKICAgICAvLyBidXQgaXQgZG9lc24ndCBtYXR0ZXIgZXhhY3RseSB3aGF0IGl0IGlz LCBzaW5jZSB3ZSBkb24ndCBwZXJmb3JtIGFueSBzZWFyY2hlcwogICAgIC8vIHdpdGhvdXQgc2V0 dGluZyBib3RoIHRoZSBwYXR0ZXJuIGFuZCB0aGUgdGV4dC4KICAgICBVRXJyb3JDb2RlIHN0YXR1 cyA9IFVfWkVST19FUlJPUjsKLSAgICBVU3RyaW5nU2VhcmNoKiBzZWFyY2hlciA9IHVzZWFyY2hf b3BlbigmbmV3bGluZUNoYXJhY3RlciwgMSwgJm5ld2xpbmVDaGFyYWN0ZXIsIDEsIGN1cnJlbnRT ZWFyY2hMb2NhbGVJRCgpLCAwLCAmc3RhdHVzKTsKKyAgICBTdHJpbmcgc2VhcmNoQ29sbGF0b3JO YW1lID0gbWFrZVN0cmluZyhjdXJyZW50U2VhcmNoTG9jYWxlSUQoKSwgIkBjb2xsYXRpb249c2Vh cmNoIik7CisgICAgVVN0cmluZ1NlYXJjaCogc2VhcmNoZXIgPSB1c2VhcmNoX29wZW4oJm5ld2xp bmVDaGFyYWN0ZXIsIDEsICZuZXdsaW5lQ2hhcmFjdGVyLCAxLCBzZWFyY2hDb2xsYXRvck5hbWUu dXRmOCgpLmRhdGEoKSwgMCwgJnN0YXR1cyk7CiAgICAgQVNTRVJUKHN0YXR1cyA9PSBVX1pFUk9f RVJST1IgfHwgc3RhdHVzID09IFVfVVNJTkdfRkFMTEJBQ0tfV0FSTklORyB8fCBzdGF0dXMgPT0g VV9VU0lOR19ERUZBVUxUX1dBUk5JTkcpOwogICAgIHJldHVybiBzZWFyY2hlcjsKIH0K