62907 2011-06-17 13:54:35 -0700 [chromium] force rebaseline-chromium-webkit-tests to use the chromium port 2011-06-17 14:48:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony tony dpranke webkit.review.bot oldest_to_newest 422865 0 tony 2011-06-17 13:54:35 -0700 [chromium] force rebaseline-chromium-webkit-tests to use the chromium port 422866 1 97649 tony 2011-06-17 13:56:27 -0700 Created attachment 97649 Patch 422867 2 97649 dpranke 2011-06-17 13:58:48 -0700 Comment on attachment 97649 Patch This is fine. See the email I just sent you, though, I don't think this explains rniwa's problem (it might fix it, but there's probably another bug in here somewhere). Ideally we'd find whatever ImageDiff was built, but that can certainly be a separate patch. 422869 3 tony 2011-06-17 14:02:28 -0700 See the ChangeLog description. Even with a tolerance of 0, it doesn't do an exact pixel match. Here's the code in question: http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/cg/ImageDiffCG.cpp#L118 It calculates a distance and if the distance is small enough, it considers the pixels the same. 422872 4 tony 2011-06-17 14:02:59 -0700 *** Bug 61833 has been marked as a duplicate of this bug. *** 422875 5 dpranke 2011-06-17 14:06:54 -0700 Wow, that just seems like a bug. It seems like --tolerance=0 should mean "exact match". 422897 6 97649 webkit.review.bot 2011-06-17 14:48:25 -0700 Comment on attachment 97649 Patch Clearing flags on attachment: 97649 Committed r89174: <http://trac.webkit.org/changeset/89174> 422898 7 webkit.review.bot 2011-06-17 14:48:31 -0700 All reviewed patches have been landed. Closing bug. 97649 2011-06-17 13:56:27 -0700 2011-06-17 14:48:25 -0700 Patch bug-62907-20110617135626.patch text/plain 2254 tony U3VidmVyc2lvbiBSZXZpc2lvbjogODkxNTAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxY2Q1MWU5YjFlNzUwZjA4OWQ0NmU0MDFjNWNkMTVlMjMy NzQ3YmQzLi5kYWRmOTRjZDU1ODE3ZjUyODQ2YzZjZjNhYjc3MTI5ZWY2NDMzNmZlIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDYtMTcgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIGZvcmNl IHJlYmFzZWxpbmUtY2hyb21pdW0td2Via2l0LXRlc3RzIHRvIHVzZSB0aGUgY2hyb21pdW0gcG9y dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjI5MDcK KworICAgICAgICBUaGlzIGZpeGVzIGEgYnVnIHdoZXJlIHRoZSBJbWFnZURpZmYgb24gdGhlIHVz ZXIncyBtYWNoaW5lIGRvZXNuJ3QKKyAgICAgICAgbWF0Y2ggdGhlIGxvZ2ljIHVzZWQgb24gdGhl IENocm9taXVtIGJ1aWxkYm90cy4gIFRoaXMgaGFzIHRoZSBkb3duc2lkZQorICAgICAgICBvZiBy ZXF1aXJpbmcgdGhhdCB0aGUgQ2hyb21pdW0gSW1hZ2VEaWZmIGlzIGJ1aWx0LCBidXQgaXQgdHVy bnMgb3V0CisgICAgICAgIHRoYXQgZXZlbiB3aXRoIC0tdG9sZXJhbmNlIDAsIHRoZSBDRyBJbWFn ZURpZmYgd2lsbCBhbGxvdyBzbWFsbCBwaXhlbAorICAgICAgICBkaWZmZXJlbmNlcyB0aHJvdWdo LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcmViYXNlbGluZV9j aHJvbWl1bV93ZWJraXRfdGVzdHMucHk6CisKIDIwMTEtMDUtMjUgIEJyZW50IEZ1bGdoYW0gIDxi ZnVsZ2hhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEJyaWFuIFdlaW5zdGVp bi4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3JlYmFz ZWxpbmVfY2hyb21pdW1fd2Via2l0X3Rlc3RzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcmViYXNlbGluZV9jaHJvbWl1bV93ZWJraXRfdGVzdHMucHkKaW5kZXggMWUy YTVhZjE2NGZiNzQxNjJlZjE5ZjNiNzM0MmM4ZTIwYTIzZDlmMC4uMWYyNWY4ZDcxZTM4NGJmYjBi ZGJhZWNlNmFhZjgyZTI1ODgzMzM3OCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcmViYXNlbGluZV9jaHJvbWl1bV93ZWJraXRfdGVzdHMucHkKKysrIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcmViYXNlbGluZV9jaHJvbWl1bV93 ZWJraXRfdGVzdHMucHkKQEAgLTgwNSwxMSArODA1LDExIEBAIGNsYXNzIEh0bWxHZW5lcmF0b3Io b2JqZWN0KToKIAogZGVmIGdldF9ob3N0X3BvcnRfb2JqZWN0KG9wdGlvbnMpOgogICAgICIiIlJl dHVybiBhIHBvcnQgb2JqZWN0IGZvciB0aGUgcGxhdGZvcm0gd2UncmUgcnVubmluZyBvbi4iIiIK LSAgICAjIFRoZSBvbmx5IHRoaW5nIHdlIHJlYWxseSBuZWVkIG9uIHRoZSBob3N0IGlzIGEgd2F5 IHRvIGRpZmYKLSAgICAjIHRleHQgZmlsZXMgYW5kIGltYWdlIGZpbGVzLCB3aGljaCBtZWFucyB3 ZSBuZWVkIHRvIGNoZWNrIHRoYXQgc29tZQotICAgICMgdmVyc2lvbiBvZiBJbWFnZURpZmYgaGFz IGJlZW4gYnVpbHQuIFdlIHdpbGwgbG9vayBmb3IgZWl0aGVyIERlYnVnCi0gICAgIyBvciBSZWxl YXNlIHZlcnNpb25zIG9mIHRoZSBkZWZhdWx0IHBvcnQgb24gdGhlIHBsYXRmb3JtLgorICAgICMg V2Ugd2FudCB0aGUgSW1hZ2VEaWZmIGxvZ2ljIHRvIG1hdGNoIHRoYXQgb2YgdGhlIGNocm9taXVt IGJvdHMsIHNvIHdlCisgICAgIyBmb3JjZSB0aGUgdXNlIG9mIGEgQ2hyb21pdW0gcG9ydC4gIFdl IHdpbGwgbG9vayBmb3IgZWl0aGVyIERlYnVnIG9yCisgICAgIyBSZWxlYXNlIHZlcnNpb25zLgog ICAgIG9wdGlvbnMuY29uZmlndXJhdGlvbiA9ICJSZWxlYXNlIgorICAgIG9wdGlvbnMuY2hyb21p dW0gPSBUcnVlCiAgICAgcG9ydF9vYmogPSBwb3J0LmdldChOb25lLCBvcHRpb25zKQogICAgIGlm IG5vdCBwb3J0X29iai5jaGVja19pbWFnZV9kaWZmKG92ZXJyaWRlX3N0ZXA9Tm9uZSwgbG9nZ2lu Zz1GYWxzZSk6CiAgICAgICAgIF9sb2cuZGVidWcoJ05vIHJlbGVhc2UgdmVyc2lvbiBvZiB0aGUg aW1hZ2UgZGlmZiBiaW5hcnkgd2FzIGZvdW5kLicpCg==