62901 2011-06-17 12:45:44 -0700 Playing video from the manifest crashes on Windows 2011-06-21 12:54:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble adachan oldest_to_newest 422831 0 jer.noble 2011-06-17 12:45:44 -0700 Playing video from the manifest crashes on Windows 422837 1 97639 jer.noble 2011-06-17 12:57:09 -0700 Created attachment 97639 Patch 422839 2 jer.noble 2011-06-17 12:57:27 -0700 <rdar://problem/9631240> 422846 3 adachan 2011-06-17 13:04:46 -0700 One thing I overlooked: in the method above, QTMovie::loadPath(), should we null check cfURL and urlStringRef before releasing also? Can use RetainPtr also. 422851 4 97639 darin 2011-06-17 13:16:17 -0700 Comment on attachment 97639 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97639&action=review > Source/WebCore/html/HTMLMediaElement.cpp:694 > +#if USE(CF) && PLATFORM(WIN) > + RetainPtr<CFStringRef> cfPath(AdoptCF, path.createCFString()); > + RetainPtr<CFURLRef> cfURL(AdoptCF, CFURLCreateWithFileSystemPath(0, cfPath.get(), kCFURLWindowsPathStyle, false)); > + KURL url(cfURL.get()); > +#else > KURL url; > > url.setProtocol("file"); > url.setPath(path); > +#endif This is probably the best short term fix. But longer term we would like a helper function that does this. 422870 5 jer.noble 2011-06-17 14:02:32 -0700 (In reply to comment #3) > One thing I overlooked: in the method above, QTMovie::loadPath(), should we null check cfURL and urlStringRef before releasing also? Yes, we should. This patch adds null-checks there as well. > Can use RetainPtr also. Unfortunately, we can't use RetainPtr from within the QTMovie subproject. This is because of the (ridiculous) way QuickTime includes work; they have their own versions of CF headers which conflict with the AAS versions. 422884 6 jer.noble 2011-06-17 14:23:01 -0700 Committed r89172: <http://trac.webkit.org/changeset/89172> 424665 7 98041 jer.noble 2011-06-21 12:24:38 -0700 Created attachment 98041 Patch 97639 2011-06-17 12:57:09 -0700 2011-06-21 12:24:35 -0700 Patch bug-62901-20110617125707.patch text/plain 3114 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogODkwNjAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3YmNhOGNkY2QxYTFiNzFk YmExMWZhZDEyZmM3YjczOTJmMTQzMGUxLi4wN2VkMzMwZDdmYTA0ZGU3MmM1MGRkNWYwZjE1YzA3 NjA2MTc2MTcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDYtMTcgIEplciBO b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUGxheWluZyB2aWRlbyBmcm9tIHRoZSBtYW5pZmVzdCBjcmFz aGVzIG9uIFdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTYyOTAxCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIHdpbGwgYmUgY292ZXJl ZCBieSBleGlzdGluZyBBcHAgQ2FjaGUgdGVzdHMuCisKKyAgICAgICAgVHdvIHJlbGF0ZWQgZml4 ZXMuICAxKSBOdWxsLWNoZWNrIHRoZSBDRlN0cmluZ1JlZiBhbmQgQ0ZVUkxSZWYgY3JlYXRlZCBp biBRVE1vdmllOjpsb2FkKCkgYmVmb3JlCisgICAgICAgIHBhc3NpbmcgdGhlbSB0byBDRlJlbGVh c2UoKS4gIDIpIFVzZSBDRlVSTCB0byBjcmVhdGUgYW4gYXBwcm9wcmlhdGUgZmlsZS1VUkwgb24g d2luZG93cyBpbiAKKyAgICAgICAgY3JlYXRlRmlsZVVSTEZvckFwcGxpY2F0aW9uQ2FjaGVSZXNv dXJjZS4KKworICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpjcmVhdGVGaWxlVVJMRm9yQXBwbGljYXRpb25DYWNoZVJlc291cmNlKToKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93aW4vUVRNb3ZpZS5jcHA6CisgICAgICAgIChRVE1vdmll Ojpsb2FkKToKKwogMjAxMS0wNi0xNiAgdW5hIHNhYm92aWMgIDx1bmEuc2Fib3ZpY0BwYWxtLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MTWVkaWFFbGVtZW50LmNwcAppbmRleCBhNTVmZjE0NTYzODYzOWViNmQ0YjEzZjI2YmM3 ZWMxY2QyODE5MGJhLi5jMzgzY2M5ZmNmZGYwNDNlYTVjYjQ1YTE4OGZkNzdmNzg0NmVkMmYxIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTY4MSwxMCArNjgx LDE3IEBAIHN0YXRpYyBLVVJMIGNyZWF0ZUZpbGVVUkxGb3JBcHBsaWNhdGlvbkNhY2hlUmVzb3Vy Y2UoY29uc3QgU3RyaW5nJiBwYXRoKQogICAgIC8vIGlzIG5vdCBzdWl0YWJsZSBiZWNhdXNlIEtV Ukw6OnNldFBhdGggdXNlcyBlbmNvZGVXaXRoVVJMRXNjYXBlU2VxdWVuY2VzLCB3aGljaCBpdCBu b3RlcwogICAgIC8vIGRvZXMgbm90IGNvcnJlY3RseSBlc2NhcGUgJyMnIGFuZCAnPycuIFRoaXMg ZnVuY3Rpb24gd29ya3MgZm9yIG91ciBwdXJwb3NlcyBiZWNhdXNlCiAgICAgLy8gYXBwIGNhY2hl IG1lZGlhIGZpbGVzIGFyZSBhbHdheXMgY3JlYXRlZCB3aXRoIGVuY29kZUZvckZpbGVOYW1lKGNy ZWF0ZUNhbm9uaWNhbFVVSURTdHJpbmcoKSkuCisKKyNpZiBVU0UoQ0YpICYmIFBMQVRGT1JNKFdJ TikKKyAgICBSZXRhaW5QdHI8Q0ZTdHJpbmdSZWY+IGNmUGF0aChBZG9wdENGLCBwYXRoLmNyZWF0 ZUNGU3RyaW5nKCkpOworICAgIFJldGFpblB0cjxDRlVSTFJlZj4gY2ZVUkwoQWRvcHRDRiwgQ0ZV UkxDcmVhdGVXaXRoRmlsZVN5c3RlbVBhdGgoMCwgY2ZQYXRoLmdldCgpLCBrQ0ZVUkxXaW5kb3dz UGF0aFN0eWxlLCBmYWxzZSkpOworICAgIEtVUkwgdXJsKGNmVVJMLmdldCgpKTsKKyNlbHNlCiAg ICAgS1VSTCB1cmw7CiAKICAgICB1cmwuc2V0UHJvdG9jb2woImZpbGUiKTsKICAgICB1cmwuc2V0 UGF0aChwYXRoKTsKKyNlbmRpZgogICAgIHJldHVybiB1cmw7CiB9CiAjZW5kaWYKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9RVE1vdmllLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9RVE1vdmllLmNwcAppbmRleCA2Zjlj NjY4MjAwYTJkMzVkN2I0NWRiMjcyNDE0MjZlMjc0MmU3ZWE4Li43Y2UyOGU1MTU2ZGZjY2I5Yzgw NGUzM2VmOWZjNDhiMzU3ZjQxZmFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy93aW4vUVRNb3ZpZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3Mvd2luL1FUTW92aWUuY3BwCkBAIC00NDksOCArNDQ5LDEwIEBAIHZvaWQgUVRNb3Zp ZTo6bG9hZFBhdGgoY29uc3QgVUNoYXIqIHVybCwgaW50IGxlbiwgYm9vbCBwcmVzZXJ2ZXNQaXRj aCkKIAogICAgIGxvYWQoY2ZVUkwsIHByZXNlcnZlc1BpdGNoKTsKIAotICAgIENGUmVsZWFzZShj ZlVSTCk7Ci0gICAgQ0ZSZWxlYXNlKHVybFN0cmluZ1JlZik7CisgICAgaWYgKGNmVVJMKQorICAg ICAgICBDRlJlbGVhc2UoY2ZVUkwpOworICAgIGlmICh1cmxTdHJpbmdSZWYpCisgICAgICAgIENG UmVsZWFzZSh1cmxTdHJpbmdSZWYpOwogfQogCiB2b2lkIFFUTW92aWU6OmxvYWQoY29uc3QgVUNo YXIqIHVybCwgaW50IGxlbiwgYm9vbCBwcmVzZXJ2ZXNQaXRjaCkKQEAgLTQ2MCw4ICs0NjIsMTAg QEAgdm9pZCBRVE1vdmllOjpsb2FkKGNvbnN0IFVDaGFyKiB1cmwsIGludCBsZW4sIGJvb2wgcHJl c2VydmVzUGl0Y2gpCiAKICAgICBsb2FkKGNmVVJMLCBwcmVzZXJ2ZXNQaXRjaCk7CiAKLSAgICBD RlJlbGVhc2UoY2ZVUkwpOwotICAgIENGUmVsZWFzZSh1cmxTdHJpbmdSZWYpOworICAgIGlmIChj ZlVSTCkKKyAgICAgICAgQ0ZSZWxlYXNlKGNmVVJMKTsKKyAgICBpZiAodXJsU3RyaW5nUmVmKQor ICAgICAgICBDRlJlbGVhc2UodXJsU3RyaW5nUmVmKTsKIH0KIAogdm9pZCBRVE1vdmllOjpsb2Fk KENGVVJMUmVmIHVybCwgYm9vbCBwcmVzZXJ2ZXNQaXRjaCkK 98041 2011-06-21 12:24:38 -0700 2011-06-21 12:54:27 -0700 Patch bug-62901-20110621122437.patch text/plain 3025 jer.noble SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5MzY4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDYtMjEgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUGxheWluZyB2aWRlbyBmcm9tIHRoZSBtYW5pZmVzdCBjcmFzaGVz IG9uIFdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTYyOTAxCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIHdpbGwgYmUgY292ZXJlZCBi eSBleGlzdGluZyBBcHAgQ2FjaGUgdGVzdHMuCisgICAgICAgIAorICAgICAgICBUd28gcmVsYXRl ZCBmaXhlcy4gMSkgTnVsbC1jaGVjayB0aGUgQ0ZTdHJpbmdSZWYgYW5kIENGVVJMUmVmIGNyZWF0 ZWQgaW4gUVRNb3ZpZTo6bG9hZCgpIGJlZm9yZQorICAgICAgICBwYXNzaW5nIHRoZW0gdG8gQ0ZS ZWxlYXNlKCkuIDIpIENhbGwgUVRNb3ZpZTo6bG9hZFBhdGgoKSBpbnN0ZWFkIG9mIFFUTW92aWU6 OmxvYWQoKSB3aGVuIGxvYWRpbmcKKyAgICAgICAgZnJvbSB0aGUgYXBwIGNhY2hlLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL01lZGlhUGxheWVyUHJpdmF0ZVF1aWNrVGltZVZp c3VhbENvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlUXVp Y2tUaW1lVmlzdWFsQ29udGV4dDo6bG9hZEludGVybmFsKToKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy93aW4vUVRNb3ZpZS5jcHA6CisgICAgICAgIChRVE1vdmllOjpsb2FkUGF0aCk6Cisg ICAgICAgIChRVE1vdmllOjpsb2FkKToKKwogMjAxMS0wNi0xNCAgTHVjYXMgRm9yc2NobGVyICA8 bGZvcnNjaGxlckBhcHBsZS5jb20+CiAKICAgICBSb2xsZWQgb3V0IDg5MDgwLgpJbmRleDogU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL01lZGlhUGxheWVyUHJpdmF0ZVF1aWNr VGltZVZpc3VhbENvbnRleHQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3dpbi9NZWRpYVBsYXllclByaXZhdGVRdWlja1RpbWVWaXN1YWxDb250ZXh0 LmNwcAkocmV2aXNpb24gODkyOTkpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy93aW4vTWVkaWFQbGF5ZXJQcml2YXRlUXVpY2tUaW1lVmlzdWFsQ29udGV4dC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTM3OSw3ICszNzksNyBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZVF1aWNr VGltZVZpc3VhbENvCiAgICAgQXBwbGljYXRpb25DYWNoZUhvc3QqIGNhY2hlSG9zdCA9IGZyYW1l ID8gZnJhbWUtPmxvYWRlcigpLT5kb2N1bWVudExvYWRlcigpLT5hcHBsaWNhdGlvbkNhY2hlSG9z dCgpIDogMDsKICAgICBBcHBsaWNhdGlvbkNhY2hlUmVzb3VyY2UqIHJlc291cmNlID0gMDsKICAg ICBpZiAoY2FjaGVIb3N0ICYmIGNhY2hlSG9zdC0+c2hvdWxkTG9hZFJlc291cmNlRnJvbUFwcGxp Y2F0aW9uQ2FjaGUoUmVzb3VyY2VSZXF1ZXN0KHVybCksIHJlc291cmNlKSAmJiByZXNvdXJjZSAm JiAhcmVzb3VyY2UtPnBhdGgoKS5pc0VtcHR5KCkpCi0gICAgICAgIG1fbW92aWUtPmxvYWQocmVz b3VyY2UtPnBhdGgoKS5jaGFyYWN0ZXJzKCksIHJlc291cmNlLT5wYXRoKCkubGVuZ3RoKCksIG1f cGxheWVyLT5wcmVzZXJ2ZXNQaXRjaCgpKTsKKyAgICAgICAgbV9tb3ZpZS0+bG9hZFBhdGgocmVz b3VyY2UtPnBhdGgoKS5jaGFyYWN0ZXJzKCksIHJlc291cmNlLT5wYXRoKCkubGVuZ3RoKCksIG1f cGxheWVyLT5wcmVzZXJ2ZXNQaXRjaCgpKTsKICAgICBlbHNlCiAjZW5kaWYKICAgICAgICAgbV9t b3ZpZS0+bG9hZCh1cmwuY2hhcmFjdGVycygpLCB1cmwubGVuZ3RoKCksIG1fcGxheWVyLT5wcmVz ZXJ2ZXNQaXRjaCgpKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dp bi9RVE1vdmllLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy93aW4vUVRNb3ZpZS5jcHAJKHJldmlzaW9uIDg5Mjk5KQorKysgU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3Mvd2luL1FUTW92aWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NDks OCArNDQ5LDEwIEBAIHZvaWQgUVRNb3ZpZTo6bG9hZFBhdGgoY29uc3QgVUNoYXIqIHVybCwKIAog ICAgIGxvYWQoY2ZVUkwsIHByZXNlcnZlc1BpdGNoKTsKIAotICAgIENGUmVsZWFzZShjZlVSTCk7 Ci0gICAgQ0ZSZWxlYXNlKHVybFN0cmluZ1JlZik7CisgICAgaWYgKGNmVVJMKQorICAgICAgICBD RlJlbGVhc2UoY2ZVUkwpOworICAgIGlmICh1cmxTdHJpbmdSZWYpCisgICAgICAgIENGUmVsZWFz ZSh1cmxTdHJpbmdSZWYpOwogfQogCiB2b2lkIFFUTW92aWU6OmxvYWQoY29uc3QgVUNoYXIqIHVy bCwgaW50IGxlbiwgYm9vbCBwcmVzZXJ2ZXNQaXRjaCkKQEAgLTQ2MCw4ICs0NjIsMTAgQEAgdm9p ZCBRVE1vdmllOjpsb2FkKGNvbnN0IFVDaGFyKiB1cmwsIGludAogCiAgICAgbG9hZChjZlVSTCwg cHJlc2VydmVzUGl0Y2gpOwogCi0gICAgQ0ZSZWxlYXNlKGNmVVJMKTsKLSAgICBDRlJlbGVhc2Uo dXJsU3RyaW5nUmVmKTsKKyAgICBpZiAoY2ZVUkwpCisgICAgICAgIENGUmVsZWFzZShjZlVSTCk7 CisgICAgaWYgKHVybFN0cmluZ1JlZikKKyAgICAgICAgQ0ZSZWxlYXNlKHVybFN0cmluZ1JlZik7 CiB9CiAKIHZvaWQgUVRNb3ZpZTo6bG9hZChDRlVSTFJlZiB1cmwsIGJvb2wgcHJlc2VydmVzUGl0 Y2gpCg==