62898 2011-06-17 12:02:46 -0700 Expand Web Worker test coverage for onerror to have test for url/line numbers. 2011-06-20 14:34:25 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 levin levin ap dimich oldest_to_newest 422808 0 levin 2011-06-17 12:02:46 -0700 See summary. 423921 1 97853 levin 2011-06-20 13:37:03 -0700 Created attachment 97853 Patch 423927 2 97853 dimich 2011-06-20 13:49:37 -0700 Comment on attachment 97853 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97853&action=review r=me with a nit: > LayoutTests/fast/workers/resources/worker-script-error-bubbled.js:7 > return true; There is unbalanced ' in the output this line produces. 423931 3 levin 2011-06-20 13:56:09 -0700 (In reply to comment #2) > (From update of attachment 97853 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=97853&action=review > > r=me with a nit: > > > LayoutTests/fast/workers/resources/worker-script-error-bubbled.js:7 > > return true; > > There is unbalanced ' in the output this line produces. I don't see it. Perhaps one issue is that both the worker and the main page use ' to quote which is confusing. I could switch the quotes in the main page to be "" for this message. 423933 4 dimich 2011-06-20 13:59:07 -0700 (In reply to comment #3) > > There is unbalanced ' in the output this line produces. > > I don't see it. Perhaps one issue is that both the worker and the main page use ' to quote which is confusing. I don't see it now as well. Please disregard my comment. Perhaps indeed using " for main page could be less confusing. 423958 5 levin 2011-06-20 14:34:25 -0700 Committed as http://trac.webkit.org/changeset/89291. 97853 2011-06-20 13:37:03 -0700 2011-06-20 13:49:36 -0700 Patch bug-62898-20110620133702.patch text/plain 4600 levin U3VidmVyc2lvbiBSZXZpc2lvbjogODkyODUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA2M2Q1MjlhN2Q4ZjA3NWZlZjYwZmU2 ZmQyYzUxNTY5ODMyYzNlN2NiLi5iMjMxNzhmZTU3NmEzZDY2Y2FiY2FmOWE4ZWQ2ZGFmOTg3ODg3 ZGIyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMjAgIERhdmlkIExldmluICA8bGV2 aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEV4cGFuZCBXZWIgV29ya2VyIHRlc3QgY292ZXJhZ2UgZm9yIG9uZXJyb3IgdG8g aGF2ZSB0ZXN0IGZvciB1cmwvbGluZSBudW1iZXJzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjI4OTgKKworICAgICAgICAqIGZhc3Qvd29ya2Vycy9y ZXNvdXJjZXMvd29ya2VyLXNjcmlwdC1lcnJvci1idWJibGVkLmpzOgorICAgICAgICAob25lcnJv cik6IEFkZGVkIGEgY2hlY2sgZm9yIHRoZSB1cmwgYW5kIHB1dCB0aGUgbGFzdCBwYXJ0IGluIHRo ZSBtZXNzYWdlLgorICAgICAgICAqIGZhc3Qvd29ya2Vycy93b3JrZXItc2NyaXB0LWVycm9yLWV4 cGVjdGVkLnR4dDogVXBkYXRlIHRvIGhhdmUgdGhlIG5ldyByZXN1bHQuCisgICAgICAgICogZmFz dC93b3JrZXJzL3dvcmtlci1zY3JpcHQtZXJyb3IuaHRtbDogQWN0dWFsbHkgcHJpbnQgdGhlIG1l c3NhZ2UgZnJvbSB0aGUgd29ya2VyLgorCiAyMDExLTA2LTIwICBPbGl2ZXIgSHVudCAgPG9saXZl ckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L3dvcmtlcnMvcmVzb3VyY2VzL3dvcmtlci1zY3JpcHQtZXJy b3ItYnViYmxlZC5qcyBiL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy9yZXNvdXJjZXMvd29ya2Vy LXNjcmlwdC1lcnJvci1idWJibGVkLmpzCmluZGV4IGEyMGQ0MTA4YjU5NWMwNGEwODllYmViMDQ4 YjIxZGFiY2U5YWM4ODcuLjA4MWRlY2I3Zjk4MzFiNWNhMzkzMTM1NTkxMzExMjZjZDkxZWYxZGQg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy9yZXNvdXJjZXMvd29ya2VyLXNj cmlwdC1lcnJvci1idWJibGVkLmpzCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy9yZXNv dXJjZXMvd29ya2VyLXNjcmlwdC1lcnJvci1idWJibGVkLmpzCkBAIC0xLDYgKzEsOSBAQAogb25l cnJvciA9IGZ1bmN0aW9uKG1lc3NhZ2UsIHVybCwgbGluZW5vKQogewotICAgIHBvc3RNZXNzYWdl KCJvbmVycm9yIGludm9rZWQgZm9yIGEgc2NyaXB0IHRoYXQgaGFzIHNjcmlwdCBlcnJvciAnIiAr IG1lc3NhZ2UgKyAiJyBhdCBsaW5lICIgKyBsaW5lbm8pOworICAgIGlmICh1cmwgIT0gbG9jYXRp b24uaHJlZikKKyAgICAgICAgcG9zdE1lc3NhZ2UoIkZBSUw6IEJhZCBsb2NhdGlvbi4gQWN0dWFs OiAiICsgdXJsICsgIiBFeHBlY3RlZDogIiArIGxvY2F0aW9uLmhyZWYpOworICAgIHNwbGl0VXJs ID0gdXJsLnNwbGl0KCcvJyk7CisgICAgcG9zdE1lc3NhZ2UoIlBBU1M6IG9uZXJyb3IgaW4gd29y a2VyIGNvbnRleHQgaW52b2tlZCBmb3IgYSBzY3JpcHQgdGhhdCBoYXMgc2NyaXB0IGVycm9yICci ICsgbWVzc2FnZSArICInIGF0IGxpbmUgIiArIGxpbmVubyArICIgaW4gIiArIHNwbGl0VXJsW3Nw bGl0VXJsLmxlbmd0aCAtIDFdKTsKICAgICByZXR1cm4gdHJ1ZTsKIH0KIApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL3dvcmtlci1zY3JpcHQtZXJyb3ItZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL3dvcmtlci1zY3JpcHQtZXJyb3ItZXhwZWN0ZWQu dHh0CmluZGV4IDQwNDE2NDA4OWU4MjRhOTBlNDBkZTkyYzdlMTI0OTUwMWI3ODg3MTkuLmRhN2Rm YzBiNjJjYWE2YzU2MzAxNjcxYTI4Njc2NzcyM2RiYTU2NjIgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2Zhc3Qvd29ya2Vycy93b3JrZXItc2NyaXB0LWVycm9yLWV4cGVjdGVkLnR4dAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L3dvcmtlcnMvd29ya2VyLXNjcmlwdC1lcnJvci1leHBlY3RlZC50eHQK QEAgLTEsNCArMSw0IEBACi1DT05TT0xFIE1FU1NBR0U6IGxpbmUgNzogUmVmZXJlbmNlRXJyb3I6 IENhbid0IGZpbmQgdmFyaWFibGU6IGZvbworQ09OU09MRSBNRVNTQUdFOiBsaW5lIDEwOiBSZWZl cmVuY2VFcnJvcjogQ2FuJ3QgZmluZCB2YXJpYWJsZTogZm9vCiBUZXN0IFdvcmtlciBzY3JpcHQg ZXJyb3IgaGFuZGxpbmcgZnVuY3Rpb25hbGl0eS4gU2hvdWxkIHByaW50IGEgc2VyaWVzIG9mIFBB U1MgbWVzc2FnZXMsIGZvbGxvd2VkIHdpdGggRE9ORS4KIAogUEFTUzogb25lcnJvciBpbnZva2Vk IGZvciBhIHNjcmlwdCB0aGF0IGhhcyBpbnZhbGlkIHN5bnRheC4KQEAgLTYsOCArNiw5IEBAIFBB U1M6IG9uZXJyb3IgaW52b2tlZCBmb3IgYSBzY3JpcHQgdGhhdCBoYXMgc2NyaXB0IGVycm9yICdS ZWZlcmVuY2VFcnJvcjogQ2FuJ3QKIFBBU1M6IGV2ZW50IGxpc3RlbmVyIGludm9rZWQgZm9yIGEg c2NyaXB0IHRoYXQgaGFzIHNjcmlwdCBlcnJvciAnUmVmZXJlbmNlRXJyb3I6IENhbid0IGZpbmQg dmFyaWFibGU6IGZvbycgYXQgbGluZSAxLgogUEFTUzogb25lcnJvciBpbnZva2VkIGZvciBhIHNj cmlwdCB0aGF0IGhhcyBzY3JpcHQgZXJyb3IgJ1JlZmVyZW5jZUVycm9yOiBDYW4ndCBmaW5kIHZh cmlhYmxlOiBmb28nIGF0IGxpbmUgNy4KIFBBU1M6IG9uZXJyb3IgaW52b2tlZCBmb3IgYSBzY3Jp cHQgdGhhdCBoYXMgc2NyaXB0IGVycm9yICdSZWZlcmVuY2VFcnJvcjogQ2FuJ3QgZmluZCB2YXJp YWJsZTogYmFyJyBhdCBsaW5lIDMuCi1QQVNTOiBvbmVycm9yIGludm9rZWQgZm9yIGEgc2NyaXB0 IHRoYXQgaGFzIHNjcmlwdCBlcnJvciAnUmVmZXJlbmNlRXJyb3I6IENhbid0IGZpbmQgdmFyaWFi bGU6IGZvbycgYXQgbGluZSA3LgotUEFTUzogb25lcnJvciBpbnZva2VkIGZvciBhIHNjcmlwdCB0 aGF0IGhhcyBzY3JpcHQgZXJyb3IgJ1JlZmVyZW5jZUVycm9yOiBDYW4ndCBmaW5kIHZhcmlhYmxl OiBmb28nIGF0IGxpbmUgNy4KK21lc3NhZ2UgZnJvbSB3b3JrZXI6ICdQQVNTOiBvbmVycm9yIGlu IHdvcmtlciBjb250ZXh0IGludm9rZWQgZm9yIGEgc2NyaXB0IHRoYXQgaGFzIHNjcmlwdCBlcnJv ciAnUmVmZXJlbmNlRXJyb3I6IENhbid0IGZpbmQgdmFyaWFibGU6IGZvbycgYXQgbGluZSAxMCBp biB3b3JrZXItc2NyaXB0LWVycm9yLWJ1YmJsZWQuanMnLgorUEFTUzogb25lcnJvciBpbnZva2Vk IGZvciBhIHNjcmlwdCB0aGF0IGhhcyBzY3JpcHQgZXJyb3IgJ1JlZmVyZW5jZUVycm9yOiBDYW4n dCBmaW5kIHZhcmlhYmxlOiBmb28nIGF0IGxpbmUgMTAuCitQQVNTOiBvbmVycm9yIGludm9rZWQg Zm9yIGEgc2NyaXB0IHRoYXQgaGFzIHNjcmlwdCBlcnJvciAnUmVmZXJlbmNlRXJyb3I6IENhbid0 IGZpbmQgdmFyaWFibGU6IGZvbycgYXQgbGluZSAxMC4KIFBBU1M6IG1lc3NhZ2UgcmVjZWl2ZWQg ZnJvbSBXb3JrZXJHbG9iYWxTY29wZS5vbmVycm9yOiBvbmVycm9yIGludm9rZWQgZm9yIGEgc2Ny aXB0IHRoYXQgaGFzIHNjcmlwdCBlcnJvciAnUmVmZXJlbmNlRXJyb3I6IENhbid0IGZpbmQgdmFy aWFibGU6IGZvbycgYXQgbGluZSA3LgogUEFTUzogb25lcnJvciBpbnZva2VkIGZvciBhbiBleGNl cHRpb24gaW4gc2V0VGltZW91dCBjYWxsYmFjay4KIERPTkUKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2Zhc3Qvd29ya2Vycy93b3JrZXItc2NyaXB0LWVycm9yLmh0bWwgYi9MYXlvdXRUZXN0cy9m YXN0L3dvcmtlcnMvd29ya2VyLXNjcmlwdC1lcnJvci5odG1sCmluZGV4IDJiYTJlYWI2MTdlYzcy MzE1OTE0ZTRlNDNhZTg4MzhjZjMwMjJlODIuLjQ2ZDM1NWM2YmIxYzQxMDIwYzAyYTdiYjczOTNl Yzc5OTgzMDkxYTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy93b3JrZXIt c2NyaXB0LWVycm9yLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL3dvcmtlci1z Y3JpcHQtZXJyb3IuaHRtbApAQCAtMTAwLDYgKzEwMCw5IEBAIGZ1bmN0aW9uIHRlc3RTY3JpcHRF cnJvckJ1YmJsZWRBbmRIYW5kbGVkSW5Xb3JrZXIoKQogewogICAgIHRyeSB7CiAgICAgICAgIHZh ciB3b3JrZXIgPSBuZXcgV29ya2VyKCJyZXNvdXJjZXMvd29ya2VyLXNjcmlwdC1lcnJvci1idWJi bGVkLmpzIik7CisgICAgICAgIHdvcmtlci5vbm1lc3NhZ2UgPSBmdW5jdGlvbihldnQpIHsKKyAg ICAgICAgICAgIGxvZygibWVzc2FnZSBmcm9tIHdvcmtlcjogJyIgKyBldnQuZGF0YSArICInLiIp OworICAgICAgICB9CiAgICAgICAgIHdvcmtlci5vbmVycm9yID0gZnVuY3Rpb24oZXZ0KSB7CiAg ICAgICAgICAgICBsb2coIlBBU1M6IG9uZXJyb3IgaW52b2tlZCBmb3IgYSBzY3JpcHQgdGhhdCBo YXMgc2NyaXB0IGVycm9yICciICsgZXZ0Lm1lc3NhZ2UgKyAiJyBhdCBsaW5lICIgKyBldnQubGlu ZW5vICsgIi4iKTsKICAgICAgICAgICAgIHJ1bk5leHRUZXN0KCk7Cg==