6289 2005-12-29 16:56:23 -0800 REGRESSION: firstCharacterForRange(0, 0) returns a 0x0 rect 2005-12-30 13:25:21 -0800 1 1 1 Unclassified WebKit HTML Editing 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 mitz ap ap oldest_to_newest 27176 0 mitz 2005-12-29 16:56:23 -0800 The following layout tests are failing in TOT due to firstCharacterForRange(0, 0) returning a 0x0 rect: editing/input/firstrectforcharacterrange-plain editing/input/firstrectforcharacterrange-styled fast/text/attributed-substring-from-range It looks like a regression from fixing bug 6246. 27212 1 5369 ap 2005-12-29 22:42:51 -0800 Created attachment 5369 band-aid fix Looks like an indirect result of issues described in bug 5610: the range returned for (0, 0) in these tests is (#text, 1)-(#text,1) rather than (#text, 0)-(#text,0) - and the latter or equivalent don't give correct results in firstRectForDOMRange (which may be a separate issue). Going to cleanup this further as part of the investigation on 5610... 27229 2 mjs 2005-12-30 02:09:56 -0800 r=me, looks like an ok fix for now if it gets the tests passing and doesn't break anything. 5369 2005-12-29 22:42:51 -0800 2005-12-30 02:12:48 -0800 band-aid fix 6289.txt text/plain 1518 ap SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29yZS9D aGFuZ2VMb2csdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNjMKZGlmZiAtcCAtdSAtcjEuNjMgQ2hh bmdlTG9nCi0tLSBDaGFuZ2VMb2cJMzAgRGVjIDIwMDUgMDU6NDM6MjMgLTAwMDAJMS42MworKysg Q2hhbmdlTG9nCTMwIERlYyAyMDA1IDA2OjQ5OjM0IC0wMDAwCkBAIC0xLDMgKzEsMTIgQEAKKzIw MDUtMTItMzAgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBueXBvcC5jb20+CisKKyAgICAgICAg LSBGaXggaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD02Mjg5 CisgICAgICAgIFJFR1JFU1NJT046IGZpcnN0Q2hhcmFjdGVyRm9yUmFuZ2UoMCwgMCkgcmV0dXJu cyBhIDB4MCByZWN0CisKKyAgICAgICAgKiBraHRtbC9lZGl0aW5nL3Zpc2libGVfdGV4dC5jcHA6 CisgICAgICAgIChraHRtbDo6VGV4dEl0ZXJhdG9yOjpyYW5nZUZyb21Mb2NhdGlvbkFuZExlbmd0 aCk6CisgICAgICAgIE9ubHkgc3BlY2lhbC1jYXNlICgwLCAwKSByYW5nZXMgZm9yIGVtcHR5IGRv Y3VtZW50cy4KKwogMjAwNS0xMi0yOSAgRXJpYyBTZWlkZWwgIDxlc2VpZGVsQGFwcGxlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBtanMuCkluZGV4OiBraHRtbC9lZGl0aW5nL3Zpc2libGVf dGV4dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dlYkNvcmUva2h0bWwvZWRp dGluZy92aXNpYmxlX3RleHQuY3BwLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjQ1CmRpZmYgLXAg LXUgLXIxLjQ1IGtodG1sL2VkaXRpbmcvdmlzaWJsZV90ZXh0LmNwcAotLS0ga2h0bWwvZWRpdGlu Zy92aXNpYmxlX3RleHQuY3BwCTI4IERlYyAyMDA1IDE4OjIxOjUwIC0wMDAwCTEuNDUKKysrIGto dG1sL2VkaXRpbmcvdmlzaWJsZV90ZXh0LmNwcAkzMCBEZWMgMjAwNSAwNjo0OTozOCAtMDAwMApA QCAtOTk3LDcgKzk5Nyw4IEBAIFJhbmdlSW1wbCAqVGV4dEl0ZXJhdG9yOjpyYW5nZUZyb21Mb2Nh dGkKIAogICAgIFRleHRJdGVyYXRvciBpdChyYW5nZU9mQ29udGVudHMoZG9jKS5nZXQoKSk7CiAg ICAgCi0gICAgaWYgKHJhbmdlTG9jYXRpb24gPT0gMCAmJiByYW5nZUxlbmd0aCA9PSAwKSB7Cisg ICAgLy8gRklYTUU6IHRoZSBhdEVuZCgpIGNoZWNrIHNob3VsZG4ndCBiZSBuZWNlc3NhcnksIHdv cmthcm91bmQgZm9yIDxodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dp P2lkPTYyODk+LgorICAgIGlmIChyYW5nZUxvY2F0aW9uID09IDAgJiYgcmFuZ2VMZW5ndGggPT0g MCAmJiBpdC5hdEVuZCgpKSB7CiAgICAgICAgIGludCBleGNlcHRpb24gPSAwOwogICAgICAgICB0 ZXh0UnVuUmFuZ2UgPSBpdC5yYW5nZSgpOwogICAgICAgICAK