62884 2011-06-17 10:58:06 -0700 Assertion failure in SVGTextLayoutEngine constructor (!m_layoutAttributes.isEmpty()) 2011-06-19 07:57:07 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) All All RESOLVED FIXED http://code.google.com/p/chromium/issues/detail?id=84048 P2 Normal --- 1 jchaffraix jchaffraix eric webkit.review.bot zimmermann oldest_to_newest 422731 0 jchaffraix 2011-06-17 10:58:06 -0700 It looks like we can have an empty layoutAttributes in some cases. The URL has a reduced test case. Patch forthcoming. 422841 1 97641 jchaffraix 2011-06-17 13:00:06 -0700 Created attachment 97641 Proposed fix: do not layout if you don't have any layout attributes. 423026 2 97641 webkit.review.bot 2011-06-17 19:44:03 -0700 Comment on attachment 97641 Proposed fix: do not layout if you don't have any layout attributes. Rejecting attachment 97641 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 1 Last 500 characters of output: return self.open(self.click(*args, **kwds)) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open return self._mech_open(url, data, timeout=timeout) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open raise response webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error Full output: http://queues.webkit.org/results/8873023 423056 3 zimmermann 2011-06-17 23:39:30 -0700 Good catch, thanks Julien - generated content & SVG Text did not play well together. 423059 4 zimmermann 2011-06-17 23:53:54 -0700 Oh, this was already landed manually by Julien in r89183. Closing bug. 423362 5 jchaffraix 2011-06-19 07:57:07 -0700 (Adding Eric as there was some hogs with the commit queue, Eric see this comment and comment #2 for reference) (In reply to comment #4) > Oh, this was already landed manually by Julien in r89183. Closing bug. Good catch, thanks! However I did not land the patch. The commit queue did but got an error before closing the bug. Not sure which component returned a 500 response. 97641 2011-06-17 13:00:06 -0700 2011-06-17 19:44:03 -0700 Proposed fix: do not layout if you don't have any layout attributes. bug-62884-20110617130005.patch text/plain 3809 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogODkxNDEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBlYjA5YzAwOGJjNDU0YmRiNzI2Yzdi ZGE4ZTlmMjU5MGZlM2U4MDZiLi4xZTZlZjkwMDU2MzdmNjc5M2MzNTJkMmVlMDZmYmFhMTQ3ZTIy NTI3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDYtMTcgIEp1bGllbiBDaGFmZnJhaXgg IDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQXNzZXJ0aW9uIGZhaWx1cmUgaW4gU1ZHVGV4dExheW91dEVuZ2lu ZSBjb25zdHJ1Y3RvciAoIW1fbGF5b3V0QXR0cmlidXRlcy5pc0VtcHR5KCkpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Mjg4NAorCisgICAgICAgICog c3ZnL2N1c3RvbS9hc3NlcnQtZW1wdHktbGF5b3V0LWF0dHJpYnV0ZXMtZXhwZWN0ZWQudHh0OiBB ZGRlZC4KKyAgICAgICAgKiBzdmcvY3VzdG9tL2Fzc2VydC1lbXB0eS1sYXlvdXQtYXR0cmlidXRl cy5zdmc6IEFkZGVkLgorCiAyMDExLTA2LTE3ICBZdXRhIEtpdGFtdXJhICA8eXV0YWtAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHVwZGF0ZSBDaHJvbWl1bSB0ZXN0IGV4cGVj dGF0aW9uIGZvciBmYXN0L2RvbS9IVE1MTWV0ZXJFbGVtZW50L21ldGVyLXdyaXRpbmctbW9kZS5o dG1sLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9hc3NlcnQtZW1wdHktbGF5 b3V0LWF0dHJpYnV0ZXMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9hc3Nl cnQtZW1wdHktbGF5b3V0LWF0dHJpYnV0ZXMtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmY2ZWQz YjdkMzA1Zjk0NzRiZGRmYzViYTZiZTRhZmVmZmUyZjZhODIKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9zdmcvY3VzdG9tL2Fzc2VydC1lbXB0eS1sYXlvdXQtYXR0cmlidXRlcy1leHBl Y3RlZC50eHQKQEAgLTAsMCArMSwyIEBACitUZXN0IGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NjI4ODQKK1RoaXMgdGVzdCBwYXNzZXMgaWYgaXQgZGlkIG5vdCBj cmFzaApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9hc3NlcnQtZW1wdHktbGF5 b3V0LWF0dHJpYnV0ZXMuc3ZnIGIvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9hc3NlcnQtZW1wdHkt bGF5b3V0LWF0dHJpYnV0ZXMuc3ZnCm5ldyBmaWxlIG1vZGUgMTAwNzU1CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmI2YWE5NWIyMzFmZGEzNTgxNTJiZmJk ZTNjOTEzMjU4Y2ZmNTkzNGUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9zdmcvY3Vz dG9tL2Fzc2VydC1lbXB0eS1sYXlvdXQtYXR0cmlidXRlcy5zdmcKQEAgLTAsMCArMSwyMSBAQAor PD94bWwgdmVyc2lvbj0iMS4wIiBzdGFuZGFsb25lPSJubyI/PgorPCFET0NUWVBFIHggUFVCTElD ICIiICIiPgorPHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPgorICAgIDxz dHlsZT4KKyAgICAgICAgKjphZnRlciB7CisgICAgICAgIGNvbnRlbnQ6ICJ4IgorICAgICAgICB9 CisgICAgPC9zdHlsZT4KKyAgICA8ZGVmcz4KKyAgICAgICAgPGZvbnQ+CisgICAgICAgICAgICA8 Zm9udC1mYWNlIGZvbnQtZmFtaWx5PSJTVkdBcmlhbCIgLz4KKyAgICAgICAgPC9mb250PgorICAg IDwvZGVmcz4KKyAgICA8dGV4dCBzdHlsZT0iZm9udC1mYW1pbHk6U1ZHQXJpYWw7Ij48L3RleHQ+ CisgICAgPHNjcmlwdD4KKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAg ICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgPC9zY3JpcHQ+Cisg ICAgPHRleHQgeD0iMTBweCIgeT0iNTBweCIgPlRlc3QgZm9yIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02Mjg4NDwvdGV4dD4KKyAgICA8dGV4dCB4PSIxMHB4IiB5PSIx MDBweCI+VGhpcyB0ZXN0IHBhc3NlcyBpZiBpdCBkaWQgbm90IGNyYXNoPC90ZXh0PgorPC9zdmc+ CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKaW5kZXggYWMyMTFiYzRlZGVmOTc4ZWQ3ODM1Zjc1NGM1NjAzMmEzN2EzZTY3OC4u N2MzM2FiMWU1MjQzYjk4ODA5NjkyNjY5YWI0YTc5YTQwMDIyNWZiZCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE3IEBACisyMDExLTA2LTE3ICBKdWxpZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3 ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFzc2VydGlvbiBmYWlsdXJlIGluIFNWR1RleHRMYXlvdXRFbmdpbmUgY29uc3RydWN0b3Ig KCFtX2xheW91dEF0dHJpYnV0ZXMuaXNFbXB0eSgpKQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjI4ODQKKworICAgICAgICBUZXN0OiBzdmcvY3VzdG9t L2Fzc2VydC1lbXB0eS1sYXlvdXQtYXR0cmlidXRlcy5zdmcKKworICAgICAgICAqIHJlbmRlcmlu Zy9zdmcvU1ZHUm9vdElubGluZUJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdSb290SW5s aW5lQm94Ojpjb21wdXRlUGVyQ2hhcmFjdGVyTGF5b3V0SW5mb3JtYXRpb24pOiBBZGRlZCBhIGVh cmx5IHJldHVybiBoZXJlLgorICAgICAgICBJdCBpcyBub3QgbmVlZGVkIHRvIGRvIHRoZSB0ZXh0 IGxheW91dCBhbGdvcml0aG0gaWYgeW91IGRvbid0IGhhdmUgYW55IGxheW91dCBpbmZvcm1hdGlv biBhcworICAgICAgICB5b3VyIHNpemUgaXMgKDAsIDApIGFueXdheS4KKwogMjAxMS0wNi0xNiAg UGF2ZWwgUG9kaXZpbG92ICA8cG9kaXZpbG92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL3N2Zy9TVkdSb290SW5saW5lQm94LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9zdmcvU1ZHUm9vdElubGluZUJveC5jcHAKaW5kZXggMjcwYzAyYTgxZWI1MzBkMzg4OWVkMDZh NjQ2ZDNhZTYxMjdjNGNjMi4uMDI1Y2I5MDQzOGJlYWE2OWQ4MmVlZDZiN2NkNWEwZjRhMTdhYWE1 ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9TVkdSb290SW5saW5l Qm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR1Jvb3RJbmxpbmVC b3guY3BwCkBAIC03Nyw2ICs3Nyw5IEBAIHZvaWQgU1ZHUm9vdElubGluZUJveDo6Y29tcHV0ZVBl ckNoYXJhY3RlckxheW91dEluZm9ybWF0aW9uKCkKICAgICBBU1NFUlQocGFyZW50QmxvY2spOwog CiAgICAgVmVjdG9yPFNWR1RleHRMYXlvdXRBdHRyaWJ1dGVzPiYgYXR0cmlidXRlcyA9IHBhcmVu dEJsb2NrLT5sYXlvdXRBdHRyaWJ1dGVzKCk7CisgICAgaWYgKGF0dHJpYnV0ZXMuaXNFbXB0eSgp KQorICAgICAgICByZXR1cm47CisKICAgICBpZiAocGFyZW50QmxvY2stPm5lZWRzUmVvcmRlcmlu ZygpKQogICAgICAgICByZW9yZGVyVmFsdWVMaXN0cyhhdHRyaWJ1dGVzKTsKIAo=