62877 2011-06-17 10:35:13 -0700 [EFL] Add OwnPtr specializations for EFL types. 2011-06-17 11:58:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 61942 61974 62034 0 rakuco webkit-unassigned abarth eric leandro webkit.review.bot oldest_to_newest 422703 0 rakuco 2011-06-17 10:35:13 -0700 [EFL] Add OwnPtr specializations for EFL types. 422716 1 97617 rakuco 2011-06-17 10:46:33 -0700 Created attachment 97617 Patch 422720 2 rakuco 2011-06-17 10:48:58 -0700 These specializations are needed for us to upstream EFL's DumpRenderTree, as Eric has been very clear that we should not be doing manual memory management in the code. The style bot will complain about some struct names, but they are false positives. 422723 3 97617 eric 2011-06-17 10:50:06 -0700 Comment on attachment 97617 Patch FANTASTIC. This is the right approach, thank you. 422724 4 webkit.review.bot 2011-06-17 10:50:46 -0700 Attachment 97617 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/OwnPtrCommon.h:54: Ecore_Evas is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/OwnPtrCommon.h:55: Evas_Object is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 422805 5 97617 webkit.review.bot 2011-06-17 11:58:43 -0700 Comment on attachment 97617 Patch Clearing flags on attachment: 97617 Committed r89153: <http://trac.webkit.org/changeset/89153> 422806 6 webkit.review.bot 2011-06-17 11:58:48 -0700 All reviewed patches have been landed. Closing bug. 97617 2011-06-17 10:46:33 -0700 2011-06-17 11:58:43 -0700 Patch bug-62877-20110617144952.patch text/plain 4437 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogODkxNDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGEy MWE3ZmNlNDU0YTg4YTBmMGYzMjNjNTYzYjMxY2VkZTZkOGI4Y2MuLjhjZGE2OTk3YTlkZTFkODA1 ODdhYWQxNjY1MDViMDZlNGNlNzRhOWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE2IEBACisyMDExLTA2LTE3ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxrdWJvQHByb2Z1 c2lvbi5tb2JpPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFtFRkxdIEFkZCBzb21lIE93blB0ciBzcGVjaWFsaXphdGlvbnMgZm9yIEVGTCB0eXBlcy4K KyAgICAgICAgRm9yIG5vdyB0aGVyZSBhcmUgc3BlY2lhbGl6YXRpb25zIGZvciBFY29yZV9FdmFz IGFuZCBFdmFzX09iamVjdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTYyODc3CisKKyAgICAgICAgKiB3dGYvQ01ha2VMaXN0c0VmbC50eHQ6CisgICAg ICAgICogd3RmL093blB0ckNvbW1vbi5oOgorICAgICAgICAqIHd0Zi9lZmwvT3duUHRyRWZsLmNw cDogQWRkZWQuCisgICAgICAgIChXVEY6OmRlbGV0ZU93bmVkUHRyKToKKwogMjAxMS0wNi0xNyAg Sm9vbmUgSHVyICA8am9vbmUuaHVyQGNvbGxhYm9yYS5jby51az4KIAogICAgICAgICBSZXZpZXdl ZCBieSBNYXJ0aW4gUm9iaW5zb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv d3RmL0NNYWtlTGlzdHNFZmwudHh0IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9DTWFrZUxp c3RzRWZsLnR4dAppbmRleCA1NmU2Nzg2MTljN2YwM2QzZjU5ZWY3ZjNmMGFiYjFjYmMzZjI0ZjAz Li44OWZmNzI0M2M3YzA2NGQ0ODE5OWYwMzMxNGQwOTU4M2I0MGQxYTE5IDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0NNYWtlTGlzdHNFZmwudHh0CisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS93dGYvQ01ha2VMaXN0c0VmbC50eHQKQEAgLTgsNiArOCw3IEBAIEVORElG KCkKIAogTElTVChBUFBFTkQgV1RGX1NPVVJDRVMKICAgICBlZmwvTWFpblRocmVhZEVmbC5jcHAK KyAgICBlZmwvT3duUHRyRWZsLmNwcAogCiAgICAgT1NBbGxvY2F0b3JQb3NpeC5jcHAKICAgICBU aHJlYWRJZGVudGlmaWVyRGF0YVB0aHJlYWRzLmNwcApAQCAtMzksMTAgKzQwLDE0IEBAIExJU1Qo QVBQRU5EIFdURl9MSUJSQVJJRVMKIAogTElTVChBUFBFTkQgV1RGX0xJTktfRkxBR1MKICAgICAk e0VDT1JFX0xERkxBR1N9CisgICAgJHtFQ09SRV9FVkFTX0xERkxBR1N9CisgICAgJHtFVkFTX0xE RkxBR1N9CiApCiAKIExJU1QoQVBQRU5EIFdURl9JTkNMVURFX0RJUkVDVE9SSUVTCiAgICAgJHtF Q09SRV9JTkNMVURFX0RJUlN9CisgICAgJHtFQ09SRV9FVkFTX0lOQ0xVREVfRElSU30KKyAgICAk e0VWQVNfSU5DTFVERV9ESVJTfQogICAgICR7SUNVX0lOQ0xVREVfRElSU30KICAgICAke0pBVkFT Q1JJUFRDT1JFX0RJUn0vd3RmL3VuaWNvZGUvCiApCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvd3RmL093blB0ckNvbW1vbi5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9P d25QdHJDb21tb24uaAppbmRleCAxOTI1NmVhYmMzNzI2MjE3MzIxNzRmNTAyODU3MTUxNjM0ODNi NDljLi5kMmFiZGI1M2VjNzA0NGU1MzU1MzE4NGNiZjQxMzU4ZmZiMmNiNzNhIDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL093blB0ckNvbW1vbi5oCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS93dGYvT3duUHRyQ29tbW9uLmgKQEAgLTUwLDYgKzUwLDExIEBAIHR5cGVk ZWYgc3RydWN0IElNZW1Hcm91cCBJTWVtR3JvdXA7CiB0eXBlZGVmIHN0cnVjdCBJTWVtU3BhY2Ug SU1lbVNwYWNlOwogI2VuZGlmCiAKKyNpZiBQTEFURk9STShFRkwpCit0eXBlZGVmIHN0cnVjdCBf RWNvcmVfRXZhcyBFY29yZV9FdmFzOwordHlwZWRlZiBzdHJ1Y3QgX0V2YXNfT2JqZWN0IEV2YXNf T2JqZWN0OworI2VuZGlmCisKIG5hbWVzcGFjZSBXVEYgewogCiAgICAgdGVtcGxhdGUgPHR5cGVu YW1lIFQ+IGlubGluZSB2b2lkIGRlbGV0ZU93bmVkUHRyKFQqIHB0cikKQEAgLTc5LDYgKzg0LDEx IEBAIG5hbWVzcGFjZSBXVEYgewogICAgIHZvaWQgZGVsZXRlT3duZWRQdHIoSU1lbVNwYWNlKik7 CiAjZW5kaWYKIAorI2lmIFBMQVRGT1JNKEVGTCkKKyAgICB2b2lkIGRlbGV0ZU93bmVkUHRyKEVj b3JlX0V2YXMqKTsKKyAgICB2b2lkIGRlbGV0ZU93bmVkUHRyKEV2YXNfT2JqZWN0Kik7CisjZW5k aWYKKwogfSAvLyBuYW1lc3BhY2UgV1RGCiAKICNlbmRpZiAvLyBXVEZfT3duUHRyQ29tbW9uX2gK ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvZWZsL093blB0ckVmbC5jcHAg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL2VmbC9Pd25QdHJFZmwuY3BwCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LjY2ZWVhZTljMjBhYjc2NmExODE5NmEwZDVjNWFjYzc5MTc0MjUyZWEKLS0tIC9kZXYvbnVsbAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL2VmbC9Pd25QdHJFZmwuY3BwCkBAIC0wLDAg KzEsNDYgQEAKKy8qCisgKiBDb3B5cmlnaHQgKEMpIDIwMTEgUHJvRlVTSU9OIGVtYmVkZGVkIHN5 c3RlbXMKKyAqIENvcHlyaWdodCAoQykgMjAxMSBTYW1zdW5nIEVsZWN0cm9uaWNzCisgKgorICog UmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBv ciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0 aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKKyAqIGFyZSBtZXQ6CisgKiAxLiBSZWRpc3RyaWJ1dGlv bnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICogICAg bm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFp bWVyLgorICogMi4gUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNl IHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlv bnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKKyAqICAgIGRvY3VtZW50YXRp b24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24u CisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBDT01QVVRFUiwgSU5D LiBgYEFTIElTJycgQU5EIEFOWQorICogRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElO Q0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBUSEUKKyAqIElNUExJRUQgV0FSUkFOVElFUyBP RiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUgorICogUFVSUE9T RSBBUkUgRElTQ0xBSU1FRC4gIElOIE5PIEVWRU5UIFNIQUxMIEFQUExFIENPTVBVVEVSLCBJTkMu IE9SCisgKiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwg SU5DSURFTlRBTCwgU1BFQ0lBTCwKKyAqIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1B R0VTIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywKKyAqIFBST0NVUkVNRU5UIE9GIFNV QlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBPUgorICogUFJP RklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5Z IFRIRU9SWQorICogT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElB QklMSVRZLCBPUiBUT1JUCisgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBB UklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyAqIE9GIFRISVMgU09GVFdBUkUsIEVW RU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisgKi8KKwor I2luY2x1ZGUgImNvbmZpZy5oIgorI2luY2x1ZGUgIk93blB0ci5oIgorCisjaW5jbHVkZSA8RWNv cmVfRXZhcy5oPgorI2luY2x1ZGUgPEV2YXMuaD4KKworbmFtZXNwYWNlIFdURiB7CisKK3ZvaWQg ZGVsZXRlT3duZWRQdHIoRWNvcmVfRXZhcyogcHRyKQoreworICAgIGlmIChwdHIpCisgICAgICAg IGVjb3JlX2V2YXNfZnJlZShwdHIpOworfQorCit2b2lkIGRlbGV0ZU93bmVkUHRyKEV2YXNfT2Jq ZWN0KiBwdHIpCit7CisgICAgZXZhc19vYmplY3RfZGVsKHB0cik7Cit9CisKK30K