62861 2011-06-17 06:37:38 -0700 Web Inspector: REGRESSION: Breakpoint is missed 2011-06-21 03:30:42 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 aandrey podivilov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr podivilov rik timothy yurys oldest_to_newest 422590 0 aandrey 2011-06-17 06:37:38 -0700 A breakpoint on the last line of a <script>...</script> block is missed. For example: <script> console.log("TRY TO SET A BREAKPOINT HERE - IT IS OK"); console.log("TRY TO SET A BREAKPOINT HERE - IT WILL BE MISSED"); </script> The bug exists in Chrome 13.0.782.15 (Official Build 88529) dev, and Chrome v14 422673 1 97610 podivilov 2011-06-17 10:02:03 -0700 Created attachment 97610 Patch. 422711 2 aandrey 2011-06-17 10:40:34 -0700 View in context: https://bugs.webkit.org/attachment.cgi?id=97610&action=review > Source/WebCore/inspector/InspectorDebuggerAgent.cpp:267 > + if (breakpoint.lineNumber < script.startLine || script.endLine + 1 <= breakpoint.lineNumber) maybe: script.endLine < breakpoint.lineNumber ? 422712 3 aandrey 2011-06-17 10:42:19 -0700 btw, what about this case: <script> console.log("TRY TO SET A BREAKPOINT HERE");</script> ? 424369 4 podivilov 2011-06-21 03:30:42 -0700 Committed r89346: <http://trac.webkit.org/changeset/89346> 97610 2011-06-17 10:02:03 -0700 2011-06-17 11:00:06 -0700 Patch. patch text/plain 6554 podivilov ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmMjZiNTFiLi43MzJmMmQ3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYt MTcgIFBhdmVsIFBvZGl2aWxvdiAgPHBvZGl2aWxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogY2Fu J3Qgc2V0IGJyZWFrcG9pbnQgb24gdGhlIGxhc3Qgc2NyaXB0IGxpbmUuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Mjg2MQorCisgICAgICAgICogaHR0 cC90ZXN0cy9pbnNwZWN0b3IvZGVidWdnZXItdGVzdC5qczoKKyAgICAgICAgKGluaXRpYWxpemVf RGVidWdnZXJUZXN0KToKKyAgICAgICAgKiBpbnNwZWN0b3IvZGVidWdnZXIvZGVidWdnZXItcGF1 c2Utb24tYnJlYWtwb2ludC1leHBlY3RlZC50eHQ6CisgICAgICAgICogaW5zcGVjdG9yL2RlYnVn Z2VyL2RlYnVnZ2VyLXBhdXNlLW9uLWJyZWFrcG9pbnQuaHRtbDoKKwogMjAxMS0wNi0xNiAgR2F2 aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgUnViYmVy IHN0YW1wZWQgYnkgU2FtIFdlaW5pZy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVz dHMvaW5zcGVjdG9yL2RlYnVnZ2VyLXRlc3QuanMgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2lu c3BlY3Rvci9kZWJ1Z2dlci10ZXN0LmpzCmluZGV4IDJhNDMxZjIuLmY5YTg4OGEgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL2RlYnVnZ2VyLXRlc3QuanMKKysr IGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3IvZGVidWdnZXItdGVzdC5qcwpAQCAt Miw3ICsyLDggQEAgdmFyIGluaXRpYWxpemVfRGVidWdnZXJUZXN0ID0gZnVuY3Rpb24oKSB7CiAK IEluc3BlY3RvclRlc3Quc3RhcnREZWJ1Z2dlclRlc3QgPSBmdW5jdGlvbihjYWxsYmFjaywgcXVp ZXQpCiB7Ci0gICAgSW5zcGVjdG9yVGVzdC5fcXVpZXQgPSBxdWlldDsKKyAgICBpZiAocXVpZXQg IT09IHVuZGVmaW5lZCkKKyAgICAgICAgSW5zcGVjdG9yVGVzdC5fcXVpZXQgPSBxdWlldDsKICAg ICBXZWJJbnNwZWN0b3Iuc2hvd1BhbmVsKCJzY3JpcHRzIik7CiAKICAgICBpZiAoV2ViSW5zcGVj dG9yLnBhbmVscy5zY3JpcHRzLl9kZWJ1Z2dlckVuYWJsZWQpCkBAIC0yMTksNCArMjIwLDkgQEAg SW5zcGVjdG9yVGVzdC5fZmluZENoaWxkUHJvcGVydHlUcmVlRWxlbWVudCA9IGZ1bmN0aW9uKHBh cmVudCwgY2hpbGROYW1lKQogICAgIH0KIH07CiAKK0luc3BlY3RvclRlc3Quc2V0UXVpZXQgPSBm dW5jdGlvbihxdWlldCkKK3sKKyAgICBJbnNwZWN0b3JUZXN0Ll9xdWlldCA9IHF1aWV0OworfTsK KwogfTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9kZWJ1Z2dlci9kZWJ1Z2dl ci1wYXVzZS1vbi1icmVha3BvaW50LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2luc3BlY3Rv ci9kZWJ1Z2dlci9kZWJ1Z2dlci1wYXVzZS1vbi1icmVha3BvaW50LWV4cGVjdGVkLnR4dAppbmRl eCA5Yjk3MDNjLi5iODgyZDJkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZGVi dWdnZXIvZGVidWdnZXItcGF1c2Utb24tYnJlYWtwb2ludC1leHBlY3RlZC50eHQKKysrIGIvTGF5 b3V0VGVzdHMvaW5zcGVjdG9yL2RlYnVnZ2VyL2RlYnVnZ2VyLXBhdXNlLW9uLWJyZWFrcG9pbnQt ZXhwZWN0ZWQudHh0CkBAIC0xLDExICsxLDE3IEBACiBUZXN0cyB0aGF0IGRlYnVnZ2VyIHdpbGwg c3RvcCBvbiBicmVha3BvaW50LgogCiBEZWJ1Z2dlciB3YXMgZW5hYmxlZC4KKworUnVubmluZzog dGVzdFNldEJyZWFrcG9pbnQKIFNjcmlwdCBzb3VyY2Ugd2FzIHNob3duLgogU2V0IHRpbWVyIGZv ciB0ZXN0IGZ1bmN0aW9uLgogU2NyaXB0IGV4ZWN1dGlvbiBwYXVzZWQuCiBDYWxsIHN0YWNrOgot ICAgIDApIHRlc3RGdW5jdGlvbiAoZGVidWdnZXItcGF1c2Utb24tYnJlYWtwb2ludC5odG1sOjkp CisgICAgMCkgdGVzdEZ1bmN0aW9uIChkZWJ1Z2dlci1wYXVzZS1vbi1icmVha3BvaW50Lmh0bWw6 MTQpCiBTY3JpcHQgZXhlY3V0aW9uIHJlc3VtZWQuCisKK1J1bm5pbmc6IHRlc3RTZXRCcmVha3Bv aW50T25UaGVMYXN0TGluZQorQ2FsbCBzdGFjazoKKyAgICAwKSBvbmVMaW5lVGVzdEZ1bmN0aW9u IChkZWJ1Z2dlci1wYXVzZS1vbi1icmVha3BvaW50Lmh0bWw6NykKIERlYnVnZ2VyIHdhcyBkaXNh YmxlZC4KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2RlYnVnZ2VyL2RlYnVn Z2VyLXBhdXNlLW9uLWJyZWFrcG9pbnQuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9kZWJ1 Z2dlci9kZWJ1Z2dlci1wYXVzZS1vbi1icmVha3BvaW50Lmh0bWwKaW5kZXggOTA3MTI2Mi4uMTNl ZWEyZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2RlYnVnZ2VyL2RlYnVnZ2Vy LXBhdXNlLW9uLWJyZWFrcG9pbnQuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZGVi dWdnZXIvZGVidWdnZXItcGF1c2Utb24tYnJlYWtwb2ludC5odG1sCkBAIC0yLDYgKzIsMTEgQEAK IDxoZWFkPgogPHNjcmlwdCBzcmM9Ii4uLy4uL2h0dHAvdGVzdHMvaW5zcGVjdG9yL2luc3BlY3Rv ci10ZXN0LmpzIj48L3NjcmlwdD4KIDxzY3JpcHQgc3JjPSIuLi8uLi9odHRwL3Rlc3RzL2luc3Bl Y3Rvci9kZWJ1Z2dlci10ZXN0LmpzIj48L3NjcmlwdD4KKworPHNjcmlwdD4KK2Z1bmN0aW9uIG9u ZUxpbmVUZXN0RnVuY3Rpb24oKSB7IHJldHVybiAwOyB9Cis8L3NjcmlwdD4KKwogPHNjcmlwdD4K IAogZnVuY3Rpb24gdGVzdEZ1bmN0aW9uKCkKQEAgLTEyLDI1ICsxNyw1MSBAQCBmdW5jdGlvbiB0 ZXN0RnVuY3Rpb24oKQogCiB2YXIgdGVzdCA9IGZ1bmN0aW9uKCkKIHsKLSAgICBJbnNwZWN0b3JU ZXN0LnN0YXJ0RGVidWdnZXJUZXN0KHN0ZXAxKTsKLQotICAgIGZ1bmN0aW9uIHN0ZXAxKCkKLSAg ICB7Ci0gICAgICAgIEluc3BlY3RvclRlc3Quc2hvd1NjcmlwdFNvdXJjZSgiZGVidWdnZXItcGF1 c2Utb24tYnJlYWtwb2ludC5odG1sIiwgc3RlcDIpOwotICAgIH0KLQotICAgIGZ1bmN0aW9uIHN0 ZXAyKHNvdXJjZUZyYW1lKQotICAgIHsKLSAgICAgICAgSW5zcGVjdG9yVGVzdC5hZGRSZXN1bHQo IlNjcmlwdCBzb3VyY2Ugd2FzIHNob3duLiIpOwotICAgICAgICBJbnNwZWN0b3JUZXN0LnNldEJy ZWFrcG9pbnQoc291cmNlRnJhbWUsIDgsICIiLCB0cnVlKTsKLSAgICAgICAgSW5zcGVjdG9yVGVz dC5ydW5UZXN0RnVuY3Rpb25BbmRXYWl0VW50aWxQYXVzZWQoc3RlcDMpOwotICAgIH0KLQotICAg IGZ1bmN0aW9uIHN0ZXAzKGNhbGxGcmFtZXMpCi0gICAgewotICAgICAgICBJbnNwZWN0b3JUZXN0 LmNhcHR1cmVTdGFja1RyYWNlKGNhbGxGcmFtZXMpOwotICAgICAgICBJbnNwZWN0b3JUZXN0LmNv bXBsZXRlRGVidWdnZXJUZXN0KCk7Ci0gICAgfQorICAgIEluc3BlY3RvclRlc3Quc2V0UXVpZXQo dHJ1ZSk7CisgICAgSW5zcGVjdG9yVGVzdC5ydW5EZWJ1Z2dlclRlc3RTdWl0ZShbCisgICAgICAg IGZ1bmN0aW9uIHRlc3RTZXRCcmVha3BvaW50KG5leHQpCisgICAgICAgIHsKKyAgICAgICAgICAg IEluc3BlY3RvclRlc3Quc2hvd1NjcmlwdFNvdXJjZSgiZGVidWdnZXItcGF1c2Utb24tYnJlYWtw b2ludC5odG1sIiwgZGlkU2hvd1NjcmlwdFNvdXJjZSk7CisKKyAgICAgICAgICAgIGZ1bmN0aW9u IGRpZFNob3dTY3JpcHRTb3VyY2Uoc291cmNlRnJhbWUpCisgICAgICAgICAgICB7CisgICAgICAg ICAgICAgICAgSW5zcGVjdG9yVGVzdC5hZGRSZXN1bHQoIlNjcmlwdCBzb3VyY2Ugd2FzIHNob3du LiIpOworICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3Quc2V0QnJlYWtwb2ludChzb3VyY2VG cmFtZSwgMTMsICIiLCB0cnVlKTsKKyAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LnJ1blRl c3RGdW5jdGlvbkFuZFdhaXRVbnRpbFBhdXNlZChkaWRQYXVzZWQpOworICAgICAgICAgICAgfQor CisgICAgICAgICAgICBmdW5jdGlvbiBkaWRQYXVzZWQoY2FsbEZyYW1lcykKKyAgICAgICAgICAg IHsKKyAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmFkZFJlc3VsdCgiU2NyaXB0IGV4ZWN1 dGlvbiBwYXVzZWQuIik7CisgICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5jYXB0dXJlU3Rh Y2tUcmFjZShjYWxsRnJhbWVzKTsKKyAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LnJlc3Vt ZUV4ZWN1dGlvbihkaWRSZXN1bWUpOworICAgICAgICAgICAgfQorCisgICAgICAgICAgICBmdW5j dGlvbiBkaWRSZXN1bWUoKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIEluc3BlY3Rv clRlc3QuYWRkUmVzdWx0KCJTY3JpcHQgZXhlY3V0aW9uIHJlc3VtZWQuIik7CisgICAgICAgICAg ICAgICAgbmV4dCgpOworICAgICAgICAgICAgfQorICAgICAgICB9LAorCisgICAgICAgIGZ1bmN0 aW9uIHRlc3RTZXRCcmVha3BvaW50T25UaGVMYXN0TGluZShuZXh0KQorICAgICAgICB7CisgICAg ICAgICAgICBJbnNwZWN0b3JUZXN0LnNob3dTY3JpcHRTb3VyY2UoImRlYnVnZ2VyLXBhdXNlLW9u LWJyZWFrcG9pbnQuaHRtbCIsIGRpZFNob3dTY3JpcHRTb3VyY2UpOworCisgICAgICAgICAgICBm dW5jdGlvbiBkaWRTaG93U2NyaXB0U291cmNlKHNvdXJjZUZyYW1lKQorICAgICAgICAgICAgewor ICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3Quc2V0QnJlYWtwb2ludChzb3VyY2VGcmFtZSwg NiwgIiIsIHRydWUpOworICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3Qud2FpdFVudGlsUGF1 c2VkKGRpZFBhdXNlZCk7CisgICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5ldmFsdWF0ZUlu UGFnZSgic2V0VGltZW91dChvbmVMaW5lVGVzdEZ1bmN0aW9uLCAwKSIpOworICAgICAgICAgICAg fQorCisgICAgICAgICAgICBmdW5jdGlvbiBkaWRQYXVzZWQoY2FsbEZyYW1lcykKKyAgICAgICAg ICAgIHsKKyAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmNhcHR1cmVTdGFja1RyYWNlKGNh bGxGcmFtZXMpOworICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3QucmVzdW1lRXhlY3V0aW9u KG5leHQpOworICAgICAgICAgICAgfQorICAgICAgICB9CisgICAgXSk7CiB9CiAKIDwvc2NyaXB0 PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCmluZGV4IGE5NTUwNzYuLjRiYTkyMzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx MyBAQAorMjAxMS0wNi0xNyAgUGF2ZWwgUG9kaXZpbG92ICA8cG9kaXZpbG92QGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIg SW5zcGVjdG9yOiBjYW4ndCBzZXQgYnJlYWtwb2ludCBvbiB0aGUgbGFzdCBzY3JpcHQgbGluZS4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyODYxCisK KyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRGVidWdnZXJBZ2VudC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpJbnNwZWN0b3JEZWJ1Z2dlckFnZW50OjpyZXNvbHZlQnJlYWtwb2ludCk6CisK IDIwMTEtMDYtMTYgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvSW5zcGVjdG9yRGVidWdnZXJBZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvSW5zcGVjdG9yRGVidWdnZXJBZ2VudC5jcHAKaW5kZXggMDAxZDg4ZS4uZmViZDVhZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRlYnVnZ2VyQWdlbnQu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JEZWJ1Z2dlckFnZW50 LmNwcApAQCAtMjY0LDcgKzI2NCw3IEBAIFBhc3NSZWZQdHI8SW5zcGVjdG9yT2JqZWN0PiBJbnNw ZWN0b3JEZWJ1Z2dlckFnZW50OjpyZXNvbHZlQnJlYWtwb2ludChjb25zdCBTdHJpCiAgICAgaWYg KHNjcmlwdEl0ZXJhdG9yID09IG1fc2NyaXB0cy5lbmQoKSkKICAgICAgICAgcmV0dXJuIDA7CiAg ICAgU2NyaXB0JiBzY3JpcHQgPSBzY3JpcHRJdGVyYXRvci0+c2Vjb25kOwotICAgIGlmIChicmVh a3BvaW50LmxpbmVOdW1iZXIgPCBzY3JpcHQuc3RhcnRMaW5lIHx8IHNjcmlwdC5lbmRMaW5lIDw9 IGJyZWFrcG9pbnQubGluZU51bWJlcikKKyAgICBpZiAoYnJlYWtwb2ludC5saW5lTnVtYmVyIDwg c2NyaXB0LnN0YXJ0TGluZSB8fCBzY3JpcHQuZW5kTGluZSArIDEgPD0gYnJlYWtwb2ludC5saW5l TnVtYmVyKQogICAgICAgICByZXR1cm4gMDsKIAogICAgIGludCBhY3R1YWxMaW5lTnVtYmVyOwo=