62843 2011-06-16 22:51:12 -0700 WebKit Mac API calls didReceiveAuthenticationChallenge instead of didCancelAuthenticationChallenge 2011-06-18 14:04:59 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Mac Unspecified RESOLVED FIXED P2 Normal --- 1 andrew webkit-unassigned webkit.review.bot oldest_to_newest 422424 0 andrew 2011-06-16 22:51:12 -0700 WebKit Mac incorrectly calls webView:resource:didReceiveAuthenticationChallenge:fromDataSource: on WebResourceLoadDelegate instead of webView:resource:didCancelAuthenticationChallenge:fromDataSource: This appears to have been broken for a long long time, since r17396. 422425 1 97543 andrew 2011-06-16 22:53:47 -0700 Created attachment 97543 Proposed fix 422428 2 webkit.review.bot 2011-06-16 22:55:30 -0700 Attachment 97543 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/mac/ChangeLog:5: Line contains tab character. [whitespace/tab] [5] Source/WebKit/mac/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Source/WebKit/mac/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 422431 3 97544 andrew 2011-06-16 23:01:01 -0700 Created attachment 97544 Fix tabs in ChangeLog 423259 4 97544 webkit.review.bot 2011-06-18 14:04:55 -0700 Comment on attachment 97544 Fix tabs in ChangeLog Clearing flags on attachment: 97544 Committed r89207: <http://trac.webkit.org/changeset/89207> 423260 5 webkit.review.bot 2011-06-18 14:04:59 -0700 All reviewed patches have been landed. Closing bug. 97543 2011-06-16 22:53:47 -0700 2011-06-16 23:01:01 -0700 Proposed fix webkit-bug-62843.patch text/plain 1708 andrew SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5MTEzKQorKysgU291cmNlL1dlYktpdC9t YWMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDYtMTYg IEFuZHJldyBXZWxsaW5ndG9uICA8YW5kcmV3QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKwkJaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTYyODQzCisJCVdlYktpdCBNYWMgQVBJIGNhbGxzIGRpZFJlY2VpdmVBdXRoZW50 aWNhdGlvbkNoYWxsZW5nZSBpbnN0ZWFkIG9mCisJCWRpZENhbmNlbEF1dGhlbnRpY2F0aW9uQ2hh bGxlbmdlCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYlZpZXcubW06CisgICAgICAgICgtW1dlYlZp ZXcgX2NhY2hlUmVzb3VyY2VMb2FkRGVsZWdhdGVJbXBsZW1lbnRhdGlvbnNdKToKKwogMjAxMS0w Ni0xNiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAg ICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjg5MDI2LgpJbmRleDogU291cmNlL1dlYktpdC9t YWMvV2ViVmlldy9XZWJWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvbWFjL1dl YlZpZXcvV2ViVmlldy5tbQkocmV2aXNpb24gODkxMTMpCisrKyBTb3VyY2UvV2ViS2l0L21hYy9X ZWJWaWV3L1dlYlZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAgLTE2MDQsNyArMTYwNCw3IEBAIC0g KHZvaWQpX2NhY2hlUmVzb3VyY2VMb2FkRGVsZWdhdGVJbXBsZW0KICAgICAgICAgcmV0dXJuOwog ICAgIH0KIAotICAgIGNhY2hlLT5kaWRDYW5jZWxBdXRoZW50aWNhdGlvbkNoYWxsZW5nZUZ1bmMg PSBnZXRNZXRob2QoZGVsZWdhdGUsIEBzZWxlY3Rvcih3ZWJWaWV3OnJlc291cmNlOmRpZFJlY2Vp dmVBdXRoZW50aWNhdGlvbkNoYWxsZW5nZTpmcm9tRGF0YVNvdXJjZTopKTsKKyAgICBjYWNoZS0+ ZGlkQ2FuY2VsQXV0aGVudGljYXRpb25DaGFsbGVuZ2VGdW5jID0gZ2V0TWV0aG9kKGRlbGVnYXRl LCBAc2VsZWN0b3Iod2ViVmlldzpyZXNvdXJjZTpkaWRDYW5jZWxBdXRoZW50aWNhdGlvbkNoYWxs ZW5nZTpmcm9tRGF0YVNvdXJjZTopKTsKICAgICBjYWNoZS0+ZGlkRmFpbExvYWRpbmdXaXRoRXJy b3JGcm9tRGF0YVNvdXJjZUZ1bmMgPSBnZXRNZXRob2QoZGVsZWdhdGUsIEBzZWxlY3Rvcih3ZWJW aWV3OnJlc291cmNlOmRpZEZhaWxMb2FkaW5nV2l0aEVycm9yOmZyb21EYXRhU291cmNlOikpOwog ICAgIGNhY2hlLT5kaWRGaW5pc2hMb2FkaW5nRnJvbURhdGFTb3VyY2VGdW5jID0gZ2V0TWV0aG9k KGRlbGVnYXRlLCBAc2VsZWN0b3Iod2ViVmlldzpyZXNvdXJjZTpkaWRGaW5pc2hMb2FkaW5nRnJv bURhdGFTb3VyY2U6KSk7CiAgICAgY2FjaGUtPmRpZExvYWRSZXNvdXJjZUZyb21NZW1vcnlDYWNo ZUZ1bmMgPSBnZXRNZXRob2QoZGVsZWdhdGUsIEBzZWxlY3Rvcih3ZWJWaWV3OmRpZExvYWRSZXNv dXJjZUZyb21NZW1vcnlDYWNoZTpyZXNwb25zZTpsZW5ndGg6ZnJvbURhdGFTb3VyY2U6KSk7Cg== 97544 2011-06-16 23:01:01 -0700 2011-06-18 14:04:55 -0700 Fix tabs in ChangeLog webkit-bug-62843.patch text/plain 1726 andrew SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5MTEzKQorKysgU291cmNlL1dlYktpdC9t YWMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDYtMTYg IEFuZHJldyBXZWxsaW5ndG9uICA8YW5kcmV3QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTYyODQzCisgICAgICAgIFdlYktpdCBNYWMgQVBJIGNhbGxzIGRpZFJl Y2VpdmVBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSBpbnN0ZWFkIG9mCisgICAgICAgIGRpZENhbmNl bEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYlZpZXcubW06 CisgICAgICAgICgtW1dlYlZpZXcgX2NhY2hlUmVzb3VyY2VMb2FkRGVsZWdhdGVJbXBsZW1lbnRh dGlvbnNdKToKKwogMjAxMS0wNi0xNiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBn bWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjg5MDI2LgpJbmRl eDogU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQkocmV2aXNpb24gODkxMTMpCisrKyBT b3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAgLTE2 MDQsNyArMTYwNCw3IEBAIC0gKHZvaWQpX2NhY2hlUmVzb3VyY2VMb2FkRGVsZWdhdGVJbXBsZW0K ICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIGNhY2hlLT5kaWRDYW5jZWxBdXRoZW50aWNh dGlvbkNoYWxsZW5nZUZ1bmMgPSBnZXRNZXRob2QoZGVsZWdhdGUsIEBzZWxlY3Rvcih3ZWJWaWV3 OnJlc291cmNlOmRpZFJlY2VpdmVBdXRoZW50aWNhdGlvbkNoYWxsZW5nZTpmcm9tRGF0YVNvdXJj ZTopKTsKKyAgICBjYWNoZS0+ZGlkQ2FuY2VsQXV0aGVudGljYXRpb25DaGFsbGVuZ2VGdW5jID0g Z2V0TWV0aG9kKGRlbGVnYXRlLCBAc2VsZWN0b3Iod2ViVmlldzpyZXNvdXJjZTpkaWRDYW5jZWxB dXRoZW50aWNhdGlvbkNoYWxsZW5nZTpmcm9tRGF0YVNvdXJjZTopKTsKICAgICBjYWNoZS0+ZGlk RmFpbExvYWRpbmdXaXRoRXJyb3JGcm9tRGF0YVNvdXJjZUZ1bmMgPSBnZXRNZXRob2QoZGVsZWdh dGUsIEBzZWxlY3Rvcih3ZWJWaWV3OnJlc291cmNlOmRpZEZhaWxMb2FkaW5nV2l0aEVycm9yOmZy b21EYXRhU291cmNlOikpOwogICAgIGNhY2hlLT5kaWRGaW5pc2hMb2FkaW5nRnJvbURhdGFTb3Vy Y2VGdW5jID0gZ2V0TWV0aG9kKGRlbGVnYXRlLCBAc2VsZWN0b3Iod2ViVmlldzpyZXNvdXJjZTpk aWRGaW5pc2hMb2FkaW5nRnJvbURhdGFTb3VyY2U6KSk7CiAgICAgY2FjaGUtPmRpZExvYWRSZXNv dXJjZUZyb21NZW1vcnlDYWNoZUZ1bmMgPSBnZXRNZXRob2QoZGVsZWdhdGUsIEBzZWxlY3Rvcih3 ZWJWaWV3OmRpZExvYWRSZXNvdXJjZUZyb21NZW1vcnlDYWNoZTpyZXNwb25zZTpsZW5ndGg6ZnJv bURhdGFTb3VyY2U6KSk7Cg==