62802 2011-06-16 10:02:16 -0700 [GTK] Fix typos in PageClientImpl::getEditorCommandsForKeyEvent() 2011-07-06 20:53:27 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED DUPLICATE 63081 Gtk P2 Normal --- 1 cgarcia webkit-unassigned mrobinson oldest_to_newest 422015 0 cgarcia 2011-06-16 10:02:16 -0700 There are two typos there, one in the assert command that makes the build fail with --enable-debug and another one in the line to get the the even type. 422053 1 97461 cgarcia 2011-06-16 10:47:11 -0700 Created attachment 97461 Patch It also renames KeyPress as KeyUp since it's confusing to have KeyDown and KeyPress, I would use KeyPress/KeyRelease or KeyDown/KeyUp 422063 2 97461 mrobinson 2011-06-16 10:50:51 -0700 Comment on attachment 97461 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97461&action=review > Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:62 > + ASSERT(event.type() == WebEvent::KeyDown || event.type() == WebEvent::KeyUp); > + KeyBindingTranslator::EventType type = event.type() == WebEvent::KeyDown ? > + KeyBindingTranslator::KeyDown : KeyBindingTranslator::KeyUp; > m_keyBindingTranslator.getEditorCommandsForKeyEvent(const_cast<GdkEventKey*>(&event.nativeEvent()->key), type, commandList); The typo fix looks good, but a WebEvent::KeyDown and a WebEvent.KeyPress event are two very different things. 422088 3 97461 cgarcia 2011-06-16 11:16:15 -0700 Comment on attachment 97461 Patch Clearing flags, martin explained to me that keypress and keyup are actually two different things. 426852 4 98487 cgarcia 2011-06-24 05:25:20 -0700 Created attachment 98487 New patch Looking at http://trac.webkit.org/browser/trunk/Source/WebCore/dom/KeyboardEvent.cpp#L37 it seems KeyPress is WebEvent::Char. 426868 5 98487 mrobinson 2011-06-24 06:56:29 -0700 Comment on attachment 98487 New patch View in context: https://bugs.webkit.org/attachment.cgi?id=98487&action=review > Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:61 > + ASSERT(event.type() == WebEvent::KeyDown || event.type() == WebEvent::Char); > + KeyBindingTranslator::EventType type = event.type() == WebEvent::KeyDown ? I'm not sure I understand here when we generate char events on the UIProcess side and why they map to KeyDown DOM events. 431947 6 mrobinson 2011-07-04 08:50:07 -0700 Dupe of https://bugs.webkit.org/show_bug.cgi?id=63081 now? 432651 7 cgarcia 2011-07-05 23:56:55 -0700 *** This bug has been marked as a duplicate of bug 63081 *** 433215 8 98487 dbates 2011-07-06 20:53:27 -0700 Comment on attachment 98487 New patch Clearing review flag to get this out of the review queue since this bug was marked as a duplicate of bug #63081. At the time of writing, bug #63081 has a patch up for review. 97461 2011-06-16 10:47:11 -0700 2011-06-24 05:25:20 -0700 Patch wk2-typos.diff text/plain 6781 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2MjdlZDRhLi5iYTFiOWRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDYtMTYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtd IEZpeCB0eXBvcyBpbiBQYWdlQ2xpZW50SW1wbDo6Z2V0RWRpdG9yQ29tbWFuZHNGb3JLZXlFdmVu dCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Mjgw MgorCisgICAgICAgIFJlbmFtZSBLZXlQcmVzcyBhcyBLZXlVcCwgaXQncyBjb25mdXNpbmcgaGF2 aW5nIEtleURvd24gYW5kCisgICAgICAgIEtleVByZXNzLgorCisgICAgICAgICogcGxhdGZvcm0v Z3RrL0tleUJpbmRpbmdUcmFuc2xhdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OktleUJpbmRp bmdUcmFuc2xhdG9yOjpnZXRFZGl0b3JDb21tYW5kc0ZvcktleUV2ZW50KToKKyAgICAgICAgKiBw bGF0Zm9ybS9ndGsvS2V5QmluZGluZ1RyYW5zbGF0b3IuaDoKKwogMjAxMS0wNi0xNiAgU2hlcmlm ZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdl ZCwgcm9sbGluZyBvdXQgcjg5MDI1LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvQ2hh bmdlTG9nIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IDFjYWIzNTEuLjA2ODVj YjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMS0wNi0xNiAgQ2FybG9z IEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gRml4IHR5cG9zIGluIFBhZ2VDbGll bnRJbXBsOjpnZXRFZGl0b3JDb21tYW5kc0ZvcktleUV2ZW50KCkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyODAyCisKKyAgICAgICAgKiBXZWJDb3Jl U3VwcG9ydC9FZGl0b3JDbGllbnRHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpFZGl0b3JDbGll bnQ6OmhhbmRsZUtleWJvYXJkRXZlbnQpOiBVc2UgS2V5VXAgaW5zdGVhZCBvZgorICAgICAgICBL ZXlQcmVzcy4KKwogMjAxMS0wNi0xNiAgVml0YWx5IFJlcGVzaGtvICA8dml0YWx5ckBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA5MzJhM2Q4Li5kZDU1 MDlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMTEtMDYtMTYgIENhcmxvcyBHYXJj aWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIEZpeCB0eXBvcyBpbiBQYWdlQ2xpZW50SW1w bDo6Z2V0RWRpdG9yQ29tbWFuZHNGb3JLZXlFdmVudCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MjgwMgorCisgICAgICAgIEl0IGZpeGVzIHRoZSBi dWlsZCB3aXRoIC0tZW5hYmxlLWRlYnVnLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsv UGFnZUNsaWVudEltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpQYWdlQ2xpZW50SW1wbDo6Z2V0 RWRpdG9yQ29tbWFuZHNGb3JLZXlFdmVudCk6CisKKzIwMTEtMDYtMTYgIENhcmxvcyBHYXJjaWEg Q2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IFhhbiBM b3Blei4KIAogICAgICAgICBbR1RLXSBSZW1vdmUgc3VwcG9ydCBmb3IgR1RLKzIgaW4gV2ViS2l0 MgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0tleUJpbmRpbmdUcmFu c2xhdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9LZXlCaW5kaW5nVHJhbnNs YXRvci5jcHAKaW5kZXggODkwMzFjMC4uYzBmYzViOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3RrL0tleUJpbmRpbmdUcmFuc2xhdG9yLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ndGsvS2V5QmluZGluZ1RyYW5zbGF0b3IuY3BwCkBAIC0xOTgsNyArMTk4 LDcgQEAgc3RhdGljIGNvbnN0IEtleUNvbWJpbmF0aW9uRW50cnkga2V5RG93bkVudHJpZXNbXSA9 IHsKIAogLy8gVGhlc2UgY29tbWFuZHMgYXJlIHRleHQgaW5zZXJ0aW9uIGNvbW1hbmRzLCBzbyBz aG91bGQgdGFrZSBwbGFjZQogLy8gd2hpbGUgaGFuZGxpbmcgdGhlIEtleVByZXNzIGV2ZW50Lgot c3RhdGljIGNvbnN0IEtleUNvbWJpbmF0aW9uRW50cnkga2V5UHJlc3NFbnRyaWVzW10gPSB7Citz dGF0aWMgY29uc3QgS2V5Q29tYmluYXRpb25FbnRyeSBrZXlVcEVudHJpZXNbXSA9IHsKICAgICB7 IEdES19UYWIsICAgICAgIDAsICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIkluc2VydFRh YiIgICAgIH0sCiAgICAgeyBHREtfVGFiLCAgICAgICBHREtfU0hJRlRfTUFTSywgICAgICAgICAg ICAgICAgICJJbnNlcnRCYWNrdGFiIiB9LAogICAgIHsgR0RLX1RhYiwgICAgICAgMCwgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAiSW5zZXJ0VGFiIiAgICAgfSwKQEAgLTIzMywyMCArMjMz LDIwIEBAIHZvaWQgS2V5QmluZGluZ1RyYW5zbGF0b3I6OmdldEVkaXRvckNvbW1hbmRzRm9yS2V5 RXZlbnQoR2RrRXZlbnRLZXkqIGV2ZW50LCBFdmVuCiAgICAgfQogCiAgICAgREVGSU5FX1NUQVRJ Q19MT0NBTChJbnRDb25zdENoYXJIYXNoTWFwLCBrZXlEb3duQ29tbWFuZHNNYXAsICgpKTsKLSAg ICBERUZJTkVfU1RBVElDX0xPQ0FMKEludENvbnN0Q2hhckhhc2hNYXAsIGtleVByZXNzQ29tbWFu ZHNNYXAsICgpKTsKKyAgICBERUZJTkVfU1RBVElDX0xPQ0FMKEludENvbnN0Q2hhckhhc2hNYXAs IGtleVVwQ29tbWFuZHNNYXAsICgpKTsKIAogICAgIGlmIChrZXlEb3duQ29tbWFuZHNNYXAuaXNF bXB0eSgpKSB7CiAgICAgICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBHX05fRUxFTUVOVFMo a2V5RG93bkVudHJpZXMpOyBpKyspCiAgICAgICAgICAgICBrZXlEb3duQ29tbWFuZHNNYXAuc2V0 KGtleURvd25FbnRyaWVzW2ldLnN0YXRlIDw8IDE2IHwga2V5RG93bkVudHJpZXNbaV0uZ2RrS2V5 Q29kZSwga2V5RG93bkVudHJpZXNbaV0ubmFtZSk7CiAKLSAgICAgICAgZm9yICh1bnNpZ25lZCBp ID0gMDsgaSA8IEdfTl9FTEVNRU5UUyhrZXlQcmVzc0VudHJpZXMpOyBpKyspCi0gICAgICAgICAg ICBrZXlQcmVzc0NvbW1hbmRzTWFwLnNldChrZXlQcmVzc0VudHJpZXNbaV0uc3RhdGUgPDwgMTYg fCBrZXlQcmVzc0VudHJpZXNbaV0uZ2RrS2V5Q29kZSwga2V5UHJlc3NFbnRyaWVzW2ldLm5hbWUp OworICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgR19OX0VMRU1FTlRTKGtleVVwRW50 cmllcyk7IGkrKykKKyAgICAgICAgICAgIGtleVVwQ29tbWFuZHNNYXAuc2V0KGtleVVwRW50cmll c1tpXS5zdGF0ZSA8PCAxNiB8IGtleVVwRW50cmllc1tpXS5nZGtLZXlDb2RlLCBrZXlVcEVudHJp ZXNbaV0ubmFtZSk7CiAgICAgfQogCiAgICAgLy8gRm9yIGtleXByZXNzIGV2ZW50cywgd2Ugd2Fu dCBjaGFyQ29kZSgpLCBidXQga2V5Q29kZSgpIGRvZXMgdGhhdC4KICAgICBpbnQgbWFwS2V5ID0g ZXZlbnQtPnN0YXRlIDw8IDE2IHwgZXZlbnQtPmtleXZhbDsKICAgICBpZiAobWFwS2V5KSB7Ci0g ICAgICAgIEhhc2hNYXA8aW50LCBjb25zdCBjaGFyKj4qIGNvbW1hbmRNYXAgPSB0eXBlID09IEtl eURvd24gPyAgJmtleURvd25Db21tYW5kc01hcCA6ICZrZXlQcmVzc0NvbW1hbmRzTWFwOworICAg ICAgICBIYXNoTWFwPGludCwgY29uc3QgY2hhcio+KiBjb21tYW5kTWFwID0gdHlwZSA9PSBLZXlE b3duID8gICZrZXlEb3duQ29tbWFuZHNNYXAgOiAma2V5VXBDb21tYW5kc01hcDsKICAgICAgICAg aWYgKGNvbnN0IGNoYXIqIGNvbW1hbmRTdHJpbmcgPSBjb21tYW5kTWFwLT5nZXQobWFwS2V5KSkg ewogICAgICAgICAgICAgY29tbWFuZExpc3QuYXBwZW5kKGNvbW1hbmRTdHJpbmcpOyAgCiAgICAg ICAgICAgICByZXR1cm47CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsv S2V5QmluZGluZ1RyYW5zbGF0b3IuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9LZXlC aW5kaW5nVHJhbnNsYXRvci5oCmluZGV4IDA5OTFhNDQuLmM4MmQ1ZGUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9LZXlCaW5kaW5nVHJhbnNsYXRvci5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9LZXlCaW5kaW5nVHJhbnNsYXRvci5oCkBAIC0zMSw3 ICszMSw3IEBAIGNsYXNzIEtleUJpbmRpbmdUcmFuc2xhdG9yIHsKIHB1YmxpYzoKICAgICBLZXlC aW5kaW5nVHJhbnNsYXRvcigpOwogCi0gICAgZW51bSBFdmVudFR5cGUgeyBLZXlEb3duLCBLZXlQ cmVzcyB9OworICAgIGVudW0gRXZlbnRUeXBlIHsgS2V5RG93biwgS2V5VXAgfTsKICAgICB2b2lk IGdldEVkaXRvckNvbW1hbmRzRm9yS2V5RXZlbnQoR2RrRXZlbnRLZXkqLCBFdmVudFR5cGUsIFZl Y3RvcjxXVEY6OlN0cmluZz4mKTsKICAgICB2b2lkIGFkZFBlbmRpbmdFZGl0b3JDb21tYW5kKGNv bnN0IGNoYXIqIGNvbW1hbmQpIHsgbV9wZW5kaW5nRWRpdG9yQ29tbWFuZHMuYXBwZW5kKFdURjo6 U3RyaW5nKGNvbW1hbmQpKTsgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJD b3JlU3VwcG9ydC9FZGl0b3JDbGllbnRHdGsuY3BwIGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29y ZVN1cHBvcnQvRWRpdG9yQ2xpZW50R3RrLmNwcAppbmRleCBiZDY1YmMyLi4xYTI4NjU3IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRHdGsu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEd0 ay5jcHAKQEAgLTQ5Nyw3ICs0OTcsNyBAQCB2b2lkIEVkaXRvckNsaWVudDo6aGFuZGxlS2V5Ym9h cmRFdmVudChLZXlib2FyZEV2ZW50KiBldmVudCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgS2V5 QmluZGluZ1RyYW5zbGF0b3I6OkV2ZW50VHlwZSB0eXBlID0gZXZlbnQtPnR5cGUoKSA9PSBldmVu dE5hbWVzKCkua2V5ZG93bkV2ZW50ID8KLSAgICAgICAgS2V5QmluZGluZ1RyYW5zbGF0b3I6Oktl eURvd24gOiBLZXlCaW5kaW5nVHJhbnNsYXRvcjo6S2V5UHJlc3M7CisgICAgICAgIEtleUJpbmRp bmdUcmFuc2xhdG9yOjpLZXlEb3duIDogS2V5QmluZGluZ1RyYW5zbGF0b3I6OktleVVwOwogICAg IG1fa2V5QmluZGluZ1RyYW5zbGF0b3IuZ2V0RWRpdG9yQ29tbWFuZHNGb3JLZXlFdmVudChwbGF0 Zm9ybUV2ZW50LT5nZGtFdmVudEtleSgpLCB0eXBlLCBtX3BlbmRpbmdFZGl0b3JDb21tYW5kcyk7 CiAgICAgaWYgKG1fcGVuZGluZ0VkaXRvckNvbW1hbmRzLnNpemUoKSA+IDApIHsKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwuY3Bw IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwuY3BwCmlu ZGV4IDdhMjRmZjAuLmQ2YmFiYzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5jcHAKQEAgLTU2LDkgKzU2LDkgQEAgUGFnZUNsaWVu dEltcGw6On5QYWdlQ2xpZW50SW1wbCgpCiAKIHZvaWQgUGFnZUNsaWVudEltcGw6OmdldEVkaXRv ckNvbW1hbmRzRm9yS2V5RXZlbnQoY29uc3QgTmF0aXZlV2ViS2V5Ym9hcmRFdmVudCYgZXZlbnQs IFZlY3RvcjxXVEY6OlN0cmluZz4mIGNvbW1hbmRMaXN0KQogewotICAgIEFTU0VSVChldmVudC50 eXBlID09IFdlYkV2ZW50OjpLZXlEb3duIHx8IGV2ZW50LnR5cGUgPT0gV2ViRXZlbnQuS2V5UHJl c3MpOwotICAgIEtleUJpbmRpbmdUcmFuc2xhdG9yOjpFdmVudFR5cGUgdHlwZSA9IFdlYkV2ZW50 OjpLZXlEb3duID8gCi0gICAgICAgIEtleUJpbmRpbmdUcmFuc2xhdG9yOjpLZXlEb3duIDogS2V5 QmluZGluZ1RyYW5zbGF0b3I6OktleVByZXNzOworICAgIEFTU0VSVChldmVudC50eXBlKCkgPT0g V2ViRXZlbnQ6OktleURvd24gfHwgZXZlbnQudHlwZSgpID09IFdlYkV2ZW50OjpLZXlVcCk7Cisg ICAgS2V5QmluZGluZ1RyYW5zbGF0b3I6OkV2ZW50VHlwZSB0eXBlID0gZXZlbnQudHlwZSgpID09 IFdlYkV2ZW50OjpLZXlEb3duID8KKyAgICAgICAgS2V5QmluZGluZ1RyYW5zbGF0b3I6OktleURv d24gOiBLZXlCaW5kaW5nVHJhbnNsYXRvcjo6S2V5VXA7CiAgICAgbV9rZXlCaW5kaW5nVHJhbnNs YXRvci5nZXRFZGl0b3JDb21tYW5kc0ZvcktleUV2ZW50KGNvbnN0X2Nhc3Q8R2RrRXZlbnRLZXkq PigmZXZlbnQubmF0aXZlRXZlbnQoKS0+a2V5KSwgdHlwZSwgY29tbWFuZExpc3QpOwogfQogCg== 98487 2011-06-24 05:25:20 -0700 2011-07-06 20:53:27 -0700 New patch wk2-typos-page-client-impl2.diff text/plain 1566 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjNDU4NmE0Li5lNjc5MGNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDYtMjQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtd IEZpeCB0eXBvcyBpbiBQYWdlQ2xpZW50SW1wbDo6Z2V0RWRpdG9yQ29tbWFuZHNGb3JLZXlFdmVu dCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Mjgw MgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwuY3BwOgorICAg ICAgICAoV2ViS2l0OjpQYWdlQ2xpZW50SW1wbDo6Z2V0RWRpdG9yQ29tbWFuZHNGb3JLZXlFdmVu dCk6CisKIDIwMTEtMDYtMjMgSmFtaWUgQ29vbGV5ICA8amFtZXMuY29vbGV5QG5va2lhLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5nLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwuY3BwIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwuY3BwCmluZGV4IGFiNTY0NmYu Ljk5NDAwM2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1Bh Z2VDbGllbnRJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9Q YWdlQ2xpZW50SW1wbC5jcHAKQEAgLTU3LDggKzU3LDggQEAgUGFnZUNsaWVudEltcGw6On5QYWdl Q2xpZW50SW1wbCgpCiAKIHZvaWQgUGFnZUNsaWVudEltcGw6OmdldEVkaXRvckNvbW1hbmRzRm9y S2V5RXZlbnQoY29uc3QgTmF0aXZlV2ViS2V5Ym9hcmRFdmVudCYgZXZlbnQsIFZlY3RvcjxXVEY6 OlN0cmluZz4mIGNvbW1hbmRMaXN0KQogewotICAgIEFTU0VSVChldmVudC50eXBlID09IFdlYkV2 ZW50OjpLZXlEb3duIHx8IGV2ZW50LnR5cGUgPT0gV2ViRXZlbnQuS2V5UHJlc3MpOwotICAgIEtl eUJpbmRpbmdUcmFuc2xhdG9yOjpFdmVudFR5cGUgdHlwZSA9IFdlYkV2ZW50OjpLZXlEb3duID8g CisgICAgQVNTRVJUKGV2ZW50LnR5cGUoKSA9PSBXZWJFdmVudDo6S2V5RG93biB8fCBldmVudC50 eXBlKCkgPT0gV2ViRXZlbnQ6OkNoYXIpOworICAgIEtleUJpbmRpbmdUcmFuc2xhdG9yOjpFdmVu dFR5cGUgdHlwZSA9IGV2ZW50LnR5cGUoKSA9PSBXZWJFdmVudDo6S2V5RG93biA/CiAgICAgICAg IEtleUJpbmRpbmdUcmFuc2xhdG9yOjpLZXlEb3duIDogS2V5QmluZGluZ1RyYW5zbGF0b3I6Oktl eVByZXNzOwogICAgIG1fa2V5QmluZGluZ1RyYW5zbGF0b3IuZ2V0RWRpdG9yQ29tbWFuZHNGb3JL ZXlFdmVudChjb25zdF9jYXN0PEdka0V2ZW50S2V5Kj4oJmV2ZW50Lm5hdGl2ZUV2ZW50KCktPmtl eSksIHR5cGUsIGNvbW1hbmRMaXN0KTsKIH0K