62800 2011-06-16 09:24:25 -0700 HTMLTable should cache its 'rows' collection results 2011-06-16 18:08:53 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED http://code.google.com/p/chromium/issues/attachmentText?id=73106&aid=541403547953126335&name=chromium-bugreport.txt P2 Normal --- 1 jchaffraix jchaffraix darin webkit.review.bot oldest_to_newest 421996 0 jchaffraix 2011-06-16 09:24:25 -0700 This stems from http://code.google.com/p/chromium/issues/detail?id=73120 The test page is a 22k table. Some JS code is calling table.rows for each element at least twice. Currently, we create a new HTMLTableRowsCollection every time table.rows is called. This means that the length is potentially recalculated every time table.rows is used. In the example, the DOM is not mutated so we could potentially reuse the CollectionCache to avoid the bad behavior. Patch forthcoming. 421997 1 97451 jchaffraix 2011-06-16 09:34:40 -0700 Created attachment 97451 Patch 421999 2 97451 darin 2011-06-16 09:37:45 -0700 Comment on attachment 97451 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97451&action=review > Source/WebCore/html/HTMLTableElement.cpp:630 > + m_collectionCache = adoptPtr(new CollectionCache()); I usually don’t put in the parentheses in cases like this. 422002 3 97451 webkit.review.bot 2011-06-16 09:50:31 -0700 Comment on attachment 97451 Patch Clearing flags on attachment: 97451 Committed r89035: <http://trac.webkit.org/changeset/89035> 422003 4 webkit.review.bot 2011-06-16 09:50:35 -0700 All reviewed patches have been landed. Closing bug. 422365 5 darin 2011-06-16 18:04:18 -0700 I am seeing crashes when running dom/html/level2/html/HTMLCollection01.html and other tests now. Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000098 0 com.apple.WebCore 0x000000010fe13478 WTF::OwnPtr<WebCore::CollectionCache>::operator!() const + 8 (OwnPtr.h:65) 1 com.apple.WebCore 0x000000010fe8b0e9 WebCore::HTMLTableElement::collectionCache() const + 41 (HTMLTableElement.cpp:629) 2 com.apple.WebCore 0x000000010fe8ed18 WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection(WTF::PassRefPtr<WebCore::HTMLTableElement>) + 72 (HTMLTableRowsCollection.cpp:153) Caused by this patch? 422367 6 darin 2011-06-16 18:08:53 -0700 Yup, this patch makes incorrect use of PassRefPtr. 97451 2011-06-16 09:34:40 -0700 2011-06-16 09:50:31 -0700 Patch bug-62800-20110616093438.patch text/plain 6086 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogODg5NzAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwOWNiN2Y0M2RmYjUzOTEzYjU1MTNk Nzk5ZTNjY2M4Nzg2ZWNmMDljLi40YjliNTEwMTIwZDI0MGM3MGE1NzYzNjk3ZjE3YzcyNzcyZjA5 Yjc1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMTYgIEp1bGllbiBDaGFmZnJhaXgg IDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgSFRNTFRhYmxlIHNob3VsZCBjYWNoZSBpdHMgJ3Jvd3MnIGNvbGxl Y3Rpb24gcmVzdWx0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjI4MDAKKworICAgICAgICAqIHBlcmYvdGFibGUtcm93cy1sZW5ndGgtY2FjaGluZy1l eHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHBlcmYvdGFibGUtcm93cy1sZW5ndGgtY2Fj aGluZy5odG1sOiBBZGRlZC4KKyAgICAgICAgVGhpcyB0ZXN0IGNoZWNrcyB0aGF0IHRoZSBjYWxs IHRvIHRhYmxlLnJvd3MgaXMgQ09OU1RBTlQgb25jZSBpdCBoYXMKKyAgICAgICAgYmVlbiBwb3B1 bGF0ZWQgb25jZSAoYW5kIHRoZSBET00gaXMgbm90IG11dGF0ZWQpLgorCiAyMDExLTA2LTE1ICBT dGVwaGVuIFdoaXRlICA8c2Vub3JibGFuY29AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2 aWV3ZWQ7IG5ldyBjaHJvbWl1bSB0ZXN0IGJhc2VsaW5lcy4KZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL3BlcmYvdGFibGUtcm93cy1sZW5ndGgtY2FjaGluZy1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9wZXJmL3RhYmxlLXJvd3MtbGVuZ3RoLWNhY2hpbmctZXhwZWN0ZWQudHh0Cm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAuLjA5MmI1NWRlNzViOWZlMWJiODRjMjZmZDQ3ZjMyNTQ1NDg4NDY4NWEKLS0tIC9kZXYvbnVs bAorKysgYi9MYXlvdXRUZXN0cy9wZXJmL3RhYmxlLXJvd3MtbGVuZ3RoLWNhY2hpbmctZXhwZWN0 ZWQudHh0CkBAIC0wLDAgKzEsMyBAQAorVGVzdHMgdGhhdCBjaGVjayB0aGF0IHRhYmxlLnJvdy5s ZW5ndGggaXMgcHJvcGVybHkgY2FjaGVkCitQQVNTCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L3BlcmYvdGFibGUtcm93cy1sZW5ndGgtY2FjaGluZy5odG1sIGIvTGF5b3V0VGVzdHMvcGVyZi90 YWJsZS1yb3dzLWxlbmd0aC1jYWNoaW5nLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZTEzNGU5YmEzNGQwMGZl NmExYzNiY2U4OGQyMzlmNTMxZGM0MDAzOQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L3BlcmYvdGFibGUtcm93cy1sZW5ndGgtY2FjaGluZy5odG1sCkBAIC0wLDAgKzEsNDMgQEAKKzwh RE9DVFlQRSBodG1sPgorPGh0bWw+Cis8Ym9keT4KKzxkaXYgaWQ9J3NhbmRib3gnPjwvZGl2Pgor PGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL21hZ25p dHVkZS1wZXJmLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CisKK2lmICh3aW5kb3cubGF5b3V0VGVz dENvbnRyb2xsZXIpCisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCit2 YXIgdGFibGU7Cit2YXIgc2FuZGJveCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdzYW5kYm94 Jyk7CisKKy8vIENoZWNrIHRoYXQgdGFibGUucm93cy5sZW5ndGggaXMgcHJvcGVybHkgY2FjaGVk LgorCitmdW5jdGlvbiBzZXR1cFRhYmxlUm93cyhtYWduaXR1ZGUpCit7CisgICAgaWYgKHNhbmRi b3guZmlyc3RDaGlsZCkKKyAgICAgICAgc2FuZGJveC5yZW1vdmVDaGlsZChzYW5kYm94LmZpcnN0 Q2hpbGQpOworICAgIHRhYmxlID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgndGFibGUnKTsKKwor ICAgIGZvciAodmFyIGkgPSAwOyBpIDwgbWFnbml0dWRlOyArK2kpIHsKKyAgICAgICAgdmFyIHRy ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgndHInKTsKKyAgICAgICAgdGFibGUuYXBwZW5kQ2hp bGQodHIpOworICAgIH0KKyAgICBzYW5kYm94LmFwcGVuZENoaWxkKHRhYmxlKTsKKworICAgIC8v IE1ha2Ugc3VyZSB3ZSBoYXZlIGNhY2hlZCB0aGUgbGVuZ3RoIGJlZm9yZSB0ZXN0aW5nIQorICAg IHRhYmxlLnJvd3MubGVuZ3RoOworfQorCitmdW5jdGlvbiB0ZXN0VGFibGVSb3dzKG1hZ25pdHVk ZSkKK3sKKyAgICB0YWJsZS5yb3dzLmxlbmd0aDsKK30KKworTWFnbml0dWRlLmRlc2NyaXB0aW9u KCdUZXN0cyB0aGF0IGNoZWNrIHRoYXQgdGFibGUucm93Lmxlbmd0aCBpcyBwcm9wZXJseSBjYWNo ZWQnKTsKK01hZ25pdHVkZS5ydW4oc2V0dXBUYWJsZVJvd3MsIHRlc3RUYWJsZVJvd3MsIE1hZ25p dHVkZS5DT05TVEFOVCk7CitzYW5kYm94LnJlbW92ZUNoaWxkKHNhbmRib3guZmlyc3RDaGlsZCk7 Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjY2VhMGQ0ZjIxMWFi NTJjNTNhMjJhYTQ4ZGU2Njc2NTNkZDA1MzU0Li41NmUzNWU3OWVmOTQ1MDNjM2EyMTAyYzhjMWVj OTc5YWQ4Mzg0YTU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzAgQEAKKzIwMTEtMDYtMTYgIEp1 bGllbiBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSFRNTFRhYmxlIHNob3VsZCBjYWNoZSBp dHMgJ3Jvd3MnIGNvbGxlY3Rpb24gcmVzdWx0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjI4MDAKKworICAgICAgICBUZXN0OiBwZXJmL3RhYmxlLXJv d3MtbGVuZ3RoLWNhY2hpbmcuaHRtbAorCisgICAgICAgIEN1cnJlbnRseSBhbGwgb3VyIEhUTUxD b2xsZWN0aW9uJ3MgYXJlIHJlY3JlYXRlZCBvbiBjYWxsLiBUaGlzIG1lYW5zIHRoYXQKKyAgICAg ICAgd2UgZG9uJ3QgY2FjaGUgdGhlIGluZm9ybWF0aW9uIGFib3V0IHRoZSBjb2xsZWN0aW9uIGJl dHdlZW4gY2FsbHMgdG8sIGZvcgorICAgICAgICBleGFtcGxlLCB0YWJsZS5yb3dzLgorCisgICAg ICAgIFRoaXMgY2hhbmdlIGFkZHMgYSBDb2xsZWN0aW9uQ2FjaGUgdG8gSFRNTFRhYmxlRWxlbWVu dC4gSXQgaXMgc2ltaWxhciB0byB3aGF0CisgICAgICAgIGlzIGRvbmUgZm9yIEhUTUxGb3JtRWxl bWVudC4KKworICAgICAgICAqIGh0bWwvSFRNTFRhYmxlRWxlbWVudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpIVE1MVGFibGVFbGVtZW50Ojpjb2xsZWN0aW9uQ2FjaGUpOiBUaGlzIG1ldGhvZCBk b2VzCisgICAgICAgIGxhenkgaW5pdGlhbGl6YXRpb24gb2YgdGhlIHRhYmxlJ3MgY29sbGVjdGlv bkNhY2hlLgorICAgICAgICAqIGh0bWwvSFRNTFRhYmxlRWxlbWVudC5oOiBBZGRlZCBhIG5ldyBt ZW1iZXIgYW5kIHRoZSBwcmV2aW91cworICAgICAgICBtZXRob2QuCisKKyAgICAgICAgKiBodG1s L0hUTUxUYWJsZVJvd3NDb2xsZWN0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxUYWJs ZVJvd3NDb2xsZWN0aW9uOjpIVE1MVGFibGVSb3dzQ29sbGVjdGlvbik6IFBhc3MKKyAgICAgICAg dGhlIEhUTUxUYWJsZUVsZW1lbnQncyBDb2xsZWN0aW9uQ2FjaGUgc28gdGhhdCB3ZSByZXVzZSB0 aGUgY2FjaGVkCisgICAgICAgIHJlc3VsdHMuCisKIDIwMTEtMDYtMTUgIEVyaWMgQ2FybHNvbiAg PGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGV5IFBy b3NrdXJ5YWtvdi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRhYmxlRWxl bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUYWJsZUVsZW1lbnQuY3BwCmluZGV4 IGU1NTQ2MjAzMzQ5M2JlOGQxNzhjY2JlZjZhNTNiMzVmZjBhN2I2NGQuLjU5YjA2M2E0NmU0MmI3 M2RhYjc4NzU2MWIwZDIzMTk2MzkwOWU5ZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTFRhYmxlRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGFi bGVFbGVtZW50LmNwcApAQCAtNjI0LDYgKzYyNCwxNCBAQCB2b2lkIEhUTUxUYWJsZUVsZW1lbnQ6 OmFkZFNoYXJlZEdyb3VwRGVjbHMoYm9vbCByb3dzLCBWZWN0b3I8Q1NTTXV0YWJsZVN0eWxlRGVj bAogICAgIHJlc3VsdHMuYXBwZW5kKGRlY2wpOwogfQogCitDb2xsZWN0aW9uQ2FjaGUqIEhUTUxU YWJsZUVsZW1lbnQ6OmNvbGxlY3Rpb25DYWNoZSgpIGNvbnN0Cit7CisgICAgaWYgKCFtX2NvbGxl Y3Rpb25DYWNoZSkKKyAgICAgICAgbV9jb2xsZWN0aW9uQ2FjaGUgPSBhZG9wdFB0cihuZXcgQ29s bGVjdGlvbkNhY2hlKCkpOworCisgICAgcmV0dXJuIG1fY29sbGVjdGlvbkNhY2hlLmdldCgpOwor fQorCiB2b2lkIEhUTUxUYWJsZUVsZW1lbnQ6OmF0dGFjaCgpCiB7CiAgICAgQVNTRVJUKCFhdHRh Y2hlZCgpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRhYmxlRWxlbWVu dC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGFibGVFbGVtZW50LmgKaW5kZXggZGEzZGMz MDNmZDRhN2Q1OGZiYWFlMmYwOWM1OTc1Njg2ZmUzOGJmMi4uMDVlMzQ4NjEzNGYwZmI3ZmM4ZGVh YTM0NjgzNmZhYTAyYzc0ZWMwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M VGFibGVFbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGFibGVFbGVtZW50 LmgKQEAgLTY4LDYgKzY4LDggQEAgcHVibGljOgogICAgIHZvaWQgYWRkU2hhcmVkQ2VsbERlY2xz KFZlY3RvcjxDU1NNdXRhYmxlU3R5bGVEZWNsYXJhdGlvbio+Jik7CiAgICAgdm9pZCBhZGRTaGFy ZWRHcm91cERlY2xzKGJvb2wgcm93cywgVmVjdG9yPENTU011dGFibGVTdHlsZURlY2xhcmF0aW9u Kj4mKTsKIAorICAgIENvbGxlY3Rpb25DYWNoZSogY29sbGVjdGlvbkNhY2hlKCkgY29uc3Q7CisK IHByaXZhdGU6CiAgICAgSFRNTFRhYmxlRWxlbWVudChjb25zdCBRdWFsaWZpZWROYW1lJiwgRG9j dW1lbnQqKTsKIApAQCAtMTAwLDYgKzEwMiw3IEBAIHByaXZhdGU6CiAKICAgICB1bnNpZ25lZCBz aG9ydCBtX3BhZGRpbmc7CiAgICAgUmVmUHRyPENTU01hcHBlZEF0dHJpYnV0ZURlY2xhcmF0aW9u PiBtX3BhZGRpbmdEZWNsOworICAgIG11dGFibGUgT3duUHRyPENvbGxlY3Rpb25DYWNoZT4gbV9j b2xsZWN0aW9uQ2FjaGU7CiB9OwogCiB9IC8vbmFtZXNwYWNlCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxUYWJsZVJvd3NDb2xsZWN0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTFRhYmxlUm93c0NvbGxlY3Rpb24uY3BwCmluZGV4IDIwMTQzZDliNTllODJjNWI1 OTEwNjMxMjIyZjlmNWIxYTA2MGVjMTguLjQ2ODFhODVmNjdiYjRiYzM3ODI0ODFkZWZlNzc5YjMx NTY2OGFkNzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRhYmxlUm93c0Nv bGxlY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRhYmxlUm93c0NvbGxl Y3Rpb24uY3BwCkBAIC0xNDksNyArMTQ5LDcgQEAgSFRNTFRhYmxlUm93RWxlbWVudCogSFRNTFRh YmxlUm93c0NvbGxlY3Rpb246Omxhc3RSb3coSFRNTFRhYmxlRWxlbWVudCogdGFibGUpCiB9CiAK IEhUTUxUYWJsZVJvd3NDb2xsZWN0aW9uOjpIVE1MVGFibGVSb3dzQ29sbGVjdGlvbihQYXNzUmVm UHRyPEhUTUxUYWJsZUVsZW1lbnQ+IHRhYmxlKQotICAgIDogSFRNTENvbGxlY3Rpb24odGFibGUs IE90aGVyQ29sbGVjdGlvbiwgMCkKKyAgICA6IEhUTUxDb2xsZWN0aW9uKHRhYmxlLCBPdGhlckNv bGxlY3Rpb24sIHRhYmxlLT5jb2xsZWN0aW9uQ2FjaGUoKSkKIHsKIH0KIAo=