62792 2011-06-16 02:03:47 -0700 Add an assertion that percent height box is unregistered correctly 2011-07-05 02:31:42 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 1 tkent tkent dglazkov jamesr mitz webkit.review.bot oldest_to_newest 421867 0 tkent 2011-06-16 02:03:47 -0700 gPercentHeightDescendantsMap in RenderBlock tracks boxes with a percent height. It would be possible that gPercentHeightDescendantsMap contains a stale pointer if a height of a RenderStyle was updated in layout(). I don't think we have such code at this moment. I had this problem with my local change. 421868 1 97424 tkent 2011-06-16 02:07:56 -0700 Created attachment 97424 Patch 432111 2 97424 morrita 2011-07-04 23:18:58 -0700 Comment on attachment 97424 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97424&action=review > Source/WebCore/rendering/RenderBlock.cpp:3424 > +#ifndef NDEBUG I found that we have a preprocessor symbol called ASSERT_DISABLED. 432159 3 99680 tkent 2011-07-05 01:44:20 -0700 Created attachment 99680 Patch 2 Chekcs ASSERT_DISABLED 432161 4 97424 tkent 2011-07-05 01:45:43 -0700 Comment on attachment 97424 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97424&action=review >> Source/WebCore/rendering/RenderBlock.cpp:3424 >> +#ifndef NDEBUG > > I found that we have a preprocessor symbol called ASSERT_DISABLED. Yes, ASSERT_DISABLED is better. I have updated the patch. 432164 5 99680 morrita 2011-07-05 01:49:30 -0700 Comment on attachment 99680 Patch 2 Assertion failure should be better than use-after-free. 432174 6 99680 webkit.review.bot 2011-07-05 02:31:37 -0700 Comment on attachment 99680 Patch 2 Clearing flags on attachment: 99680 Committed r90388: <http://trac.webkit.org/changeset/90388> 432175 7 webkit.review.bot 2011-07-05 02:31:42 -0700 All reviewed patches have been landed. Closing bug. 97424 2011-06-16 02:07:56 -0700 2011-07-05 01:45:43 -0700 Patch bug-62792-20110616180754.patch text/plain 3623 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogODkwMDUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiMTJjZDM3MTZhNWE3ZTk3 OWI1OGQwMTM1NzA4ZTNmYzY4MTQyZTg5Li42OWY2NWQ2MzNhYmJjNTdhOThlZDNhYTFhZDlhMmRl ZWNkMDdjYjJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDYtMTYgIEtlbnQg VGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhbiBhc3NlcnRpb24gdGhhdCBwZXJjZW50IGhlaWdo dCBib3ggaXMgdW5yZWdpc3RlcmVkIGNvcnJlY3RseS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyNzkyCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBU aGlzIHdvbid0IGNoYW5nZSBiZWhhdmlvci4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJC bG9jay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6aGFzUGVyY2VudEhlaWdo dERlc2NlbmRhbnQpOiBBZGRlZC4KKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2suaDog RGVjbGFyZSBoYXNQZXJjZW50SGVpZ2h0RGVzY2VuZGFudCgpLgorICAgICAgICAqIHJlbmRlcmlu Zy9SZW5kZXJCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQm94OjpkZXN0cm95KTog QXNzZXJ0ICFoYXNQZXJjZW50SGVpZ2h0RGVzY2VuZGFudCgpLgorCiAyMDExLTA2LTE1ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gIChUZWNo bmljYWxseSBJIHNob3VsZCBnZXQgdGhpcyByZXZpZXdlZCwgYnV0IEkKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCmluZGV4IDFmMzUzNDI0NzkxYTM0YTc5MDY4ZGM1ZDgx YTM1Nzk0MmM3Njg4OGEuLjlmZDVjMGY0YzY1NjIxNzhiMjU4OWY5NmY5NjlkMzdkYTk1ZmU3MWQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcApAQCAtMzQyMSw2ICsz NDIxLDE5IEBAIEhhc2hTZXQ8UmVuZGVyQm94Kj4qIFJlbmRlckJsb2NrOjpwZXJjZW50SGVpZ2h0 RGVzY2VuZGFudHMoKSBjb25zdAogICAgIHJldHVybiBnUGVyY2VudEhlaWdodERlc2NlbmRhbnRz TWFwID8gZ1BlcmNlbnRIZWlnaHREZXNjZW5kYW50c01hcC0+Z2V0KHRoaXMpIDogMDsKIH0KIAor I2lmbmRlZiBOREVCVUcKK2Jvb2wgUmVuZGVyQmxvY2s6Omhhc1BlcmNlbnRIZWlnaHREZXNjZW5k YW50KFJlbmRlckJveCogZGVzY2VuZGFudCkKK3sKKyAgICBBU1NFUlQoZGVzY2VuZGFudCk7Cisg ICAgaWYgKCFnUGVyY2VudEhlaWdodENvbnRhaW5lck1hcCkKKyAgICAgICAgcmV0dXJuIGZhbHNl OworICAgIEhhc2hTZXQ8UmVuZGVyQmxvY2sqPiogY29udGFpbmVyU2V0ID0gZ1BlcmNlbnRIZWln aHRDb250YWluZXJNYXAtPnRha2UoZGVzY2VuZGFudCk7CisgICAgaWYgKCFjb250YWluZXJTZXQg fHwgIWNvbnRhaW5lclNldC0+c2l6ZSgpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgcmV0 dXJuIHRydWU7Cit9CisjZW5kaWYKKwogLy8gRklYTUU6IFRoZSBsb2dpY2FsTGVmdE9mZnNldEZv ckxpbmUvbG9naWNhbFJpZ2h0T2Zmc2V0Rm9yTGluZSBmdW5jdGlvbnMgYXJlIHZlcnkgc2xvdyBp ZiB0aGVyZSBhcmUgbWFueSBmbG9hdHMKIC8vIHByZXNlbnQuIFdlIG5lZWQgdG8gYWRkIGEgc3Ry dWN0dXJlIHRvIGZsb2F0aW5nIG9iamVjdHMgdG8gcmVwcmVzZW50ICJsaW5lcyIgb2YgZmxvYXRz LiAgVGhlbiBpbnN0ZWFkIG9mIGNoZWNraW5nCiAvLyBlYWNoIGZsb2F0IGluZGl2aWR1YWxseSwg d2UnZCBqdXN0IHdhbGsgYmFja3dhcmRzIHRocm91Z2ggdGhlICJsaW5lcyIgYW5kIHN0b3Agd2hl biB3ZSBoaXQgYSBsaW5lIHRoYXQgaXMgZnVsbHkgYWJvdmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJsb2NrLmgKaW5kZXggNWU4NjU1ZmNhNDM5YjE4YTI2ODg3ZDQ4OGVjZGRlYjM0NTAy NDY3ZC4uZmM5YWM5ZGY4Y2I4NGZkMDBkZjYzNjUzYWFmM2Q5YzY1MTY5ZGZlNSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmgKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmgKQEAgLTEwMiw2ICsxMDIsOSBAQCBwdWJsaWM6 CiAgICAgdm9pZCBhZGRQZXJjZW50SGVpZ2h0RGVzY2VuZGFudChSZW5kZXJCb3gqKTsKICAgICBz dGF0aWMgdm9pZCByZW1vdmVQZXJjZW50SGVpZ2h0RGVzY2VuZGFudChSZW5kZXJCb3gqKTsKICAg ICBIYXNoU2V0PFJlbmRlckJveCo+KiBwZXJjZW50SGVpZ2h0RGVzY2VuZGFudHMoKSBjb25zdDsK KyNpZm5kZWYgTkRFQlVHCisgICAgc3RhdGljIGJvb2wgaGFzUGVyY2VudEhlaWdodERlc2NlbmRh bnQoUmVuZGVyQm94Kik7CisjZW5kaWYKIAogICAgIFJvb3RJbmxpbmVCb3gqIGNyZWF0ZUFuZEFw cGVuZFJvb3RJbmxpbmVCb3goKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNw cAppbmRleCA4M2EyOTc2ZmU4NjZmYzgxMmU4MGU1NjE1NzY5NmJkZTgyYzE2MjZlLi5iNDQ5NDZk YmM3NTdhNWQxODNjODg5MjcwZWFjZDJkOGMyODFjMGViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyQm94LmNwcApAQCAtMjAzLDYgKzIwMywxMCBAQCB2b2lkIFJlbmRlckJveDo6ZGVz dHJveSgpCiAKICAgICBpZiAoc3R5bGUoKSAmJiAoc3R5bGUoKS0+bG9naWNhbEhlaWdodCgpLmlz UGVyY2VudCgpIHx8IHN0eWxlKCktPmxvZ2ljYWxNaW5IZWlnaHQoKS5pc1BlcmNlbnQoKSB8fCBz dHlsZSgpLT5sb2dpY2FsTWF4SGVpZ2h0KCkuaXNQZXJjZW50KCkpKQogICAgICAgICBSZW5kZXJC bG9jazo6cmVtb3ZlUGVyY2VudEhlaWdodERlc2NlbmRhbnQodGhpcyk7CisgICAgLy8gSWYgdGhl IGZvbGxvd2luZyBhc3NlcnRpb24gZmFpbHMsIGxvZ2ljYWxIZWlnaHQoKS9sb2dpY2FsTWluSGVp Z2h0KCkvCisgICAgLy8gbG9naWNhbE1heEhlaWdodCgpIHZhbHVlcyBhcmUgY2hhbmdlZCBmcm9t IGEgcGVyY2VudCB2YWx1ZSB0byBhIG5vbi1wZXJjZW50CisgICAgLy8gdmFsdWUgZHVyaW5nIGxh eWluZyBvdXQuIEl0IGNhdXNlcyBhIHVzZS1hZnRlci1mcmVlIGJ1Zy4KKyAgICBBU1NFUlQoIVJl bmRlckJsb2NrOjpoYXNQZXJjZW50SGVpZ2h0RGVzY2VuZGFudCh0aGlzKSk7CiAKICAgICBSZW5k ZXJCb3hNb2RlbE9iamVjdDo6ZGVzdHJveSgpOwogfQo= 99680 2011-07-05 01:44:20 -0700 2011-07-05 02:31:37 -0700 Patch 2 bug-62792-20110705174418.patch text/plain 3566 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogOTAzODUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjNTg2YTI0MjFkMzZmNDdi YjM0NWExOTU2MDBjOTY4ZGJlOGI4YmMzLi4wNDliMGNmZmJlMGEyZmYwNmFiYTlmYjA3MTJjMDhk MTcwMzMwYzkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDctMDUgIEtlbnQg VGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFkZCBhbiBhc3NlcnRpb24g dGhhdCBwZXJjZW50IGhlaWdodCBib3ggaXMgdW5yZWdpc3RlcmVkIGNvcnJlY3RseS4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyNzkyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBU aGlzIHdvbid0IGNoYW5nZSBiZWhhdmlvci4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJC bG9jay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6aGFzUGVyY2VudEhlaWdo dERlc2NlbmRhbnQpOiBBZGRlZC4KKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2suaDog RGVjbGFyZSBoYXNQZXJjZW50SGVpZ2h0RGVzY2VuZGFudCgpLgorICAgICAgICAqIHJlbmRlcmlu Zy9SZW5kZXJCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQm94OjpkZXN0cm95KTog QXNzZXJ0ICFoYXNQZXJjZW50SGVpZ2h0RGVzY2VuZGFudCgpLgorCiAyMDExLTA3LTA1ICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg S2VudCBUYW11cmEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy QmxvY2suY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAppbmRl eCA3YTQzMTFmMjNkNGQwMWQxNzcxM2M5MDc5NmEzN2EyMTUyNDNiZmUxLi5iNjVkYzQwNzE0YWY0 OTY4N2Y2MzA3Yzk0N2Q0MThkMTJlM2NkYjQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCbG9jay5jcHAKQEAgLTM0NDYsNiArMzQ0NiwxNyBAQCBIYXNoU2V0PFJlbmRlckJveCo+ KiBSZW5kZXJCbG9jazo6cGVyY2VudEhlaWdodERlc2NlbmRhbnRzKCkgY29uc3QKICAgICByZXR1 cm4gZ1BlcmNlbnRIZWlnaHREZXNjZW5kYW50c01hcCA/IGdQZXJjZW50SGVpZ2h0RGVzY2VuZGFu dHNNYXAtPmdldCh0aGlzKSA6IDA7CiB9CiAKKyNpZiAhQVNTRVJUX0RJU0FCTEVECitib29sIFJl bmRlckJsb2NrOjpoYXNQZXJjZW50SGVpZ2h0RGVzY2VuZGFudChSZW5kZXJCb3gqIGRlc2NlbmRh bnQpCit7CisgICAgQVNTRVJUKGRlc2NlbmRhbnQpOworICAgIGlmICghZ1BlcmNlbnRIZWlnaHRD b250YWluZXJNYXApCisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICBIYXNoU2V0PFJlbmRlckJs b2NrKj4qIGNvbnRhaW5lclNldCA9IGdQZXJjZW50SGVpZ2h0Q29udGFpbmVyTWFwLT50YWtlKGRl c2NlbmRhbnQpOworICAgIHJldHVybiBjb250YWluZXJTZXQgJiYgY29udGFpbmVyU2V0LT5zaXpl KCk7Cit9CisjZW5kaWYKKwogLy8gRklYTUU6IFRoZSBsb2dpY2FsTGVmdE9mZnNldEZvckxpbmUv bG9naWNhbFJpZ2h0T2Zmc2V0Rm9yTGluZSBmdW5jdGlvbnMgYXJlIHZlcnkgc2xvdyBpZiB0aGVy ZSBhcmUgbWFueSBmbG9hdHMKIC8vIHByZXNlbnQuIFdlIG5lZWQgdG8gYWRkIGEgc3RydWN0dXJl IHRvIGZsb2F0aW5nIG9iamVjdHMgdG8gcmVwcmVzZW50ICJsaW5lcyIgb2YgZmxvYXRzLiAgVGhl biBpbnN0ZWFkIG9mIGNoZWNraW5nCiAvLyBlYWNoIGZsb2F0IGluZGl2aWR1YWxseSwgd2UnZCBq dXN0IHdhbGsgYmFja3dhcmRzIHRocm91Z2ggdGhlICJsaW5lcyIgYW5kIHN0b3Agd2hlbiB3ZSBo aXQgYSBsaW5lIHRoYXQgaXMgZnVsbHkgYWJvdmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJCbG9jay5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJsb2NrLmgKaW5kZXggYjIwNmUxMDRkNzI0YjUxZjQxZjIyMmEzYmM5MWNhNTRlNWMzMjE5Ny4u N2Q2OGJhM2ZkYmFmZjFmODgxNGJmZjI0ZWMwYmYxOWRhYjkzY2JhMiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmgKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckJsb2NrLmgKQEAgLTEwMiw2ICsxMDIsOSBAQCBwdWJsaWM6CiAgICAg dm9pZCBhZGRQZXJjZW50SGVpZ2h0RGVzY2VuZGFudChSZW5kZXJCb3gqKTsKICAgICBzdGF0aWMg dm9pZCByZW1vdmVQZXJjZW50SGVpZ2h0RGVzY2VuZGFudChSZW5kZXJCb3gqKTsKICAgICBIYXNo U2V0PFJlbmRlckJveCo+KiBwZXJjZW50SGVpZ2h0RGVzY2VuZGFudHMoKSBjb25zdDsKKyNpZiAh QVNTRVJUX0RJU0FCTEVECisgICAgc3RhdGljIGJvb2wgaGFzUGVyY2VudEhlaWdodERlc2NlbmRh bnQoUmVuZGVyQm94Kik7CisjZW5kaWYKIAogICAgIFJvb3RJbmxpbmVCb3gqIGNyZWF0ZUFuZEFw cGVuZFJvb3RJbmxpbmVCb3goKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNw cAppbmRleCAzYWU1Zjk3MTRmMjkxOTE1MzI0OGViNzI2MGJmMGE1ZGE1ZTBkMjZkLi4zZWYzOGMz ZTQ5NjVhNTRhNDMwODAyZmVjMTcwYTNiNDZiMDg2NzVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyQm94LmNwcApAQCAtMjAzLDYgKzIwMywxMCBAQCB2b2lkIFJlbmRlckJveDo6ZGVz dHJveSgpCiAKICAgICBpZiAoc3R5bGUoKSAmJiAoc3R5bGUoKS0+bG9naWNhbEhlaWdodCgpLmlz UGVyY2VudCgpIHx8IHN0eWxlKCktPmxvZ2ljYWxNaW5IZWlnaHQoKS5pc1BlcmNlbnQoKSB8fCBz dHlsZSgpLT5sb2dpY2FsTWF4SGVpZ2h0KCkuaXNQZXJjZW50KCkpKQogICAgICAgICBSZW5kZXJC bG9jazo6cmVtb3ZlUGVyY2VudEhlaWdodERlc2NlbmRhbnQodGhpcyk7CisgICAgLy8gSWYgdGhl IGZvbGxvd2luZyBhc3NlcnRpb24gZmFpbHMsIGxvZ2ljYWxIZWlnaHQoKS9sb2dpY2FsTWluSGVp Z2h0KCkvCisgICAgLy8gbG9naWNhbE1heEhlaWdodCgpIHZhbHVlcyBhcmUgY2hhbmdlZCBmcm9t IGEgcGVyY2VudCB2YWx1ZSB0byBhIG5vbi1wZXJjZW50CisgICAgLy8gdmFsdWUgZHVyaW5nIGxh eWluZyBvdXQuIEl0IGNhdXNlcyBhIHVzZS1hZnRlci1mcmVlIGJ1Zy4KKyAgICBBU1NFUlQoIVJl bmRlckJsb2NrOjpoYXNQZXJjZW50SGVpZ2h0RGVzY2VuZGFudCh0aGlzKSk7CiAKICAgICBSZW5k ZXJCb3hNb2RlbE9iamVjdDo6ZGVzdHJveSgpOwogfQo=