62775 2011-06-15 21:14:12 -0700 Remove ScriptController::isJavaScriptAnchorNavigation 2011-06-15 21:25:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth aestes eric jnd webkit.review.bot oldest_to_newest 421747 0 abarth 2011-06-15 21:14:12 -0700 Remove ScriptController::isJavaScriptAnchorNavigation 421750 1 97393 abarth 2011-06-15 21:15:44 -0700 Created attachment 97393 Patch 421751 2 97393 andersca 2011-06-15 21:17:50 -0700 Comment on attachment 97393 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97393&action=review > Source/WebCore/ChangeLog:8 > + This function no longer plays a roll in the user gesture code now that Typo, role. 421753 3 97394 abarth 2011-06-15 21:19:10 -0700 Created attachment 97394 Patch for landing 421754 4 abarth 2011-06-15 21:25:16 -0700 Committed r89002: <http://trac.webkit.org/changeset/89002> 97393 2011-06-15 21:15:44 -0700 2011-06-15 21:19:06 -0700 Patch bug-62775-20110615211542.patch text/plain 3728 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5MDAxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDYtMTUgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBSZW1vdmUgU2NyaXB0Q29udHJvbGxlcjo6aXNKYXZhU2NyaXB0QW5j aG9yTmF2aWdhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjI3NzUKKworICAgICAgICBUaGlzIGZ1bmN0aW9uIG5vIGxvbmdlciBwbGF5cyBhIHJv bGwgaW4gdGhlIHVzZXIgZ2VzdHVyZSBjb2RlIG5vdyB0aGF0CisgICAgICAgIHdlJ3JlIG5vdCBl bmNvZGluZyB0aGUgdXNlciBnZXN0dXJlIHN0YXRlIGludG8gdGhlIFNjcmlwdFNvdXJjZUNvZGUK KyAgICAgICAgVVJMLgorCisgICAgICAgICogYmluZGluZ3MvanMvU2NyaXB0Q29udHJvbGxlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRDb250cm9sbGVyOjpwcm9jZXNzaW5nVXNlckdl c3R1cmUpOgorICAgICAgICAqIGJpbmRpbmdzL2pzL1NjcmlwdENvbnRyb2xsZXIuaDoKKyAgICAg ICAgKiBiaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlNjcmlwdENvbnRyb2xsZXI6OnByb2Nlc3NpbmdVc2VyR2VzdHVyZSk6CisKIDIwMTEtMDYtMTUg IEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBF cmljIFNlaWRlbC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdENvbnRy b2xsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1Njcmlw dENvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiA4OTAwMSkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL2pzL1NjcmlwdENvbnRyb2xsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNTEsMTAgKzI1 MSw2IEBAIGJvb2wgU2NyaXB0Q29udHJvbGxlcjo6cHJvY2Vzc2luZ1VzZXJHZXMKICAgICBpZiAo IWZyYW1lKQogICAgICAgICByZXR1cm4gVXNlckdlc3R1cmVJbmRpY2F0b3I6OmdldFVzZXJHZXN0 dXJlU3RhdGUoKSAhPSBEZWZpbml0ZWx5Tm90UHJvY2Vzc2luZ1VzZXJHZXN0dXJlOwogCi0gICAg Ly8gRklYTUU6IFJlbW92ZSB0aGUgaXNKYXZhU2NyaXB0QW5jaG9yTmF2aWdhdGlvbiBjaGVjayBv bmNlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MjcwMiBpcyBmaXhl ZC4KLSAgICBpZiAoZnJhbWUtPnNjcmlwdCgpLT5pc0phdmFTY3JpcHRBbmNob3JOYXZpZ2F0aW9u KCkpCi0gICAgICAgIHJldHVybiB0cnVlOwotCiAgICAgLy8gSWYgYSBET00gZXZlbnQgaXMgYmVp bmcgcHJvY2Vzc2VkLCBjaGVjayB0aGF0IGl0IHdhcyBpbml0aWF0ZWQgYnkgdGhlIHVzZXIKICAg ICAvLyBhbmQgdGhhdCBpdCBpcyBpbiB0aGUgd2hpdGVsaXN0IG9mIGV2ZW50IHR5cGVzIGFsbG93 ZWQgdG8gZ2VuZXJhdGUgcG9wLXVwcy4KICAgICBpZiAoSlNET01XaW5kb3dTaGVsbCogc2hlbGwg PSBmcmFtZS0+c2NyaXB0KCktPmV4aXN0aW5nV2luZG93U2hlbGwoY3VycmVudFdvcmxkKGV4ZWMp KSkKQEAgLTI2NCwxNyArMjYwLDYgQEAgYm9vbCBTY3JpcHRDb250cm9sbGVyOjpwcm9jZXNzaW5n VXNlckdlcwogICAgIHJldHVybiBVc2VyR2VzdHVyZUluZGljYXRvcjo6cHJvY2Vzc2luZ1VzZXJH ZXN0dXJlKCk7CiB9CiAKLS8vIEZJWE1FOiBUaGlzIHNlZW1zIGxpa2UgYW4gaW5zdWZmaWNpZW50 IGNoZWNrIHRvIHZlcmlmeSBhIGNsaWNrIG9uIGEgamF2YXNjcmlwdDogYW5jaG9yLgotYm9vbCBT Y3JpcHRDb250cm9sbGVyOjppc0phdmFTY3JpcHRBbmNob3JOYXZpZ2F0aW9uKCkgY29uc3QKLXsK LSAgICAvLyBUaGlzIGlzIHRoZSA8YSBocmVmPSJqYXZhc2NyaXB0OndpbmRvdy5vcGVuKCcuLi4n KT4gY2FzZSAtPiB3ZSBsZXQgaXQgdGhyb3VnaAotICAgIGlmIChtX3NvdXJjZVVSTCAmJiBtX3Nv dXJjZVVSTC0+aXNOdWxsKCkgJiYgIW1fcHJvY2Vzc2luZ1RpbWVyQ2FsbGJhY2spCi0gICAgICAg IHJldHVybiB0cnVlOwotCi0gICAgLy8gVGhpcyBpcyB0aGUgPHNjcmlwdD53aW5kb3cub3Blbigu Li4pPC9zY3JpcHQ+IGNhc2Ugb3IgYSB0aW1lciBjYWxsYmFjayAtPiBibG9jayBpdAotICAgIHJl dHVybiBmYWxzZTsKLX0KLQogYm9vbCBTY3JpcHRDb250cm9sbGVyOjpjYW5BY2Nlc3NGcm9tQ3Vy cmVudE9yaWdpbihGcmFtZSAqZnJhbWUpCiB7CiAgICAgRXhlY1N0YXRlKiBleGVjID0gSlNNYWlu VGhyZWFkRXhlY1N0YXRlOjpjdXJyZW50U3RhdGUoKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2pzL1NjcmlwdENvbnRyb2xsZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9qcy9TY3JpcHRDb250cm9sbGVyLmgJKHJldmlzaW9uIDg5MDAxKQorKysgU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0Q29udHJvbGxlci5oCSh3b3JraW5nIGNvcHkp CkBAIC0xNjksOCArMTY5LDYgQEAgcHJpdmF0ZToKIAogICAgIHZvaWQgZGlzY29ubmVjdFBsYXRm b3JtU2NyaXB0T2JqZWN0cygpOwogCi0gICAgYm9vbCBpc0phdmFTY3JpcHRBbmNob3JOYXZpZ2F0 aW9uKCkgY29uc3Q7Ci0KICAgICBTaGVsbE1hcCBtX3dpbmRvd1NoZWxsczsKICAgICBGcmFtZSog bV9mcmFtZTsKICAgICBjb25zdCBTdHJpbmcqIG1fc291cmNlVVJMOwpJbmRleDogU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHAJKHJldmlzaW9uIDg5 MDAxKQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTE3MCwxMSArMTcwLDYgQEAgYm9vbCBTY3JpcHRDb250cm9sbGVy Ojpwcm9jZXNzaW5nVXNlckdlcwogICAgIGlmIChldmVudCkKICAgICAgICAgcmV0dXJuIGV2ZW50 LT5mcm9tVXNlckdlc3R1cmUoKTsKIAotICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhpcyBjaGVjayBv bmNlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MjcwMiBpcyBmaXhl ZC4KLSAgICBjb25zdCBTdHJpbmcqIHNvdXJjZVVSTCA9IGZpcnN0RnJhbWUtPnNjcmlwdCgpLT5z b3VyY2VVUkwoKTsKLSAgICBpZiAoc291cmNlVVJMICYmIHNvdXJjZVVSTC0+aXNOdWxsKCkgJiYg IWZpcnN0RnJhbWUtPnNjcmlwdCgpLT5wcm94eSgpLT50aW1lckNhbGxiYWNrKCkpCi0gICAgICAg IHJldHVybiB0cnVlOwotCiAgICAgcmV0dXJuIFVzZXJHZXN0dXJlSW5kaWNhdG9yOjpwcm9jZXNz aW5nVXNlckdlc3R1cmUoKTsKIH0KIAo= 97394 2011-06-15 21:19:10 -0700 2011-06-15 21:19:10 -0700 Patch for landing bug-62775-20110615211908.patch text/plain 3908 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg5MDAxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDYtMTUgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2Fy bHNzb24uCisKKyAgICAgICAgUmVtb3ZlIFNjcmlwdENvbnRyb2xsZXI6OmlzSmF2YVNjcmlwdEFu Y2hvck5hdmlnYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTYyNzc1CisKKyAgICAgICAgVGhpcyBmdW5jdGlvbiBubyBsb25nZXIgcGxheXMgYSBy b2xlIGluIHRoZSB1c2VyIGdlc3R1cmUgY29kZSBub3cgdGhhdAorICAgICAgICB3ZSdyZSBub3Qg ZW5jb2RpbmcgdGhlIHVzZXIgZ2VzdHVyZSBzdGF0ZSBpbnRvIHRoZSBTY3JpcHRTb3VyY2VDb2Rl CisgICAgICAgIFVSTC4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL1NjcmlwdENvbnRyb2xsZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0Q29udHJvbGxlcjo6cHJvY2Vzc2luZ1VzZXJH ZXN0dXJlKToKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9TY3JpcHRDb250cm9sbGVyLmg6CisgICAg ICAgICogYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpTY3JpcHRDb250cm9sbGVyOjpwcm9jZXNzaW5nVXNlckdlc3R1cmUpOgorCiAyMDExLTA2LTE1 ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RXJpYyBTZWlkZWwuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRDb250 cm9sbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3Jp cHRDb250cm9sbGVyLmNwcAkocmV2aXNpb24gODkwMDEpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9TY3JpcHRDb250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjUxLDEwICsy NTEsNiBAQCBib29sIFNjcmlwdENvbnRyb2xsZXI6OnByb2Nlc3NpbmdVc2VyR2VzCiAgICAgaWYg KCFmcmFtZSkKICAgICAgICAgcmV0dXJuIFVzZXJHZXN0dXJlSW5kaWNhdG9yOjpnZXRVc2VyR2Vz dHVyZVN0YXRlKCkgIT0gRGVmaW5pdGVseU5vdFByb2Nlc3NpbmdVc2VyR2VzdHVyZTsKIAotICAg IC8vIEZJWE1FOiBSZW1vdmUgdGhlIGlzSmF2YVNjcmlwdEFuY2hvck5hdmlnYXRpb24gY2hlY2sg b25jZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjI3MDIgaXMgZml4 ZWQuCi0gICAgaWYgKGZyYW1lLT5zY3JpcHQoKS0+aXNKYXZhU2NyaXB0QW5jaG9yTmF2aWdhdGlv bigpKQotICAgICAgICByZXR1cm4gdHJ1ZTsKLQogICAgIC8vIElmIGEgRE9NIGV2ZW50IGlzIGJl aW5nIHByb2Nlc3NlZCwgY2hlY2sgdGhhdCBpdCB3YXMgaW5pdGlhdGVkIGJ5IHRoZSB1c2VyCiAg ICAgLy8gYW5kIHRoYXQgaXQgaXMgaW4gdGhlIHdoaXRlbGlzdCBvZiBldmVudCB0eXBlcyBhbGxv d2VkIHRvIGdlbmVyYXRlIHBvcC11cHMuCiAgICAgaWYgKEpTRE9NV2luZG93U2hlbGwqIHNoZWxs ID0gZnJhbWUtPnNjcmlwdCgpLT5leGlzdGluZ1dpbmRvd1NoZWxsKGN1cnJlbnRXb3JsZChleGVj KSkpCkBAIC0yNjQsMTcgKzI2MCw2IEBAIGJvb2wgU2NyaXB0Q29udHJvbGxlcjo6cHJvY2Vzc2lu Z1VzZXJHZXMKICAgICByZXR1cm4gVXNlckdlc3R1cmVJbmRpY2F0b3I6OnByb2Nlc3NpbmdVc2Vy R2VzdHVyZSgpOwogfQogCi0vLyBGSVhNRTogVGhpcyBzZWVtcyBsaWtlIGFuIGluc3VmZmljaWVu dCBjaGVjayB0byB2ZXJpZnkgYSBjbGljayBvbiBhIGphdmFzY3JpcHQ6IGFuY2hvci4KLWJvb2wg U2NyaXB0Q29udHJvbGxlcjo6aXNKYXZhU2NyaXB0QW5jaG9yTmF2aWdhdGlvbigpIGNvbnN0Ci17 Ci0gICAgLy8gVGhpcyBpcyB0aGUgPGEgaHJlZj0iamF2YXNjcmlwdDp3aW5kb3cub3BlbignLi4u Jyk+IGNhc2UgLT4gd2UgbGV0IGl0IHRocm91Z2gKLSAgICBpZiAobV9zb3VyY2VVUkwgJiYgbV9z b3VyY2VVUkwtPmlzTnVsbCgpICYmICFtX3Byb2Nlc3NpbmdUaW1lckNhbGxiYWNrKQotICAgICAg ICByZXR1cm4gdHJ1ZTsKLQotICAgIC8vIFRoaXMgaXMgdGhlIDxzY3JpcHQ+d2luZG93Lm9wZW4o Li4uKTwvc2NyaXB0PiBjYXNlIG9yIGEgdGltZXIgY2FsbGJhY2sgLT4gYmxvY2sgaXQKLSAgICBy ZXR1cm4gZmFsc2U7Ci19Ci0KIGJvb2wgU2NyaXB0Q29udHJvbGxlcjo6Y2FuQWNjZXNzRnJvbUN1 cnJlbnRPcmlnaW4oRnJhbWUgKmZyYW1lKQogewogICAgIEV4ZWNTdGF0ZSogZXhlYyA9IEpTTWFp blRocmVhZEV4ZWNTdGF0ZTo6Y3VycmVudFN0YXRlKCk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9qcy9TY3JpcHRDb250cm9sbGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvYmluZGluZ3MvanMvU2NyaXB0Q29udHJvbGxlci5oCShyZXZpc2lvbiA4OTAwMSkKKysrIFNv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdENvbnRyb2xsZXIuaAkod29ya2luZyBjb3B5 KQpAQCAtMTY5LDE1ICsxNjksMTIgQEAgcHJpdmF0ZToKIAogICAgIHZvaWQgZGlzY29ubmVjdFBs YXRmb3JtU2NyaXB0T2JqZWN0cygpOwogCi0gICAgYm9vbCBpc0phdmFTY3JpcHRBbmNob3JOYXZp Z2F0aW9uKCkgY29uc3Q7Ci0KICAgICBTaGVsbE1hcCBtX3dpbmRvd1NoZWxsczsKICAgICBGcmFt ZSogbV9mcmFtZTsKICAgICBjb25zdCBTdHJpbmcqIG1fc291cmNlVVJMOwogCiAgICAgYm9vbCBt X2luRXhlY3V0ZVNjcmlwdDsKIAotICAgIGJvb2wgbV9wcm9jZXNzaW5nVGltZXJDYWxsYmFjazsK ICAgICBib29sIG1fcGF1c2VkOwogCiAgICAgLy8gVGhlIHJvb3Qgb2JqZWN0IHVzZWQgZm9yIG9i amVjdHMgYm91bmQgb3V0c2lkZSB0aGUgY29udGV4dCBvZiBhIHBsdWdpbiwgc3VjaApJbmRleDog U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHAJKHJl dmlzaW9uIDg5MDAxKQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJv bGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3MCwxMSArMTcwLDYgQEAgYm9vbCBTY3JpcHRD b250cm9sbGVyOjpwcm9jZXNzaW5nVXNlckdlcwogICAgIGlmIChldmVudCkKICAgICAgICAgcmV0 dXJuIGV2ZW50LT5mcm9tVXNlckdlc3R1cmUoKTsKIAotICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhp cyBjaGVjayBvbmNlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Mjcw MiBpcyBmaXhlZC4KLSAgICBjb25zdCBTdHJpbmcqIHNvdXJjZVVSTCA9IGZpcnN0RnJhbWUtPnNj cmlwdCgpLT5zb3VyY2VVUkwoKTsKLSAgICBpZiAoc291cmNlVVJMICYmIHNvdXJjZVVSTC0+aXNO dWxsKCkgJiYgIWZpcnN0RnJhbWUtPnNjcmlwdCgpLT5wcm94eSgpLT50aW1lckNhbGxiYWNrKCkp Ci0gICAgICAgIHJldHVybiB0cnVlOwotCiAgICAgcmV0dXJuIFVzZXJHZXN0dXJlSW5kaWNhdG9y Ojpwcm9jZXNzaW5nVXNlckdlc3R1cmUoKTsKIH0KIAo=