62767 2011-06-15 17:45:16 -0700 Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options 2011-06-19 11:17:33 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dbates dbates aroben darin eric mrowe rniwa wsiegrist oldest_to_newest 421664 0 dbates 2011-06-15 17:45:16 -0700 We should add a remark about the optional --skip-build argument to the usage message of run-javascriptcore-tests. 421669 1 97379 dbates 2011-06-15 17:47:26 -0700 Created attachment 97379 Patch 421672 2 97379 eric 2011-06-15 17:59:15 -0700 Comment on attachment 97379 Patch Is that how the arg is named for run-webkit-tests? I feel like we must have this sort of arg elsewhere. 421689 3 dbates 2011-06-15 18:32:42 -0700 (In reply to comment #2) > (From update of attachment 97379 [details]) > Is that how the arg is named for run-webkit-tests? I feel like we must have this sort of arg elsewhere. Both old-run-webkit-tests and run-webkit-tests.py have a --no-build option which is analogous to --skip-build. Note, for old-run-webkit-tests this option isn't listed in its usage message. We should add it. For consistency, we should either chose to use --skip-build or --no-build. Note, to change run-javascriptcore-tests to use the latter we'll need to modify the buildbot configuration which references --skip-build. 422019 4 97456 dbates 2011-06-16 10:07:37 -0700 Created attachment 97456 Patch Rename --skip-build to --no-build to be consistent with the option of the same name in run-webkit-tests. We should follow up and add a build option to old-run-webkit-tests (it only has --no-build, but new-run-webkit-tests also has a --build option). We should also add the --no-build option to the usage message for old-run-webkit-tests. 422022 5 97456 eric 2011-06-16 10:11:00 -0700 Comment on attachment 97456 Patch OK. This will require a master restart. 422630 6 dbates 2011-06-17 08:08:34 -0700 As discussed with Eric Seidel on IRC yesterday (06/16/2011), I'm going to land this in three parts. Part 1 will add the --build/--no-build option to run-javascriptcore-tests. Part 2 will change the buildbot master config. Part 3 will remove the --skip-build option from run-javascriptcore-tests once the master buildbot pick up this configuration. 422643 7 dbates 2011-06-17 08:34:58 -0700 Committed part 1 in changeset 89136 <http://trac.webkit.org/changeset/89136>. Comitted buildbot master.cfg (part 2) in changeset 89138 <http://trac.webkit.org/changeset/89138>. 422646 8 wsiegrist 2011-06-17 08:38:41 -0700 Master updated. 422934 9 rniwa 2011-06-17 15:53:23 -0700 It seems unit tests are failing to build after this patch was landed: http://build.webkit.org/builders/SnowLeopard%20Intel%20Debug%20%28Tests%29/builds/713 Running build-api-tests Compiling TestWebKitAPI failed! program finished with exit code 1 elapsedTime=24.968663 422937 10 dbates 2011-06-17 16:02:43 -0700 (In reply to comment #9) > It seems unit tests are failing to build after this patch was landed: > http://build.webkit.org/builders/SnowLeopard%20Intel%20Debug%20%28Tests%29/builds/713 > > Running build-api-tests > Compiling TestWebKitAPI failed! > program finished with exit code 1 > elapsedTime=24.968663 It's unclear to me why. I mean, we shouldn't be compiling such API tests for GTK. I filed <https://bugs.webkit.org/show_bug.cgi?id=62892> for this. 422953 11 dbates 2011-06-17 16:41:48 -0700 (In reply to comment #9) > It seems unit tests are failing to build after this patch was landed: > http://build.webkit.org/builders/SnowLeopard%20Intel%20Debug%20%28Tests%29/builds/713 > I misread, this is also failing on the Snow Leopard Debug build machine. In order to roll this out we need to roll out r89138, restart the buildbot master and then roll out r89136. Using a debug build of r89139, I was able to successfully run build-api-tests --debug (which is called by run-api-tests) on Mac OS 10.6.7. For some reason the Snow Leopard Debug bot just calls build-api-tests (without the --debug flag). 422963 12 dbates 2011-06-17 17:14:45 -0700 (In reply to comment #11) > For some reason the Snow Leopard Debug bot just calls build-api-tests (without the --debug flag). Support for running unit tests was added to the build bot master config as part of bug #62603. Notice, the patch will make the bot always calls run-api-tests (without the --debug argument). Hence, the bot will attempt a release build, but this fails since the bot has a debug build. 422971 13 dbates 2011-06-17 17:23:30 -0700 (In reply to comment #12) > (In reply to comment #11) > > For some reason the Snow Leopard Debug bot just calls build-api-tests (without the --debug flag). > > Support for running unit tests was added to the build bot master config as part of bug #62603. Notice, the patch will make the bot always calls run-api-tests (without the --debug argument). Hence, the bot will attempt a release build, but this fails since the bot has a debug build. See bug #62918 for more details. 423291 14 dbates 2011-06-18 17:51:33 -0700 Committed part 3 (removal of --skip-build option) in changeset 89208 <http://trac.webkit.org/changeset/89208>. 423379 15 wsiegrist 2011-06-19 11:17:33 -0700 Master updated. 97379 2011-06-15 17:47:26 -0700 2011-06-16 10:07:37 -0700 Patch bug-62767-20110615174402.patch text/plain 1269 dbates SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDg4OTg0KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMDYtMTUgIERhbmllbCBCYXRlcyAgPGRiYXRlc0ByaW0uY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCAtLXNraXAt YnVpbGQgdG8gcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzIHVzYWdlIG1lc3NhZ2UKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYyNzY3CisKKyAgICAgICAg VGhpcyBvcHRpb25hbCBjb21tYW5kIGxpbmUgYXJndW1lbnQgdG8gc2tpcCBidWlsZGluZyBqc2Mg aXNuJ3QgbWVudGlvbmVkIGluCisgICAgICAgIHRoZSB1c2FnZSBtZXNzYWdlIG9mIHJ1bi1qYXZh c2NyaXB0Y29yZS10ZXN0cy4gV2Ugc2hvdWxkIG1lbnRpb24gaXQuCisKKyAgICAgICAgKiBTY3Jp cHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0czoKKwogMjAxMS0wNi0xNSAgSmVyZW15IE9ybG93 ICA8am9ybG93QHdlYmtpdC5vcmc+CiAKICAgICAgICAgQ2hhbmdlIG15IGVtYWlsIHRvIEB3ZWJr aXQub3JnCkluZGV4OiBUb29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwkocmV2aXNp b24gODg5ODQpCisrKyBUb29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwkod29y a2luZyBjb3B5KQpAQCAtNjQsNiArNjQsNyBAQCBVc2FnZTogJHByb2dyYW1OYW1lIFtvcHRpb25z XSBbb3B0aW9ucyB0CiAgIC0taGVscCAgICAgICAgICAgICAgICAgICAgICAgIFNob3cgdGhpcyBo ZWxwIG1lc3NhZ2UKICAgLS1qc0RyaXZlci1hcmdzPSAgICAgICAgICAgICAgQSBzdHJpbmcgb2Yg YXJndW1lbnRzIHRvIHBhc3MgdG8ganNEcml2ZXIucGwKICAgLS1yb290PSAgICAgICAgICAgICAg ICAgICAgICAgUGF0aCB0byBwcmUtYnVpbHQgcm9vdCBjb250YWluaW5nIGpzYworICAtLXNraXAt YnVpbGQgICAgICAgICAgICAgICAgICBBc3N1bWUganNjIHdhcyBhbHJlYWR5IGJ1aWx0CiBFT0YK IAogR2V0T3B0aW9ucygK 97456 2011-06-16 10:07:37 -0700 2011-06-16 10:11:00 -0700 Patch bug62767.patch text/plain 5452 dbates SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDg5MDMyKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTggQEAKKzIwMTEtMDYtMTYgIERhbmllbCBCYXRlcyAgPGRiYXRlc0ByaW0uY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBydW4t amF2YXNjcmlwdGNvcmUtdGVzdHMgLS1za2lwLWJ1aWxkIG9wdGlvbjsgSW5zdGVhZCBhZGQgLS1i dWlsZC9uby1idWlsZCBvcHRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02Mjc2NworCisgICAgICAgIFJlbmFtZSB0aGUgY29tbWFuZCBsaW5lIG9w dGlvbiAtLXNraXAtYnVpbGQgdG8gLS1uby1idWlsZCB0byBiZSBjb25zaXN0ZW50IHdpdGggdGhl IG9wdGlvbgorICAgICAgICBvZiB0aGUgc2FtZSBuYW1lIGluIHJ1bi13ZWJraXQtdGVzdHMgd2hp Y2ggaGFzIGEgc2ltaWxhciBwdXJwb3NlLiBBbHNvLCBhZGQgYSByZW1hcmsgYWJvdXQKKyAgICAg ICAgdGhpcyBvcHRpb24gdG8gdGhlIHVzYWdlIG1lc3NhZ2UgcHJpbnRlZCBieSBydW4tamF2YXNj cmlwdGNvcmUtdGVzdHMuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJr aXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnOgorICAgICAgICAqIFNjcmlwdHMvcnVuLWphdmFzY3Jp cHRjb3JlLXRlc3RzOiBBZGRpdGlvbmFsbHksIHJlbW92ZSB1bm5lY2Vzc2FyeSBpbml0aWFsaXph dGlvbgorICAgICAgICAgIG9mICRzaG93SGVscC4KKwogMjAxMS0wNi0xNiAgVG9tbXkgV2lkZW5m bHljaHQgIDx0b21teXdAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBUb255IEdl bnRpbGNvcmUuCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9tYXN0ZXIuY2ZnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcJKHJldmlzaW9uIDg4OTg0KQorKysg VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNm Zwkod29ya2luZyBjb3B5KQpAQCAtMTQ4LDE1ICsxNDgsMTUgQEAgY2xhc3MgUnVuSmF2YVNjcmlw dENvcmVUZXN0cyhzaGVsbC5UZXN0KQogICAgIGNvbW1hbmQgPSBbInBlcmwiLCAiLi9Ub29scy9T Y3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cyIsIFdpdGhQcm9wZXJ0aWVzKCItLSUoY29u ZmlndXJhdGlvbilzIildCiAgICAgbG9nZmlsZXMgPSB7J2FjdHVhbC5odG1sIChzb3VyY2UpJzog J1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9tb3ppbGxhL2FjdHVhbC5odG1sJ30KIAotICAg IGRlZiBfX2luaXRfXyhzZWxmLCBza2lwQnVpbGQ9RmFsc2UsICphcmdzLCAqKmt3YXJncyk6Ci0g ICAgICAgIHNlbGYuc2tpcEJ1aWxkID0gc2tpcEJ1aWxkCisgICAgZGVmIF9faW5pdF9fKHNlbGYs IGJ1aWxkSlNDPVRydWUsICphcmdzLCAqKmt3YXJncyk6CisgICAgICAgIHNlbGYuYnVpbGRKU0Mg PSBidWlsZEpTQwogICAgICAgICBzaGVsbC5UZXN0Ll9faW5pdF9fKHNlbGYsICphcmdzLCAqKmt3 YXJncykKLSAgICAgICAgc2VsZi5hZGRGYWN0b3J5QXJndW1lbnRzKHNraXBCdWlsZD1za2lwQnVp bGQpCisgICAgICAgIHNlbGYuYWRkRmFjdG9yeUFyZ3VtZW50cyhidWlsZEpTQz1idWlsZEpTQykK IAogICAgIGRlZiBzdGFydChzZWxmKToKICAgICAgICAgYXBwZW5kQ3VzdG9tQnVpbGRGbGFncyhz ZWxmLCBzZWxmLmdldFByb3BlcnR5KCdwbGF0Zm9ybScpKQotICAgICAgICBpZiBzZWxmLnNraXBC dWlsZDoKLSAgICAgICAgICAgIHNlbGYuc2V0Q29tbWFuZChzZWxmLmNvbW1hbmQgKyBbJy0tc2tp cC1idWlsZCddKQorICAgICAgICBpZiBub3Qgc2VsZi5idWlsZEpTQzoKKyAgICAgICAgICAgIHNl bGYuc2V0Q29tbWFuZChzZWxmLmNvbW1hbmQgKyBbJy0tbm8tYnVpbGQnXSkKICAgICAgICAgcmV0 dXJuIHNoZWxsLlRlc3Quc3RhcnQoc2VsZikKIAogICAgIGRlZiBjb21tYW5kQ29tcGxldGUoc2Vs ZiwgY21kKToKQEAgLTE5OSwxMCArMTk5LDEwIEBAIGNsYXNzIFJ1bldlYktpdFRlc3RzKHNoZWxs LlRlc3QpOgogICAgICAgICAgICAgICAgIi0tbm8tc2FtcGxlLW9uLXRpbWVvdXQiLCAiLS1yZXN1 bHRzLWRpcmVjdG9yeSIsICJsYXlvdXQtdGVzdC1yZXN1bHRzIiwgIi0tdXNlLXJlbW90ZS1saW5r cy10by10ZXN0cyIsCiAgICAgICAgICAgICAgICBXaXRoUHJvcGVydGllcygiLS0lKGNvbmZpZ3Vy YXRpb24pcyIpLCAiLS1leGl0LWFmdGVyLW4tY3Jhc2hlcy1vci10aW1lb3V0cyIsICIyMCIsICAi LS1leGl0LWFmdGVyLW4tZmFpbHVyZXMiLCAiNTAwIl0KIAotICAgIGRlZiBfX2luaXRfXyhzZWxm LCBza2lwQnVpbGQ9RmFsc2UsICphcmdzLCAqKmt3YXJncyk6Ci0gICAgICAgIHNlbGYuc2tpcEJ1 aWxkID0gc2tpcEJ1aWxkCisgICAgZGVmIF9faW5pdF9fKHNlbGYsIGJ1aWxkSlNDPVRydWUsICph cmdzLCAqKmt3YXJncyk6CisgICAgICAgIHNlbGYuYnVpbGRKU0MgPSBidWlsZEpTQwogICAgICAg ICBzaGVsbC5UZXN0Ll9faW5pdF9fKHNlbGYsICphcmdzLCAqKmt3YXJncykKLSAgICAgICAgc2Vs Zi5hZGRGYWN0b3J5QXJndW1lbnRzKHNraXBCdWlsZD1za2lwQnVpbGQpCisgICAgICAgIHNlbGYu YWRkRmFjdG9yeUFyZ3VtZW50cyhidWlsZEpTQz1idWlsZEpTQykKIAogICAgIGRlZiBzdGFydChz ZWxmKToKICAgICAgICAgcGxhdGZvcm0gPSBzZWxmLmdldFByb3BlcnR5KCdwbGF0Zm9ybScpCkBA IC0yMTEsNyArMjExLDcgQEAgY2xhc3MgUnVuV2ViS2l0VGVzdHMoc2hlbGwuVGVzdCk6CiAgICAg ICAgICAgICByb290QXJndW1lbnQgPSBbJy0tcm9vdD0nICsgb3MucGF0aC5qb2luKCJXZWJLaXRC dWlsZCIsIHNlbGYuZ2V0UHJvcGVydHkoJ2NvbmZpZ3VyYXRpb24nKSwgImJpbiIpXQogICAgICAg ICBlbHNlOgogICAgICAgICAgICAgcm9vdEFyZ3VtZW50ID0gWyctLXJvb3Q9V2ViS2l0QnVpbGQv YmluJ10KLSAgICAgICAgaWYgc2VsZi5za2lwQnVpbGQ6CisgICAgICAgIGlmIG5vdCBzZWxmLmJ1 aWxkSlNDOgogICAgICAgICAgICAgc2VsZi5zZXRDb21tYW5kKHNlbGYuY29tbWFuZCArIHJvb3RB cmd1bWVudCkKICAgICAgICAgcmV0dXJuIHNoZWxsLlRlc3Quc3RhcnQoc2VsZikKIApAQCAtNTE5 LDggKzUxOSw4IEBAIGNsYXNzIFRlc3RGYWN0b3J5KEZhY3RvcnkpOgogICAgICAgICAgICAgc2Vs Zi5hZGRTdGVwKFN0YXJ0QVRTU2VydmVyKQogICAgICAgICBzZWxmLmFkZFN0ZXAoRG93bmxvYWRC dWlsdFByb2R1Y3QpCiAgICAgICAgIHNlbGYuYWRkU3RlcChFeHRyYWN0QnVpbHRQcm9kdWN0KQot ICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuSmF2YVNjcmlwdENvcmVUZXN0cywgc2tpcEJ1aWxkPVRy dWUpCi0gICAgICAgIHNlbGYuYWRkU3RlcChzZWxmLlRlc3RDbGFzcywgc2tpcEJ1aWxkPShwbGF0 Zm9ybSA9PSAnd2luJykpCisgICAgICAgIHNlbGYuYWRkU3RlcChSdW5KYXZhU2NyaXB0Q29yZVRl c3RzLCBidWlsZEpTQz1GYWxzZSkKKyAgICAgICAgc2VsZi5hZGRTdGVwKHNlbGYuVGVzdENsYXNz LCBidWlsZEpTQz0ocGxhdGZvcm0gIT0gJ3dpbicpKQogICAgICAgICAjIFRpZ2VyJ3MgUHl0aG9u IDIuMyBpcyB0b28gb2xkLiAgV2ViS2l0IFB5dGhvbiByZXF1aXJlcyAyLjUrLgogICAgICAgICAj IFNhZGx5IHdlIGhhdmUgbm8gd2F5IHRvIGRldGVjdCB0aGUgdmVyc2lvbiBvbiB0aGUgc2xhdmUg ZnJvbSBoZXJlLgogICAgICAgICBpZiBwbGF0Zm9ybSAhPSAibWFjLXRpZ2VyIjoKSW5kZXg6IFRv b2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzCShyZXZpc2lvbiA4ODk4NCkKKysrIFRv b2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC01 NCwyMiArNTQsMjYgQEAgbXkgQHRlc3RzVG9Ta2lwID0gKAogKTsKIAogbXkgJGpzRHJpdmVyQXJn cyA9ICItTCAiIC4gam9pbigiICIsIEB0ZXN0c1RvU2tpcCk7Ci1teSAkcm9vdDsgIyBpbnRlbnRp b25hbGx5IGxlZnQgdW5kZWZpbmVkCi1teSAkc2tpcEJ1aWxkID0gMDsKLW15ICRzaG93SGVscCA9 IDA7CisjIFRoZXNlIHZhcmlhYmxlcyBhcmUgaW50ZW50aW9uYWxseSBsZWZ0IHVuZGVmaW5lZC4K K215ICRyb290OworbXkgJHNob3dIZWxwOworCitteSAkYnVpbGRKU0MgPSAxOwogCiBteSAkcHJv Z3JhbU5hbWUgPSBiYXNlbmFtZSgkMCk7CitteSAkYnVpbGRKU0NEZWZhdWx0ID0gJGJ1aWxkSlND ID8gIndpbGwgY2hlY2siIDogIndpbGwgbm90IGNoZWNrIjsKIG15ICR1c2FnZSA9IDw8RU9GOwog VXNhZ2U6ICRwcm9ncmFtTmFtZSBbb3B0aW9uc10gW29wdGlvbnMgdG8gcGFzcyB0byBidWlsZCBz eXN0ZW1dCiAgIC0taGVscCAgICAgICAgICAgICAgICAgICAgICAgIFNob3cgdGhpcyBoZWxwIG1l c3NhZ2UKICAgLS1qc0RyaXZlci1hcmdzPSAgICAgICAgICAgICAgQSBzdHJpbmcgb2YgYXJndW1l bnRzIHRvIHBhc3MgdG8ganNEcml2ZXIucGwKICAgLS1yb290PSAgICAgICAgICAgICAgICAgICAg ICAgUGF0aCB0byBwcmUtYnVpbHQgcm9vdCBjb250YWluaW5nIGpzYworICAtLVtuby1dYnVpbGQg ICAgICAgICAgICAgICAgICBDaGVjayAob3IgZG9uJ3QgY2hlY2spIHRvIHNlZSBpZiB0aGUganNj IGJ1aWxkIGlzIHVwLXRvLWRhdGUgKGRlZmF1bHQ6ICRidWlsZEpTQ0RlZmF1bHQpCiBFT0YKIAog R2V0T3B0aW9ucygKICAgICAnanxqc0RyaXZlci1hcmdzPXMnID0+IFwkanNEcml2ZXJBcmdzLAog ICAgICdyb290PXMnID0+IFwkcm9vdCwKLSAgICAnc2tpcC1idWlsZCcgPT4gXCRza2lwQnVpbGQs CisgICAgJ2J1aWxkIScgPT4gXCRidWlsZEpTQywKICAgICAnaGVscCcgPT4gXCRzaG93SGVscAog KTsKIApAQCAtODYsNyArOTAsNyBAQCBpZiAoJHNob3dIZWxwKSB7CiAKIHNldENvbmZpZ3VyYXRp b25Qcm9kdWN0RGlyKEN3ZDo6YWJzX3BhdGgoJHJvb3QpKSBpZiAoZGVmaW5lZCgkcm9vdCkpOwog Ci1pZiAoIWRlZmluZWQoJHJvb3QpICYmICEkc2tpcEJ1aWxkKSB7CitpZiAoIWRlZmluZWQoJHJv b3QpICYmICRidWlsZEpTQykgewogICAgIGNoZGlyV2ViS2l0KCk7CiAKICAgICBwdXNoKEBidWls ZEFyZ3MsIGFyZ3VtZW50c0ZvckNvbmZpZ3VyYXRpb24oKSk7Cg==