62763 2011-06-15 16:07:29 -0700 WKSecurityOriginGetProtocol and WKSecurityOriginGetHost are named wrong because they return copied strings 2011-06-15 16:18:57 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sullivan sullivan oldest_to_newest 421631 0 sullivan 2011-06-15 16:07:29 -0700 WKSecurityOriginGetProtocol and WKSecurityOriginGetHost are named as if they return a pre-existing object, but they actually return copied strings. This leads to leaks in callers that don't know to take ownership responsibility for the return values. <rdar://problem/9618071> 421632 1 97373 sullivan 2011-06-15 16:10:09 -0700 Created attachment 97373 Patch to update the two names to correctly reflect their behavior. 421636 2 sullivan 2011-06-15 16:18:57 -0700 http://trac.webkit.org/changeset/88983 97373 2011-06-15 16:10:09 -0700 2011-06-15 16:11:27 -0700 Patch to update the two names to correctly reflect their behavior. 62763_patch.txt text/plain 2724 sullivan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4OTgwKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDYtMTUgIEpvaG4gU3Vs bGl2YW4gIDxzdWxsaXZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV0tTZWN1cml0eU9yaWdpbkdldFByb3RvY29sIGFuZCBXS1Nl Y3VyaXR5T3JpZ2luR2V0SG9zdCBhcmUgbmFtZWQgd3JvbmcgYmVjYXVzZSB0aGV5IHJldHVybiBj b3BpZWQgc3RyaW5ncworICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTYyNzYzPgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vOTYxODA3MT4KKworICAgICAg ICAqIFNoYXJlZC9BUEkvYy9XS1NlY3VyaXR5T3JpZ2luLmNwcDoKKyAgICAgICAgKFdLU2VjdXJp dHlPcmlnaW5Db3B5UHJvdG9jb2wpOgorICAgICAgICBSZW5hbWVkIHRvIHVzZSAiQ29weSIgaW5z dGVhZCBvZiAiR2V0IiBiZWNhdXNlIGl0IHJldHVybnMgYSBjb3B5LgorICAgICAgICAoV0tTZWN1 cml0eU9yaWdpbkNvcHlIb3N0KToKKyAgICAgICAgRGl0dG8uCisKKyAgICAgICAgKiBTaGFyZWQv QVBJL2MvV0tTZWN1cml0eU9yaWdpbi5oOgorICAgICAgICBVcGRhdGVkIGRlY2xhcmF0aW9ucy4K KwogMjAxMS0wNi0xNCAgSm9uIEhvbmV5Y3V0dCAgPGpob25leWN1dHRAYXBwbGUuY29tPgogCiAg ICAgICAgIFJFR1JFU1NJT04oNzgyMDEpOiBXaW5kb3dsZXNzIEZsYXNoIHBsdWctaW5zIGFyZSB0 cmFuc3BhcmVudCBvbiBzb21lIHNpdGVzCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJ L2MvV0tTZWN1cml0eU9yaWdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvU2hh cmVkL0FQSS9jL1dLU2VjdXJpdHlPcmlnaW4uY3BwCShyZXZpc2lvbiA4ODg5OCkKKysrIFNvdXJj ZS9XZWJLaXQyL1NoYXJlZC9BUEkvYy9XS1NlY3VyaXR5T3JpZ2luLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNDgsMTIgKzQ4LDEyIEBAIFdLU2VjdXJpdHlPcmlnaW5SZWYgV0tTZWN1cml0eU9yaWdp bkNyZWEKICAgICByZXR1cm4gdG9BUEkoc2VjdXJpdHlPcmlnaW4ucmVsZWFzZSgpLmxlYWtSZWYo KSk7CiB9CiAKLVdLU3RyaW5nUmVmIFdLU2VjdXJpdHlPcmlnaW5HZXRQcm90b2NvbChXS1NlY3Vy aXR5T3JpZ2luUmVmIHNlY3VyaXR5T3JpZ2luKQorV0tTdHJpbmdSZWYgV0tTZWN1cml0eU9yaWdp bkNvcHlQcm90b2NvbChXS1NlY3VyaXR5T3JpZ2luUmVmIHNlY3VyaXR5T3JpZ2luKQogewogICAg IHJldHVybiB0b0NvcGllZEFQSSh0b0ltcGwoc2VjdXJpdHlPcmlnaW4pLT5wcm90b2NvbCgpKTsK IH0KIAotV0tTdHJpbmdSZWYgV0tTZWN1cml0eU9yaWdpbkdldEhvc3QoV0tTZWN1cml0eU9yaWdp blJlZiBzZWN1cml0eU9yaWdpbikKK1dLU3RyaW5nUmVmIFdLU2VjdXJpdHlPcmlnaW5Db3B5SG9z dChXS1NlY3VyaXR5T3JpZ2luUmVmIHNlY3VyaXR5T3JpZ2luKQogewogICAgIHJldHVybiB0b0Nv cGllZEFQSSh0b0ltcGwoc2VjdXJpdHlPcmlnaW4pLT5ob3N0KCkpOwogfQpJbmRleDogU291cmNl L1dlYktpdDIvU2hhcmVkL0FQSS9jL1dLU2VjdXJpdHlPcmlnaW4uaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tTZWN1cml0eU9yaWdpbi5oCShyZXZpc2lvbiA4 ODg5OCkKKysrIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvYy9XS1NlY3VyaXR5T3JpZ2luLmgJ KHdvcmtpbmcgY29weSkKQEAgLTM3LDggKzM3LDggQEAgV0tfRVhQT1JUIFdLVHlwZUlEIFdLU2Vj dXJpdHlPcmlnaW5HZXRUeQogV0tfRVhQT1JUIFdLU2VjdXJpdHlPcmlnaW5SZWYgV0tTZWN1cml0 eU9yaWdpbkNyZWF0ZUZyb21JZGVudGlmaWVyKFdLU3RyaW5nUmVmIGlkZW50aWZpZXIpOwogV0tf RVhQT1JUIFdLU2VjdXJpdHlPcmlnaW5SZWYgV0tTZWN1cml0eU9yaWdpbkNyZWF0ZShXS1N0cmlu Z1JlZiBwcm90b2NvbCwgV0tTdHJpbmdSZWYgaG9zdCwgaW50IHBvcnQpOwogCi1XS19FWFBPUlQg V0tTdHJpbmdSZWYgV0tTZWN1cml0eU9yaWdpbkdldFByb3RvY29sKFdLU2VjdXJpdHlPcmlnaW5S ZWYgc2VjdXJpdHlPcmlnaW4pOwotV0tfRVhQT1JUIFdLU3RyaW5nUmVmIFdLU2VjdXJpdHlPcmln aW5HZXRIb3N0KFdLU2VjdXJpdHlPcmlnaW5SZWYgc2VjdXJpdHlPcmlnaW4pOworV0tfRVhQT1JU IFdLU3RyaW5nUmVmIFdLU2VjdXJpdHlPcmlnaW5Db3B5UHJvdG9jb2woV0tTZWN1cml0eU9yaWdp blJlZiBzZWN1cml0eU9yaWdpbik7CitXS19FWFBPUlQgV0tTdHJpbmdSZWYgV0tTZWN1cml0eU9y aWdpbkNvcHlIb3N0KFdLU2VjdXJpdHlPcmlnaW5SZWYgc2VjdXJpdHlPcmlnaW4pOwogV0tfRVhQ T1JUIHVuc2lnbmVkIHNob3J0IFdLU2VjdXJpdHlPcmlnaW5HZXRQb3J0KFdLU2VjdXJpdHlPcmln aW5SZWYgc2VjdXJpdHlPcmlnaW4pOwogCiAjaWZkZWYgX19jcGx1c3BsdXMK