62757 2011-06-15 14:40:06 -0700 Have Document keep track of whether scroll listeners are registered 2011-06-15 16:03:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser ap mihaip sam simon.fraser oldest_to_newest 421587 0 simon.fraser 2011-06-15 14:40:06 -0700 Have Document keep track of whether scroll listeners are registered 421591 1 97365 simon.fraser 2011-06-15 14:44:51 -0700 Created attachment 97365 Patch 421598 2 97365 ap 2011-06-15 14:52:51 -0700 Comment on attachment 97365 Patch Did you check that this works with both document.onscroll and window.onscroll? 421599 3 simon.fraser 2011-06-15 14:56:50 -0700 Will check. 421627 4 simon.fraser 2011-06-15 15:56:36 -0700 window.onscroll and document.onscroll both work fine. DOMWindow::addEventListener() calls document->addListenerTypeIfNeeded(). 421629 5 simon.fraser 2011-06-15 16:03:25 -0700 http://trac.webkit.org/changeset/88980 97365 2011-06-15 14:44:51 -0700 2011-06-15 14:52:51 -0700 Patch bug-62757-20110615144450.patch text/plain 5129 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogODg5NjIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBkZjI2OWNkY2FjNDNjYTY5YjNlZTY4 MTJmNWY4MTk3Y2ViOGVhNTcyLi43YmY2Mzg4MTAzMzhhNGNmY2U3MzliYzQwNDJlNmMwOGVmOWVi NGJmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDYtMTUgIFNpbW9uIEZyYXNlciAgPHNp bW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgSGF2ZSBEb2N1bWVudCBrZWVwIHRyYWNrIG9mIHdoZXRoZXIgc2Nyb2xs IGxpc3RlbmVycyBhcmUgcmVnaXN0ZXJlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NjI3NTcKKyAgICAgICAgCisgICAgICAgIFRoaXMgdGVzdCByZWxp ZWQgb24gdGhlIGZhY3QgdGhhdCwgd2l0aCBhc3luYyBzY3JvbGwgZXZlbnQgZGlzcGF0Y2gsCisg ICAgICAgIGFuIGVsZW1lbnQgd291bGQgZ2V0IGEgc2Nyb2xsIGV2ZW50IGV2ZW4gaWYgdGhlIGxp c3RlbmVyIGlzIHJlZ2lzdGVyZWQKKyAgICAgICAgYWZ0ZXIgdGhlIHNjcm9sbCBoYXBwZW5zLiBG aXggdGhlIHRlc3QgdG8gcmVnaXN0ZXIgdGhlIGxpc3RlbmVyIGJlZm9yZQorICAgICAgICB0aGUg Zmlyc3Qgc2Nyb2xsLgorCisgICAgICAgICogZmFzdC9ldmVudHMvcmVtb3ZlLWNoaWxkLW9uc2Ny b2xsLmh0bWw6CisKIDIwMTEtMDYtMTUgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4K IAogICAgICAgICBGaXggUXQgcmVzdWx0cyBmb3IgUmVuZGVyRGVwcmVjYXRlZEZsZXhpYmxlQm94 IHJlbmFtZS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3JlbW92ZS1jaGls ZC1vbnNjcm9sbC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvcmVtb3ZlLWNoaWxkLW9u c2Nyb2xsLmh0bWwKaW5kZXggMTA5YTVkNjI3MzNhZjRhOTMwODRkNTVjNGQyYTE1ZGNjMDZhZTNh Ny4uYzVlMDQ2OGE5YjZmNjQ1Y2Q4YzU0Y2MxNDgwZTY5ODA0YzY1MDYzYiAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvcmVtb3ZlLWNoaWxkLW9uc2Nyb2xsLmh0bWwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvcmVtb3ZlLWNoaWxkLW9uc2Nyb2xsLmh0bWwKQEAgLTEw LDggKzEwLDYgQEAKICAgICAgICAgICAgIHsKICAgICAgICAgICAgICAgICBpZiAod2luZG93LmV2 ZW50U2VuZGVyICYmIHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewogICAgICAgICAgICAg ICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7Ci0gICAgICAgICAg ICAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKDEwMCwgMTAwKTsKLSAgICAgICAgICAg ICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VTY3JvbGxCeSgwLCAtMSk7CiAgICAgICAgICAgICAg ICAgICAgIHZhciBzY3JvbGxDb3VudCA9IDA7CiAgICAgICAgICAgICAgICAgICAgIGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCdkdicpLmFkZEV2ZW50TGlzdGVuZXIoCiAgICAgICAgICAgICAgICAg ICAgICAgICAnc2Nyb2xsJywKQEAgLTI0LDYgKzIyLDkgQEAKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOwogICAgICAgICAg ICAgICAgICAgICAgICAgfSwKICAgICAgICAgICAgICAgICAgICAgICAgIGZhbHNlKTsKKworICAg ICAgICAgICAgICAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKDEwMCwgMTAwKTsKKyAg ICAgICAgICAgICAgICAgICAgICBldmVudFNlbmRlci5tb3VzZVNjcm9sbEJ5KDAsIC0xKTsKICAg ICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9CiAgICAgICAgIDwvc2NyaXB0PgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CmluZGV4IGNjZWEwZDRmMjExYWI1MmM1M2EyMmFhNDhkZTY2NzY1M2RkMDUzNTQuLjkxMjE1ZmJh NTc4NzRiZTIzMDA2NDA3OTM4Y2U2ZGMwZjgxMDM5NGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwy MCBAQAorMjAxMS0wNi0xNSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBIYXZlIERv Y3VtZW50IGtlZXAgdHJhY2sgb2Ygd2hldGhlciBzY3JvbGwgbGlzdGVuZXJzIGFyZSByZWdpc3Rl cmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02Mjc1 NworICAgICAgICAKKyAgICAgICAgVG8gYXZvaWQgZXh0cmEgd29yayBkaXNwYXRjaGluZyBzY3Jv bGwgZXZlbnRzIHdoZW4gdGhlcmUgYXJlIG5vIGxpc3RlbmVycywKKyAgICAgICAgaGF2ZSBEb2N1 bWVudCBrZWVwIHRyYWNrIG9mIHdoZXRoZXIgYW55IHNjcm9sbCBsaXN0ZW5lcnMgYXJlIHJlZ2lz dGVyZWQsCisgICAgICAgIGp1c3QgbGlrZSBpdCBkb2VzIGZvciBzb21lIG90aGVyIGV2ZW50IHR5 cGVzLgorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRv Y3VtZW50OjphZGRMaXN0ZW5lclR5cGVJZk5lZWRlZCk6CisgICAgICAgICogZG9tL0RvY3VtZW50 Lmg6CisgICAgICAgICogZG9tL0V2ZW50UXVldWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RXZl bnRRdWV1ZTo6ZW5xdWV1ZU9yRGlzcGF0Y2hTY3JvbGxFdmVudCk6CisKIDIwMTEtMDYtMTUgIEVy aWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9E b2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IGRkMTlm NWQzY2Q0MTcxNGUxYzY0NDRkZDMwZWRjZTI0Y2ZhZjA1MDYuLmM5NjJhMzI0NjcwZGZmZDIyMzMz YTdkMmFmMjRjNGM5NzE2ZTFlMWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1 bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtMzUyNCw2 ICszNTI0LDggQEAgdm9pZCBEb2N1bWVudDo6YWRkTGlzdGVuZXJUeXBlSWZOZWVkZWQoY29uc3Qg QXRvbWljU3RyaW5nJiBldmVudFR5cGUpCiAgICAgICAgICAgICBwYWdlLT5jaHJvbWUoKS0+Y2xp ZW50KCktPm5lZWRUb3VjaEV2ZW50cyh0cnVlKTsKICAgICB9CiAjZW5kaWYKKyAgICBlbHNlIGlm IChldmVudFR5cGUgPT0gZXZlbnROYW1lcygpLnNjcm9sbEV2ZW50KQorICAgICAgICBhZGRMaXN0 ZW5lclR5cGUoU0NST0xMX0xJU1RFTkVSKTsKIH0KIAogQ1NTU3R5bGVEZWNsYXJhdGlvbiogRG9j dW1lbnQ6OmdldE92ZXJyaWRlU3R5bGUoRWxlbWVudCosIGNvbnN0IFN0cmluZyYpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9E b2N1bWVudC5oCmluZGV4IDMzYjgwYjlhNWZiMTk3MDkxY2VjNDMwOWMyMjI4YmI3Y2I0NDE2MTAu LmFhMDc3MDRkMzc1MzZmMzBkMTc3MjQzNWVkMjE3NmMyYjQ0N2NkZWUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1 bWVudC5oCkBAIC03NTgsNyArNzU4LDggQEAgcHVibGljOgogICAgICAgICBUUkFOU0lUSU9ORU5E X0xJU1RFTkVSICAgICAgICAgICAgICAgPSAweDgwMCwKICAgICAgICAgQkVGT1JFTE9BRF9MSVNU RU5FUiAgICAgICAgICAgICAgICAgID0gMHgxMDAwLAogICAgICAgICBUT1VDSF9MSVNURU5FUiAg ICAgICAgICAgICAgICAgICAgICAgPSAweDIwMDAsCi0gICAgICAgIEJFRk9SRVBST0NFU1NfTElT VEVORVIgICAgICAgICAgICAgICA9IDB4NDAwMAorICAgICAgICBCRUZPUkVQUk9DRVNTX0xJU1RF TkVSICAgICAgICAgICAgICAgPSAweDQwMDAsCisgICAgICAgIFNDUk9MTF9MSVNURU5FUiAgICAg ICAgICAgICAgICAgICAgICA9IDB4ODAwMAogICAgIH07CiAKICAgICBib29sIGhhc0xpc3RlbmVy VHlwZShMaXN0ZW5lclR5cGUgbGlzdGVuZXJUeXBlKSBjb25zdCB7IHJldHVybiAobV9saXN0ZW5l clR5cGVzICYgbGlzdGVuZXJUeXBlKTsgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9t L0V2ZW50UXVldWUuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50UXVldWUuY3BwCmluZGV4 IGVkZjA0ZjdmZTkwMTFmM2Y1YTEwNDc1N2M5NWUxYTU4YTljMjRhNDMuLjM5MWE5NWMxMjE4OThi M2QxNDhmMmVmNjdhMmU1NDQ5NGMzZjI5MzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9FdmVudFF1ZXVlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnRRdWV1ZS5jcHAK QEAgLTExNyw2ICsxMTcsOSBAQCB2b2lkIEV2ZW50UXVldWU6OmVucXVldWVFdmVudChQYXNzUmVm UHRyPEV2ZW50PiBwcnBFdmVudCkKIAogdm9pZCBFdmVudFF1ZXVlOjplbnF1ZXVlT3JEaXNwYXRj aFNjcm9sbEV2ZW50KFBhc3NSZWZQdHI8Tm9kZT4gdGFyZ2V0LCBTY3JvbGxFdmVudFRhcmdldFR5 cGUgdGFyZ2V0VHlwZSkKIHsKKyAgICBpZiAoIXRhcmdldC0+ZG9jdW1lbnQoKS0+aGFzTGlzdGVu ZXJUeXBlKERvY3VtZW50OjpTQ1JPTExfTElTVEVORVIpKQorICAgICAgICByZXR1cm47CisKICAg ICAvLyBQZXIgdGhlIFczQyBDU1NPTSBWaWV3IE1vZHVsZSwgc2Nyb2xsIGV2ZW50cyBmaXJlZCBh dCB0aGUgZG9jdW1lbnQgc2hvdWxkIGJ1YmJsZSwgb3RoZXJzIHNob3VsZCBub3QuCiAgICAgYm9v bCBjYW5CdWJibGUgPSB0YXJnZXRUeXBlID09IFNjcm9sbEV2ZW50RG9jdW1lbnRUYXJnZXQ7CiAg ICAgUmVmUHRyPEV2ZW50PiBzY3JvbGxFdmVudCA9IEV2ZW50OjpjcmVhdGUoZXZlbnROYW1lcygp LnNjcm9sbEV2ZW50LCBjYW5CdWJibGUsIGZhbHNlIC8qIG5vbiBjYW5jZWxsZWFibGUgKi8pOwo=