62752 2011-06-15 13:32:50 -0700 [GTK] Transition to Mozilla named cursors have incorrect hotspot and rendering 2011-07-11 15:43:26 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 mrobinson mrobinson dbates oldest_to_newest 421540 0 mrobinson 2011-06-15 13:32:50 -0700 When the view cursor switches to a Mozilla named cursor, the pointer jumps to a different location. Additionally the hotspot is incorrect. This is visible when dragging the slider on today's Google doodle (lunar eclipse). These are cached here for posterity: http://www.google.com/logos/. You can also see this in Source/WebCore/manual-tests/cur-hotspot.html. 421546 1 97357 mrobinson 2011-06-15 13:40:32 -0700 Created attachment 97357 Patch 422397 2 97357 eric 2011-06-16 21:08:29 -0700 Comment on attachment 97357 Patch Makes sense. How do we test this? 422408 3 mrobinson 2011-06-16 21:45:57 -0700 (In reply to comment #2) > (From update of attachment 97357 [details]) > Makes sense. How do we test this? I don't think there are automated tests for cursors, so we just have to rely on the manual test at Source/WebCore/manual-tests/cursor.html. 433221 4 97357 dbates 2011-07-06 21:03:07 -0700 Comment on attachment 97357 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97357&action=review > Source/WebCore/ChangeLog:11 > + * manual-tests/cursor.html: The grab cursor div covers this change. Nit: On my first read of this commit message I thought you that you were adding this test since you use the same '*:' style as prepare-ChangeLog. I suggest writing a complete sentence instead of using the same notation. Maybe something like: "This change is covered by the grab cursor div in manual-tests/cursor.html." 435242 5 mrobinson 2011-07-11 15:43:08 -0700 Committed r90788: <http://trac.webkit.org/changeset/90788> 435243 6 mrobinson 2011-07-11 15:43:26 -0700 Thanks for the review! I used the line: "No new tests. This is covered by manual-tests/cursor.html." 97357 2011-06-15 13:40:32 -0700 2011-07-06 21:03:07 -0700 Patch bug-62752-20110615134030.patch text/plain 2124 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogODg5NDkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxOTIwMTI1MWIzYmFlNTIy ZWI4ZTNlZWE4M2IyNmEyZTY5MzFkYWExLi44MDEzMzRlNWIwYzA5NjdhYWQ1ZGM0ZjA0MWUwMDg4 YTZlNDJmZGUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDYtMTUgIE1hcnRp biBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIFRyYW5zaXRpb24gdG8gTW96aWxsYSBu YW1lZCBjdXJzb3JzIGhhdmUgaW5jb3JyZWN0IGhvdHNwb3QgYW5kIHJlbmRlcmluZworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjI3NTIKKworICAgICAg ICBJbnN0ZWFkIG9mIG9mZnNldHRpbmcgdGhlIGN1cnNvciBibGl0IGJ5IHRoZSBob3RzcG90LCBq dXN0IHBhc3MgdGhlIGhvdHNwb3QKKyAgICAgICAgYXJndW1lbnRzIHRvIHRoZSBHZGtDdXJzb3Ig Y29uc3RydWN0b3IuCisKKyAgICAgICAgKiBtYW51YWwtdGVzdHMvY3Vyc29yLmh0bWw6IFRoZSBn cmFiIGN1cnNvciBkaXYgY292ZXJzIHRoaXMgY2hhbmdlLgorCisgICAgICAgICogcGxhdGZvcm0v Z3RrL0N1cnNvckd0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVOYW1lZEN1cnNvcik6 CisKIDIwMTEtMDYtMTUgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRjaGVyLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3RrL0N1cnNvckd0ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n dGsvQ3Vyc29yR3RrLmNwcAppbmRleCA5YzVjMTZjMTgxOGYwNGEyMmU2ODlhNzZjNmE0MDA3ZTRk NDc1MzI2Li43YTg1YmYxNmIyMDBhZTM4YjNlZGEwZTVkZDk2Mzk0OWU3YjIzODVmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvQ3Vyc29yR3RrLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvQ3Vyc29yR3RrLmNwcApAQCAtNTIsMTEgKzUyLDExIEBA IHN0YXRpYyBHUmVmUHRyPEdka0N1cnNvcj4gY3JlYXRlTmFtZWRDdXJzb3IoQ3VzdG9tQ3Vyc29y VHlwZSBjdXJzb3JUeXBlKQogICAgIFJlZlB0cjxjYWlyb19zdXJmYWNlX3Q+IHN1cmZhY2UgPSBh ZG9wdFJlZihjYWlyb19pbWFnZV9zdXJmYWNlX2NyZWF0ZShDQUlST19GT1JNQVRfQTEsIDMyLCAz MikpOwogICAgIFJlZlB0cjxjYWlyb190PiBjciA9IGFkb3B0UmVmKGNhaXJvX2NyZWF0ZShzdXJm YWNlLmdldCgpKSk7CiAKLSAgICBjYWlyb19zZXRfc291cmNlX3N1cmZhY2UoY3IuZ2V0KCksIHNv dXJjZS5nZXQoKSwgY3Vyc29yLmhvdF94LCBjdXJzb3IuaG90X3kpOwotICAgIGNhaXJvX21hc2tf c3VyZmFjZShjci5nZXQoKSwgbWFzay5nZXQoKSwgY3Vyc29yLmhvdF94LCBjdXJzb3IuaG90X3kp OworICAgIGNhaXJvX3NldF9zb3VyY2Vfc3VyZmFjZShjci5nZXQoKSwgc291cmNlLmdldCgpLCAw LCAwKTsKKyAgICBjYWlyb19tYXNrX3N1cmZhY2UoY3IuZ2V0KCksIG1hc2suZ2V0KCksIDAsIDAp OwogCiAgICAgR1JlZlB0cjxHZGtQaXhidWY+IHBpeGJ1ZiA9IGFkb3B0R1JlZihnZGtfcGl4YnVm X2dldF9mcm9tX3N1cmZhY2Uoc3VyZmFjZS5nZXQoKSwgMCwgMCwgMzIsIDMyKSk7Ci0gICAgcmV0 dXJuIGFkb3B0R1JlZihnZGtfY3Vyc29yX25ld19mcm9tX3BpeGJ1ZihnZGtfZGlzcGxheV9nZXRf ZGVmYXVsdCgpLCBwaXhidWYuZ2V0KCksIDAsIDApKTsKKyAgICByZXR1cm4gYWRvcHRHUmVmKGdk a19jdXJzb3JfbmV3X2Zyb21fcGl4YnVmKGdka19kaXNwbGF5X2dldF9kZWZhdWx0KCksIHBpeGJ1 Zi5nZXQoKSwgY3Vyc29yLmhvdF94LCBjdXJzb3IuaG90X3kpKTsKIH0KIAogc3RhdGljIEdSZWZQ dHI8R2RrQ3Vyc29yPiBjcmVhdGVDdXN0b21DdXJzb3IoSW1hZ2UqIGltYWdlLCBjb25zdCBJbnRQ b2ludCYgaG90U3BvdCkK