62751 2011-06-15 13:27:36 -0700 we should only log the test names to the tests_run.txt files during layout_tests 2011-06-20 14:30:46 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Trivial --- 1 dpranke dpranke abarth eric ojan ossy tony webkit.review.bot oldest_to_newest 421536 0 dpranke 2011-06-15 13:27:36 -0700 Currently, both ORWT and NRWT log the full path to the test being run to a file in the layout-test-results directory. There's not really any need for the full path, so we should just log the test names (which are relative paths using unix-style directory separators) instead. See bug 58692 for a bit of background on the change that added the logging to ORWT (NRWT has had this forever). 421539 1 97355 dpranke 2011-06-15 13:31:52 -0700 Created attachment 97355 Patch 421603 2 97355 eric 2011-06-15 15:08:04 -0700 Comment on attachment 97355 Patch Seems fine. But would be nice to have a unit test. 421604 3 eric 2011-06-15 15:08:27 -0700 (I only care about worker.py, ORWT is deadman walking.) 421798 4 ossy 2011-06-15 23:33:00 -0700 (In reply to comment #3) > (I only care about worker.py, ORWT is deadman walking.) rs=me for ORWT change. Thanks for the fix. 423869 5 97840 dpranke 2011-06-20 12:39:04 -0700 Created attachment 97840 add testing of the contents of tests_run*.txt per review feedback from eseidel 423953 6 97840 webkit.review.bot 2011-06-20 14:30:41 -0700 Comment on attachment 97840 add testing of the contents of tests_run*.txt per review feedback from eseidel Clearing flags on attachment: 97840 Committed r89290: <http://trac.webkit.org/changeset/89290> 423954 7 webkit.review.bot 2011-06-20 14:30:46 -0700 All reviewed patches have been landed. Closing bug. 97355 2011-06-15 13:31:52 -0700 2011-06-20 12:39:01 -0700 Patch bug-62751-20110615133151.patch text/plain 2015 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogODg2ODUKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1ZDViNWZmNDQ4Nzc4Zjc4ODZkOTViMTVjNGY0Njg3MDNm MTRmMmY1Li41MDAxOWI5YWNjZTA1MjBmYjBlZTRhMzVhZDQ5M2FmY2Y3YjlhMTUyIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDYtMTUgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgd2Ugc2hvdWxkIG9u bHkgbG9nIHRoZSB0ZXN0IG5hbWVzIHRvIHRoZSB0ZXN0c19ydW4udHh0IGZpbGVzIGR1cmluZyBs YXlvdXRfdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTYyNzUxCisKKyAgICAgICAgKiBTY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzOgorICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3dvcmtl ci5weToKKwogMjAxMS0wNi0xNCAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1Rvb2xz L1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMgYi9Ub29scy9TY3JpcHRzL29sZC1ydW4td2Vi a2l0LXRlc3RzCmluZGV4IGFlZTQ4YTZiMzMzZWYyY2I4ZjNhZDI2ZWI5NzQzNjlkNGQ4ZDA5NmMu LjBkMjVlMjFlZmMzY2JiZGVjNTdkZWY1MTgzMGQ5NzVjYTk2MjNkNTYgMTAwNzU1Ci0tLSBhL1Rv b2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9vbGQt cnVuLXdlYmtpdC10ZXN0cwpAQCAtNzUyLDcgKzc1Miw3IEBAIGZvciBteSAkdGVzdCAoQHRlc3Rz KSB7CiAKICAgICBteSAkc3RhcnRUaW1lID0gdGltZSBpZiAkcmVwb3J0MTBTbG93ZXN0OwogCi0g ICAgcHJpbnQgJHRlc3RzX3J1bl9maCAiJHRlc3REaXJlY3RvcnkvJHRlc3RcbiI7CisgICAgcHJp bnQgJHRlc3RzX3J1bl9maCAiJHRlc3RcbiI7CiAKICAgICAjIFRyeSB0byByZWFkIGV4cGVjdGVk IGhhc2ggZmlsZSBmb3IgcGl4ZWwgdGVzdHMKICAgICBteSAkc3VmZml4RXhwZWN0ZWRIYXNoID0g IiI7CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlv dXRfcGFja2FnZS93b3JrZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9sYXlvdXRfcGFja2FnZS93b3JrZXIucHkKaW5kZXggYWI1ZDc2ZmFhZGNmYzE4NzE3ZWM0MGMy YWI4YWYwNTc3OTA1MmZmMy4uY2E0MjdlYmM2MjgyNmUwN2Q4N2QxYTEyMTA0MzA5Y2I5NmFlNmI2 NSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0 X3BhY2thZ2Uvd29ya2VyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL2xheW91dF9wYWNrYWdlL3dvcmtlci5weQpAQCAtMjAxLDggKzIwMSw4IEBAIGNsYXNzIFdv cmtlcihtYW5hZ2VyX3dvcmtlcl9icm9rZXIuQWJzdHJhY3RXb3JrZXIpOgogCiAgICAgZGVmIGNs ZWFuX3VwX2FmdGVyX3Rlc3Qoc2VsZiwgdGVzdF9pbnB1dCwgcmVzdWx0KToKICAgICAgICAgc2Vs Zi5fYmF0Y2hfY291bnQgKz0gMQotICAgICAgICBzZWxmLl90ZXN0c19ydW5fZmlsZS53cml0ZSh0 ZXN0X2lucHV0LmZpbGVuYW1lICsgIlxuIikKICAgICAgICAgdGVzdF9uYW1lID0gc2VsZi5fcG9y dC5yZWxhdGl2ZV90ZXN0X2ZpbGVuYW1lKHRlc3RfaW5wdXQuZmlsZW5hbWUpCisgICAgICAgIHNl bGYuX3Rlc3RzX3J1bl9maWxlLndyaXRlKHRlc3RfbmFtZSArICJcbiIpCiAKICAgICAgICAgaWYg cmVzdWx0LmZhaWx1cmVzOgogICAgICAgICAgICAgIyBDaGVjayBhbmQga2lsbCBEdW1wUmVuZGVy VHJlZSBpZiB3ZSBuZWVkIHRvLgo= 97840 2011-06-20 12:39:04 -0700 2011-06-20 14:30:41 -0700 add testing of the contents of tests_run*.txt per review feedback from eseidel bug-62751-20110620123903.patch text/plain 3309 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogODg2ODUKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4OTJlM2YxMjI5ODA5MDQzYjIwNGNmZGYwYzI1YjRiMTA0 NmZjYjgyLi43YThkNWZkMzdlMDFmNDU4NzY2MmQwNWQ1ZmRhY2Q1NWY2ODZjNGM0IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDYtMTUgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgd2Ugc2hvdWxkIG9u bHkgbG9nIHRoZSB0ZXN0IG5hbWVzIHRvIHRoZSB0ZXN0c19ydW4udHh0IGZpbGVzIGR1cmluZyBs YXlvdXRfdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTYyNzUxCisKKyAgICAgICAgKiBTY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzOgorICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3dvcmtl ci5weToKKwogMjAxMS0wNi0xMyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFp bC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjg4NjcxLgpkaWZmIC0t Z2l0IGEvVG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0cyBiL1Rvb2xzL1NjcmlwdHMv b2xkLXJ1bi13ZWJraXQtdGVzdHMKaW5kZXggYWVlNDhhNmIzMzNlZjJjYjhmM2FkMjZlYjk3NDM2 OWQ0ZDhkMDk2Yy4uMGQyNWUyMWVmYzNjYmJkZWM1N2RlZjUxODMwZDk3NWNhOTYyM2Q1NiAxMDA3 NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0cworKysgYi9Ub29scy9T Y3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzCkBAIC03NTIsNyArNzUyLDcgQEAgZm9yIG15ICR0 ZXN0IChAdGVzdHMpIHsKIAogICAgIG15ICRzdGFydFRpbWUgPSB0aW1lIGlmICRyZXBvcnQxMFNs b3dlc3Q7CiAKLSAgICBwcmludCAkdGVzdHNfcnVuX2ZoICIkdGVzdERpcmVjdG9yeS8kdGVzdFxu IjsKKyAgICBwcmludCAkdGVzdHNfcnVuX2ZoICIkdGVzdFxuIjsKIAogICAgICMgVHJ5IHRvIHJl YWQgZXhwZWN0ZWQgaGFzaCBmaWxlIGZvciBwaXhlbCB0ZXN0cwogICAgIG15ICRzdWZmaXhFeHBl Y3RlZEhhc2ggPSAiIjsKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL2xheW91dF9wYWNrYWdlL3dvcmtlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3dvcmtlci5weQppbmRleCBhYjVkNzZmYWFkY2Zj MTg3MTdlYzQwYzJhYjhhZjA1Nzc5MDUyZmYzLi5jYTQyN2ViYzYyODI2ZTA3ZDg3ZDFhMTIxMDQz MDljYjk2YWU2YjY1IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9sYXlvdXRfcGFja2FnZS93b3JrZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2Uvd29ya2VyLnB5CkBAIC0yMDEsOCArMjAxLDgg QEAgY2xhc3MgV29ya2VyKG1hbmFnZXJfd29ya2VyX2Jyb2tlci5BYnN0cmFjdFdvcmtlcik6CiAK ICAgICBkZWYgY2xlYW5fdXBfYWZ0ZXJfdGVzdChzZWxmLCB0ZXN0X2lucHV0LCByZXN1bHQpOgog ICAgICAgICBzZWxmLl9iYXRjaF9jb3VudCArPSAxCi0gICAgICAgIHNlbGYuX3Rlc3RzX3J1bl9m aWxlLndyaXRlKHRlc3RfaW5wdXQuZmlsZW5hbWUgKyAiXG4iKQogICAgICAgICB0ZXN0X25hbWUg PSBzZWxmLl9wb3J0LnJlbGF0aXZlX3Rlc3RfZmlsZW5hbWUodGVzdF9pbnB1dC5maWxlbmFtZSkK KyAgICAgICAgc2VsZi5fdGVzdHNfcnVuX2ZpbGUud3JpdGUodGVzdF9uYW1lICsgIlxuIikKIAog ICAgICAgICBpZiByZXN1bHQuZmFpbHVyZXM6CiAgICAgICAgICAgICAjIENoZWNrIGFuZCBraWxs IER1bXBSZW5kZXJUcmVlIGlmIHdlIG5lZWQgdG8uCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzX2ludGVncmF0aW9udGVzdC5w eSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNf aW50ZWdyYXRpb250ZXN0LnB5CmluZGV4IGYyMzJjYTI5MWQxYWE2YmFmZDY4MmU4ZmYxMmVhMTNh NWUzNmUzZDQuLjYyODVhNzk1ODBjMWYzZTVkYmZiM2NmYWU4MGIyNjk3ZTU3MjljZDUgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVz dHNfaW50ZWdyYXRpb250ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNfaW50ZWdyYXRpb250ZXN0LnB5CkBAIC0zNTEsOCArMzUx LDEyIEBAIGNsYXNzIE1haW5UZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgc2VsZi5h c3NlcnRFcXVhbHMocmVzLCA1KQogCiAgICAgZGVmIHRlc3Rfc2luZ2xlX2ZpbGUoc2VsZik6Ci0g ICAgICAgIHRlc3RzX3J1biA9IGdldF90ZXN0c19ydW4oWydwYXNzZXMvdGV4dC5odG1sJ10sIHRl c3RzX2luY2x1ZGVkPVRydWUsIGZsYXR0ZW5fYmF0Y2hlcz1UcnVlKQotICAgICAgICBzZWxmLmFz c2VydEVxdWFscyhbJ3Bhc3Nlcy90ZXh0Lmh0bWwnXSwgdGVzdHNfcnVuKQorICAgICAgICAjIEZJ WE1FOiBXZSBzaG91bGQgY29uc2lkZXIgcmVwbGFjaW5nIG1vcmUgb2YgdGhlIGdldF90ZXN0c19y dW4oKS1zdHlsZSB0ZXN0cworICAgICAgICAjIHdpdGggdGVzdHMgdGhhdCByZWFkIHRoZSB0ZXN0 c19ydW4qIGZpbGVzLCBsaWtlIHRoaXMgb25lLgorICAgICAgICBmcyA9IHBvcnQudW5pdF90ZXN0 X2ZpbGVzeXN0ZW0oKQorICAgICAgICB0ZXN0c19ydW4gPSBwYXNzaW5nX3J1bihbJ3Bhc3Nlcy90 ZXh0Lmh0bWwnXSwgdGVzdHNfaW5jbHVkZWQ9VHJ1ZSwgZmlsZXN5c3RlbT1mcykKKyAgICAgICAg c2VsZi5hc3NlcnRFcXVhbHMoZnMucmVhZF90ZXh0X2ZpbGUoJy90bXAvbGF5b3V0LXRlc3QtcmVz dWx0cy90ZXN0c19ydW4wLnR4dCcpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAncGFzc2Vz L3RleHQuaHRtbFxuJykKIAogICAgIGRlZiB0ZXN0X3NpbmdsZV9maWxlX3dpdGhfcHJlZml4KHNl bGYpOgogICAgICAgICB0ZXN0c19ydW4gPSBnZXRfdGVzdHNfcnVuKFsnTGF5b3V0VGVzdHMvcGFz c2VzL3RleHQuaHRtbCddLCB0ZXN0c19pbmNsdWRlZD1UcnVlLCBmbGF0dGVuX2JhdGNoZXM9VHJ1 ZSkK