62744 2011-06-15 12:11:08 -0700 [Qt] enable icu build not work 2011-06-17 02:33:21 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Normal --- 1 qi.2.zhang qi.2.zhang christian.webkit cshu kenneth kimmo.t.kinnunen laszlo.gombos webkit.review.bot zalan oldest_to_newest 421490 0 qi.2.zhang 2011-06-15 12:11:08 -0700 enable icu build not work 421495 1 97342 qi.2.zhang 2011-06-15 12:21:57 -0700 Created attachment 97342 patch See https://bugs.webkit.org/attachment.cgi?bugid=60786, which define use_system_icu to enable WTF_USE_QT4_UNICODE or WTF_USE_ICU_UNICODE. But in Platform.h we still keep the default flag to enable WTF_USE_QT4_UNICODE, which means when we use use_system_icu, actually both of them will be enabled. 421925 2 97342 laszlo.gombos 2011-06-16 06:22:53 -0700 Comment on attachment 97342 patch I prefer to keep these rules in the source code and not in the build system. Instead of removing this from the source code, can we do the following ? #ifndef WTF_USE_ICU_UNICODE #define WTF_USE_QT4_UNICODE 1 #endif 421945 3 97441 qi.2.zhang 2011-06-16 07:27:02 -0700 Created attachment 97441 patch2 Renew the patch. 421988 4 97441 laszlo.gombos 2011-06-16 09:13:14 -0700 Comment on attachment 97441 patch2 Looks good to me. Thanks. 422009 5 97441 webkit.review.bot 2011-06-16 09:56:09 -0700 Comment on attachment 97441 patch2 Clearing flags on attachment: 97441 Committed r89037: <http://trac.webkit.org/changeset/89037> 422010 6 webkit.review.bot 2011-06-16 09:56:13 -0700 All reviewed patches have been landed. Closing bug. 97342 2011-06-15 12:21:57 -0700 2011-06-16 07:27:02 -0700 patch 62744.patch text/plain 1181 qi.2.zhang SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODg5NjMpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTEtMDYtMTUgIFFpIFpoYW5nICA8cWkuMi56aGFuZ0Bub2tpYS5jb20+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBlbmFibGUgaWN1IGJ1 aWxkIG5vdCB3b3JrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02Mjc0NAorCisgICAgICAgIFdURl9VU0VfUVQ0X1VOSUNPREUgb3IgV1RGX1VTRV9JQ1Vf VU5JQ09ERSBhcmUgYWxyZWFkeSBkZWZpbmVkIGluIEphdmFTY3JpcHRDb3JlLnByaSBhbmQKKyAg ICAgICAgZmVhdHVyZS5wcmksIHJlbW92ZSBpdCBmcm9tIFBsYXRmb3JtLmgKKworICAgICAgICAq IHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDExLTA2LTE1ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvd3RmL1BsYXRmb3JtLmgJKHJldmlzaW9uIDg4NjQ2KQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCSh3b3JraW5nIGNvcHkpCkBAIC02MDAsNyArNjAwLDcg QEAKICNlbmRpZiAgLyogT1MoV0lOQ0UpICYmICFQTEFURk9STShRVCkgKi8KIAogI2lmIFBMQVRG T1JNKFFUKQotI2RlZmluZSBXVEZfVVNFX1FUNF9VTklDT0RFIDEKKy8qIFdURl9VU0VfUVQ0X1VO SUNPREUgb3IgV1RGX1VTRV9JQ1VfVU5JQ09ERSBpcyBkZWZpbmVkIGluIEphdmFTY3JpcHRDb3Jl LnByaSBhbmQgZmVhdHVyZS5wcmkgKi8KICNlbGlmIE9TKFdJTkNFKQogI2RlZmluZSBXVEZfVVNF X1dJTkNFX1VOSUNPREUgMQogI2VsaWYgUExBVEZPUk0oQlJFV01QKQo= 97441 2011-06-16 07:27:02 -0700 2011-06-16 09:56:09 -0700 patch2 62744_2.patch text/plain 1061 qi.2.zhang SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODkwMjQpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTEtMDYtMTYgIFFpIFpoYW5nICA8cWkuMi56aGFuZ0Bub2tpYS5jb20+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBGaXggYnVpbGRpbmcg d2l0aCBDT05GSUcodXNlX3N5c3RlbV9pY3UpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02Mjc0NAorCisgICAgICAgIERvIG5vdCBkZWZpbmUgV1RGX1VT RV9RVDRfVU5JQ09ERSBpZiBXVEZfVVNFX0lDVV9VTklDT0RFIGlzIHNldC4KKworICAgICAgICAq IHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDExLTA2LTE1ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS93dGYvUGxhdGZvcm0uaAkocmV2aXNpb24gODg2NDYpCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvd3RmL1BsYXRmb3JtLmgJKHdvcmtpbmcgY29weSkKQEAgLTYwMCw3ICs2MDAsOSBA QAogI2VuZGlmICAvKiBPUyhXSU5DRSkgJiYgIVBMQVRGT1JNKFFUKSAqLwogCiAjaWYgUExBVEZP Uk0oUVQpCisjaWZuZGVmIFdURl9VU0VfSUNVX1VOSUNPREUKICNkZWZpbmUgV1RGX1VTRV9RVDRf VU5JQ09ERSAxCisjZW5kaWYKICNlbGlmIE9TKFdJTkNFKQogI2RlZmluZSBXVEZfVVNFX1dJTkNF X1VOSUNPREUgMQogI2VsaWYgUExBVEZPUk0oQlJFV01QKQo=