<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>62738</bug_id>
          
          <creation_ts>2011-06-15 10:33:47 -0700</creation_ts>
          <short_desc>Reduce the size of global_resolve</short_desc>
          <delta_ts>2011-06-15 11:27:24 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Oliver Hunt">oliver</reporter>
          <assigned_to name="Oliver Hunt">oliver</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>421431</commentid>
    <comment_count>0</comment_count>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2011-06-15 10:33:47 -0700</bug_when>
    <thetext>Reduce the size of global_resolve</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>421434</commentid>
    <comment_count>1</comment_count>
      <attachid>97321</attachid>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2011-06-15 10:41:20 -0700</bug_when>
    <thetext>Created attachment 97321
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>421461</commentid>
    <comment_count>2</comment_count>
      <attachid>97321</attachid>
    <who name="Sam Weinig">sam</who>
    <bug_when>2011-06-15 11:19:02 -0700</bug_when>
    <thetext>Comment on attachment 97321
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97321&amp;action=review

&gt; Source/JavaScriptCore/ChangeLog:8
&gt; +        Reduce the code size of global_resolve in the JIT but replacing

Typo but -&gt; by.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>421470</commentid>
    <comment_count>3</comment_count>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2011-06-15 11:27:24 -0700</bug_when>
    <thetext>Committed r88962: &lt;http://trac.webkit.org/changeset/88962&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>97321</attachid>
            <date>2011-06-15 10:41:20 -0700</date>
            <delta_ts>2011-06-15 11:19:02 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-62738-20110615104119.patch</filename>
            <type>text/plain</type>
            <size>4069</size>
            <attacher name="Oliver Hunt">oliver</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogODg4NzMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDBj
ZTJmOGMzOGZhNzhkZjIwNmI1NDlhZTE4NGY2MzFlYjE3MzA0ZjIuLjUwNTk3OTI2ZTk0ZjYzMjMx
MTE0YWEyMDA2NjNhNDNhZGMyNWNmOGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz
ICsxLDE5IEBACisyMDExLTA2LTE1ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVkdWNlIHRo
ZSBzaXplIG9mIGdsb2JhbF9yZXNvbHZlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD02MjczOAorCisgICAgICAgIFJlZHVjZSB0aGUgY29kZSBzaXplIG9m
IGdsb2JhbF9yZXNvbHZlIGluIHRoZSBKSVQgYnV0IHJlcGxhY2luZworICAgICAgICBtdWx0aXBs
ZSBwb2ludGVyIGxvYWRzIHdpdGggYSBzaW5nbGUgcG9pbnRlciBtb3ZlICsgdHdvIG9mZnNldAor
ICAgICAgICBsb2Fkcy4KKworICAgICAgICAqIGppdC9KSVRPcGNvZGVzLmNwcDoKKyAgICAgICAg
KEpTQzo6SklUOjplbWl0X29wX3Jlc29sdmVfZ2xvYmFsKToKKyAgICAgICAgKiBqaXQvSklUT3Bj
b2RlczMyXzY0LmNwcDoKKyAgICAgICAgKEpTQzo6SklUOjplbWl0X29wX3Jlc29sdmVfZ2xvYmFs
KToKKwogMjAxMS0wNi0xNCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAg
ICAgIFJldmlld2VkIGJ5IEdhdmluIEJhcnJhY2xvdWdoLgpkaWZmIC0tZ2l0IGEvU291cmNlL0ph
dmFTY3JpcHRDb3JlL2ppdC9KSVRPcGNvZGVzLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9q
aXQvSklUT3Bjb2Rlcy5jcHAKaW5kZXggOWYwZjU1MjhiZWEyZmVmZDhiZTExM2NmNmNiZWZiMWFi
ZjE1Zjg5ZC4uMzc4OGI1MDZhOGM4ZWU1NGIzMWQ1OWIwMmFhYTMxZTdjMmQ2MzA1YiAxMDA2NDQK
LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGNvZGVzLmNwcAorKysgYi9Tb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wY29kZXMuY3BwCkBAIC02MzgsMTggKzYzOCwxOCBA
QCB2b2lkIEpJVDo6ZW1pdF9vcF9yZXNvbHZlX2dsb2JhbChJbnN0cnVjdGlvbiogY3VycmVudElu
c3RydWN0aW9uLCBib29sKQogICAgIC8vIEZhc3QgY2FzZQogICAgIHZvaWQqIGdsb2JhbE9iamVj
dCA9IG1fY29kZUJsb2NrLT5nbG9iYWxPYmplY3QoKTsKICAgICB1bnNpZ25lZCBjdXJyZW50SW5k
ZXggPSBtX2dsb2JhbFJlc29sdmVJbmZvSW5kZXgrKzsKLSAgICB2b2lkKiBzdHJ1Y3R1cmVBZGRy
ZXNzID0gJihtX2NvZGVCbG9jay0+Z2xvYmFsUmVzb2x2ZUluZm8oY3VycmVudEluZGV4KS5zdHJ1
Y3R1cmUpOwotICAgIHZvaWQqIG9mZnNldEFkZHIgPSAmKG1fY29kZUJsb2NrLT5nbG9iYWxSZXNv
bHZlSW5mbyhjdXJyZW50SW5kZXgpLm9mZnNldCk7CisgICAgR2xvYmFsUmVzb2x2ZUluZm8qIHJl
c29sdmVJbmZvQWRkcmVzcyA9ICYobV9jb2RlQmxvY2stPmdsb2JhbFJlc29sdmVJbmZvKGN1cnJl
bnRJbmRleCkpOwogCiAgICAgLy8gQ2hlY2sgU3RydWN0dXJlIG9mIGdsb2JhbCBvYmplY3QKICAg
ICBtb3ZlKFRydXN0ZWRJbW1QdHIoZ2xvYmFsT2JqZWN0KSwgcmVnVDApOwotICAgIGxvYWRQdHIo
c3RydWN0dXJlQWRkcmVzcywgcmVnVDEpOworICAgIG1vdmUoVHJ1c3RlZEltbVB0cihyZXNvbHZl
SW5mb0FkZHJlc3MpLCByZWdUMik7CisgICAgbG9hZFB0cihBZGRyZXNzKHJlZ1QyLCBPQkpFQ1Rf
T0ZGU0VUT0YoR2xvYmFsUmVzb2x2ZUluZm8sIHN0cnVjdHVyZSkpLCByZWdUMSk7CiAgICAgYWRk
U2xvd0Nhc2UoYnJhbmNoUHRyKE5vdEVxdWFsLCByZWdUMSwgQWRkcmVzcyhyZWdUMCwgSlNDZWxs
OjpzdHJ1Y3R1cmVPZmZzZXQoKSkpKTsgLy8gU3RydWN0dXJlcyBkb24ndCBtYXRjaAogCiAgICAg
Ly8gTG9hZCBjYWNoZWQgcHJvcGVydHkKICAgICAvLyBBc3N1bWUgdGhhdCB0aGUgZ2xvYmFsIG9i
amVjdCBhbHdheXMgdXNlcyBleHRlcm5hbCBzdG9yYWdlLgogICAgIGxvYWRQdHIoQWRkcmVzcyhy
ZWdUMCwgT0JKRUNUX09GRlNFVE9GKEpTR2xvYmFsT2JqZWN0LCBtX3Byb3BlcnR5U3RvcmFnZSkp
LCByZWdUMCk7Ci0gICAgbG9hZDMyKG9mZnNldEFkZHIsIHJlZ1QxKTsKKyAgICBsb2FkMzIoQWRk
cmVzcyhyZWdUMiwgT0JKRUNUX09GRlNFVE9GKEdsb2JhbFJlc29sdmVJbmZvLCBvZmZzZXQpKSwg
cmVnVDEpOwogICAgIGxvYWRQdHIoQmFzZUluZGV4KHJlZ1QwLCByZWdUMSwgU2NhbGVQdHIpLCBy
ZWdUMCk7CiAgICAgZW1pdFB1dFZpcnR1YWxSZWdpc3RlcihjdXJyZW50SW5zdHJ1Y3Rpb25bMV0u
dS5vcGVyYW5kKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklU
T3Bjb2RlczMyXzY0LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3Bjb2RlczMy
XzY0LmNwcAppbmRleCBlOGZlMTAwMTllMTJkM2ZhNDhkZDBkOGJmYThlYzA4OTU0NDBiMWU0Li4z
MmNhOTE0M2QwMDM3MmJkOWU5OTczZDgyYTQ1NTJkNWJhZWY4NGViIDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wY29kZXMzMl82NC5jcHAKKysrIGIvU291cmNlL0ph
dmFTY3JpcHRDb3JlL2ppdC9KSVRPcGNvZGVzMzJfNjQuY3BwCkBAIC04MDYsMTcgKzgwNiwxOCBA
QCB2b2lkIEpJVDo6ZW1pdF9vcF9yZXNvbHZlX2dsb2JhbChJbnN0cnVjdGlvbiogY3VycmVudElu
c3RydWN0aW9uLCBib29sIGR5bmFtaWMpCiAgICAgdm9pZCogZ2xvYmFsT2JqZWN0ID0gbV9jb2Rl
QmxvY2stPmdsb2JhbE9iamVjdCgpOwogCiAgICAgdW5zaWduZWQgY3VycmVudEluZGV4ID0gbV9n
bG9iYWxSZXNvbHZlSW5mb0luZGV4Kys7Ci0gICAgdm9pZCogc3RydWN0dXJlQWRkcmVzcyA9ICYo
bV9jb2RlQmxvY2stPmdsb2JhbFJlc29sdmVJbmZvKGN1cnJlbnRJbmRleCkuc3RydWN0dXJlKTsK
LSAgICB2b2lkKiBvZmZzZXRBZGRyID0gJihtX2NvZGVCbG9jay0+Z2xvYmFsUmVzb2x2ZUluZm8o
Y3VycmVudEluZGV4KS5vZmZzZXQpOworICAgIEdsb2JhbFJlc29sdmVJbmZvKiByZXNvbHZlSW5m
b0FkZHJlc3MgPSAmbV9jb2RlQmxvY2stPmdsb2JhbFJlc29sdmVJbmZvKGN1cnJlbnRJbmRleCk7
CisKIAogICAgIC8vIFZlcmlmeSBzdHJ1Y3R1cmUuCiAgICAgbW92ZShUcnVzdGVkSW1tUHRyKGds
b2JhbE9iamVjdCksIHJlZ1QwKTsKLSAgICBsb2FkUHRyKHN0cnVjdHVyZUFkZHJlc3MsIHJlZ1Qx
KTsKKyAgICBtb3ZlKFRydXN0ZWRJbW1QdHIocmVzb2x2ZUluZm9BZGRyZXNzKSwgcmVnVDMpOwor
ICAgIGxvYWRQdHIoQWRkcmVzcyhyZWdUMywgT0JKRUNUX09GRlNFVE9GKEdsb2JhbFJlc29sdmVJ
bmZvLCBzdHJ1Y3R1cmUpKSwgcmVnVDEpOwogICAgIGFkZFNsb3dDYXNlKGJyYW5jaFB0cihOb3RF
cXVhbCwgcmVnVDEsIEFkZHJlc3MocmVnVDAsIEpTQ2VsbDo6c3RydWN0dXJlT2Zmc2V0KCkpKSk7
CiAKICAgICAvLyBMb2FkIHByb3BlcnR5LgogICAgIGxvYWRQdHIoQWRkcmVzcyhyZWdUMCwgT0JK
RUNUX09GRlNFVE9GKEpTR2xvYmFsT2JqZWN0LCBtX3Byb3BlcnR5U3RvcmFnZSkpLCByZWdUMik7
Ci0gICAgbG9hZDMyKG9mZnNldEFkZHIsIHJlZ1QzKTsKKyAgICBsb2FkMzIoQWRkcmVzcyhyZWdU
MywgT0JKRUNUX09GRlNFVE9GKEdsb2JhbFJlc29sdmVJbmZvLCBvZmZzZXQpKSwgcmVnVDMpOwog
ICAgIGxvYWQzMihCYXNlSW5kZXgocmVnVDIsIHJlZ1QzLCBUaW1lc0VpZ2h0LCBPQkpFQ1RfT0ZG
U0VUT0YoSlNWYWx1ZSwgdS5hc0JpdHMucGF5bG9hZCkpLCByZWdUMCk7IC8vIHBheWxvYWQKICAg
ICBsb2FkMzIoQmFzZUluZGV4KHJlZ1QyLCByZWdUMywgVGltZXNFaWdodCwgT0JKRUNUX09GRlNF
VE9GKEpTVmFsdWUsIHUuYXNCaXRzLnRhZykpLCByZWdUMSk7IC8vIHRhZwogICAgIGVtaXRTdG9y
ZShkc3QsIHJlZ1QxLCByZWdUMCk7Cg==
</data>
<flag name="review"
          id="91239"
          type_id="1"
          status="+"
          setter="sam"
    />
          </attachment>
      

    </bug>

</bugzilla>