62734 2011-06-15 09:49:26 -0700 Layout tests editing/inserting/return-key-in-hidden-field.html and return-key-span-start.html don't run in webkit2 2011-06-17 11:20:49 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sullivan webkit-unassigned rniwa webkit.review.bot oldest_to_newest 421390 0 sullivan 2011-06-15 09:49:26 -0700 These tests would run correctly if we used execCommand(insertParagraph) instead of eventSender('\n') 421477 1 97337 sullivan 2011-06-15 11:50:05 -0700 Created attachment 97337 Patch 421479 2 sullivan 2011-06-15 11:52:29 -0700 (In reply to comment #1) > Created an attachment (id=97337) [details] > Patch Note on this patch: switching to execCommand(insertParagraph) resulted in an extra newline being added in return-key-in-hidden-field. I am not sure if this is okay, or if I have changed the behavior of the test too much. Also, the qt platform has its own expected results file (which has one more newline than the original). Not sure how to check if it needs to be updated (I only have a mac to test on locally) 421488 3 97337 rniwa 2011-06-15 12:10:00 -0700 Comment on attachment 97337 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97337&action=review > LayoutTests/editing/inserting/return-key-in-hidden-field-expected.txt:6 > + Interesting to see extra line added here. Maybe because we're in standard mode now? 421489 4 rniwa 2011-06-15 12:10:08 -0700 cq? 421518 5 sullivan 2011-06-15 12:53:33 -0700 I'd like to put this patch in the commit queue, but I won't be able to watch it while I am at the conference. Should we wait till I get back in the office on Friday? 421523 6 sullivan 2011-06-15 13:03:09 -0700 (In reply to comment #3) > Interesting to see extra line added here. Maybe because we're in standard mode now? I tried deleting <!DOCTYPE html> and got the same result. 421526 7 rniwa 2011-06-15 13:05:06 -0700 (In reply to comment #5) > I'd like to put this patch in the commit queue, but I won't be able to watch it while I am at the conference. Should we wait till I get back in the office on Friday? That sounds good to me. 422772 8 97337 webkit.review.bot 2011-06-17 11:20:45 -0700 Comment on attachment 97337 Patch Clearing flags on attachment: 97337 Committed r89149: <http://trac.webkit.org/changeset/89149> 422773 9 webkit.review.bot 2011-06-17 11:20:49 -0700 All reviewed patches have been landed. Closing bug. 97337 2011-06-15 11:50:05 -0700 2011-06-17 11:20:45 -0700 Patch bug-62734-20110615115004.patch text/plain 4454 sullivan U3VidmVyc2lvbiBSZXZpc2lvbjogODg5NTgKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAxMjExZmMwYjhkYTliZWRjYTk5NWVh ZmNiODBjZTYxYWFiYmU5Y2M2Li5kNTEyZjEyZjM0Nzk3OWE0NDQ5MWQ4MjE5M2FhNzkzZTQzNWVi MGQ4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDYtMTUgIEFubmllIFN1bGxpdmFuICA8 c3VsbGl2YW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIExheW91dCB0ZXN0cyBlZGl0aW5nL2luc2VydGluZy9yZXR1cm4ta2V5 LWluLWhpZGRlbi1maWVsZC5odG1sIGFuZCByZXR1cm4ta2V5LXNwYW4tc3RhcnQuaHRtbCBkb24n dCBydW4gaW4gd2Via2l0MgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjI3MzQKKworICAgICAgICBNb2RpZnkgdGVzdHMgdG8gdXNlIGV4ZWNDb21tYW5k KGluc2VydFBhcmFncmFwaCkgaW5zdGVhZCBvZiBldmVudFNlbmRlciB0byBpbmplY3QgYSBuZXcg bGluZS4KKworICAgICAgICAqIGVkaXRpbmcvaW5zZXJ0aW5nL3JldHVybi1rZXktaW4taGlkZGVu LWZpZWxkLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBlZGl0aW5nL2luc2VydGluZy9yZXR1cm4t a2V5LWluLWhpZGRlbi1maWVsZC5odG1sOgorICAgICAgICAqIGVkaXRpbmcvaW5zZXJ0aW5nL3Jl dHVybi1rZXktc3Bhbi1zdGFydC5odG1sOgorICAgICAgICAqIHBsYXRmb3JtL21hYy13azIvU2tp cHBlZDoKKwogMjAxMS0wNi0xNSAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292LgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNlcnRpbmcvcmV0dXJuLWtleS1pbi1oaWRkZW4tZmll bGQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNlcnRpbmcvcmV0dXJuLWtl eS1pbi1oaWRkZW4tZmllbGQtZXhwZWN0ZWQudHh0CmluZGV4IDk2OTA4OTBhM2QzYzc4YzQwOGE3 ZmY2Njg1MTM5OGRhMDllNTdhYmQuLmRlYmI3ZjNiMjBjNDMxYjU2OGFkZDM2ZTY2NGQ1YjQyM2U2 NDIyYmUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL3JldHVybi1r ZXktaW4taGlkZGVuLWZpZWxkLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5n L2luc2VydGluZy9yZXR1cm4ta2V5LWluLWhpZGRlbi1maWVsZC1leHBlY3RlZC50eHQKQEAgLTMs MyArMyw0IEBAIFRoaXMgdGVzdHMgdG8gbWFrZSBzdXJlIHRoYXQgaW5zZXJ0aW5nIGEgbGluZSBi cmVhayBpbiBhIGhpZGRlbiB0ZXh0YXJlYSBkb2Vzbid0CiAKIAogCisKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL3JldHVybi1rZXktaW4taGlkZGVuLWZpZWxkLmh0 bWwgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2luc2VydGluZy9yZXR1cm4ta2V5LWluLWhpZGRlbi1m aWVsZC5odG1sCmluZGV4IGE0ZjMxN2EwNDU3YmJjNGJlNThmYjkzNGE0OTE3YWFiMjBiNDE4NTQu LjU4MWQ1NmQyYWIwMzJhMzQyNjk4YzMxMWNiMTFlMGMxNGM4YmFiOGIgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL3JldHVybi1rZXktaW4taGlkZGVuLWZpZWxkLmh0 bWwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNlcnRpbmcvcmV0dXJuLWtleS1pbi1oaWRk ZW4tZmllbGQuaHRtbApAQCAtMSwzICsxLDUgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+CiA8 Ym9keT4KIDxwPlRoaXMgdGVzdHMgdG8gbWFrZSBzdXJlIHRoYXQgaW5zZXJ0aW5nIGEgbGluZSBi cmVhayBpbiBhIGhpZGRlbiB0ZXh0YXJlYSBkb2Vzbid0IGNyYXNoLgogVG8gcmVwcm8gbWFudWFs bHksIHByZXNzIGVudGVyIG9yIHJldHVybiBpbiB0aGUgdGV4dGFyZWEuICBXZSBwYXNzIGlmIHdl IGRvbid0IGNyYXNoLjwvcD4KQEAgLTE2LDE4ICsxOCwxOSBAQCBmdW5jdGlvbiBydW5UZXN0KCkK IHsKICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGV4dGFyZWEiKS5mb2N1cygpOwogCi0g ICAgaWYgKCF3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIgfHwgIXdpbmRvdy5ldmVudFNlbmRl cikKKyAgICBpZiAoIXdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKICAgICAgICAgcmV0dXJu OwogICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKLSAgICBldmVudFNlbmRl ci5rZXlEb3duKCdcbicpOworICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCdJbnNlcnRQYXJhZ3Jh cGgnLCBmYWxzZSwgbnVsbCk7CiAKICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZDIiKS5m b2N1cygpOwogICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJkMiIpLnN0eWxlLnZpc2liaWxp dHkgPSAiIjsKIAogICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKLSAgICBl dmVudFNlbmRlci5rZXlEb3duKCdcbicpOworICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCdJbnNl cnRQYXJhZ3JhcGgnLCBmYWxzZSwgbnVsbCk7CiB9CiBydW5UZXN0KCk7CiAKIDwvc2NyaXB0Pgog PC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNlcnRp bmcvcmV0dXJuLWtleS1zcGFuLXN0YXJ0Lmh0bWwgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2luc2Vy dGluZy9yZXR1cm4ta2V5LXNwYW4tc3RhcnQuaHRtbAppbmRleCBhM2RhMDgxY2ExMDk1ODI2MGUw NDM1Njg5NDA4NTk1Y2FkNTgzMzZiLi44Y2EzNWY5MWQwOGYyNzRkNzczMWQzNGIwZmFiYjNiMWQ5 OTM4NTE2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2luc2VydGluZy9yZXR1cm4t a2V5LXNwYW4tc3RhcnQuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2luc2VydGluZy9y ZXR1cm4ta2V5LXNwYW4tc3RhcnQuaHRtbApAQCAtNiw3ICs2LDcgQEAKIDxzY3JpcHQ+CiB2YXIg c2VsID0gd2luZG93LmdldFNlbGVjdGlvbigpOwogc2VsLnNldFBvc2l0aW9uKGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCJkdXBlIiksIDApOwotZXZlbnRTZW5kZXIua2V5RG93bigiXG4iKTsKK2Rv Y3VtZW50LmV4ZWNDb21tYW5kKCdJbnNlcnRQYXJhZ3JhcGgnLCBmYWxzZSwgbnVsbCkKIE1hcmt1 cC5kZXNjcmlwdGlvbigiVGhpcyBzZXRzIHRoZSBzZWxlY3Rpb24gdG8gdGhlIHN0YXJ0IG9mIGEg c3BhbiwgYW5kIGhpdHMgdGhlIGVudGVyIGtleS5cbiIKICAgICArICJFeHBlY3RlZCBiZWhhdmlv cjogd2hlbiB0aGUgc3BhbiBpcyBzcGxpdCwgaXRzIElEIHNob3VsZCBub3QgYmUgZHVwbGljYXRl ZC4gU2VlIGJ1ZyA2MjYyMS4iKTsKIE1hcmt1cC5kdW1wKHJvb3QpOwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjLXdrMi9Ta2lwcGVkCmluZGV4IDE0MzZmMjBiMTFmYjMxZGFjMjVjMTRiMzkxYWY1MzJkZDIx NmI2ZjguLjRiNzdkZjM4MDI1ZjhhMDAyYmQ5NThmMTg3ZWFlNzg0NDBhZmRhMjcgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9tYWMtd2syL1NraXBwZWQKQEAgLTg1LDcgKzg1LDYgQEAgZWRpdGluZy9pbnB1 dC9lbWFjcy1jdHJsLW8uaHRtbAogZWRpdGluZy9pbnB1dC9vcHRpb24tcGFnZS11cC1kb3duLmh0 bWwKIGVkaXRpbmcvaW5wdXQvcGFnZS11cC1kb3duLXNjcm9sbHMuaHRtbAogZWRpdGluZy9pbnB1 dC9zY3JvbGwtdmlld3BvcnQtcGFnZS11cC1kb3duLmh0bWwKLWVkaXRpbmcvaW5zZXJ0aW5nL3Jl dHVybi1rZXktaW4taGlkZGVuLWZpZWxkLmh0bWwKIGVkaXRpbmcvaW5zZXJ0aW5nL3R5cGluZy10 YWItZGVzaWdubW9kZS1mb3Jtcy5odG1sCiBlZGl0aW5nL2luc2VydGluZy90eXBpbmctdGFiLWRl c2lnbm1vZGUuaHRtbAogZWRpdGluZy9wYXN0ZWJvYXJkLzQ5NDQ3NzAtMi5odG1sCkBAIC0xNzgx LDcgKzE3ODAsNiBAQCBmYXN0L2Zvcm1zL3JhZGlvLWdyb3VwLWtleWJvYXJkLWNoYW5nZS1ldmVu dC5odG1sCiBmYXN0L2Zvcm1zL2ZvY3VzLXdpdGgtZGlzcGxheS1ibG9jay5odG1sCiBmYXN0L2Zv cm1zL1ZhbGlkaXR5U3RhdGUtdmFsdWVNaXNzaW5nLTAwMi5odG1sCiBzdmcvY3VzdG9tL2ZvY3Vz LWV2ZW50LWhhbmRsaW5nLWtleWJvYXJkLnhodG1sCi1lZGl0aW5nL2luc2VydGluZy9yZXR1cm4t a2V5LXNwYW4tc3RhcnQuaHRtbAogCiAjIGV2ZW50U2VuZGVyLmNvbnRleHRDbGljaygpIGlzIHVu aW1wbGVtZW50ZWQKIGVkaXRpbmcvc3BlbGxpbmcvc3BlbGxjaGVjay1pbnB1dC1zZWFyY2gtY3Jh c2guaHRtbAo=