62726 2011-06-15 07:33:40 -0700 REGRESSION(r88723): Stack can be empty, so it needs to be checked before as pointed out in the comments of the bug. (Requested by demarchi on #webkit). 2011-06-15 07:38:39 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 62536 1 webkit.review.bot webkit.review.bot eric lucas.de.marchi oldest_to_newest 421262 0 webkit.review.bot 2011-06-15 07:33:40 -0700 http://trac.webkit.org/changeset/88723 broke the build: Stack can be empty, so it needs to be checked before as pointed out in the comments of the bug. (Requested by demarchi on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 421263 1 97291 webkit.review.bot 2011-06-15 07:34:03 -0700 Created attachment 97291 ROLLOUT of r88723 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment. 421268 2 97291 lucas.de.marchi 2011-06-15 07:38:26 -0700 Comment on attachment 97291 ROLLOUT of r88723 Clearing flags on attachment: 97291 Committed r88928: <http://trac.webkit.org/changeset/88928> 421269 3 lucas.de.marchi 2011-06-15 07:38:39 -0700 All reviewed patches have been landed. Closing bug. 97291 2011-06-15 07:34:03 -0700 2011-06-15 07:38:25 -0700 ROLLOUT of r88723 bug-62726-20110615143219.patch text/plain 3220 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogODg5MjcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCA3YzBlMWQ4MmY2 MWI1NWVmMzYxMjFjYWYzYTQ2NjVjMTI1NjZkNTE3Li5lN2MxYWIyZGQzZTczYWM3NjIyNDBjZGFm ODlmOTEwOTkwMzc2NWE4IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEt MDYtMTUgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgorCisgICAg ICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI4ODcyMy4KKyAgICAgICAgaHR0cDovL3RyYWMu d2Via2l0Lm9yZy9jaGFuZ2VzZXQvODg3MjMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTYyNzI2CisKKyAgICAgICAgU3RhY2sgY2FuIGJlIGVtcHR5LCBz byBpdCBuZWVkcyB0byBiZSBjaGVja2VkIGJlZm9yZSBhcworICAgICAgICBwb2ludGVkIG91dCBp biB0aGUgY29tbWVudHMgb2YgdGhlIGJ1Zy4gKFJlcXVlc3RlZCBieSBkZW1hcmNoaQorICAgICAg ICBvbiAjd2Via2l0KS4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEVm bC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFZGl0b3JDbGllbnRFZmw6OnJlZ2lzdGVyQ29tbWFu ZEZvclVuZG8pOgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9yQ2xpZW50RWZsOjpyZWdpc3RlckNv bW1hbmRGb3JSZWRvKToKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRvckNsaWVudEVmbDo6Y2xlYXJV bmRvUmVkb09wZXJhdGlvbnMpOgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9yQ2xpZW50RWZsOjpj YW5SZWRvKToKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRvckNsaWVudEVmbDo6cmVkbyk6CisgICAg ICAgICogV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50RWZsLmg6CisKIDIwMTEtMDYtMTMgIE1p Y2hhbCBQYWt1bGEgdmVsIFJ1dGthICA8bS5wYWt1bGFAc2Ftc3VuZy5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9X ZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRFZmwuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvV2Vi Q29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50RWZsLmNwcAppbmRleCA1OTgxMjdhY2UzMDQ1OGEwMTgz MzhjMzI1MWFiOGRhYWY0YjM5Njg1Li43NDVhM2JjZTY1N2QzZjJlODU1YTBkMGU1YWU4ZTY4MzIy Y2U1MGQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9FZGl0 b3JDbGllbnRFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0Vk aXRvckNsaWVudEVmbC5jcHAKQEAgLTE0NywxOSArMTQ3LDE3IEBAIHZvaWQgRWRpdG9yQ2xpZW50 RWZsOjpkaWRTZXRTZWxlY3Rpb25UeXBlc0ZvclBhc3RlYm9hcmQoKQogCiB2b2lkIEVkaXRvckNs aWVudEVmbDo6cmVnaXN0ZXJDb21tYW5kRm9yVW5kbyhXVEY6OlBhc3NSZWZQdHI8RWRpdENvbW1h bmQ+IGNvbW1hbmQpCiB7Ci0gICAgcmVkb1N0YWNrLmNsZWFyKCk7CiAgICAgdW5kb1N0YWNrLmFw cGVuZChjb21tYW5kKTsKIH0KIAotdm9pZCBFZGl0b3JDbGllbnRFZmw6OnJlZ2lzdGVyQ29tbWFu ZEZvclJlZG8oV1RGOjpQYXNzUmVmUHRyPEVkaXRDb21tYW5kPiBjb21tYW5kKQordm9pZCBFZGl0 b3JDbGllbnRFZmw6OnJlZ2lzdGVyQ29tbWFuZEZvclJlZG8oV1RGOjpQYXNzUmVmUHRyPEVkaXRD b21tYW5kPikKIHsKLSAgICByZWRvU3RhY2suYXBwZW5kKGNvbW1hbmQpOworICAgIG5vdEltcGxl bWVudGVkKCk7CiB9CiAKIHZvaWQgRWRpdG9yQ2xpZW50RWZsOjpjbGVhclVuZG9SZWRvT3BlcmF0 aW9ucygpCiB7CiAgICAgdW5kb1N0YWNrLmNsZWFyKCk7Ci0gICAgcmVkb1N0YWNrLmNsZWFyKCk7 CiB9CiAKIGJvb2wgRWRpdG9yQ2xpZW50RWZsOjpjYW5Db3B5Q3V0KEZyYW1lKiwgYm9vbCBkZWZh dWx0VmFsdWUpIGNvbnN0CkBAIC0xNzksNyArMTc3LDggQEAgYm9vbCBFZGl0b3JDbGllbnRFZmw6 OmNhblVuZG8oKSBjb25zdAogCiBib29sIEVkaXRvckNsaWVudEVmbDo6Y2FuUmVkbygpIGNvbnN0 CiB7Ci0gICAgcmV0dXJuICFyZWRvU3RhY2suaXNFbXB0eSgpOworICAgIG5vdEltcGxlbWVudGVk KCk7CisgICAgcmV0dXJuIGZhbHNlOwogfQogCiB2b2lkIEVkaXRvckNsaWVudEVmbDo6dW5kbygp CkBAIC0xOTEsOSArMTkwLDcgQEAgdm9pZCBFZGl0b3JDbGllbnRFZmw6OnVuZG8oKQogCiB2b2lk IEVkaXRvckNsaWVudEVmbDo6cmVkbygpCiB7Ci0gICAgUmVmUHRyPFdlYkNvcmU6OkVkaXRDb21t YW5kPiBjb21tYW5kKCooLS1yZWRvU3RhY2suZW5kKCkpKTsKLSAgICByZWRvU3RhY2sucmVtb3Zl KC0tcmVkb1N0YWNrLmVuZCgpKTsKLSAgICBjb21tYW5kLT5yZWFwcGx5KCk7CisgICAgbm90SW1w bGVtZW50ZWQoKTsKIH0KIAogYm9vbCBFZGl0b3JDbGllbnRFZmw6OnNob3VsZEluc2VydE5vZGUo Tm9kZSosIFJhbmdlKiwgRWRpdG9ySW5zZXJ0QWN0aW9uKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50RWZsLmggYi9Tb3VyY2UvV2ViS2l0 L2VmbC9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRFZmwuaAppbmRleCA0ZjJhNzMxNGY4ODNj NGM1OTdmOGFkYTY1MmIwYzkzMDg4YjAxZWE3Li45MTZmOTYwOGMwYmVkNTVjYWM0ZDg1ZWIwY2U5 ODNlNGJkZjUwMDYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9y dC9FZGl0b3JDbGllbnRFZmwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9y dC9FZGl0b3JDbGllbnRFZmwuaApAQCAtNDcsNyArNDcsNiBAQCBjbGFzcyBQYWdlOwogY2xhc3Mg RWRpdG9yQ2xpZW50RWZsIDogcHVibGljIEVkaXRvckNsaWVudCwgcHVibGljIFRleHRDaGVja2Vy Q2xpZW50IHsKIHByb3RlY3RlZDoKICAgICBXVEY6OkRlcXVlPFdURjo6UmVmUHRyPFdlYkNvcmU6 OkVkaXRDb21tYW5kPiA+IHVuZG9TdGFjazsKLSAgICBXVEY6OkRlcXVlPFdURjo6UmVmUHRyPFdl YkNvcmU6OkVkaXRDb21tYW5kPiA+IHJlZG9TdGFjazsKIAogcHVibGljOgogICAgIEVkaXRvckNs aWVudEVmbChFdmFzX09iamVjdCAqdmlldyk7Cg==