62713 2011-06-15 03:24:30 -0700 [EFL] Implement animationXXX functions for Progress Tag 2011-06-15 17:37:19 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim webkit-unassigned eric gyuyoung.kim kenneth leandro lucas.de.marchi rakuco tkent tonikitoo webkit.review.bot oldest_to_newest 421159 0 gyuyoung.kim 2011-06-15 03:24:30 -0700 Progress tag need to implement acnimationXXX functions in order to show animation or progress tag. animationRepeatIntervalForProgressBar() animationDurationForProgressBar() Because, RenderProgress decides to show update progress bar's animation according to the functions. I add the functions to EFL port referencing to GTK port. 421160 1 97267 gyuyoung.kim 2011-06-15 03:28:21 -0700 Created attachment 97267 Proposed Patch 421215 2 rakuco 2011-06-15 06:13:13 -0700 > Source/WebCore/platform/efl/RenderThemeEfl.cpp:1095 > +// These values have been copied from RenderThemeGtk.cpp I'd rather have all these static consts in the beginning of the file, before the actual method implementations. > Source/WebCore/platform/efl/RenderThemeEfl.cpp:1096 > +static const int progressActivityBlocks = 5; This one doesn't seem to be used. 421326 3 97300 gyuyoung.kim 2011-06-15 08:50:15 -0700 Created attachment 97300 Patch Ok, patch is modified. 421377 4 97300 leandro 2011-06-15 09:38:56 -0700 Comment on attachment 97300 Patch LGTM. 421644 5 97300 tkent 2011-06-15 16:57:28 -0700 Comment on attachment 97300 Patch Rubber stamped by me. 421656 6 97300 webkit.review.bot 2011-06-15 17:37:14 -0700 Comment on attachment 97300 Patch Clearing flags on attachment: 97300 Committed r88985: <http://trac.webkit.org/changeset/88985> 421657 7 webkit.review.bot 2011-06-15 17:37:19 -0700 All reviewed patches have been landed. Closing bug. 97267 2011-06-15 03:28:21 -0700 2011-06-15 08:56:28 -0700 Proposed Patch patch-progressbar-animation.patch text/plain 2683 gyuyoung.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0YjNjMzAzLi4yYmM0ZTBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMDYtMTUgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbRUZMXSBJ bXBsZW1lbnQgYW5pbWF0aW9uWFhYIGZ1bmN0aW9ucyBmb3IgUHJvZ3Jlc3MgVGFnCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MjcxMworCisgICAgICAg IFByb2dyZXNzIHRhZyBuZWVkIHRvIGltcGxlbWVudCBhY25pbWF0aW9uWFhYIGZ1bmN0aW9ucyBp biBvcmRlciB0byBzaG93IGFuaW1hdGlvbiBvZiAKKyAgICAgICAgcHJvZ3Jlc3MgdGFnLiBCZWNh dXNlLCBSZW5kZXJQcm9ncmVzcyBkZWNpZGVzIHRvIHNob3cgdXBkYXRlIHByb2dyZXNzIGJhcidz IGFuaW1hdGlvbgorICAgICAgICBhY2NvcmRpbmcgdG8gdGhlIGZ1bmN0aW9ucy4KKworICAgICAg ICAqIHBsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJUaGVtZUVmbDo6YW5pbWF0aW9uUmVwZWF0SW50ZXJ2YWxGb3JQcm9ncmVzc0Jhcik6IEFk ZGVkLgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVFZmw6OmFuaW1hdGlvbkR1cmF0aW9u Rm9yUHJvZ3Jlc3NCYXIpOiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvUmVuZGVyVGhl bWVFZmwuaDoKKwogMjAxMS0wNi0xMyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBIeWF0dC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwCmluZGV4IDc4NjY5MjIuLmNjNzFiYjUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcApAQCAt MTA5Miw2ICsxMDkyLDIwIEBAIHZvaWQgUmVuZGVyVGhlbWVFZmw6OmFkanVzdFByb2dyZXNzQmFy U3R5bGUoQ1NTU3R5bGVTZWxlY3Rvciogc2VsZWN0b3IsIFJlbmRlclN0CiAgICAgc3R5bGUtPnNl dEJveFNoYWRvdyhudWxscHRyKTsKIH0KIAorLy8gVGhlc2UgdmFsdWVzIGhhdmUgYmVlbiBjb3Bp ZWQgZnJvbSBSZW5kZXJUaGVtZUd0ay5jcHAKK3N0YXRpYyBjb25zdCBpbnQgcHJvZ3Jlc3NBY3Rp dml0eUJsb2NrcyA9IDU7CitzdGF0aWMgY29uc3QgaW50IHByb2dyZXNzQW5pbWF0aW9uRnJhbWVz ID0gMTA7CitzdGF0aWMgY29uc3QgZG91YmxlIHByb2dyZXNzQW5pbWF0aW9uSW50ZXJ2YWwgPSAw LjEyNTsKK2RvdWJsZSBSZW5kZXJUaGVtZUVmbDo6YW5pbWF0aW9uUmVwZWF0SW50ZXJ2YWxGb3JQ cm9ncmVzc0JhcihSZW5kZXJQcm9ncmVzcyopIGNvbnN0Cit7CisgICAgcmV0dXJuIHByb2dyZXNz QW5pbWF0aW9uSW50ZXJ2YWw7Cit9CisKK2RvdWJsZSBSZW5kZXJUaGVtZUVmbDo6YW5pbWF0aW9u RHVyYXRpb25Gb3JQcm9ncmVzc0JhcihSZW5kZXJQcm9ncmVzcyopIGNvbnN0Cit7CisgICAgcmV0 dXJuIHByb2dyZXNzQW5pbWF0aW9uSW50ZXJ2YWwgKiBwcm9ncmVzc0FuaW1hdGlvbkZyYW1lcyAq IDI7IC8vICIyIiBmb3IgYmFjayBhbmQgZm9ydGg7Cit9CisKIGJvb2wgUmVuZGVyVGhlbWVFZmw6 OnBhaW50UHJvZ3Jlc3NCYXIoUmVuZGVyT2JqZWN0KiBvYmplY3QsIGNvbnN0IFBhaW50SW5mbyYg aW5mbywgY29uc3QgSW50UmVjdCYgcmVjdCkKIHsKICAgICByZXR1cm4gcGFpbnRUaGVtZVBhcnQo b2JqZWN0LCBQcm9ncmVzc0JhciwgaW5mbywgcmVjdCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5oCmluZGV4IDYyYjBlM2EuLjQwYTM4ZDkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5oCkBAIC0xNjYsNiArMTY2 LDggQEAgcHVibGljOgogI2lmIEVOQUJMRShQUk9HUkVTU19UQUcpCiAgICAgdmlydHVhbCB2b2lk IGFkanVzdFByb2dyZXNzQmFyU3R5bGUoQ1NTU3R5bGVTZWxlY3RvciosIFJlbmRlclN0eWxlKiwg RWxlbWVudCopIGNvbnN0OwogICAgIHZpcnR1YWwgYm9vbCBwYWludFByb2dyZXNzQmFyKFJlbmRl ck9iamVjdCosIGNvbnN0IFBhaW50SW5mbyYsIGNvbnN0IEludFJlY3QmKTsKKyAgICB2aXJ0dWFs IGRvdWJsZSBhbmltYXRpb25SZXBlYXRJbnRlcnZhbEZvclByb2dyZXNzQmFyKFJlbmRlclByb2dy ZXNzKikgY29uc3Q7CisgICAgdmlydHVhbCBkb3VibGUgYW5pbWF0aW9uRHVyYXRpb25Gb3JQcm9n cmVzc0JhcihSZW5kZXJQcm9ncmVzcyopIGNvbnN0OwogI2VuZGlmCiAKICNpZiBFTkFCTEUoVklE RU8pCg== 97300 2011-06-15 08:50:15 -0700 2011-06-15 17:37:14 -0700 Patch patch-progresstag.patch text/plain 3107 gyuyoung.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2N2NkOTQxLi42NDljMDdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMDYtMTUgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbRUZMXSBJ bXBsZW1lbnQgYW5pbWF0aW9uWFhYIGZ1bmN0aW9ucyBmb3IgUHJvZ3Jlc3MgVGFnCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MjcxMworCisgICAgICAg IFByb2dyZXNzIHRhZyBuZWVkIHRvIGltcGxlbWVudCBhY25pbWF0aW9uWFhYIGZ1bmN0aW9ucyBp biBvcmRlciB0byBzaG93IGFuaW1hdGlvbiBvZiAKKyAgICAgICAgcHJvZ3Jlc3MgdGFnLiBCZWNh dXNlLCBSZW5kZXJQcm9ncmVzcyBkZWNpZGVzIHRvIHNob3cgdXBkYXRlIHByb2dyZXNzIGJhcidz IGFuaW1hdGlvbgorICAgICAgICBhY2NvcmRpbmcgdG8gdGhlIGZ1bmN0aW9ucy4KKworICAgICAg ICAqIHBsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJUaGVtZUVmbDo6YW5pbWF0aW9uUmVwZWF0SW50ZXJ2YWxGb3JQcm9ncmVzc0Jhcik6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUVmbDo6YW5pbWF0aW9uRHVyYXRpb25Gb3JQcm9n cmVzc0Jhcik6CisgICAgICAgICogcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmg6CisKIDIw MTEtMDYtMTQgIEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHAKaW5kZXggNmU3ODc5ZS4uYjJjMDAxMSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwCkBAIC02 MSwxMCArNjEsMTQgQEAgdXNpbmcgbmFtZXNwYWNlIEhUTUxOYW1lczsKIC8vIFRPRE86IGNoYW5n ZSBmcm9tIG9iamVjdCBjb3VudCB0byBlY29yZV9ldmFzIHNpemUgKGJ5dGVzKQogLy8gVE9ETzog YXMgb2JqZWN0cyBhcmUgd2VicGFnZS91c2VyIGRlZmluZWQgYW5kIHRoZXkgY2FuIGJlIHZlcnkg bGFyZ2UuCiAjZGVmaW5lIFJFTkRFUl9USEVNRV9FRkxfUEFSVF9DQUNIRV9NQVggMzIKLSAgICAK KworLy8gQ29uc3RhbnRzIGZvciBwcm9ncmVzcyB0YWcgYW5pbWF0aW9uLgorLy8gVGhlc2UgdmFs dWVzIGhhdmUgYmVlbiBjb3BpZWQgZnJvbSBSZW5kZXJUaGVtZUd0ay5jcHAKK3N0YXRpYyBjb25z dCBpbnQgcHJvZ3Jlc3NBbmltYXRpb25GcmFtZXMgPSAxMDsKK3N0YXRpYyBjb25zdCBkb3VibGUg cHJvZ3Jlc3NBbmltYXRpb25JbnRlcnZhbCA9IDAuMTI1OworCiBzdGF0aWMgY29uc3QgaW50IHNs aWRlclRodW1iV2lkdGggPSAxMjsKIHN0YXRpYyBjb25zdCBpbnQgc2xpZGVyVGh1bWJIZWlnaHQg PSAxMjsKLQogI2lmIEVOQUJMRShWSURFTykKIHN0YXRpYyBjb25zdCBpbnQgbWVkaWFTbGlkZXJI ZWlnaHQgPSAxNDsKIHN0YXRpYyBjb25zdCBpbnQgbWVkaWFTbGlkZXJUaHVtYldpZHRoID0gMTI7 CkBAIC0xMDkyLDYgKzEwOTYsMTYgQEAgdm9pZCBSZW5kZXJUaGVtZUVmbDo6YWRqdXN0UHJvZ3Jl c3NCYXJTdHlsZShDU1NTdHlsZVNlbGVjdG9yKiBzZWxlY3RvciwgUmVuZGVyU3QKICAgICBzdHls ZS0+c2V0Qm94U2hhZG93KG51bGxwdHIpOwogfQogCitkb3VibGUgUmVuZGVyVGhlbWVFZmw6OmFu aW1hdGlvblJlcGVhdEludGVydmFsRm9yUHJvZ3Jlc3NCYXIoUmVuZGVyUHJvZ3Jlc3MqKSBjb25z dAoreworICAgIHJldHVybiBwcm9ncmVzc0FuaW1hdGlvbkludGVydmFsOworfQorCitkb3VibGUg UmVuZGVyVGhlbWVFZmw6OmFuaW1hdGlvbkR1cmF0aW9uRm9yUHJvZ3Jlc3NCYXIoUmVuZGVyUHJv Z3Jlc3MqKSBjb25zdAoreworICAgIHJldHVybiBwcm9ncmVzc0FuaW1hdGlvbkludGVydmFsICog cHJvZ3Jlc3NBbmltYXRpb25GcmFtZXMgKiAyOyAvLyAiMiIgZm9yIGJhY2sgYW5kIGZvcnRoOwor fQorCiBib29sIFJlbmRlclRoZW1lRWZsOjpwYWludFByb2dyZXNzQmFyKFJlbmRlck9iamVjdCog b2JqZWN0LCBjb25zdCBQYWludEluZm8mIGluZm8sIGNvbnN0IEludFJlY3QmIHJlY3QpCiB7CiAg ICAgcmV0dXJuIHBhaW50VGhlbWVQYXJ0KG9iamVjdCwgUHJvZ3Jlc3NCYXIsIGluZm8sIHJlY3Qp OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZs LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuaAppbmRleCA2 MmIwZTNhLi40MGEzOGQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwv UmVuZGVyVGhlbWVFZmwuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUmVuZGVy VGhlbWVFZmwuaApAQCAtMTY2LDYgKzE2Niw4IEBAIHB1YmxpYzoKICNpZiBFTkFCTEUoUFJPR1JF U1NfVEFHKQogICAgIHZpcnR1YWwgdm9pZCBhZGp1c3RQcm9ncmVzc0JhclN0eWxlKENTU1N0eWxl U2VsZWN0b3IqLCBSZW5kZXJTdHlsZSosIEVsZW1lbnQqKSBjb25zdDsKICAgICB2aXJ0dWFsIGJv b2wgcGFpbnRQcm9ncmVzc0JhcihSZW5kZXJPYmplY3QqLCBjb25zdCBQYWludEluZm8mLCBjb25z dCBJbnRSZWN0Jik7CisgICAgdmlydHVhbCBkb3VibGUgYW5pbWF0aW9uUmVwZWF0SW50ZXJ2YWxG b3JQcm9ncmVzc0JhcihSZW5kZXJQcm9ncmVzcyopIGNvbnN0OworICAgIHZpcnR1YWwgZG91Ymxl IGFuaW1hdGlvbkR1cmF0aW9uRm9yUHJvZ3Jlc3NCYXIoUmVuZGVyUHJvZ3Jlc3MqKSBjb25zdDsK ICNlbmRpZgogCiAjaWYgRU5BQkxFKFZJREVPKQo=