62712 2011-06-15 03:20:16 -0700 [EFL] Remove ewk_view_scrolls_process. 2011-06-15 17:46:49 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 62688 0 ryuan.choi webkit-unassigned antognolli+webkit gyuyoung.kim gyuyoung.kim hyuki.kim leandro lucas.de.marchi rakuco oldest_to_newest 421157 0 ryuan.choi 2011-06-15 03:20:16 -0700 I don't know ewk_view_tiled too much, but, I don't know why _ewk_view_tiled_smart_zoom_set calls ewk_view_scrolls_process. evas_object_smart_calculate(sd->self) will do same thing. I think that ewk_view_scrolls_process looks no needed. 421164 1 97269 ryuan.choi 2011-06-15 03:33:58 -0700 Created attachment 97269 Patch 421235 2 antognolli+webkit 2011-06-15 06:49:49 -0700 Hello Ryuan, (In reply to comment #0) > I don't know ewk_view_tiled too much, > but, I don't know why _ewk_view_tiled_smart_zoom_set calls ewk_view_scrolls_process. > evas_object_smart_calculate(sd->self) will do same thing. It doesn't do the same thing, since ewk_view_scrolls_process(sd) will call _ewk_view_tiled_smart_scrolls_process(sd), which does more than just processing offset changes in the backing store. It gets scroll requests stored in the view (sr = ewk_view_scroll_requests_get(sd->_priv, &count)), and add them to the backing store. Then yes, the backing store could process these scroll requests normally. It also adds these scroll requests, when they are not scrolls of the entire page, as repaint requests, as you can see in the code of this function. Please take a look at it, I think you can't just remove this call without having more problems later when mixing scroll with zoom. 421667 3 ryuan.choi 2011-06-15 17:46:20 -0700 (In reply to comment #2) > Hello Ryuan, > > (In reply to comment #0) > > I don't know ewk_view_tiled too much, > > but, I don't know why _ewk_view_tiled_smart_zoom_set calls ewk_view_scrolls_process. > > evas_object_smart_calculate(sd->self) will do same thing. > > It doesn't do the same thing, since ewk_view_scrolls_process(sd) will call _ewk_view_tiled_smart_scrolls_process(sd), which does more than just processing offset changes in the backing store. It gets scroll requests stored in the view (sr = ewk_view_scroll_requests_get(sd->_priv, &count)), and add them to the backing store. Then yes, the backing store could process these scroll requests normally. > > It also adds these scroll requests, when they are not scrolls of the entire page, as repaint requests, as you can see in the code of this function. Please take a look at it, I think you can't just remove this call without having more problems later when mixing scroll with zoom. Hello, rafael. Thanks for your kindness and I almost understand. I wish to simplify them, but I understand that this patch is not way go. 97269 2011-06-15 03:33:58 -0700 2011-06-15 17:46:49 -0700 Patch bug-62712-20110615193347.patch text/plain 1519 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogODg5MDUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCA3YzBlMWQ4MmY2 MWI1NWVmMzYxMjFjYWYzYTQ2NjVjMTI1NjZkNTE3Li5mZmNiZmIwMzgyMzI5YjQ5ZmJhYzkxMzA1 NWE4MTM4MjZjODgzOTk2IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEt MDYtMTUgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIFJlbW92ZSBld2tfdmll d19zY3JvbGxzX3Byb2Nlc3MuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02MjcxMgorCisgICAgICAgIFJlbW92ZSBld2tfdmlld19zY3JvbGxzX3Byb2Nl c3MgYmVjYXVzZSBldmFzX29iamVjdF9zbWFydF9jYWxjdWxhdGUKKyAgICAgICAgY2FuIGNvdmVy IGl0LgorCisgICAgICAgICogZXdrL2V3a192aWV3X3RpbGVkLmM6CisgICAgICAgIChfZXdrX3Zp ZXdfdGlsZWRfc21hcnRfem9vbV9zZXQpOgorCiAyMDExLTA2LTEzICBNaWNoYWwgUGFrdWxhIHZl bCBSdXRrYSAgPG0ucGFrdWxhQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVy aWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3X3Rp bGVkLmMgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXdfdGlsZWQuYwppbmRleCBkMzgw ZThlNjFjOWY1MjM1N2JlOWIwMGFiZjg3NzllMmEyYmU4YTc3Li41ZDM5YTdhODc2MzM3Nzg4YzE0 M2RlNjJjYjRkZGVlODUwOWZhM2U0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX3ZpZXdfdGlsZWQuYworKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXdfdGls ZWQuYwpAQCAtMTc1LDcgKzE3NSw2IEBAIHN0YXRpYyBFaW5hX0Jvb2wgX2V3a192aWV3X3RpbGVk X3NtYXJ0X3pvb21fc2V0KEV3a19WaWV3X1NtYXJ0X0RhdGEgKnNkLCBmbG9hdCB6CiAgICAgZXdr X2ZyYW1lX3Njcm9sbF9zZXQoc2QtPm1haW5fZnJhbWUsIC14LCAteSk7CiAgICAgZXdrX2ZyYW1l X3Njcm9sbF9zaXplX2dldChzZC0+bWFpbl9mcmFtZSwgJncsICZoKTsKICAgICBld2tfdGlsZWRf YmFja2luZ19zdG9yZV9maXhfb2Zmc2V0cyhzZC0+YmFja2luZ19zdG9yZSwgdywgaCk7Ci0gICAg ZXdrX3ZpZXdfc2Nyb2xsc19wcm9jZXNzKHNkKTsKICAgICBldmFzX29iamVjdF9zbWFydF9jYWxj dWxhdGUoc2QtPmJhY2tpbmdfc3RvcmUpOwogICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGN1bGF0 ZShzZC0+c2VsZik7CiAgICAgZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmVfZGlzYWJsZWRfdXBkYXRl X3NldChzZC0+YmFja2luZ19zdG9yZSwgRUlOQV9GQUxTRSk7Cg==