62711 2011-06-15 03:16:12 -0700 [EFL][WK2] Add missing functions of EFL port's PageClientImpl 2011-06-18 20:43:06 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 61838 0 enmi.lee webkit-unassigned antognolli+webkit gyuyoung.kim kenneth leandro lucas.de.marchi rakuco ryuan.choi sangseok.lim tonikitoo webkit.review.bot youngtaeck.song oldest_to_newest 421154 0 enmi.lee 2011-06-15 03:16:12 -0700 I've added missing functions of EFL port's PageClientImpl.cpp. There are 3 functions which is added in the latest PageClient.h. +IntPoint PageClientImpl::screenToWindow(const IntPoint&) +void PageClientImpl::enterAcceleratedCompositingMode(const LayerTreeContext&) +void PageClientImpl::exitAcceleratedCompositingMode() 421156 1 97266 enmi.lee 2011-06-15 03:19:35 -0700 Created attachment 97266 Patch 421158 2 97266 kenneth 2011-06-15 03:22:46 -0700 Comment on attachment 97266 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97266&action=review > Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp:170 > +IntPoint PageClientImpl::screenToWindow(const IntPoint&) > +{ > + notImplemented(); > + return IntPoint(); > +} Maybe returning the given point makes more sense. This is a conversion method and converting it to the same will surely work better than converting everything to 0, 0 421720 3 97391 enmi.lee 2011-06-15 19:49:24 -0700 Created attachment 97391 Patch 421721 4 enmi.lee 2011-06-15 19:50:16 -0700 (In reply to comment #2) > (From update of attachment 97266 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=97266&action=review > > > Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp:170 > > +IntPoint PageClientImpl::screenToWindow(const IntPoint&) > > +{ > > + notImplemented(); > > + return IntPoint(); > > +} > > Maybe returning the given point makes more sense. This is a conversion method and converting it to the same will surely work better than converting everything to 0, 0 OK, I've changed to return the given point :) 421764 5 gyuyoung.kim 2011-06-15 21:46:49 -0700 LGTM. 421932 6 leandro 2011-06-16 06:54:40 -0700 (In reply to comment #4) > > OK, I've changed to return the given point :) > Looks like you've sent the old patch again :) 422353 7 enmi.lee 2011-06-16 17:40:11 -0700 (In reply to comment #6) > (In reply to comment #4) > > > > OK, I've changed to return the given point :) > > > > Looks like you've sent the old patch again :) Oh, I changed as follows :) -169 return IntPoint() +169 return point; 422634 8 leandro 2011-06-17 08:17:23 -0700 (In reply to comment #7) > > > > Looks like you've sent the old patch again :) > > Oh, I changed as follows :) > -169 return IntPoint() > +169 return point; Oops, missed that :) 423321 9 97391 webkit.review.bot 2011-06-18 20:43:00 -0700 Comment on attachment 97391 Patch Clearing flags on attachment: 97391 Committed r89210: <http://trac.webkit.org/changeset/89210> 423322 10 webkit.review.bot 2011-06-18 20:43:06 -0700 All reviewed patches have been landed. Closing bug. 97266 2011-06-15 03:19:35 -0700 2011-06-15 19:49:15 -0700 Patch bug-62711-20110615191923.patch text/plain 3284 enmi.lee U3VidmVyc2lvbiBSZXZpc2lvbjogODg5MTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA1NmYxODlkMThiNDE2MmRm MjJmYjNhZDE5OWEzNmVkZTBmYzkyZTg2Li4wZjVlODU2M2E0MDk4MzdjMWVmYTFjNmFhYTYxNzM3 OWU5NDhkZTQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDYtMTUgIEV1bm1p IExlZSAgPGV1bm1pMTUubGVlQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdW1dLMl0gQWRkIG1pc3NpbmcgZnVuY3Rpb25z IG9mIEVGTCBwb3J0J3MgUGFnZUNsaWVudEltcGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTYyNzExCisKKyAgICAgICAgVGhyZWUgZnVuY3Rpb25zIGFy ZSBhZGRlZCBpbiB0aGUgUGFnZUNsaWVudC5oLCBzbyBhZGQgdGhlbSB0byB0aGUgRUZMJ3MgUGFn ZUNsaWVudEltcGwuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9QYWdlQ2xpZW50SW1w bC5jcHA6CisgICAgICAgIChXZWJLaXQ6OlBhZ2VDbGllbnRJbXBsOjpzY3JlZW5Ub1dpbmRvdyk6 CisgICAgICAgIChXZWJLaXQ6OlBhZ2VDbGllbnRJbXBsOjplbnRlckFjY2VsZXJhdGVkQ29tcG9z aXRpbmdNb2RlKToKKyAgICAgICAgKFdlYktpdDo6UGFnZUNsaWVudEltcGw6OmV4aXRBY2NlbGVy YXRlZENvbXBvc2l0aW5nTW9kZSk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvUGFnZUNs aWVudEltcGwuaDoKKwogMjAxMS0wNi0xNCAgRXVubWkgTGVlICA8ZXVubWkxNS5sZWVAc2Ftc3Vu Zy5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL1BhZ2VDbGllbnRJbXBsLmNwcCBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL1BhZ2VDbGllbnRJbXBsLmNwcAppbmRleCBiNTI1 NWUzZDM1YTY2NWQyYTEzMTcxM2ZjNmUwZTdmYzBmZDBkNWQzLi42NmFiNTdkMTQzZDNjNmExOGRi OWRkNDg1ZGZmM2JlOWRiNzllOGQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2VmbC9QYWdlQ2xpZW50SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9lZmwvUGFnZUNsaWVudEltcGwuY3BwCkBAIC0xNjMsNiArMTYzLDEyIEBAIEZsb2F0 UmVjdCBQYWdlQ2xpZW50SW1wbDo6Y29udmVydFRvVXNlclNwYWNlKGNvbnN0IEZsb2F0UmVjdCYg dmlld1JlY3QpCiAgICAgcmV0dXJuIHZpZXdSZWN0OwogfQogCitJbnRQb2ludCBQYWdlQ2xpZW50 SW1wbDo6c2NyZWVuVG9XaW5kb3coY29uc3QgSW50UG9pbnQmKQoreworICAgIG5vdEltcGxlbWVu dGVkKCk7CisgICAgcmV0dXJuIEludFBvaW50KCk7Cit9CisKIEludFJlY3QgUGFnZUNsaWVudElt cGw6OndpbmRvd1RvU2NyZWVuKGNvbnN0IEludFJlY3QmKQogewogICAgIG5vdEltcGxlbWVudGVk KCk7CkBAIC0xOTEsNiArMTk3LDE4IEBAIHZvaWQgUGFnZUNsaWVudEltcGw6OnNldEZpbmRJbmRp Y2F0b3IoUGFzc1JlZlB0cjxGaW5kSW5kaWNhdG9yPiwgYm9vbCkKICAgICBub3RJbXBsZW1lbnRl ZCgpOwogfQogCisjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQordm9pZCBQYWdlQ2xp ZW50SW1wbDo6ZW50ZXJBY2NlbGVyYXRlZENvbXBvc2l0aW5nTW9kZShjb25zdCBMYXllclRyZWVD b250ZXh0JikKK3sKKyAgICBub3RJbXBsZW1lbnRlZCgpOworfQorCit2b2lkIFBhZ2VDbGllbnRJ bXBsOjpleGl0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGUoKQoreworICAgIG5vdEltcGxlbWVu dGVkKCk7Cit9CisjZW5kaWYgLy8gVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQorCiB2b2lk IFBhZ2VDbGllbnRJbXBsOjpkaWRDaGFuZ2VTY3JvbGxiYXJzRm9yTWFpbkZyYW1lKCkgY29uc3QK IHsKICAgICBub3RJbXBsZW1lbnRlZCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9lZmwvUGFnZUNsaWVudEltcGwuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZWZsL1BhZ2VDbGllbnRJbXBsLmgKaW5kZXggYjZiODBjMWUxOTQyMjM0ZjU1ZDE5MjIx ZDEyZTgxYWEwNzE0OWZiMi4uZDI4YjgwNmUyYmQ2MGRhNzJjMTY0ZGFkN2JiYjM0ZTM4NmFlMTU3 NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvUGFnZUNsaWVu dEltcGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9QYWdlQ2xpZW50 SW1wbC5oCkBAIC03Miw2ICs3Miw3IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIGV4ZWN1 dGVVbmRvUmVkbyhXZWJQYWdlUHJveHk6OlVuZG9PclJlZG8pOwogICAgIHZpcnR1YWwgV2ViQ29y ZTo6RmxvYXRSZWN0IGNvbnZlcnRUb0RldmljZVNwYWNlKGNvbnN0IFdlYkNvcmU6OkZsb2F0UmVj dCYpOwogICAgIHZpcnR1YWwgV2ViQ29yZTo6RmxvYXRSZWN0IGNvbnZlcnRUb1VzZXJTcGFjZShj b25zdCBXZWJDb3JlOjpGbG9hdFJlY3QmKTsKKyAgICB2aXJ0dWFsIFdlYkNvcmU6OkludFBvaW50 IHNjcmVlblRvV2luZG93KGNvbnN0IFdlYkNvcmU6OkludFBvaW50Jik7CiAgICAgdmlydHVhbCBX ZWJDb3JlOjpJbnRSZWN0IHdpbmRvd1RvU2NyZWVuKGNvbnN0IFdlYkNvcmU6OkludFJlY3QmKTsK IAogICAgIHZpcnR1YWwgdm9pZCBkb25lV2l0aEtleUV2ZW50KGNvbnN0IE5hdGl2ZVdlYktleWJv YXJkRXZlbnQmLCBib29sKTsKQEAgLTgwLDYgKzgxLDEwIEBAIHByaXZhdGU6CiAgICAgdmlydHVh bCBQYXNzUmVmUHRyPFdlYkNvbnRleHRNZW51UHJveHk+IGNyZWF0ZUNvbnRleHRNZW51UHJveHko V2ViUGFnZVByb3h5Kik7CiAKICAgICB2aXJ0dWFsIHZvaWQgc2V0RmluZEluZGljYXRvcihQYXNz UmVmUHRyPEZpbmRJbmRpY2F0b3I+LCBib29sKTsKKyNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9T SVRJTkcpCisgICAgdmlydHVhbCB2b2lkIGVudGVyQWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGUo Y29uc3QgTGF5ZXJUcmVlQ29udGV4dCYpOworICAgIHZpcnR1YWwgdm9pZCBleGl0QWNjZWxlcmF0 ZWRDb21wb3NpdGluZ01vZGUoKTsKKyNlbmRpZgogCiAgICAgdmlydHVhbCB2b2lkIGRpZENoYW5n ZVNjcm9sbGJhcnNGb3JNYWluRnJhbWUoKSBjb25zdDsKIAo= 97391 2011-06-15 19:49:24 -0700 2011-06-18 20:43:00 -0700 Patch bug-62711-20110616114901.patch text/plain 3285 enmi.lee U3VidmVyc2lvbiBSZXZpc2lvbjogODg5MTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA1NmYxODlkMThiNDE2MmRm MjJmYjNhZDE5OWEzNmVkZTBmYzkyZTg2Li4wZjVlODU2M2E0MDk4MzdjMWVmYTFjNmFhYTYxNzM3 OWU5NDhkZTQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDYtMTUgIEV1bm1p IExlZSAgPGV1bm1pMTUubGVlQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdW1dLMl0gQWRkIG1pc3NpbmcgZnVuY3Rpb25z IG9mIEVGTCBwb3J0J3MgUGFnZUNsaWVudEltcGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTYyNzExCisKKyAgICAgICAgVGhyZWUgZnVuY3Rpb25zIGFy ZSBhZGRlZCBpbiB0aGUgUGFnZUNsaWVudC5oLCBzbyBhZGQgdGhlbSB0byB0aGUgRUZMJ3MgUGFn ZUNsaWVudEltcGwuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9QYWdlQ2xpZW50SW1w bC5jcHA6CisgICAgICAgIChXZWJLaXQ6OlBhZ2VDbGllbnRJbXBsOjpzY3JlZW5Ub1dpbmRvdyk6 CisgICAgICAgIChXZWJLaXQ6OlBhZ2VDbGllbnRJbXBsOjplbnRlckFjY2VsZXJhdGVkQ29tcG9z aXRpbmdNb2RlKToKKyAgICAgICAgKFdlYktpdDo6UGFnZUNsaWVudEltcGw6OmV4aXRBY2NlbGVy YXRlZENvbXBvc2l0aW5nTW9kZSk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvUGFnZUNs aWVudEltcGwuaDoKKwogMjAxMS0wNi0xNCAgRXVubWkgTGVlICA8ZXVubWkxNS5sZWVAc2Ftc3Vu Zy5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL1BhZ2VDbGllbnRJbXBsLmNwcCBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL1BhZ2VDbGllbnRJbXBsLmNwcAppbmRleCBiNTI1 NWUzZDM1YTY2NWQyYTEzMTcxM2ZjNmUwZTdmYzBmZDBkNWQzLi4yYmM0YTU0OGQxY2FmODVkZmJk YmRjZmNlYjk2NDJmY2UyZDkyZDc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2VmbC9QYWdlQ2xpZW50SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9lZmwvUGFnZUNsaWVudEltcGwuY3BwCkBAIC0xNjMsNiArMTYzLDEyIEBAIEZsb2F0 UmVjdCBQYWdlQ2xpZW50SW1wbDo6Y29udmVydFRvVXNlclNwYWNlKGNvbnN0IEZsb2F0UmVjdCYg dmlld1JlY3QpCiAgICAgcmV0dXJuIHZpZXdSZWN0OwogfQogCitJbnRQb2ludCBQYWdlQ2xpZW50 SW1wbDo6c2NyZWVuVG9XaW5kb3coY29uc3QgSW50UG9pbnQmIHBvaW50KQoreworICAgIG5vdElt cGxlbWVudGVkKCk7CisgICAgcmV0dXJuIHBvaW50OworfQorCiBJbnRSZWN0IFBhZ2VDbGllbnRJ bXBsOjp3aW5kb3dUb1NjcmVlbihjb25zdCBJbnRSZWN0JikKIHsKICAgICBub3RJbXBsZW1lbnRl ZCgpOwpAQCAtMTkxLDYgKzE5NywxOCBAQCB2b2lkIFBhZ2VDbGllbnRJbXBsOjpzZXRGaW5kSW5k aWNhdG9yKFBhc3NSZWZQdHI8RmluZEluZGljYXRvcj4sIGJvb2wpCiAgICAgbm90SW1wbGVtZW50 ZWQoKTsKIH0KIAorI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKK3ZvaWQgUGFnZUNs aWVudEltcGw6OmVudGVyQWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGUoY29uc3QgTGF5ZXJUcmVl Q29udGV4dCYpCit7CisgICAgbm90SW1wbGVtZW50ZWQoKTsKK30KKwordm9pZCBQYWdlQ2xpZW50 SW1wbDo6ZXhpdEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2RlKCkKK3sKKyAgICBub3RJbXBsZW1l bnRlZCgpOworfQorI2VuZGlmIC8vIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKKwogdm9p ZCBQYWdlQ2xpZW50SW1wbDo6ZGlkQ2hhbmdlU2Nyb2xsYmFyc0Zvck1haW5GcmFtZSgpIGNvbnN0 CiB7CiAgICAgbm90SW1wbGVtZW50ZWQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZWZsL1BhZ2VDbGllbnRJbXBsLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2VmbC9QYWdlQ2xpZW50SW1wbC5oCmluZGV4IGI2YjgwYzFlMTk0MjIzNGY1NWQxOTIy MWQxMmU4MWFhMDcxNDlmYjIuLmQyOGI4MDZlMmJkNjBkYTcyYzE2NGRhZDdiYmIzNGUzODZhZTE1 NzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL1BhZ2VDbGll bnRJbXBsLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvUGFnZUNsaWVu dEltcGwuaApAQCAtNzIsNiArNzIsNyBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgdm9pZCBleGVj dXRlVW5kb1JlZG8oV2ViUGFnZVByb3h5OjpVbmRvT3JSZWRvKTsKICAgICB2aXJ0dWFsIFdlYkNv cmU6OkZsb2F0UmVjdCBjb252ZXJ0VG9EZXZpY2VTcGFjZShjb25zdCBXZWJDb3JlOjpGbG9hdFJl Y3QmKTsKICAgICB2aXJ0dWFsIFdlYkNvcmU6OkZsb2F0UmVjdCBjb252ZXJ0VG9Vc2VyU3BhY2Uo Y29uc3QgV2ViQ29yZTo6RmxvYXRSZWN0Jik7CisgICAgdmlydHVhbCBXZWJDb3JlOjpJbnRQb2lu dCBzY3JlZW5Ub1dpbmRvdyhjb25zdCBXZWJDb3JlOjpJbnRQb2ludCYpOwogICAgIHZpcnR1YWwg V2ViQ29yZTo6SW50UmVjdCB3aW5kb3dUb1NjcmVlbihjb25zdCBXZWJDb3JlOjpJbnRSZWN0Jik7 CiAKICAgICB2aXJ0dWFsIHZvaWQgZG9uZVdpdGhLZXlFdmVudChjb25zdCBOYXRpdmVXZWJLZXli b2FyZEV2ZW50JiwgYm9vbCk7CkBAIC04MCw2ICs4MSwxMCBAQCBwcml2YXRlOgogICAgIHZpcnR1 YWwgUGFzc1JlZlB0cjxXZWJDb250ZXh0TWVudVByb3h5PiBjcmVhdGVDb250ZXh0TWVudVByb3h5 KFdlYlBhZ2VQcm94eSopOwogCiAgICAgdmlydHVhbCB2b2lkIHNldEZpbmRJbmRpY2F0b3IoUGFz c1JlZlB0cjxGaW5kSW5kaWNhdG9yPiwgYm9vbCk7CisjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBP U0lUSU5HKQorICAgIHZpcnR1YWwgdm9pZCBlbnRlckFjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2Rl KGNvbnN0IExheWVyVHJlZUNvbnRleHQmKTsKKyAgICB2aXJ0dWFsIHZvaWQgZXhpdEFjY2VsZXJh dGVkQ29tcG9zaXRpbmdNb2RlKCk7CisjZW5kaWYKIAogICAgIHZpcnR1YWwgdm9pZCBkaWRDaGFu Z2VTY3JvbGxiYXJzRm9yTWFpbkZyYW1lKCkgY29uc3Q7CiAK