62697 2011-06-14 23:31:45 -0700 [CMAKE] Enable METER_TAG of HTML5 2011-06-16 11:33:48 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 62211 1 gyuyoung.kim gyuyoung.kim antognolli+webkit gyuyoung.kim kenneth leandro lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 421048 0 gyuyoung.kim 2011-06-14 23:31:45 -0700 Enable meter tag among html5 features. I test this feature in http://www.quackit.com/html_5/tags/html_meter_tag.cfm Meter tag features is working well on the site. 421055 1 97238 gyuyoung.kim 2011-06-14 23:34:39 -0700 Created attachment 97238 Proposed Patch 421066 2 gyuyoung.kim 2011-06-14 23:55:49 -0700 Bug 62211's patch should be landed in order to work this patch. 421206 3 rakuco 2011-06-15 06:01:31 -0700 It looks OK at first glance. 421220 4 97238 lucas.de.marchi 2011-06-15 06:18:25 -0700 Comment on attachment 97238 Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97238&action=review > ChangeLog:7 > + [EFL] Enable METER_TAG of HTML5 > + https://bugs.webkit.org/show_bug.cgi?id=62697 > + Since this is not specific to EFL, mind sending this again changing it to [CMAKE] instead of EFL? In fact the ideal would be to split this patch in the generic and specific parts, but since it's very small, I think it's better to just change to [CMAKE] and tell in the log message that it's being enabled for EFL port. 421229 5 97285 gyuyoung.kim 2011-06-15 06:35:08 -0700 Created attachment 97285 Modified Patch 421329 6 97285 leandro 2011-06-15 08:56:18 -0700 Comment on attachment 97285 Modified Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97285&action=review > ChangeLog:8 > + [CMAKE] Enable METER_TAG of HTML5 > + https://bugs.webkit.org/show_bug.cgi?id=62697 > + > + Support meter tag of html5 for EFL port. You could say "Right now, this is only enabled on the EFL port.", so that you don't repeat yourself (and add nothing to anyone else reading the changelog entry). 421676 7 97381 gyuyoung.kim 2011-06-15 18:06:52 -0700 Created attachment 97381 Modified Patch Leandro, ChangeLog is modified as much as I can fill. :) 421931 8 97381 leandro 2011-06-16 06:52:44 -0700 Comment on attachment 97381 Modified Patch LGTM. 422055 9 97381 eric 2011-06-16 10:48:48 -0700 Comment on attachment 97381 Modified Patch OK. 422103 10 97381 webkit.review.bot 2011-06-16 11:33:43 -0700 Comment on attachment 97381 Modified Patch Clearing flags on attachment: 97381 Committed r89051: <http://trac.webkit.org/changeset/89051> 422104 11 webkit.review.bot 2011-06-16 11:33:48 -0700 All reviewed patches have been landed. Closing bug. 97238 2011-06-14 23:34:39 -0700 2011-06-15 06:35:08 -0700 Proposed Patch patch-meter-tag.patch text/plain 1773 gyuyoung.kim ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA3YWVjMjlkLi5iNGNlMDYw IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTEtMDYtMTQgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbRUZMXSBFbmFi bGUgTUVURVJfVEFHIG9mIEhUTUw1CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02MjY5NworCisgICAgICAgIFN1cHBvcnQgbWV0ZXIgdGFnIG9mIGh0bWw1 IGZvciBFRkwgcG9ydC4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtl OiBBZGQgRU5BQkxFX01FVEVSX1RBRy4KKyAgICAgICAgKiBTb3VyY2UvY21ha2Vjb25maWcuaC5j bWFrZTpkaXR0by4KKwogMjAxMS0wNi0xNCAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3Vu Zy5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9T b3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNt YWtlCmluZGV4IDE5NjNhYmQuLjYxODZjZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zRWZsLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC03OSw2 ICs3OSw3IEBAIFdFQktJVF9GRUFUVVJFKEVOQUJMRV9JTlNQRUNUT1IgIkVuYWJsZSBpbnNwZWN0 b3IiIERFRkFVTFQgT04pCiBXRUJLSVRfRkVBVFVSRShFTkFCTEVfSkFWQVNDUklQVF9ERUJVR0dF UiAiRW5hYmxlIEphdmFTY3JpcHQgZGVidWdnZXIiIERFRkFVTFQgT04pCiBXRUJLSVRfRkVBVFVS RShFTkFCTEVfSklUICJFbmFibGUgSklUIGNvZGUiIERFRkFVTFQgT04pCiBXRUJLSVRfRkVBVFVS RShFTkFCTEVfTUFUSE1MICJFbmFibGUgTWF0aE1MIiBERUZBVUxUIE9OKQorV0VCS0lUX0ZFQVRV UkUoRU5BQkxFX01FVEVSX1RBRyAiRW5hYmxlIE1ldGVyIHRhZyIgREVGQVVMVCBPTikKIFdFQktJ VF9GRUFUVVJFKEVOQUJMRV9ORVRTQ0FQRV9QTFVHSU5fQVBJICJFbmFibGUgTmV0c2NhcGUgcGx1 Z2luIEFQSSIgREVGQVVMVCBPRkYpCiBXRUJLSVRfRkVBVFVSRShFTkFCTEVfTk9USUZJQ0FUSU9O UyAiRW5hYmxlIG5vdGlmaWNhdGlvbnMiIERFRkFVTFQgT0ZGKQogV0VCS0lUX0ZFQVRVUkUoRU5B QkxFX09GRkxJTkVfV0VCX0FQUExJQ0FUSU9OUyAiRW5hYmxlIG9mZmxpbmUgd2ViIGFwcGxpY2F0 aW9ucyIgREVGQVVMVCBPTikKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZWNvbmZpZy5oLmNtYWtl IGIvU291cmNlL2NtYWtlY29uZmlnLmguY21ha2UKaW5kZXggZWJhNGFjMC4uOTBhYjBhNCAxMDA2 NDQKLS0tIGEvU291cmNlL2NtYWtlY29uZmlnLmguY21ha2UKKysrIGIvU291cmNlL2NtYWtlY29u ZmlnLmguY21ha2UKQEAgLTI1LDYgKzI1LDcgQEAKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9KQVZB U0NSSVBUX0RFQlVHR0VSCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfSklUCiAjY21ha2VkZWZpbmUw MSBFTkFCTEVfTUFUSE1MCisjY21ha2VkZWZpbmUwMSBFTkFCTEVfTUVURVJfVEFHCiAjY21ha2Vk ZWZpbmUwMSBFTkFCTEVfTkVUU0NBUEVfUExVR0lOX0FQSQogI2NtYWtlZGVmaW5lMDEgRU5BQkxF X05PVElGSUNBVElPTlMKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9PRkZMSU5FX1dFQl9BUFBMSUNB VElPTlMK 97285 2011-06-15 06:35:08 -0700 2011-06-15 18:06:52 -0700 Modified Patch patch-meter-tag.patch text/plain 1747 gyuyoung.kim ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA3YWVjMjlkLi45MDk4Y2E5 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTEtMDYtMTUgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbQ01BS0VdIEVu YWJsZSBNRVRFUl9UQUcgb2YgSFRNTDUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTYyNjk3CisKKyAgICAgICAgU3VwcG9ydCBtZXRlciB0YWcgb2YgaHRt bDUgZm9yIEVGTCBwb3J0LgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21h a2U6CisgICAgICAgICogU291cmNlL2NtYWtlY29uZmlnLmguY21ha2U6CisKIDIwMTEtMDYtMTQg IFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21h a2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZQppbmRleCAxOTYzYWJkLi42MTg2Y2Vh IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZQorKysgYi9Tb3VyY2Uv Y21ha2UvT3B0aW9uc0VmbC5jbWFrZQpAQCAtNzksNiArNzksNyBAQCBXRUJLSVRfRkVBVFVSRShF TkFCTEVfSU5TUEVDVE9SICJFbmFibGUgaW5zcGVjdG9yIiBERUZBVUxUIE9OKQogV0VCS0lUX0ZF QVRVUkUoRU5BQkxFX0pBVkFTQ1JJUFRfREVCVUdHRVIgIkVuYWJsZSBKYXZhU2NyaXB0IGRlYnVn Z2VyIiBERUZBVUxUIE9OKQogV0VCS0lUX0ZFQVRVUkUoRU5BQkxFX0pJVCAiRW5hYmxlIEpJVCBj b2RlIiBERUZBVUxUIE9OKQogV0VCS0lUX0ZFQVRVUkUoRU5BQkxFX01BVEhNTCAiRW5hYmxlIE1h dGhNTCIgREVGQVVMVCBPTikKK1dFQktJVF9GRUFUVVJFKEVOQUJMRV9NRVRFUl9UQUcgIkVuYWJs ZSBNZXRlciB0YWciIERFRkFVTFQgT04pCiBXRUJLSVRfRkVBVFVSRShFTkFCTEVfTkVUU0NBUEVf UExVR0lOX0FQSSAiRW5hYmxlIE5ldHNjYXBlIHBsdWdpbiBBUEkiIERFRkFVTFQgT0ZGKQogV0VC S0lUX0ZFQVRVUkUoRU5BQkxFX05PVElGSUNBVElPTlMgIkVuYWJsZSBub3RpZmljYXRpb25zIiBE RUZBVUxUIE9GRikKIFdFQktJVF9GRUFUVVJFKEVOQUJMRV9PRkZMSU5FX1dFQl9BUFBMSUNBVElP TlMgIkVuYWJsZSBvZmZsaW5lIHdlYiBhcHBsaWNhdGlvbnMiIERFRkFVTFQgT04pCmRpZmYgLS1n aXQgYS9Tb3VyY2UvY21ha2Vjb25maWcuaC5jbWFrZSBiL1NvdXJjZS9jbWFrZWNvbmZpZy5oLmNt YWtlCmluZGV4IGViYTRhYzAuLjkwYWIwYTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZWNvbmZp Zy5oLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZWNvbmZpZy5oLmNtYWtlCkBAIC0yNSw2ICsyNSw3 IEBACiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfSkFWQVNDUklQVF9ERUJVR0dFUgogI2NtYWtlZGVm aW5lMDEgRU5BQkxFX0pJVAogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX01BVEhNTAorI2NtYWtlZGVm aW5lMDEgRU5BQkxFX01FVEVSX1RBRwogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX05FVFNDQVBFX1BM VUdJTl9BUEkKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9OT1RJRklDQVRJT05TCiAjY21ha2VkZWZp bmUwMSBFTkFCTEVfT0ZGTElORV9XRUJfQVBQTElDQVRJT05TCg== 97381 2011-06-15 18:06:52 -0700 2011-06-16 11:33:43 -0700 Modified Patch patch-meter-tag.patch text/plain 1853 gyuyoung.kim ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA3YWVjMjlkLi5hOGU3Yjdk IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTEtMDYtMTQgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbQ01BS0VdIEVu YWJsZSBNRVRFUl9UQUcgb2YgSFRNTDUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTYyNjk3CisKKyAgICAgICAgU3VwcG9ydCBmb3IgbWV0ZXIgdGFnIG9m IGh0bWw1IGluIENNYWtlIGJ1aWxkIHN5c3RlbS4gSG93ZXZlciwgdGhpcyBmZWF0dXJlIGlzCisg ICAgICAgIG9ubHkgZW5hYmxlZCBvbiBFRkwgcG9ydCBub3cuIAorCisgICAgICAgICogU291cmNl L2NtYWtlL09wdGlvbnNFZmwuY21ha2U6IEFkZCBFTkFCTEVfTUVURVJfVEFHLgorICAgICAgICAq IFNvdXJjZS9jbWFrZWNvbmZpZy5oLmNtYWtlOmRpdHRvLgorCiAyMDExLTA2LTE0ICBSeXVhbiBD aG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmlj IFNlaWRlbC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlIGIvU291 cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2UKaW5kZXggMTk2M2FiZC4uNjE4NmNlYSAxMDA2NDQK LS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09w dGlvbnNFZmwuY21ha2UKQEAgLTc5LDYgKzc5LDcgQEAgV0VCS0lUX0ZFQVRVUkUoRU5BQkxFX0lO U1BFQ1RPUiAiRW5hYmxlIGluc3BlY3RvciIgREVGQVVMVCBPTikKIFdFQktJVF9GRUFUVVJFKEVO QUJMRV9KQVZBU0NSSVBUX0RFQlVHR0VSICJFbmFibGUgSmF2YVNjcmlwdCBkZWJ1Z2dlciIgREVG QVVMVCBPTikKIFdFQktJVF9GRUFUVVJFKEVOQUJMRV9KSVQgIkVuYWJsZSBKSVQgY29kZSIgREVG QVVMVCBPTikKIFdFQktJVF9GRUFUVVJFKEVOQUJMRV9NQVRITUwgIkVuYWJsZSBNYXRoTUwiIERF RkFVTFQgT04pCitXRUJLSVRfRkVBVFVSRShFTkFCTEVfTUVURVJfVEFHICJFbmFibGUgTWV0ZXIg dGFnIiBERUZBVUxUIE9OKQogV0VCS0lUX0ZFQVRVUkUoRU5BQkxFX05FVFNDQVBFX1BMVUdJTl9B UEkgIkVuYWJsZSBOZXRzY2FwZSBwbHVnaW4gQVBJIiBERUZBVUxUIE9GRikKIFdFQktJVF9GRUFU VVJFKEVOQUJMRV9OT1RJRklDQVRJT05TICJFbmFibGUgbm90aWZpY2F0aW9ucyIgREVGQVVMVCBP RkYpCiBXRUJLSVRfRkVBVFVSRShFTkFCTEVfT0ZGTElORV9XRUJfQVBQTElDQVRJT05TICJFbmFi bGUgb2ZmbGluZSB3ZWIgYXBwbGljYXRpb25zIiBERUZBVUxUIE9OKQpkaWZmIC0tZ2l0IGEvU291 cmNlL2NtYWtlY29uZmlnLmguY21ha2UgYi9Tb3VyY2UvY21ha2Vjb25maWcuaC5jbWFrZQppbmRl eCBlYmE0YWMwLi45MGFiMGE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2Vjb25maWcuaC5jbWFr ZQorKysgYi9Tb3VyY2UvY21ha2Vjb25maWcuaC5jbWFrZQpAQCAtMjUsNiArMjUsNyBAQAogI2Nt YWtlZGVmaW5lMDEgRU5BQkxFX0pBVkFTQ1JJUFRfREVCVUdHRVIKICNjbWFrZWRlZmluZTAxIEVO QUJMRV9KSVQKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9NQVRITUwKKyNjbWFrZWRlZmluZTAxIEVO QUJMRV9NRVRFUl9UQUcKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9ORVRTQ0FQRV9QTFVHSU5fQVBJ CiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfTk9USUZJQ0FUSU9OUwogI2NtYWtlZGVmaW5lMDEgRU5B QkxFX09GRkxJTkVfV0VCX0FQUExJQ0FUSU9OUwo=