62693 2011-06-14 20:42:02 -0700 windowsKeyCodeForKeyEvent should be robust against NSFlagsChanged events 2011-06-14 22:40:55 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 sullivan sullivan ap darin sam oldest_to_newest 420989 0 sullivan 2011-06-14 20:42:02 -0700 The function windowsKeyCodeForKeyEvent() in WebEventFactory.mm does not explicitly check for NSFlagsChanged events before calling -charactersIgnoringModifiers. -[NSEvent charactersIgnoringModifiers] throws an exception for NSFlagsChanged events. We should make this function avoid this possibility. In Radar as <rdar://problem/9601436> 420991 1 97227 sullivan 2011-06-14 20:45:55 -0700 Created attachment 97227 Patch to bail out of windowsKeyCodeForKeyEvent for NSFlagsChanged events 420996 2 sullivan 2011-06-14 20:53:27 -0700 Fixed in http://trac.webkit.org/changeset/88903 421005 3 sam 2011-06-14 21:45:02 -0700 John, is there a particular key combination that produces this exception. If so, we should consider at least documenting it here, and if possible, writing an API test for this. 421006 4 sullivan 2011-06-14 21:47:17 -0700 Don’t know of the key code that’s causing the exception, but stack traces from crashes show that it is happening. 421013 5 darin 2011-06-14 22:20:43 -0700 Wouldn’t a white list be better than a black list for event types? 421017 6 ap 2011-06-14 22:35:35 -0700 If this is reproducible, can you just post what event causes this, and a stack trace? A switch above this code seems to handle all keys that can cause NSFlagsChanged. And if it misses some, we should find out which ones, and return a proper Windows key code for these, not a zero. 421019 7 ap 2011-06-14 22:40:55 -0700 Actually, I see this info in Radar, and it seems like the NSEvent is somehow invalid. I don't know how an event could have key code 49808. Are we dealing with some sort of a memory consistency issue here? 97227 2011-06-14 20:45:55 -0700 2011-06-14 20:51:13 -0700 Patch to bail out of windowsKeyCodeForKeyEvent for NSFlagsChanged events 62693_patch.txt text/plain 1366 sullivan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg4OTAxKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDYtMTQgIEpvaG4gU3Vs bGl2YW4gIDxzdWxsaXZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02MjY5Mz4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzk2MDE0MzY+CisgICAgICAgIHdp bmRvd3NLZXlDb2RlRm9yS2V5RXZlbnQgc2hvdWxkIGJlIHJvYnVzdCBhZ2FpbnN0IE5TRmxhZ3ND aGFuZ2VkIGV2ZW50cworCisgICAgICAgICogU2hhcmVkL21hYy9XZWJFdmVudEZhY3RvcnkubW06 CisgICAgICAgIChXZWJLaXQ6OndpbmRvd3NLZXlDb2RlRm9yS2V5RXZlbnQpOgorICAgICAgICBF eHBsaWNpdGx5IGNoZWNrIGZvciBOU0ZsYWdzQ2hhbmdlZCBiZWZvcmUgY2FsbGluZyAtY2hhcmFj dGVyc0lnbm9yaW5nTW9kaWZpZXJzLCBzaW5jZQorICAgICAgICBjaGFyYWN0ZXJzSWdub3JpbmdN b2RpZmllcnMgdGhyb3dzIGFuIGV4Y2VwdGlvbiBmb3IgTlNGbGFnc0NoYW5nZWQgZXZlbnRzLgor CiAyMDExLTA2LTE0ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJl ZC9tYWMvV2ViRXZlbnRGYWN0b3J5Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1No YXJlZC9tYWMvV2ViRXZlbnRGYWN0b3J5Lm1tCShyZXZpc2lvbiA4ODg1NSkKKysrIFNvdXJjZS9X ZWJLaXQyL1NoYXJlZC9tYWMvV2ViRXZlbnRGYWN0b3J5Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC02 OTYsNiArNjk2LDkgQEAgc3RhdGljIGludCB3aW5kb3dzS2V5Q29kZUZvcktleUV2ZW50KE5TRQog ICAgICAgICAvLyBWS19ESVZJREUgKDZGKSBEaXZpZGUga2V5CiAgICAgICAgIGNhc2UgNzU6IHJl dHVybiAweDZGOwogICAgICB9CisgICAgCisgICAgaWYgKFtldmVudCB0eXBlXSA9PSBOU0ZsYWdz Q2hhbmdlZCkKKyAgICAgICAgcmV0dXJuIDA7CiAKICAgICBOU1N0cmluZyogcyA9IFtldmVudCBj aGFyYWN0ZXJzSWdub3JpbmdNb2RpZmllcnNdOwogICAgIGlmIChbcyBsZW5ndGhdICE9IDEpCg==