62691 2011-06-14 18:50:31 -0700 [EFL] Change color initialization with clear color constant 2011-06-14 19:42:14 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim webkit-unassigned eric gyuyoung.kim lucas.de.marchi tkent webkit.review.bot oldest_to_newest 420943 0 gyuyoung.kim 2011-06-14 18:50:31 -0700 color variables are initialized with rgb value. I think Color::XXX is more clear. 420947 1 97218 gyuyoung.kim 2011-06-14 18:52:41 -0700 Created attachment 97218 Patch 420953 2 97218 tkent 2011-06-14 19:00:04 -0700 Comment on attachment 97218 Patch ok 420967 3 97218 webkit.review.bot 2011-06-14 19:42:10 -0700 Comment on attachment 97218 Patch Clearing flags on attachment: 97218 Committed r88897: <http://trac.webkit.org/changeset/88897> 420968 4 webkit.review.bot 2011-06-14 19:42:14 -0700 All reviewed patches have been landed. Closing bug. 97218 2011-06-14 18:52:41 -0700 2011-06-14 19:42:10 -0700 Patch patch-color.patch text/plain 2037 gyuyoung.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0YjNjMzAzLi44OGU5NjQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDYtMTQgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbRUZMXSBD aGFuZ2UgY29sb3IgaW5pdGlhbGl6YXRpb24gd2l0aCBjbGVhciBjb2xvciBjb25zdGFudAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjI2OTEKKworICAg ICAgICBTb21lIGNvbG9yIHZhbHVlcyBhcmUgaW5pdGlhbGl6ZWQgYnkgcmJnIHZhbHVlLiBDb2xv ciBjb25zdGFudCB2YWx1ZSBpcyBtb3JlIGNsZWFyIHRoYW4KKyAgICAgICAgcmdiIHZhbHVlLgor CisgICAgICAgICogcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlclRoZW1lRWZsOjpSZW5kZXJUaGVtZUVmbCk6CisKIDIwMTEtMDYtMTMgIFJ5 b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2 aWQgSHlhdHQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUmVuZGVy VGhlbWVFZmwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZs LmNwcAppbmRleCA3ODY2OTIyLi42ZTc4NzllIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHAKQEAgLTY4NSwxOCArNjg1LDE4IEBAIFJlbmRlclRo ZW1lRWZsOjpSZW5kZXJUaGVtZUVmbChQYWdlKiBwYWdlKQogICAgIDogUmVuZGVyVGhlbWUoKQog ICAgICwgbV9wYWdlKHBhZ2UpCiAgICAgLCBtX2FjdGl2ZVNlbGVjdGlvbkJhY2tncm91bmRDb2xv cigwLCAwLCAyNTUpCi0gICAgLCBtX2FjdGl2ZVNlbGVjdGlvbkZvcmVncm91bmRDb2xvcigyNTUs IDI1NSwgMjU1KQorICAgICwgbV9hY3RpdmVTZWxlY3Rpb25Gb3JlZ3JvdW5kQ29sb3IoQ29sb3I6 OndoaXRlKQogICAgICwgbV9pbmFjdGl2ZVNlbGVjdGlvbkJhY2tncm91bmRDb2xvcigwLCAwLCAx MjgpCiAgICAgLCBtX2luYWN0aXZlU2VsZWN0aW9uRm9yZWdyb3VuZENvbG9yKDIwMCwgMjAwLCAy MDApCiAgICAgLCBtX2ZvY3VzUmluZ0NvbG9yKDMyLCAzMiwgMjI0LCAyMjQpCiAgICAgLCBtX2J1 dHRvblRleHRCYWNrZ3JvdW5kQ29sb3IoMCwgMCwgMCwgMCkKLSAgICAsIG1fYnV0dG9uVGV4dEZv cmVncm91bmRDb2xvcigwLCAwLCAwKQorICAgICwgbV9idXR0b25UZXh0Rm9yZWdyb3VuZENvbG9y KENvbG9yOjpibGFjaykKICAgICAsIG1fY29tYm9UZXh0QmFja2dyb3VuZENvbG9yKDAsIDAsIDAs IDApCi0gICAgLCBtX2NvbWJvVGV4dEZvcmVncm91bmRDb2xvcigwLCAwLCAwKQorICAgICwgbV9j b21ib1RleHRGb3JlZ3JvdW5kQ29sb3IoQ29sb3I6OmJsYWNrKQogICAgICwgbV9lbnRyeVRleHRC YWNrZ3JvdW5kQ29sb3IoMCwgMCwgMCwgMCkKLSAgICAsIG1fZW50cnlUZXh0Rm9yZWdyb3VuZENv bG9yKDAsIDAsIDApCisgICAgLCBtX2VudHJ5VGV4dEZvcmVncm91bmRDb2xvcihDb2xvcjo6Ymxh Y2spCiAgICAgLCBtX3NlYXJjaFRleHRCYWNrZ3JvdW5kQ29sb3IoMCwgMCwgMCwgMCkKLSAgICAs IG1fc2VhcmNoVGV4dEZvcmVncm91bmRDb2xvcigwLCAwLCAwKQorICAgICwgbV9zZWFyY2hUZXh0 Rm9yZWdyb3VuZENvbG9yKENvbG9yOjpibGFjaykKICAgICAsIG1fc2xpZGVyVGh1bWJDb2xvcihD b2xvcjo6ZGFya0dyYXkpCiAjaWYgRU5BQkxFKFZJREVPKQogICAgICwgbV9tZWRpYVBhbmVsQ29s b3IoMjIwLCAyMjAsIDE5NSkgLy8gbGlnaHQgdGFubmlzaCBjb2xvci4K