62688 2011-06-14 18:18:52 -0700 [EFL] Functions needing Ewk_View_Private_Data as parameter are not part of public API. 2011-06-26 17:31:37 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 62712 0 ryuan.choi webkit-unassigned gyuyoung.kim hyuki.kim kenneth leandro lucas.de.marchi rakuco sangseok.lim tonikitoo webkit.review.bot oldest_to_newest 420921 0 ryuan.choi 2011-06-14 18:18:52 -0700 WebKit/EFL have many APIs, but some of them looks not useless. First, functions including Ewk_View_Private_Data should be private or change it to Evas_Object. ewk_view_repaints_get(Ewk_View_Private_Data*, ...) ewk_view_scroll_requests_get(Ewk_View_Private_Data*, ...) ewk_view_repaint_add(Ewk_View_Private_Data*, ...) ewk_view_layout_if_needed_recursive(Ewk_View_Private_Data*, ...) ewk_view_scrolls_process(Ewk_View_Private_Data*, ...) I checked old eve(I'll check latest in my home) and our browser, but those are only used internally. Does it required? My first suggestion is moving them to ewk_private.h If not, how do you think about change it to Evas_Object? 420928 1 hyuki.kim 2011-06-14 18:27:33 -0700 Good Idea, As ewk_private has some WebCore dependency, I prefer creation of ewk_view_private.h. I don't want both two (single and tiled view) to be tightly coupled with WebCore. 420971 2 lucas.de.marchi 2011-06-14 20:04:39 -0700 (In reply to comment #0) > WebKit/EFL have many APIs, but some of them looks not useless. > > First, functions including Ewk_View_Private_Data should be private or change it to Evas_Object. > > ewk_view_repaints_get(Ewk_View_Private_Data*, ...) > ewk_view_scroll_requests_get(Ewk_View_Private_Data*, ...) > ewk_view_repaint_add(Ewk_View_Private_Data*, ...) > ewk_view_layout_if_needed_recursive(Ewk_View_Private_Data*, ...) > ewk_view_scrolls_process(Ewk_View_Private_Data*, ...) > > I checked old eve(I'll check latest in my home) and our browser, but those are only used internally. > Does it required? It's needed if user wants to subclass the backing store. It's explained in comments above their declarations in Source/WebKit/efl/ewk/ewk_view.h So, there's not much we can do here. 420973 3 lucas.de.marchi 2011-06-14 20:06:32 -0700 (In reply to comment #1) > Good Idea, > > As ewk_private has some WebCore dependency, I prefer creation of ewk_view_private.h. No, every private functions goes to ewk_private.h, but as explained above we can not move these functions. > I don't want both two (single and tiled view) to be tightly coupled with WebCore. Changing the header doesn't change anything about this. 420986 4 lucas.de.marchi 2011-06-14 20:31:40 -0700 (In reply to comment #0) > WebKit/EFL have many APIs, but some of them looks not useless. > > First, functions including Ewk_View_Private_Data should be private or change it to Evas_Object. > > ewk_view_repaints_get(Ewk_View_Private_Data*, ...) > ewk_view_scroll_requests_get(Ewk_View_Private_Data*, ...) > ewk_view_repaint_add(Ewk_View_Private_Data*, ...) > ewk_view_layout_if_needed_recursive(Ewk_View_Private_Data*, ...) > ewk_view_scrolls_process(Ewk_View_Private_Data*, ...) > > I checked old eve(I'll check latest in my home) and our browser, but those are only used internally. > Does it required? > > My first suggestion is moving them to ewk_private.h > If not, how do you think about change it to Evas_Object? Thinking again... I think not all of them are used by a subclass implementation and the others we could indeed change to use Evas_Object as argument. 421116 5 hyuki.kim 2011-06-15 01:41:03 -0700 >> Good Idea, >> >> As ewk_private has some WebCore dependency, I prefer creation of >> ewk_view_private.h. > No, every private functions goes to ewk_private.h, but as explained above we can > not move these functions. >> I don't want both two (single and tiled view) to be tightly coupled with WebCore. > Changing the header doesn't change anything about this. Hi, Lucas. Long time no see. If ewk_view_tiled and ewk_view_single would include ewk_private.h, It would include unnecessary header file, I don't like it. 421264 6 lucas.de.marchi 2011-06-15 07:36:18 -0700 (In reply to comment #0) > WebKit/EFL have many APIs, but some of them looks not useless. > > First, functions including Ewk_View_Private_Data should be private or change it to Evas_Object. > > ewk_view_repaints_get(Ewk_View_Private_Data*, ...) > ewk_view_scroll_requests_get(Ewk_View_Private_Data*, ...) > ewk_view_repaint_add(Ewk_View_Private_Data*, ...) > ewk_view_layout_if_needed_recursive(Ewk_View_Private_Data*, ...) > ewk_view_scrolls_process(Ewk_View_Private_Data*, ...) > > I checked old eve(I'll check latest in my home) and our browser, but those are only used internally. > Does it required? > > My first suggestion is moving them to ewk_private.h I talked privately to Antognolli about this. We agreed that all these functions can be moved to ewk_private.h > If not, how do you think about change it to Evas_Object? If at any time they are needed outside of WebKit, we can move them back, but using the Evas_Object. 421769 7 97398 ryuan.choi 2011-06-15 22:17:59 -0700 Created attachment 97398 Patch 421891 8 hyuki.kim 2011-06-16 03:22:13 -0700 May be, ewk_view_single.c and ewk_view_tiled.c would need ewk_private.h. 421936 9 97398 lucas.de.marchi 2011-06-16 07:09:48 -0700 Comment on attachment 97398 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97398&action=review > Source/WebKit/efl/ChangeLog:5 > + [EFL] Functions including Ewk_View_Private_Data should not an API. Functions needing Ewk_View_Private_Data as parameter are not part of public API > Source/WebKit/efl/ChangeLog:8 > + Move functions which use Ewk_View_Private and may not be required by applcations Ewk_View_Private_Data, applications > Source/WebKit/efl/ewk/ewk_private.h:130 > #if ENABLE(CONTEXT_MENUS) > - > Ewk_Context_Menu *ewk_context_menu_new(Evas_Object *view, WebCore::ContextMenuController *controller); > Eina_Bool ewk_context_menu_free(Ewk_Context_Menu *o); > void ewk_context_menu_item_append(Ewk_Context_Menu *o, WebCore::ContextMenuItem& core); > Ewk_Context_Menu *ewk_context_menu_custom_get(Ewk_Context_Menu *o); > void ewk_context_menu_show(Ewk_Context_Menu *o); > - > #endif It's not related to the patch, but it's ok to go in. 421956 10 ryuan.choi 2011-06-16 08:04:27 -0700 (In reply to comment #8) > May be, ewk_view_single.c and ewk_view_tiled.c would need ewk_private.h. I tested when I upload and it's fine for me. And although those files required ewk_private.h, those can't include ewk_private.h because ewk_private.h include c++ matter. So, we need to find proper way if it required. I think that we can make other bugs to control it when it required. BTW, Can I know why those files use *.c ? If we don't have any reasons, it looks be better to change *.cpp. it's just my two cents. (In reply to comment #9) > (From update of attachment 97398 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=97398&action=review > > > Source/WebKit/efl/ChangeLog:5 > > + [EFL] Functions including Ewk_View_Private_Data should not an API. > > Functions needing Ewk_View_Private_Data as parameter are not part of public API > Thanks, english is more difficult than code fore me. :) I'll update like you mentioned. 422363 11 hyuki.kim 2011-06-16 17:57:03 -0700 In fact, there are three more apis which are using private data as parameter of theirs. EAPI Ewk_View_Paint_Context *ewk_view_paint_context_new(Ewk_View_Private_Data *priv, cairo_t *cr); EAPI Eina_Bool ewk_view_paint(Ewk_View_Private_Data *priv, cairo_t *cr, const Eina_Rectangle *area); EAPI Eina_Bool ewk_view_paint_contents(Ewk_View_Private_Data *priv, cairo_t *cr, const Eina_Rectangle *area); I hope that you can consider them too. 422384 12 97538 ryuan.choi 2011-06-16 19:19:06 -0700 Created attachment 97538 Patch 422385 13 ryuan.choi 2011-06-16 19:23:57 -0700 (In reply to comment #12) > Created an attachment (id=97538) [details] > Patch I updated like lucas mentioned. (In reply to comment #11) > In fact, there are three more apis which are using private data as parameter of theirs. > > EAPI Ewk_View_Paint_Context *ewk_view_paint_context_new(Ewk_View_Private_Data *priv, cairo_t *cr); > EAPI Eina_Bool ewk_view_paint(Ewk_View_Private_Data *priv, cairo_t *cr, const Eina_Rectangle *area); > EAPI Eina_Bool ewk_view_paint_contents(Ewk_View_Private_Data *priv, cairo_t *cr, const Eina_Rectangle *area); > > I hope that you can consider them too. Right, I want refactoring them also. But now they can't go into ewk_private.h and I need to check whether it should be moved or not. I'll investigate them. 427587 14 ryuan.choi 2011-06-26 16:35:27 -0700 Could you review this If you have time? 427593 15 97538 webkit.review.bot 2011-06-26 17:31:31 -0700 Comment on attachment 97538 Patch Clearing flags on attachment: 97538 Committed r89776: <http://trac.webkit.org/changeset/89776> 427594 16 webkit.review.bot 2011-06-26 17:31:37 -0700 All reviewed patches have been landed. Closing bug. 97398 2011-06-15 22:17:59 -0700 2011-06-16 19:18:57 -0700 Patch bug-62688-20110616141742.patch text/plain 3084 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogODg5OTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCAxZWUxNDUzZjdj ZTE5ZjMwOTE3ODFlNjJmYjkwNTQ1ZWE5NTE3Y2ZkLi41ZDAxNTkyMmY5MjhhNjRkOWM3ODdmZWM1 NmM5MThjMDQzMTk1ZGRhIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEt MDYtMTUgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIEZ1bmN0aW9ucyBpbmNs dWRpbmcgRXdrX1ZpZXdfUHJpdmF0ZV9EYXRhIHNob3VsZCBub3QgYW4gQVBJLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjI2ODgKKworICAgICAgICBN b3ZlIGZ1bmN0aW9ucyB3aGljaCB1c2UgRXdrX1ZpZXdfUHJpdmF0ZSBhbmQgbWF5IG5vdCBiZSBy ZXF1aXJlZCBieSBhcHBsY2F0aW9ucworICAgICAgICB0byBld2tfcHJpdmF0ZS5oLgorCisgICAg ICAgICogZXdrL2V3a19wcml2YXRlLmg6CisgICAgICAgICogZXdrL2V3a192aWV3Lmg6CisKIDIw MTEtMDYtMTUgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWprb3dza2lAc2Ftc3VuZy5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW50b25pbyBHb21lcy4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfcHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a19wcml2YXRlLmgKaW5kZXggMTFmMGQ2MjY4YjIzNzMyMmUzMWI1NWZiZjRhNzgwOWRlZjMwZDY1 YS4uY2JmYjdjODQzMDU0ZGQ3NDJjYThjYTY3NjIwMDdiZDU0ZGRlYWFiMyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdC9l ZmwvZXdrL2V3a19wcml2YXRlLmgKQEAgLTEyMiwxNSArMTIyLDIwIEBAIEV3a19IaXN0b3J5ICpl d2tfaGlzdG9yeV9uZXcoV2ViQ29yZTo6QmFja0ZvcndhcmRMaXN0SW1wbCAqaGlzdG9yeSk7CiB2 b2lkIGV3a19oaXN0b3J5X2ZyZWUoRXdrX0hpc3RvcnkgKmhpc3RvcnkpOwogCiAjaWYgRU5BQkxF KENPTlRFWFRfTUVOVVMpCi0KIEV3a19Db250ZXh0X01lbnUgKmV3a19jb250ZXh0X21lbnVfbmV3 KEV2YXNfT2JqZWN0ICp2aWV3LCBXZWJDb3JlOjpDb250ZXh0TWVudUNvbnRyb2xsZXIgKmNvbnRy b2xsZXIpOwogRWluYV9Cb29sIGV3a19jb250ZXh0X21lbnVfZnJlZShFd2tfQ29udGV4dF9NZW51 ICpvKTsKIHZvaWQgZXdrX2NvbnRleHRfbWVudV9pdGVtX2FwcGVuZChFd2tfQ29udGV4dF9NZW51 ICpvLCBXZWJDb3JlOjpDb250ZXh0TWVudUl0ZW0mIGNvcmUpOwogRXdrX0NvbnRleHRfTWVudSAq ZXdrX2NvbnRleHRfbWVudV9jdXN0b21fZ2V0KEV3a19Db250ZXh0X01lbnUgKm8pOwogdm9pZCBl d2tfY29udGV4dF9tZW51X3Nob3coRXdrX0NvbnRleHRfTWVudSAqbyk7Ci0KICNlbmRpZgogCitj b25zdCBFaW5hX1JlY3RhbmdsZSAqZXdrX3ZpZXdfcmVwYWludHNfZ2V0KGNvbnN0IEV3a19WaWV3 X1ByaXZhdGVfRGF0YSAqcHJpdiwgc2l6ZV90ICpjb3VudCk7Citjb25zdCBFd2tfU2Nyb2xsX1Jl cXVlc3QgKmV3a192aWV3X3Njcm9sbF9yZXF1ZXN0c19nZXQoY29uc3QgRXdrX1ZpZXdfUHJpdmF0 ZV9EYXRhICpwcml2LCBzaXplX3QgKmNvdW50KTsKKwordm9pZCBld2tfdmlld19yZXBhaW50X2Fk ZChFd2tfVmlld19Qcml2YXRlX0RhdGEgKnByaXYsIEV2YXNfQ29vcmQgeCwgRXZhc19Db29yZCB5 LCBFdmFzX0Nvb3JkIHcsIEV2YXNfQ29vcmQgaCk7CisKK3ZvaWQgZXdrX3ZpZXdfbGF5b3V0X2lm X25lZWRlZF9yZWN1cnNpdmUoRXdrX1ZpZXdfUHJpdmF0ZV9EYXRhICpwcml2KTsKKwogRXdrX1dp bmRvd19GZWF0dXJlcyAqZXdrX3dpbmRvd19mZWF0dXJlc19uZXdfZnJvbV9jb3JlKGNvbnN0IFdl YkNvcmU6OldpbmRvd0ZlYXR1cmVzKiBjb3JlKTsKIAogRXZhc19PYmplY3QgKmV3a19mcmFtZV9h ZGQoRXZhcyAqZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcu aCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oCmluZGV4IDAzNjBmZWU3ZmZmOTkw OGY3MDkyN2I1NTAzOTkzMzhmZTRlOGIxODYuLjIzYWZhZjU2NmEyMjcxYTI5ZWExMDE1NDBjNzE4 NDQ4ODc0YjA2OGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5o CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oCkBAIC01MDYsMTMgKzUwNiw2 IEBAIEVBUEkgRWluYV9Cb29sICAgIGV3a192aWV3X3NldHRpbmdfZW5hYmxlX2RldmVsb3Blcl9l eHRyYXNfc2V0KEV2YXNfT2JqZWN0KiBvLCBFCiAvKiB0byBiZSB1c2VkIGJ5IHN1YmNsYXNzIGlt cGxlbWVudGF0aW9ucyAqLwogRUFQSSBFd2tfVmlld19TbWFydF9EYXRhICpld2tfdmlld19zbWFy dF9kYXRhX2dldChjb25zdCBFdmFzX09iamVjdCAqbyk7CiAKLUVBUEkgY29uc3QgRWluYV9SZWN0 YW5nbGUgKmV3a192aWV3X3JlcGFpbnRzX2dldChjb25zdCBFd2tfVmlld19Qcml2YXRlX0RhdGEg KnByaXYsIHNpemVfdCAqY291bnQpOwotRUFQSSBjb25zdCBFd2tfU2Nyb2xsX1JlcXVlc3QgKmV3 a192aWV3X3Njcm9sbF9yZXF1ZXN0c19nZXQoY29uc3QgRXdrX1ZpZXdfUHJpdmF0ZV9EYXRhICpw cml2LCBzaXplX3QgKmNvdW50KTsKLQotRUFQSSB2b2lkIGV3a192aWV3X3JlcGFpbnRfYWRkKEV3 a19WaWV3X1ByaXZhdGVfRGF0YSAqcHJpdiwgRXZhc19Db29yZCB4LCBFdmFzX0Nvb3JkIHksIEV2 YXNfQ29vcmQgdywgRXZhc19Db29yZCBoKTsKLQotRUFQSSB2b2lkIGV3a192aWV3X2xheW91dF9p Zl9uZWVkZWRfcmVjdXJzaXZlKEV3a19WaWV3X1ByaXZhdGVfRGF0YSAqcHJpdik7Ci0KIEVBUEkg dm9pZCBld2tfdmlld19zY3JvbGxzX3Byb2Nlc3MoRXdrX1ZpZXdfU21hcnRfRGF0YSAqc2QpOwog CiAvKioK 97538 2011-06-16 19:19:06 -0700 2011-06-26 17:31:31 -0700 Patch bug-62688-20110617111845.patch text/plain 3110 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogODkwOTkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCAxZWUxNDUzZjdj ZTE5ZjMwOTE3ODFlNjJmYjkwNTQ1ZWE5NTE3Y2ZkLi4xMGRlOTU0NjIzY2Y5ODIwY2ZlZjQ2ODky YjdkNjI2MzZmYmU1MDA2IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEt MDYtMTYgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIEZ1bmN0aW9ucyBuZWVk aW5nIEV3a19WaWV3X1ByaXZhdGVfRGF0YSBhcyBwYXJhbWV0ZXIgYXJlIG5vdCBwYXJ0IG9mIHB1 YmxpYyBBUEkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02MjY4OAorCisgICAgICAgIE1vdmUgZnVuY3Rpb25zIHdoaWNoIHVzZSBFd2tfVmlld19Qcml2 YXRlX0RhdGEgYW5kIG1heSBub3QgYmUgcmVxdWlyZWQgYnkKKyAgICAgICAgYXBwbGljYXRpb25z IHRvIGV3a19wcml2YXRlLmguCisKKyAgICAgICAgKiBld2svZXdrX3ByaXZhdGUuaDoKKyAgICAg ICAgKiBld2svZXdrX3ZpZXcuaDoKKwogMjAxMS0wNi0xNSAgR3J6ZWdvcnogQ3phamtvd3NraSAg PGcuY3phamtvd3NraUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbnRvbmlv IEdvbWVzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmgg Yi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ByaXZhdGUuaAppbmRleCAxMWYwZDYyNjhiMjM3 MzIyZTMxYjU1ZmJmNGE3ODA5ZGVmMzBkNjVhLi5jYmZiN2M4NDMwNTRkZDc0MmNhOGNhNjc2MjAw N2JkNTRkZGVhYWIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ByaXZh dGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ByaXZhdGUuaApAQCAtMTIyLDE1 ICsxMjIsMjAgQEAgRXdrX0hpc3RvcnkgKmV3a19oaXN0b3J5X25ldyhXZWJDb3JlOjpCYWNrRm9y d2FyZExpc3RJbXBsICpoaXN0b3J5KTsKIHZvaWQgZXdrX2hpc3RvcnlfZnJlZShFd2tfSGlzdG9y eSAqaGlzdG9yeSk7CiAKICNpZiBFTkFCTEUoQ09OVEVYVF9NRU5VUykKLQogRXdrX0NvbnRleHRf TWVudSAqZXdrX2NvbnRleHRfbWVudV9uZXcoRXZhc19PYmplY3QgKnZpZXcsIFdlYkNvcmU6OkNv bnRleHRNZW51Q29udHJvbGxlciAqY29udHJvbGxlcik7CiBFaW5hX0Jvb2wgZXdrX2NvbnRleHRf bWVudV9mcmVlKEV3a19Db250ZXh0X01lbnUgKm8pOwogdm9pZCBld2tfY29udGV4dF9tZW51X2l0 ZW1fYXBwZW5kKEV3a19Db250ZXh0X01lbnUgKm8sIFdlYkNvcmU6OkNvbnRleHRNZW51SXRlbSYg Y29yZSk7CiBFd2tfQ29udGV4dF9NZW51ICpld2tfY29udGV4dF9tZW51X2N1c3RvbV9nZXQoRXdr X0NvbnRleHRfTWVudSAqbyk7CiB2b2lkIGV3a19jb250ZXh0X21lbnVfc2hvdyhFd2tfQ29udGV4 dF9NZW51ICpvKTsKLQogI2VuZGlmCiAKK2NvbnN0IEVpbmFfUmVjdGFuZ2xlICpld2tfdmlld19y ZXBhaW50c19nZXQoY29uc3QgRXdrX1ZpZXdfUHJpdmF0ZV9EYXRhICpwcml2LCBzaXplX3QgKmNv dW50KTsKK2NvbnN0IEV3a19TY3JvbGxfUmVxdWVzdCAqZXdrX3ZpZXdfc2Nyb2xsX3JlcXVlc3Rz X2dldChjb25zdCBFd2tfVmlld19Qcml2YXRlX0RhdGEgKnByaXYsIHNpemVfdCAqY291bnQpOwor Cit2b2lkIGV3a192aWV3X3JlcGFpbnRfYWRkKEV3a19WaWV3X1ByaXZhdGVfRGF0YSAqcHJpdiwg RXZhc19Db29yZCB4LCBFdmFzX0Nvb3JkIHksIEV2YXNfQ29vcmQgdywgRXZhc19Db29yZCBoKTsK Kwordm9pZCBld2tfdmlld19sYXlvdXRfaWZfbmVlZGVkX3JlY3Vyc2l2ZShFd2tfVmlld19Qcml2 YXRlX0RhdGEgKnByaXYpOworCiBFd2tfV2luZG93X0ZlYXR1cmVzICpld2tfd2luZG93X2ZlYXR1 cmVzX25ld19mcm9tX2NvcmUoY29uc3QgV2ViQ29yZTo6V2luZG93RmVhdHVyZXMqIGNvcmUpOwog CiBFdmFzX09iamVjdCAqZXdrX2ZyYW1lX2FkZChFdmFzICplKTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192 aWV3LmgKaW5kZXggMDM2MGZlZTdmZmY5OTA4ZjcwOTI3YjU1MDM5OTMzOGZlNGU4YjE4Ni4uMjNh ZmFmNTY2YTIyNzFhMjllYTEwMTU0MGM3MTg0NDg4NzRiMDY4YiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a192aWV3LmgKQEAgLTUwNiwxMyArNTA2LDYgQEAgRUFQSSBFaW5hX0Jvb2wgICAgZXdrX3ZpZXdf c2V0dGluZ19lbmFibGVfZGV2ZWxvcGVyX2V4dHJhc19zZXQoRXZhc19PYmplY3QqIG8sIEUKIC8q IHRvIGJlIHVzZWQgYnkgc3ViY2xhc3MgaW1wbGVtZW50YXRpb25zICovCiBFQVBJIEV3a19WaWV3 X1NtYXJ0X0RhdGEgKmV3a192aWV3X3NtYXJ0X2RhdGFfZ2V0KGNvbnN0IEV2YXNfT2JqZWN0ICpv KTsKIAotRUFQSSBjb25zdCBFaW5hX1JlY3RhbmdsZSAqZXdrX3ZpZXdfcmVwYWludHNfZ2V0KGNv bnN0IEV3a19WaWV3X1ByaXZhdGVfRGF0YSAqcHJpdiwgc2l6ZV90ICpjb3VudCk7Ci1FQVBJIGNv bnN0IEV3a19TY3JvbGxfUmVxdWVzdCAqZXdrX3ZpZXdfc2Nyb2xsX3JlcXVlc3RzX2dldChjb25z dCBFd2tfVmlld19Qcml2YXRlX0RhdGEgKnByaXYsIHNpemVfdCAqY291bnQpOwotCi1FQVBJIHZv aWQgZXdrX3ZpZXdfcmVwYWludF9hZGQoRXdrX1ZpZXdfUHJpdmF0ZV9EYXRhICpwcml2LCBFdmFz X0Nvb3JkIHgsIEV2YXNfQ29vcmQgeSwgRXZhc19Db29yZCB3LCBFdmFzX0Nvb3JkIGgpOwotCi1F QVBJIHZvaWQgZXdrX3ZpZXdfbGF5b3V0X2lmX25lZWRlZF9yZWN1cnNpdmUoRXdrX1ZpZXdfUHJp dmF0ZV9EYXRhICpwcml2KTsKLQogRUFQSSB2b2lkIGV3a192aWV3X3Njcm9sbHNfcHJvY2VzcyhF d2tfVmlld19TbWFydF9EYXRhICpzZCk7CiAKIC8qKgo=