62685 2011-06-14 17:52:21 -0700 REGRESSION(r88757): [Chromium] Vertical position of media slider thumb is wrong. 2011-06-14 20:41:38 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Other All RESOLVED FIXED P1 Normal --- 52920 1 tkent tkent dglazkov morrita oldest_to_newest 420903 0 tkent 2011-06-14 17:52:21 -0700 If the height of the <input> is smaller than the height of the thumb, we should center the thumb position vertically. 420961 1 97220 tkent 2011-06-14 19:14:17 -0700 Created attachment 97220 Patch 420962 2 tkent 2011-06-14 19:14:55 -0700 (In reply to comment #1) > Created an attachment (id=97220) [details] > Patch This will fix 12 tests listed in test_expectations.txt. 420976 3 97220 morrita 2011-06-14 20:09:44 -0700 Comment on attachment 97220 Patch r=me. 420979 4 97220 dglazkov 2011-06-14 20:13:46 -0700 Comment on attachment 97220 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97220&action=review > Source/WebCore/rendering/RenderSlider.cpp:106 > + thumbBox->setY(thumbBox->y() - (heightDiff / 2) - borderTop()); What about padding, or margins? 420987 5 97220 tkent 2011-06-14 20:37:55 -0700 Comment on attachment 97220 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97220&action=review >> Source/WebCore/rendering/RenderSlider.cpp:106 >> + thumbBox->setY(thumbBox->y() - (heightDiff / 2) - borderTop()); > > What about padding, or margins? Oh, it's a good point. We should take account of padding, and margin is ignorable. Well, I have just realized we'd like to center the thumb for the *content* of the <input>, not the border-box. So, int heightDiff = thumbBox->height() - contentHeight(); if (heightDiff > 0) thumbBox->setY(thumbBox->y() - (heightDiff / 2)); is the correct code. I'll land the patch with this fix. 420988 6 tkent 2011-06-14 20:41:38 -0700 Committed r88901: <http://trac.webkit.org/changeset/88901> 97220 2011-06-14 19:14:17 -0700 2011-06-14 20:37:55 -0700 Patch bug-62685-20110615111415.patch text/plain 2315 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogODg4ODMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0YjNjMzAzMDE1NzMxNmYy YWM3NTVkNzUyMzg0MGI3MmI1YzhjZGZkLi5kNjVmNWQ0MTc5ZDEzMjcxY2M3NjJhZjBjMTU2MzFj ZDI4ZWQ1NTU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDYtMTQgIEtlbnQg VGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJFR1JFU1NJT04ocjg4NzU3KTogW0Nocm9taXVtXSBWZXJ0 aWNhbCBwb3NpdGlvbiBvZiBtZWRpYSBzbGlkZXIgdGh1bWIgaXMgd3JvbmcuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MjY4NQorCisgICAgICAgIE5v IG5ldyB0ZXN0cy4gQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJTbGlkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyU2xpZGVyOjps YXlvdXQpOiBDZW50ZXIgdGhlIHRodW1iIHBvc2l0aW9uLgorICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJTbGlkZXIuaDoKKwogMjAxMS0wNi0xMyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0 Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBIeWF0dC4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJTbGlkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclNsaWRlci5jcHAKaW5kZXggYjM1NWFiYzQwMGNiMTFkZWRhYjI3M2Qz MGY1YmIzOWI3ODQ2NjM1OS4uY2I3NzY5NGY0MGRiNmJkZjBhZTNiYmI2ZGExYjlkNGQwNWY2OGQ0 MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNsaWRlci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNsaWRlci5jcHAKQEAgLTk1LDYg Kzk1LDE3IEBAIHZvaWQgUmVuZGVyU2xpZGVyOjpjb21wdXRlUHJlZmVycmVkTG9naWNhbFdpZHRo cygpCiAgICAgc2V0UHJlZmVycmVkTG9naWNhbFdpZHRoc0RpcnR5KGZhbHNlKTsgCiB9CiAKK3Zv aWQgUmVuZGVyU2xpZGVyOjpsYXlvdXQoKQoreworICAgIFJlbmRlckJsb2NrOjpsYXlvdXQoKTsK KyAgICBSZW5kZXJCb3gqIHRodW1iQm94ID0gc2xpZGVyVGh1bWJFbGVtZW50T2Yobm9kZSgpKS0+ cmVuZGVyQm94KCk7CisgICAgaWYgKCF0aHVtYkJveCkKKyAgICAgICAgcmV0dXJuOworICAgIGlu dCBoZWlnaHREaWZmID0gdGh1bWJCb3gtPmhlaWdodCgpIC0gaGVpZ2h0KCk7CisgICAgaWYgKGhl aWdodERpZmYgPiAwKQorICAgICAgICB0aHVtYkJveC0+c2V0WSh0aHVtYkJveC0+eSgpIC0gKGhl aWdodERpZmYgLyAyKSAtIGJvcmRlclRvcCgpKTsKK30KKwogYm9vbCBSZW5kZXJTbGlkZXI6Omlu RHJhZ01vZGUoKSBjb25zdAogewogICAgIHJldHVybiBzbGlkZXJUaHVtYkVsZW1lbnRPZihub2Rl KCkpLT5hY3RpdmUoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJTbGlkZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJTbGlkZXIuaAppbmRl eCA4YjdkNTUyZDlkM2ZiY2FlN2RmYThjNWQ3NGU0NzI5ZDI3OTIxMmNhLi5jMTI2MWJiMjYyMDhi MmRjOThjMTE2NjJkY2U2NDE3YzhiYmY5OGE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyU2xpZGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclNsaWRlci5oCkBAIC00Myw2ICs0Myw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAg ICAgdmlydHVhbCBpbnQgYmFzZWxpbmVQb3NpdGlvbihGb250QmFzZWxpbmUsIGJvb2wgZmlyc3RM aW5lLCBMaW5lRGlyZWN0aW9uTW9kZSwgTGluZVBvc2l0aW9uTW9kZSA9IFBvc2l0aW9uT25Db250 YWluaW5nTGluZSkgY29uc3Q7CiAgICAgICAgIHZpcnR1YWwgdm9pZCBjb21wdXRlUHJlZmVycmVk TG9naWNhbFdpZHRocygpOwogICAgICAgICB2aXJ0dWFsIGJvb2wgcmVxdWlyZXNGb3JjZWRTdHls ZVJlY2FsY1Byb3BhZ2F0aW9uKCkgY29uc3QgeyByZXR1cm4gdHJ1ZTsgfQorICAgICAgICB2aXJ0 dWFsIHZvaWQgbGF5b3V0KCk7CiAgICAgfTsKIAogICAgIGlubGluZSBSZW5kZXJTbGlkZXIqIHRv UmVuZGVyU2xpZGVyKFJlbmRlck9iamVjdCogb2JqZWN0KQo=